130076 2014-03-11 01:58:46 -0700 [GTK][CMAKE] Too verbose build output 2014-03-12 08:49:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia mrobinson gustavo mrobinson zan oldest_to_newest 989301 0 cgarcia 2014-03-11 01:58:46 -0700 When building using ninja, the output is too verbose for some targets, where we previously had GEN foo now we have several lines of noise. Another problem is that when ninja is run by cmake, the smart terminal features don't work, so all the output is written using a new line and we loose the nice colors when using icecc, for example. This is because ninja doesn't write directly to the terminal, but to a cmake pipe (or whatever, I don't know), and isatty(1) returns false and ninja disables the smart terminal features. I wonder if we could run cmake first to generate the build.ninja file and then run ninja ourselves from build-webkit instead of using cmake. So, if we can use the default ninja output suing the smart terminal features, the verbose target wouldn't be a problem. I still think we should produce less verbose output for the bots, though. 989501 1 226464 mrobinson 2014-03-11 19:12:23 -0700 Created attachment 226464 Patch 989555 2 226464 cgarcia 2014-03-12 01:10:58 -0700 Comment on attachment 226464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226464&action=review This works great, I still would like that verbose targets use something like Generating Foo for the cases where smart terminal is not used like in the bots logs. Thanks. > Source/cmake/OptionsGTK.cmake:311 > +file(COPY ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/build.sh > + DESTINATION ${CMAKE_BINARY_DIR} > + FILE_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE) I wonder why you need to first write in one directory and then copy to another, but I have no idea how cmake works :-P 989635 3 mrobinson 2014-03-12 08:44:25 -0700 (In reply to comment #2) > I wonder why you need to first write in one directory and then copy to another, but I have no idea how cmake works :-P This is the only way I could find to change the permissions of a file without resorting to a shell command, unfortunately. 989638 4 226464 mrobinson 2014-03-12 08:48:50 -0700 Comment on attachment 226464 Patch Clearing flags on attachment: 226464 Committed r165473: <http://trac.webkit.org/changeset/165473> 989641 5 mrobinson 2014-03-12 08:49:46 -0700 All reviewed patches have been landed. Closing bug. 226464 2014-03-11 19:12:23 -0700 2014-03-12 08:48:49 -0700 Patch bug-130076-20140311191200.patch text/plain 3544 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGYyMzk5 NjU3Njk0M2ZkYThkYjM5M2VhMDk4N2QyNjk2NmExM2I2YjIuLmE2OTc0ZTExNGY1YTcxNjE4YjM5 ZTJjZWZkOTU2ZGU0YzIyZDA5MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yOTksMyArMjk5 LDEzIEBAIG1hY3JvKEFERF9XSE9MRV9BUkNISVZFX1RPX0xJQlJBUklFUyBfbGlzdF9uYW1lKQog ICAgIGVuZGZvcmVhY2ggKCkKICAgICBzZXQoJHtfbGlzdF9uYW1lfSAiJHske19saXN0X25hbWV9 X1RNUH0iKQogZW5kbWFjcm8oKQorCitidWlsZF9jb21tYW5kKENPTU1BTkRfTElORV9UT19CVUlM RCkKK2ZpbGUoV1JJVEUKKyAgICAke0NNQUtFX0JJTkFSWV9ESVJ9JHtDTUFLRV9GSUxFU19ESVJF Q1RPUll9L2J1aWxkLnNoCisgICAgIiMhL2Jpbi9zaFxuIgorICAgICIke0NPTU1BTkRfTElORV9U T19CVUlMRH0gJEAiCispCitmaWxlKENPUFkgJHtDTUFLRV9CSU5BUllfRElSfSR7Q01BS0VfRklM RVNfRElSRUNUT1JZfS9idWlsZC5zaAorICBERVNUSU5BVElPTiAke0NNQUtFX0JJTkFSWV9ESVJ9 CisgIEZJTEVfUEVSTUlTU0lPTlMgT1dORVJfUkVBRCBPV05FUl9XUklURSBPV05FUl9FWEVDVVRF IEdST1VQX1JFQUQgR1JPVVBfRVhFQ1VURSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZTYxMmNlNjQ0ZTM5YjZmOGIzMzZhZGM0ZjRlN2Y1NTUz NTQ2ZDAwLi5kODVjMTdlNGIxMzkzMGEzMzg4ZTk5MWZmOTllMDI0YzJlZGI3OWJhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTQtMDMtMTEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CisgICAgICAgIFtHVEtdW0NNQUtFXSBUb28gdmVyYm9zZSBidWlsZCBvdXRwdXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDA3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluc3RlYWQgb2YgYnVpbGRp bmcgd2l0aCBjbWFrZSAtLWJ1aWxkIHdoaWNoIGlzbid0IHNtYXJ0IGFib3V0IHByZXR0eSBwcmlu dGluZyBhbmQKKyAgICAgICAgY29sb3JzLCB3ZSBidWlsZCB3aXRoIGEgc2NyaXB0IHdoaWNoIGNh bGxzIHRoZSBwcm9wZXIgYnVpbGQgY29tbWFuZC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 ZGlycy5wbToKKyAgICAgICAgKGJ1aWxkQ01ha2VHZW5lcmF0ZWRQcm9qZWN0KTogRm9yIEdUSysg Y2FsbCB0aGUgc2NyaXB0IHRoYXQgd2UgZ2VuZXJhdGUgZHVyaW5nCisgICAgICAgIHRoZSBDTWFr ZSBjb25maWd1cmF0aW9uIHBhc3MuCisKKzIwMTQtMDMtMTEgIE1hcnRpbiBSb2JpbnNvbiAgPG1y b2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFRoZSBqaGJ1aWxkIGVudmlyb25t ZW50IHNob3VsZCBzZXQgQ01BS0VfUFJFRklYX1BBVEggYW5kIENNQUtFX0xJQlJBUllfUEFUSAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMDY0CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQppbmRleCBmYTI3ZDc0ZjM5MjMzYWNmNTdhMjk2ODJkYzRhZDI5OTdlMzky ZjdiLi45NDYyMGM5M2YzYTQ2ZGIwNjdlM2E3Y2RkOTE0MzdiY2VjNTEzZTA3IDEwMDc1NQotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRk aXJzLnBtCkBAIC0yMDQ2LDEzICsyMDQ2LDIzIEBAIHN1YiBidWlsZENNYWtlR2VuZXJhdGVkUHJv amVjdCgkKQogICAgIGlmICghIC1kICRidWlsZFBhdGgpIHsKICAgICAgICAgZGllICJNdXN0IGNh bGwgZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QoKSBiZWZvcmUgYnVpbGRpbmcg Q01ha2UgcHJvamVjdC4iOwogICAgIH0KKworICAgIG15ICRjb21tYW5kID0gImNtYWtlIjsKICAg ICBteSBAYXJncyA9ICgiLS1idWlsZCIsICRidWlsZFBhdGgsICItLWNvbmZpZyIsICRjb25maWcp OwogICAgIHB1c2ggQGFyZ3MsICgiLS0iLCAkbWFrZUFyZ3MpIGlmICRtYWtlQXJnczsKIAorICAg ICMgR1RLIHVzZXMgYSBidWlsZCBzY3JpcHQgdG8gcHJlc2VydmUgY29sb3JzIGFuZCBwcmV0dHkt cHJpbnRpbmcuCisgICAgaWYgKGlzR3RrKCkpIHsKKyAgICAgICAgY2hkaXIgIiRidWlsZFBhdGgi IG9yIGRpZTsKKyAgICAgICAgJGNvbW1hbmQgPSAiJGJ1aWxkUGF0aC9idWlsZC5zaCI7CisgICAg ICAgIEBhcmdzID0gKCRtYWtlQXJncyk7CisgICAgfQorCiAgICAgIyBXZSBjYWxsIHN5c3RlbSgi Y21ha2UgQGFyZ3MiKSBpbnN0ZWFkIG9mIHN5c3RlbSgiY21ha2UiLCBAYXJncykgc28gdGhhdCBA YXJncyBpcwogICAgICMgcGFyc2VkIGZvciBzaGVsbCBtZXRhY2hhcmFjdGVycy4gSW4gcGFydGlj dWxhciwgJG1ha2VBcmdzIG1heSBjb250YWluIHN1Y2ggbWV0YWNoYXJhY3RlcnMuCiAgICAgbXkg JHdyYXBwZXIgPSBqb2luKCIgIiwgamhidWlsZFdyYXBwZXJQcmVmaXhJZk5lZWRlZCgpKSAuICIg IjsKLSAgICByZXR1cm4gc3lzdGVtKCR3cmFwcGVyIC4gImNtYWtlIEBhcmdzIik7CisgICAgcmV0 dXJuIHN5c3RlbSgkd3JhcHBlciAuICIkY29tbWFuZCBAYXJncyIpOworCiB9CiAKIHN1YiBjbGVh bkNNYWtlR2VuZXJhdGVkUHJvamVjdCgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VM b2cKaW5kZXggYmNkMzI5OWI2NGU5M2JmZjVmNjc5ZDY3MDdmNmZkMTQ1NzBiYTk0My4uZDk5OWUy ZWVmZWQzNDUzYzNmZTA4MmI3NDBjMjcxMmEwODY5YWY1ZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9n CisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAzLTExICBNYXJ0aW4gUm9i aW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtDTUFLRV0gVG9v IHZlcmJvc2UgYnVpbGQgb3V0cHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzAwNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBHZW5lcmF0ZSBh IHNjcmlwdCB3aGljaCBkb2VzIHRoZSBhY3R1YWwgYnVpbGQuIFRoaXMKKyAgICAgICAgd29ya3Mg YXJvdW5kIGFuIGlzc3VlIHdoZXJlIGNtYWtlIC0tYnVpbGQgZG9lc24ndCBzdXBwb3J0IG5pbmph J3MgcHJldHR5IHByaW50aW5nLgorCiAyMDE0LTAzLTEwICBNYXJpbyBTYW5jaGV6IFByYWRhICA8 bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgZm9y IEdlb2NsdWUyCg==