13007 2007-03-07 15:05:43 -0800 svn-create-patch doesn't handle UTF files with BOMs as text 2007-03-09 16:55:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 andrew webkit-unassigned ap ddkilzer oldest_to_newest 19978 0 andrew 2007-03-07 15:05:43 -0800 svn-create-patch gets confused at strings files because diff isn't treating the files as text (it sees the BOM in the UTF-16 file) Patch to be attached forces all files that svn-create-patch thinks are text to be treated as text. 19954 1 13534 andrew 2007-03-07 15:10:39 -0800 Created attachment 13534 Patch Trivial patch 19863 2 ddkilzer 2007-03-07 16:40:11 -0800 If you create the patch with this change to svn-create-patch, run svn-unapply, then svn-apply, do you end up with the same changes once you're done? I'm wondering if there would be any text conversion funny-business where one two-byte UTF-16 character would get split into two one-byte UTF-8 characters in the process. 19865 3 andrew 2007-03-07 17:08:23 -0800 In my testing it appears to work correctly in the situation David described. I just tried adding a line of Japanese text to a file, checking md5 of the file, creating a patch, svn-unapply, svn-apply, checking the md5 of the file. At both points the md5 was identical. 19866 4 13534 darin 2007-03-07 17:24:22 -0800 Comment on attachment 13534 Patch Can svn-apply and svn-unapply handle these kind of diffs? If not, we need to fix those first. 19915 5 13534 darin 2007-03-08 08:58:32 -0800 Comment on attachment 13534 Patch r=me 19731 6 ddkilzer 2007-03-09 16:55:30 -0800 Committed revision 20095. 13534 2007-03-07 15:10:39 -0800 2007-03-08 08:58:32 -0800 Patch svn-patch-text-patch.txt text/plain 1094 andrew SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDI5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDctMDMtMDggIEFuZHJldyBXZWxsaW5ndG9u ICA8cHJvdG9uQHdpcmV0YXBwZWQubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgRm9yY2UgZGlmZiB0byB0cmVhdCBmaWxlcyB0aGF0 IHN2bi1jcmVhdGUtcGF0Y2ggdGhpbmtzIGFyZSB0ZXh0IGFzIHRleHQKKworICAgICAgICAqIFNj cmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaDoKKwogMjAwNy0wMy0wNyAgQW5kZXJzIENhcmxzc29uICA8 YWNhcmxzc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtLgpJbmRleDog V2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dFRvb2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAkocmV2aXNpb24gMjAwMjkpCisrKyBXZWJL aXRUb29scy9TY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2gJKHdvcmtpbmcgY29weSkKQEAgLTIyMSw3 ICsyMjEsNyBAQCBzdWIgZ2VuZXJhdGVEaWZmKCQkJCkKICAgICBpZiAoJG1vZGlmaWNhdGlvblR5 cGUgZXEgImFkZGl0aW9uV2l0aEhpc3RvcnkiKSB7CiAgICAgICAgIG1hbnVmYWN0dXJlUGF0Y2hG b3JBZGRpdGlvbldpdGhIaXN0b3J5KCRmaWxlLCAkaXNCaW5hcnkpOwogICAgIH0KLSAgICBvcGVu IERJRkYsICJzdm4gZGlmZiAtLWRpZmYtY21kIGRpZmYgLXggLXVOcCAnJGZpbGUnIHwiIG9yIGRp ZTsKKyAgICBvcGVuIERJRkYsICJzdm4gZGlmZiAtLWRpZmYtY21kIGRpZmYgLXggLXVhTnAgJyRm aWxlJyB8IiBvciBkaWU7CiAgICAgd2hpbGUgKDxESUZGPikgewogICAgICAgICAkcGF0Y2ggLj0g JF87CiAgICAgfQo=