130065 2014-03-10 19:56:43 -0700 r165414 broke the 32-bit x86 tests: ASSERTION FAILED: result != InvalidIndex @ GPRInfo.h:330 2014-03-10 21:48:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo ggaren mhahnenberg mmirman msaboff oliver webkit-bug-importer oldest_to_newest 989190 0 mark.lam 2014-03-10 19:56:43 -0700 The assertion failure shows up readily when you run "run-javascriptcore-tests --debug --32-bit". 989191 1 fpizlo 2014-03-10 19:59:00 -0700 Looking at it. 989210 2 mark.lam 2014-03-10 21:08:07 -0700 <rdar://problem/16284986> 989211 3 mark.lam 2014-03-10 21:11:07 -0700 There is code in ScratchRegisterAllocator.cpp that is expecting GPRInfo::toIndex() to be able to return InvalidIndex. Hence, the assertion is invalid. Ditto for FPRInfo::toIndex(). The fix is to remove the "result != InvalidIndex" assertions. 989213 4 226381 mark.lam 2014-03-10 21:15:15 -0700 Created attachment 226381 the patch. 989215 5 226381 mark.lam 2014-03-10 21:20:08 -0700 Comment on attachment 226381 the patch. Thanks for the review. 989218 6 226381 fpizlo 2014-03-10 21:24:22 -0700 Comment on attachment 226381 the patch. r=me too 989231 7 226381 commit-queue 2014-03-10 21:48:00 -0700 Comment on attachment 226381 the patch. Clearing flags on attachment: 226381 Committed r165431: <http://trac.webkit.org/changeset/165431> 989232 8 commit-queue 2014-03-10 21:48:03 -0700 All reviewed patches have been landed. Closing bug. 226381 2014-03-10 21:15:15 -0700 2014-03-10 21:48:00 -0700 the patch. bug-130065.patch text/plain 3333 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1NDI2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTAzLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBy MTY1NDE0IGJyb2tlIHRoZSAzMi1iaXQgeDg2IHRlc3RzOiBBU1NFUlRJT04gRkFJTEVEOiByZXN1 bHQgIT0gSW52YWxpZEluZGV4IEAgR1BSSW5mby5oOjMzMC4KKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzEzMDA2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGVyZSBpcyBjb2RlIGluIFNjcmF0Y2hSZWdpc3RlckFsbG9jYXRvci5jcHAg dGhhdCBpcyByZWx5aW5nIG9uIEdQUkluZm86OnRvSW5kZXgoKQorICAgICAgICBiZWluZyBhYmxl IHRvIHJldHVybiBJbnZhbGlkSW5kZXguICBIZW5jZSwgdGhlIGFzc2VydGlvbiBpcyBpbnZhbGlk LiAgRGl0dG8gZm9yCisgICAgICAgIEZQUkluZm86OnRvSW5kZXgoKS4KKworICAgICAgICBUaGUg Zml4IGlzIHRvIHJlbW92ZSB0aGUgInJlc3VsdCAhPSBJbnZhbGlkSW5kZXgiIGFzc2VydGlvbnMu CisKKyAgICAgICAgKiBqaXQvRlBSSW5mby5oOgorICAgICAgICAoSlNDOjpGUFJJbmZvOjp0b0lu ZGV4KToKKyAgICAgICAgKiBqaXQvR1BSSW5mby5oOgorICAgICAgICAoSlNDOjpHUFJJbmZvOjp0 b0luZGV4KToKKwogMjAxNC0wMy0xMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgQ3Jhc2ggb24gYSBzdGFjayBvdmVyZmxvdyBvbiAzMi1iaXQgeDg2IGluIGh0dHAv dGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5Ymkvd29ya2Vycy9uby1vbm1lc3NhZ2UtaW4tc3luYy1v cC5odG1sLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9GUFJJbmZvLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9GUFJJbmZvLmgJKHJldmlzaW9uIDE2 NTQyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCSh3b3JraW5nIGNv cHkpCkBAIC0yNDIsNyArMjQyLDYgQEAgcHVibGljOgogICAgICAgICAgICAgMTYsIDE3LCAxOCwg MTksIDIwLCAyMSwgMjIsIEludmFsaWRJbmRleAogICAgICAgICB9OwogICAgICAgICB1bnNpZ25l ZCByZXN1bHQgPSBpbmRleEZvclJlZ2lzdGVyW3JlZ107Ci0gICAgICAgIEFTU0VSVChyZXN1bHQg IT0gSW52YWxpZEluZGV4KTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAKQEAgLTMw NSw3ICszMDQsNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICBJbnZhbGlkSW5kZXgsIEludmFsaWRJ bmRleCwgNSwgSW52YWxpZEluZGV4LAogICAgICAgICB9OwogICAgICAgICB1bnNpZ25lZCByZXN1 bHQgPSBpbmRleEZvclJlZ2lzdGVyW3JlZ107Ci0gICAgICAgIEFTU0VSVChyZXN1bHQgIT0gSW52 YWxpZEluZGV4KTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAKQEAgLTM3MSw3ICsz NjksNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwg SW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgKICAgICAgICAgfTsKICAgICAgICAgdW5zaWduZWQg cmVzdWx0ID0gaW5kZXhGb3JSZWdpc3RlcltyZWddOwotICAgICAgICBBU1NFUlQocmVzdWx0ICE9 IEludmFsaWRJbmRleCk7CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0dQUkluZm8uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0dQUkluZm8uaAkocmV2aXNpb24gMTY1NDI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9HUFJJbmZvLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyNyw3ICsz MjcsNiBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVChzdGF0aWNfY2FzdDxpbnQ+KHJlZykgPCA4 KTsKICAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGluZGV4Rm9yUmVnaXN0ZXJbOF0gPSB7 IDAsIDIsIDEsIDMsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCA1LCA0IH07CiAgICAgICAg IHVuc2lnbmVkIHJlc3VsdCA9IGluZGV4Rm9yUmVnaXN0ZXJbcmVnXTsKLSAgICAgICAgQVNTRVJU KHJlc3VsdCAhPSBJbnZhbGlkSW5kZXgpOwogICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0K IApAQCAtNTA0LDcgKzUwMyw2IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHsgMCwgMSwgMiwgOCwg MywgOSwgSW52YWxpZEluZGV4LCA3LCA0LCA1LCA2LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRl eCwgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCB9OwogI2VuZGlmCiAg ICAgICAgIHVuc2lnbmVkIHJlc3VsdCA9IGluZGV4Rm9yUmVnaXN0ZXJbcmVnXTsKLSAgICAgICAg QVNTRVJUKHJlc3VsdCAhPSBJbnZhbGlkSW5kZXgpOwogICAgICAgICByZXR1cm4gcmVzdWx0Owog ICAgIH0KIApAQCAtNjg0LDcgKzY4Miw2IEBAIHB1YmxpYzoKICAgICAgICAgICAgIDYsIEludmFs aWRJbmRleCwgMywgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52 YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgKICAgICAgICAgfTsKICAgICAgICAgdW5zaWduZWQgcmVz dWx0ID0gaW5kZXhGb3JSZWdpc3RlcltyZWddOwotICAgICAgICBBU1NFUlQocmVzdWx0ICE9IElu dmFsaWRJbmRleCk7CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogCkBAIC03NTYsNyAr NzUzLDYgQEAgcHVibGljOgogICAgICAgICBBU1NFUlQocmVnIDwgMTQpOwogICAgICAgICBzdGF0 aWMgY29uc3QgdW5zaWduZWQgaW5kZXhGb3JSZWdpc3RlclsxNF0gPSB7IDAsIDEsIDIsIEludmFs aWRJbmRleCwgNCwgNSwgNiwgNywgOCwgOSwgMywgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgs IEludmFsaWRJbmRleCB9OwogICAgICAgICB1bnNpZ25lZCByZXN1bHQgPSBpbmRleEZvclJlZ2lz dGVyW3JlZ107Ci0gICAgICAgIEFTU0VSVChyZXN1bHQgIT0gSW52YWxpZEluZGV4KTsKICAgICAg ICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAK