130063 2014-03-10 19:28:55 -0700 Remove unused method from BatteryController 2014-03-11 04:14:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 989178 0 ryuan.choi 2014-03-10 19:28:55 -0700 client() is not used since it is introduced. 989182 1 226372 ryuan.choi 2014-03-10 19:33:58 -0700 Created attachment 226372 Patch 989336 2 226372 commit-queue 2014-03-11 03:09:28 -0700 Comment on attachment 226372 Patch Rejecting attachment 226372 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 226372, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4681445800935424 989347 3 ryuan.choi 2014-03-11 04:13:42 -0700 Committed r165446: <http://trac.webkit.org/changeset/165446> 989349 4 226372 ryuan.choi 2014-03-11 04:14:56 -0700 Comment on attachment 226372 Patch clearing flags. I landed after fixed changelog which missed "Unreviewed". 226372 2014-03-10 19:33:58 -0700 2014-03-11 04:14:56 -0700 Patch bug-130063-20140311113357.patch text/plain 1393 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY0MjBlYzc5ZDdkMTYw ZjllZWJiMWE5NmMwY2ZjNWFhNzA1MGY4OS4uZTY1ZTA2ODZkMTU2MDM2YjhkYjMwMTBiMzRkMDE4 NzMyZjM1MDI1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDE0LTAzLTEwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2Vk IG1ldGhvZCBmcm9tIEJhdHRlcnlDb250cm9sbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAwNjMKKworICAgICAgICAqIE1vZHVsZXMvYmF0dGVy eS9CYXR0ZXJ5Q29udHJvbGxlci5oOiBSZW1vdmVkIGNsaWVudCgpIHdoaWNoIGlzIG5vdCB1c2Vk LgorCiAyMDE0LTAzLTEwICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K IAogICAgICAgICBSZW1vdmUgJ3Zpc2liaWxpdHljaGFuZ2UnIGF0dHJpYnV0ZSBldmVudCBsaXN0 ZW5lciBmcm9tIGRvY3VtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2Jh dHRlcnkvQmF0dGVyeUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYmF0dGVy eS9CYXR0ZXJ5Q29udHJvbGxlci5oCmluZGV4IDI3ZGEyNGEzOGQ4YjZmNGRkZGE5ODE2MjRjNzVi NzYxOTJiZGFmZTkuLjkyYjc4ODQzNzYwYzg5YmZiMjcyMjEwYzQxNWZjOWEzMzFiYWQxMTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYmF0dGVyeS9CYXR0ZXJ5Q29udHJvbGxl ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYmF0dGVyeS9CYXR0ZXJ5Q29udHJvbGxl ci5oCkBAIC00MSw4ICs0MSw2IEBAIHB1YmxpYzoKICAgICB2b2lkIHVwZGF0ZUJhdHRlcnlTdGF0 dXMoUGFzc1JlZlB0cjxCYXR0ZXJ5U3RhdHVzPik7CiAgICAgdm9pZCBkaWRDaGFuZ2VCYXR0ZXJ5 U3RhdHVzKGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBQYXNzUmVmUHRyPEJhdHRlcnlT dGF0dXM+KTsKIAotICAgIEJhdHRlcnlDbGllbnQqIGNsaWVudCgpIGNvbnN0IHsgcmV0dXJuIG1f Y2xpZW50OyB9Ci0KICAgICBzdGF0aWMgY29uc3QgY2hhciogc3VwcGxlbWVudE5hbWUoKTsKICAg ICBzdGF0aWMgQmF0dGVyeUNvbnRyb2xsZXIqIGZyb20oUGFnZSogcGFnZSkgeyByZXR1cm4gc3Rh dGljX2Nhc3Q8QmF0dGVyeUNvbnRyb2xsZXIqPihTdXBwbGVtZW50PFBhZ2U+Ojpmcm9tKHBhZ2Us IHN1cHBsZW1lbnROYW1lKCkpKTsgfQogCg==