13006 2007-03-07 14:08:00 -0800 XPath string-value is broken for some node types 2007-03-08 00:29:55 -0800 1 1 1 Unclassified WebKit XML 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 20004 0 ap 2007-03-07 14:08:00 -0800 String-value shouldn't work recursively for elements and document nodes, as the result is nonsensical then. Also, string-value should be implemented for CDATA nodes. Patch forthcoming. 19996 1 13527 ap 2007-03-07 14:12:37 -0800 Created attachment 13527 proposed fix 19975 2 13527 darin 2007-03-07 15:02:24 -0800 Comment on attachment 13527 proposed fix r=me 19887 3 ap 2007-03-08 00:29:55 -0800 Committed revision 20055. 13527 2007-03-07 14:12:37 -0800 2007-03-07 15:02:24 -0800 proposed fix 13006r1_patch.txt text/plain 5818 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDI4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDMtMDggIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDA2 CisgICAgICAgIFhQYXRoIHN0cmluZy12YWx1ZSBpcyBicm9rZW4gZm9yIHNvbWUgbm9kZSB0eXBl cworCisgICAgICAgICogZmFzdC94cGF0aC9zdHJpbmctdmFsdWUtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L3hwYXRoL3N0cmluZy12YWx1ZS5odG1sOiBBZGRlZC4KKwogMjAw Ny0wMy0wNyAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL3N0cmluZy12YWx1ZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC94cGF0aC9zdHJpbmctdmFsdWUt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC94cGF0aC9zdHJp bmctdmFsdWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDExIEBACitQQVNT IGRvYy5ldmFsdWF0ZSgnLicsIGRvYywgbnVsbCwgWFBhdGhSZXN1bHQuU1RSSU5HX1RZUEUsIG51 bGwpLnN0cmluZ1ZhbHVlIGlzICcwICAxYS1jZGF0YS1iMicKK1BBU1MgZG9jLmV2YWx1YXRlKCcu JywgZG9jLmRvY3VtZW50RWxlbWVudCwgbnVsbCwgWFBhdGhSZXN1bHQuU1RSSU5HX1RZUEUsIG51 bGwpLnN0cmluZ1ZhbHVlIGlzICcwICAxYS1jZGF0YS1iMicKK1BBU1MgZG9jLmV2YWx1YXRlKCcu JywgUEksIG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFLCBudWxsKS5zdHJpbmdWYWx1ZSBp cyAnIkRhdGEiICAnCitQQVNTIGRvYy5ldmFsdWF0ZSgnLicsIENPTU1FTlQsIG51bGwsIFhQYXRo UmVzdWx0LlNUUklOR19UWVBFLCBudWxsKS5zdHJpbmdWYWx1ZSBpcyAnIGNvbW1lbnQgJworUEFT UyBkb2MuZXZhbHVhdGUoJy4nLCBDREFUQSwgbnVsbCwgWFBhdGhSZXN1bHQuU1RSSU5HX1RZUEUs IG51bGwpLnN0cmluZ1ZhbHVlIGlzICctY2RhdGEtJworUEFTUyBkb2MuZXZhbHVhdGUoJy4nLCBU RVhULCBudWxsLCBYUGF0aFJlc3VsdC5TVFJJTkdfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUgaXMg JzAgICcKK1BBU1MgZG9jLmV2YWx1YXRlKCcuJywgRU1QVFksIG51bGwsIFhQYXRoUmVzdWx0LlNU UklOR19UWVBFLCBudWxsKS5zdHJpbmdWYWx1ZSBpcyAnJworUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91 dFRlc3RzL2Zhc3QveHBhdGgvc3RyaW5nLXZhbHVlLWV4cGVjdGVkLnR4dApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5h bWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWluCk5hbWU6IHN2bjplb2wtc3R5bGUKICAg KyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL3N0cmluZy12YWx1ZS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QveHBhdGgvc3RyaW5nLXZhbHVlLmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL3N0cmluZy12YWx1ZS5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0v L0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNo ZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBz cmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keT4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorICAgIGRvYyA9IChu ZXcgRE9NUGFyc2VyKS5wYXJzZUZyb21TdHJpbmcoCisgICAgICAgICc8P3htbCB2ZXJzaW9uPSIx LjAiIGVuY29kaW5nPSJJU08tODg1OS0xIj8+JyArCisgICAgICAgICc8IURPQ1RZUEUgZG9jIFtd PicgKworICAgICAgICAnPD94bWwtc3R5bGVzaGVldCAiRGF0YSIgID8+JyArCisgICAgICAgICc8 IScgKyAnLS0gY29tbWVudCAtLT4nICsKKyAgICAgICAgJzxkb2MgYXR0cj0iJmx0OyZhbXA7bmJz cDs+Ij4wICA8ZWxlbT4xPC9lbGVtPjwhJyArICctLSAgY29tbWVudCAgLS0+YTwhW0NEQVRBWy1j ZGF0YS1dXT5iPGVsZW0+MjwvZWxlbT48ZW1wdHk+PC9lbXB0eT48L2RvYz4nLAorICAgICAgICAn YXBwbGljYXRpb24veG1sJyk7CisKKyAgICBQSSA9IGRvYy5maXJzdENoaWxkOworICAgIHdoaWxl IChQSS5ub2RlVHlwZSAhPSBOb2RlLlBST0NFU1NJTkdfSU5TVFJVQ1RJT05fTk9ERSkKKyAgICAg ICAgUEkgPSBQSS5uZXh0U2libGluZzsKKworICAgIENPTU1FTlQgPSBkb2MuZmlyc3RDaGlsZDsK KyAgICB3aGlsZSAoQ09NTUVOVC5ub2RlVHlwZSAhPSBOb2RlLkNPTU1FTlRfTk9ERSkKKyAgICAg ICAgQ09NTUVOVCA9IENPTU1FTlQubmV4dFNpYmxpbmc7CisKKyAgICBBVFRSID0gZG9jLmRvY3Vt ZW50RWxlbWVudC5nZXRBdHRyaWJ1dGVOb2RlKCJhdHRyIik7CisKKyAgICBDREFUQSA9IGRvYy5k b2N1bWVudEVsZW1lbnQuZmlyc3RDaGlsZDsKKyAgICB3aGlsZSAoQ0RBVEEubm9kZVR5cGUgIT0g Tm9kZS5DREFUQV9TRUNUSU9OX05PREUpCisgICAgICAgIENEQVRBID0gQ0RBVEEubmV4dFNpYmxp bmc7CisKKyAgICBURVhUID0gZG9jLmRvY3VtZW50RWxlbWVudC5maXJzdENoaWxkOworICAgIAor ICAgIEVNUFRZID0gZG9jLmRvY3VtZW50RWxlbWVudC5sYXN0Q2hpbGQ7CisKKyAgICBzaG91bGRC ZSgiZG9jLmV2YWx1YXRlKCcuJywgZG9jLCBudWxsLCBYUGF0aFJlc3VsdC5TVFJJTkdfVFlQRSwg bnVsbCkuc3RyaW5nVmFsdWUiLCAiJzAgIDFhLWNkYXRhLWIyJyIpOworICAgIHNob3VsZEJlKCJk b2MuZXZhbHVhdGUoJy4nLCBkb2MuZG9jdW1lbnRFbGVtZW50LCBudWxsLCBYUGF0aFJlc3VsdC5T VFJJTkdfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUiLCAiJzAgIDFhLWNkYXRhLWIyJyIpOworICAg IHNob3VsZEJlKCJkb2MuZXZhbHVhdGUoJy4nLCBQSSwgbnVsbCwgWFBhdGhSZXN1bHQuU1RSSU5H X1RZUEUsIG51bGwpLnN0cmluZ1ZhbHVlIiwgIidcIkRhdGFcIiAgJyIpOworICAgIHNob3VsZEJl KCJkb2MuZXZhbHVhdGUoJy4nLCBDT01NRU5ULCBudWxsLCBYUGF0aFJlc3VsdC5TVFJJTkdfVFlQ RSwgbnVsbCkuc3RyaW5nVmFsdWUiLCAiJyBjb21tZW50ICciKTsKKyAgICBzaG91bGRCZSgiZG9j LmV2YWx1YXRlKCcuJywgQ0RBVEEsIG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFLCBudWxs KS5zdHJpbmdWYWx1ZSIsICInLWNkYXRhLSciKTsKKyAgICBzaG91bGRCZSgiZG9jLmV2YWx1YXRl KCcuJywgVEVYVCwgbnVsbCwgWFBhdGhSZXN1bHQuU1RSSU5HX1RZUEUsIG51bGwpLnN0cmluZ1Zh bHVlIiwgIicwICAnIik7CisgICAgc2hvdWxkQmUoImRvYy5ldmFsdWF0ZSgnLicsIEVNUFRZLCBu dWxsLCBYUGF0aFJlc3VsdC5TVFJJTkdfVFlQRSwgbnVsbCkuc3RyaW5nVmFsdWUiLCAiJyciKTsK KworICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworCis8L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QveHBhdGgv c3RyaW5nLXZhbHVlLmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4 dC9odG1sCgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDI4KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwNy0wMy0wOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAg PGFwQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMDYKKyAg ICAgICAgWFBhdGggc3RyaW5nLXZhbHVlIGlzIGJyb2tlbiBmb3Igc29tZSBub2RlIHR5cGVzCisK KyAgICAgICAgVGVzdDogZmFzdC94cGF0aC9zdHJpbmctdmFsdWUuaHRtbAorCisgICAgICAgICog eG1sL1hQYXRoVXRpbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYUGF0aDo6c3RyaW5nVmFsdWUp OiBGaXggaXQgOi0pCisKIDIwMDctMDMtMDcgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkuCkluZGV4OiBXZWJDb3JlL3ht bC9YUGF0aFV0aWwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUveG1sL1hQYXRoVXRpbC5jcHAJ KHJldmlzaW9uIDIwMDIxKQorKysgV2ViQ29yZS94bWwvWFBhdGhVdGlsLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDYsMTQgKzQ2LDE2IEBAIFN0cmluZyBzdHJpbmdWYWx1ZShOb2RlKiBub2RlKQog ICAgICAgICBjYXNlIE5vZGU6OlBST0NFU1NJTkdfSU5TVFJVQ1RJT05fTk9ERToKICAgICAgICAg Y2FzZSBOb2RlOjpDT01NRU5UX05PREU6CiAgICAgICAgIGNhc2UgTm9kZTo6VEVYVF9OT0RFOgor ICAgICAgICBjYXNlIE5vZGU6OkNEQVRBX1NFQ1RJT05fTk9ERToKKyAgICAgICAgY2FzZSBOb2Rl OjpYUEFUSF9OQU1FU1BBQ0VfTk9ERToKICAgICAgICAgICAgIHJldHVybiBub2RlLT5ub2RlVmFs dWUoKTsKICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGlmIChpc1Jvb3REb21Ob2RlKG5v ZGUpCi0gICAgICAgICAgICAgICAgIHx8IG5vZGUtPm5vZGVUeXBlKCkgPT0gTm9kZTo6RUxFTUVO VF9OT0RFKSB7CisgICAgICAgICAgICBpZiAoaXNSb290RG9tTm9kZShub2RlKSB8fCBub2RlLT5u b2RlVHlwZSgpID09IE5vZGU6OkVMRU1FTlRfTk9ERSkgewogICAgICAgICAgICAgICAgIFN0cmlu ZyBzdHI7CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgZm9yIChOb2RlKiBuID0g bm9kZS0+Zmlyc3RDaGlsZCgpOyBuOyBuID0gbi0+dHJhdmVyc2VOZXh0Tm9kZShub2RlKSkKLSAg ICAgICAgICAgICAgICAgICAgc3RyICs9IHN0cmluZ1ZhbHVlKG4pOworICAgICAgICAgICAgICAg ICAgICBpZiAobi0+aXNUZXh0Tm9kZSgpKQorICAgICAgICAgICAgICAgICAgICAgICAgc3RyICs9 IG5vZGVWYWx1ZShuKTsKIAogICAgICAgICAgICAgICAgIHJldHVybiBzdHI7CiAgICAgICAgICAg ICB9Cg==