130058 2014-03-10 17:59:32 -0700 [iOS][WebKit 2] Wire the unobscured rect in the WebProcess 2014-03-10 18:28:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 989142 0 benjamin 2014-03-10 17:59:32 -0700 [iOS][WebKit 2] Wire the unobscured rect in the WebProcess 989152 1 226361 benjamin 2014-03-10 18:21:05 -0700 Created attachment 226361 Patch 989153 2 226361 simon.fraser 2014-03-10 18:24:19 -0700 Comment on attachment 226361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226361&action=review > Source/WebCore/platform/ScrollView.h:184 > + // Only valid without platform widget. This comment is a bit vague. I'd say "The given rects are only used if there is no platform widget". 989157 3 benjamin 2014-03-10 18:28:51 -0700 Committed r165422: <http://trac.webkit.org/changeset/165422> 226361 2014-03-10 18:21:05 -0700 2014-03-10 18:24:19 -0700 Patch bug-130058-20140310182105.patch text/plain 6103 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc0Y2NjYzViYWQ1Y2Ji ZjQzNjU4NDk2ZDBhMTdlYzU2NzVlMzc5Yi4uYjFkZWU0MGMwMWRhNTU5MWRjZDQ0MjI4MGRjNjY2 YzQzZTA4ZWE4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTEwICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dlYktp dCAyXSBXaXJlIHRoZSB1bm9ic2N1cmVkIHJlY3QgaW4gdGhlIFdlYlByb2Nlc3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDA1OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46 CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5oOgorICAgICAgICAqIHBsYXRmb3JtL2lv cy9TY3JvbGxWaWV3SU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6dW5vYnNj dXJlZENvbnRlbnRSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnNldFVub2Jz Y3VyZWRDb250ZW50UmVjdCk6CisKIDIwMTQtMDMtMTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHRocmVlIGxlYWtzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZDdlNjNiZTA0NDhkYjhmOGExZDU2MzExMjkzNzI2YWZmYjczODY2ZS4uMzM2MWYyNDUzNGQwZTFi ZTU2MWRlYjQ4NWQzYjA5MGYxZjkzYThiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy MDE0LTAzLTEwICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAg ICAgIFtpT1NdW1dlYktpdCAyXSBXaXJlIHRoZSB1bm9ic2N1cmVkIHJlY3QgaW4gdGhlIFdlYlBy b2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MDA1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlOjp1cGRhdGVWaXNpYmxlQ29udGVudFJlY3RzKToKKwogMjAxNC0wMy0xMCAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhyZWUgbGVh a3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXggYzk2MmQzNDVjMWMzOWJkYzdkOGQxZjU1ODFiNDJh OWQxODhkNjdhMS4uNzZkN2EwMmU0YzQwNjdiOThiZjIwMWJkZjkwNzNhMDljYjk4NTM4ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNv cmUvV2ViQ29yZS5leHAuaW4KQEAgLTIzOTUsNiArMjM5NSw3IEBAIF9XZWJVSUFwcGxpY2F0aW9u V2lsbFJlc2lnbkFjdGl2ZU5vdGlmaWNhdGlvbgogX19aTjdXZWJDb3JlMTBGbG9hdFBvaW50QzFF Uks3Q0dQb2ludAogX19aTjdXZWJDb3JlMTBTY3JvbGxWaWV3MTVzZXRTY3JvbGxPZmZzZXRFUktO U184SW50UG9pbnRFCiBfX1pON1dlYkNvcmUxMFNjcm9sbFZpZXcyMXNldEV4cG9zZWRDb250ZW50 UmVjdEVSS05TXzdJbnRSZWN0RQorX19aTjdXZWJDb3JlMTBTY3JvbGxWaWV3MjRzZXRVbm9ic2N1 cmVkQ29udGVudFJlY3RFUktOU183SW50UmVjdEUKIF9fWk43V2ViQ29yZTEwWExpbmtOYW1lczRp bml0RXYKIF9fWk43V2ViQ29yZTEwaW5TYW1lTGluZUVSS05TXzE1VmlzaWJsZVBvc2l0aW9uRVMy XwogX19aTjdXZWJDb3JlMTFCaWRpQ29udGV4dDQxY29weVN0YWNrUmVtb3ZpbmdVbmljb2RlRW1i ZWRkaW5nQ29udGV4dHNFdgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Ny b2xsVmlldy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCmluZGV4IDEz NjZmNjEwNTlkMGEwNjQ2YTk4NjM1MmM5ODdmOGVmYjY2ZGY2M2QuLmYzZmNjYTA5YzdlMTNlNzU5 MjE0Njc3YzFiMTYzM2Y0YzM3NmRkOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1Njcm9sbFZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3 LmgKQEAgLTE4MCw3ICsxODAsMTAgQEAgcHVibGljOgogI2lmIFBMQVRGT1JNKElPUykKICAgICAv LyBUaGlzIGlzIHRoZSBhcmVhIHRoYXQgaXMgcGFydGlhbGx5IG9yIGZ1bGx5IGV4cG9zZWQsIGFu ZCBtYXkgZXh0ZW5kIHVuZGVyIG92ZXJsYXBwaW5nIFVJIGVsZW1lbnRzLgogICAgIEludFJlY3Qg ZXhwb3NlZENvbnRlbnRSZWN0KCkgY29uc3Q7CisKKyAgICAvLyBPbmx5IHZhbGlkIHdpdGhvdXQg cGxhdGZvcm0gd2lkZ2V0LgogICAgIHZvaWQgc2V0RXhwb3NlZENvbnRlbnRSZWN0KGNvbnN0IElu dFJlY3QmKTsKKyAgICB2b2lkIHNldFVub2JzY3VyZWRDb250ZW50UmVjdChjb25zdCBJbnRSZWN0 Jik7CiAKICAgICB2b2lkIHNldEFjdHVhbFNjcm9sbFBvc2l0aW9uKGNvbnN0IEludFBvaW50Jik7 CiAgICAgVGlsZUNhY2hlKiB0aWxlQ2FjaGUoKTsKQEAgLTQwNiw2ICs0MDksNyBAQCBwcml2YXRl OgogICAgIC8vIGJldHdlZW4gZXhwb3NlZCByZWN0IGFuZCB1bm9ic2N1cmVkUmVjdHMuIFRoZSB0 d28gYXR0cmlidXRlcyBzaG91bGQgZXZlbnR1YWxseSBiZSBtZXJnZWQuCiAjaWYgUExBVEZPUk0o SU9TKQogICAgIEludFJlY3QgbV9leHBvc2VkQ29udGVudFJlY3Q7CisgICAgSW50UmVjdCBtX3Vu b2JzY3VyZWRDb250ZW50UmVjdDsKICNlbHNlCiAgICAgSW50UmVjdCBtX2ZpeGVkVmlzaWJsZUNv bnRlbnRSZWN0OwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvU2Nyb2xsVmlld0lPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9TY3JvbGxW aWV3SU9TLm1tCmluZGV4IGQ3YTAxMzFjZmJmMzRjNDBmYTcwYzM3ZGZiZWFkMjRjYTE4ZjA4NDQu LjA3ZmUxOWRkNWVlOWZkZmIwZGVmZThjNjBlNjA2YzcwYzEyMjA3NTcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9TY3JvbGxWaWV3SU9TLm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9TY3JvbGxWaWV3SU9TLm1tCkBAIC05OCwxMiArOTgsMjQgQEAg Ym9vbCBTY3JvbGxWaWV3OjpwbGF0Zm9ybUNhbkJsaXRPblNjcm9sbCgpIGNvbnN0CiAKIEludFJl Y3QgU2Nyb2xsVmlldzo6dW5vYnNjdXJlZENvbnRlbnRSZWN0KCkgY29uc3QKIHsKLSAgICBDR1Jl Y3QgciA9IENHUmVjdFplcm87Ci0gICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwotICAg IFdBS1Njcm9sbFZpZXcgKnZpZXcgPSBzdGF0aWNfY2FzdDxXQUtTY3JvbGxWaWV3ICo+KHBsYXRm b3JtV2lkZ2V0KCkpOwotICAgIHIgPSBbdmlldyB1bm9ic2N1cmVkQ29udGVudFJlY3RdOwotICAg IEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7Ci0gICAgcmV0dXJuIGVuY2xvc2luZ0ludFJlY3Qo cik7CisgICAgaWYgKFdBS1Njcm9sbFZpZXcgKnZpZXcgPSBzdGF0aWNfY2FzdDxXQUtTY3JvbGxW aWV3ICo+KHBsYXRmb3JtV2lkZ2V0KCkpKSB7CisgICAgICAgIENHUmVjdCByID0gQ0dSZWN0WmVy bzsKKyAgICAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOworICAgICAgICByID0gW3Zp ZXcgdW5vYnNjdXJlZENvbnRlbnRSZWN0XTsKKyAgICAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBU SU9OUzsKKyAgICAgICAgcmV0dXJuIGVuY2xvc2luZ0ludFJlY3Qocik7CisgICAgfQorCisgICAg aWYgKCFtX3Vub2JzY3VyZWRDb250ZW50UmVjdC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBt X3Vub2JzY3VyZWRDb250ZW50UmVjdDsKKworICAgIHJldHVybiB2aXNpYmxlQ29udGVudFJlY3RJ bmNsdWRpbmdTY3JvbGxiYXJzKCk7Cit9CisKK3ZvaWQgU2Nyb2xsVmlldzo6c2V0VW5vYnNjdXJl ZENvbnRlbnRSZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCit7CisgICAgQVNTRVJUKCFwbGF0Zm9y bVdpZGdldCgpKTsKKyAgICBtX3Vub2JzY3VyZWRDb250ZW50UmVjdCA9IHJlY3Q7CiB9CiAKIElu dFJlY3QgU2Nyb2xsVmlldzo6ZXhwb3NlZENvbnRlbnRSZWN0KCkgY29uc3QKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCA2 OTFiZDc4NDc0ZTRjMTI1ZDZmNTg4ZTBmYzc3ZjAzNDFlZDM4YWYyLi40NzVmMDdkMzNmMDY5YzFk MzUxNmJhNjI3OTAzYzlmODMwODc2M2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0xNzM0LDcgKzE3MzQsOCBAQCB2 b2lkIFdlYlBhZ2U6OnVwZGF0ZVZpc2libGVDb250ZW50UmVjdHMoY29uc3QgVmlzaWJsZUNvbnRl bnRSZWN0VXBkYXRlSW5mbyYgdmlzaQogICAgIEZsb2F0UmVjdCBleHBvc2VkUmVjdCA9IHZpc2li bGVDb250ZW50UmVjdFVwZGF0ZUluZm8uZXhwb3NlZFJlY3QoKTsKICAgICBtX2RyYXdpbmdBcmVh LT5zZXRFeHBvc2VkQ29udGVudFJlY3QoZW5jbG9zaW5nSW50UmVjdChleHBvc2VkUmVjdCkpOwog Ci0gICAgSW50UG9pbnQgc2Nyb2xsUG9zaXRpb24gPSByb3VuZGVkSW50UG9pbnQodmlzaWJsZUNv bnRlbnRSZWN0VXBkYXRlSW5mby51bm9ic2N1cmVkUmVjdCgpLmxvY2F0aW9uKCkpOworICAgIElu dFJlY3Qgcm91bmRlZFVub2JzY3VyZWRSZWN0ID0gcm91bmRlZEludFJlY3QodmlzaWJsZUNvbnRl bnRSZWN0VXBkYXRlSW5mby51bm9ic2N1cmVkUmVjdCgpKTsKKyAgICBJbnRQb2ludCBzY3JvbGxQ b3NpdGlvbiA9IHJvdW5kZWRVbm9ic2N1cmVkUmVjdC5sb2NhdGlvbigpOwogCiAgICAgZG91Ymxl IGJvdW5kZWRTY2FsZSA9IHN0ZDo6bWluKG1fdmlld3BvcnRDb25maWd1cmF0aW9uLm1heGltdW1T Y2FsZSgpLCBzdGQ6Om1heChtX3ZpZXdwb3J0Q29uZmlndXJhdGlvbi5taW5pbXVtU2NhbGUoKSwg dmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlSW5mby5zY2FsZSgpKSk7CiAgICAgZmxvYXQgZmxvYXRC b3VuZGVkU2NhbGUgPSBib3VuZGVkU2NhbGU7CkBAIC0xNzQ4LDExICsxNzQ5LDEwIEBAIHZvaWQg V2ViUGFnZTo6dXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0cyhjb25zdCBWaXNpYmxlQ29udGVudFJl Y3RVcGRhdGVJbmZvJiB2aXNpCiAgICAgfQogCiAgICAgbV9wYWdlLT5tYWluRnJhbWUoKS52aWV3 KCktPnNldFNjcm9sbE9mZnNldChzY3JvbGxQb3NpdGlvbik7Ci0gICAgCisgICAgbV9wYWdlLT5t YWluRnJhbWUoKS52aWV3KCktPnNldFVub2JzY3VyZWRDb250ZW50UmVjdChyb3VuZGVkVW5vYnNj dXJlZFJlY3QpOworCiAgICAgaWYgKHZpc2libGVDb250ZW50UmVjdFVwZGF0ZUluZm8uaW5TdGFi bGVTdGF0ZSgpKQogICAgICAgICBtX3BhZ2UtPm1haW5GcmFtZSgpLnZpZXcoKS0+c2V0Q3VzdG9t Rml4ZWRQb3NpdGlvbkxheW91dFJlY3QoZW5jbG9zaW5nSW50UmVjdCh2aXNpYmxlQ29udGVudFJl Y3RVcGRhdGVJbmZvLmN1c3RvbUZpeGVkUG9zaXRpb25SZWN0KCkpKTsKLQotICAgIC8vIEZJWE1F OiB3ZSBzaG91bGQgYWxzbyB1cGRhdGUgdGhlIGZyYW1lIHZpZXcgZnJvbSB1bm9ic2N1cmVkIHJl Y3QuIEFsdGVuYXRpdmVseSwgd2UgY2FuIGhhdmUgaXQgcHVsbCB0aGUgdmFsdWVzIGZyb20gU2Ny b2xsVmlldy4KIH0KIAogdm9pZCBXZWJQYWdlOjp3aWxsU3RhcnRVc2VyVHJpZ2dlcmVkWm9vbWlu ZygpCg==