130048 2014-03-10 15:57:54 -0700 Fix three leaks 2014-03-10 16:49:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 989090 0 simon.fraser 2014-03-10 15:57:54 -0700 Fix three leaks 989091 1 226346 simon.fraser 2014-03-10 15:59:07 -0700 Created attachment 226346 Patch 989092 2 226346 andersca 2014-03-10 15:59:53 -0700 Comment on attachment 226346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226346&action=review > Source/WebCore/page/ios/UserAgentIOS.mm:47 > + RetainPtr<NSDictionary> systemInfo = adoptNS([[NSDictionary alloc] initWithContentsOfFile:[platformSystemRootDirectory() stringByAppendingPathComponent:@"System/Library/CoreServices/SystemVersion.plist"]]); Can just use auto systemInfo =. 989096 3 simon.fraser 2014-03-10 16:03:31 -0700 https://trac.webkit.org/r165412 989121 4 226346 joepeck 2014-03-10 16:49:16 -0700 Comment on attachment 226346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226346&action=review > Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:512 > + return [result autorelease]; Shouldn't this also release result in the NSException raise cases if the alloc succeeded? Could the autorelease move up to line 500? 226346 2014-03-10 15:59:07 -0700 2014-03-10 16:49:15 -0700 Patch bug-130048-20140310155907.patch text/plain 4745 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFkNjBkOWEzYTI4MTkz NjM4OGUyMWU0Yzc1OTljMWFmZTdjMDQ1Yi4uZTVkYzU0MmI0MTU0Y2Q1NTJmNTUzMzNhOTY3MTdj MDI3YWM3MDQzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTEwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCB0aHJlZSBs ZWFrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMw MDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IE5TRGljdGlvbmFyeSB3YXMgbGVha2VkLgorCisgICAgICAgICogcGFnZS9pb3MvVXNlckFnZW50 SU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6b3NNYXJrZXRpbmdWZXJzaW9uKToKKwogMjAxNC0w My0xMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gW0NNYWtlXSBDbGVhbiB1cCBsaWJyYXJ5IGxpbmtpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAyODQx YjQ5NDkwNjVlNTUyMDQ0Njk3NGU0NjQzZmY4MmY5ZDA4Y2M2Li42OTQxM2FjMTY0OWM3NzYyZGZm YmZlMzRhZTgxNmFmN2Y1N2MzOWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQt MDMtMTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAg Rml4IHRocmVlIGxlYWtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzAwNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbToKKyAgICAg ICAgKGRlY29kZU9iamVjdCk6IENvZGUgaXMgc2ltcGxlciBhbmQgbGVzcyBsZWFreSB3aXRob3V0 IHRoZSBSZXRhaW5QdHIuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRp b25BY3Rpb24ubW06IEZpeCBfb3JpZ2luYWxVUkwgbGVhaworICAgICAgICBieSBtYWtpbmcgaXQg YSBSZXRhaW5QdHIgYW5kIGltcGxlbWVudGluZyB0aGUgZ2V0dGVyIGFuZCBzZXR0ZXIuCisgICAg ICAgICgtW1dLTmF2aWdhdGlvbkFjdGlvbiBfc2V0T3JpZ2luYWxVUkw6XSk6CisgICAgICAgICgt W1dLTmF2aWdhdGlvbkFjdGlvbiBfb3JpZ2luYWxVUkxdKToKKwogMjAxNC0wMy0xMCAgTWFydGlu IFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gW0NNYWtl XSBDbGVhbiB1cCBsaWJyYXJ5IGxpbmtpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL1VzZXJBZ2VudElPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL1VzZXJBZ2Vu dElPUy5tbQppbmRleCA3ZjcyYWJlZTU1NzZlMTc1N2Q0ODAwZDFjYWE0MjQ4ODFjYWZhYmNkLi5h ODVkMWY2OWIzNjk1Mzc2OWE5YjA5MjI4OTE5ZTEwMTQ3YmYzNmUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2lvcy9Vc2VyQWdlbnRJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9pb3MvVXNlckFnZW50SU9TLm1tCkBAIC00NCw3ICs0NCw3IEBAIHN0YXRpYyBOU1N0cmlu ZyAqcGxhdGZvcm1TeXN0ZW1Sb290RGlyZWN0b3J5KCkKIAogc3RhdGljIE5TU3RyaW5nICpvc01h cmtldGluZ1ZlcnNpb24oKQogewotICAgIFJldGFpblB0cjxOU0RpY3Rpb25hcnk+IHN5c3RlbUlu Zm8gPSBbW05TRGljdGlvbmFyeSBhbGxvY10gaW5pdFdpdGhDb250ZW50c09mRmlsZTpbcGxhdGZv cm1TeXN0ZW1Sb290RGlyZWN0b3J5KCkgc3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OkAi U3lzdGVtL0xpYnJhcnkvQ29yZVNlcnZpY2VzL1N5c3RlbVZlcnNpb24ucGxpc3QiXV07CisgICAg UmV0YWluUHRyPE5TRGljdGlvbmFyeT4gc3lzdGVtSW5mbyA9IGFkb3B0TlMoW1tOU0RpY3Rpb25h cnkgYWxsb2NdIGluaXRXaXRoQ29udGVudHNPZkZpbGU6W3BsYXRmb3JtU3lzdGVtUm9vdERpcmVj dG9yeSgpIHN0cmluZ0J5QXBwZW5kaW5nUGF0aENvbXBvbmVudDpAIlN5c3RlbS9MaWJyYXJ5L0Nv cmVTZXJ2aWNlcy9TeXN0ZW1WZXJzaW9uLnBsaXN0Il1dKTsKICAgICBOU1N0cmluZyAqcHJvZHVj dFZlcnNpb24gPSBbc3lzdGVtSW5mbyBvYmplY3RGb3JLZXk6QCJQcm9kdWN0VmVyc2lvbiJdOwog ICAgIHJldHVybiAhcHJvZHVjdFZlcnNpb24gPyBAIiIgOiBbcHJvZHVjdFZlcnNpb24gc3RyaW5n QnlSZXBsYWNpbmdPY2N1cnJlbmNlc09mU3RyaW5nOkAiLiIgd2l0aFN0cmluZzpAIl8iXTsKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmpl Y3RDb2Rlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmpl Y3RDb2Rlci5tbQppbmRleCBkZmQ3MjExMjkxNzhkMTgyODRhMzM3YmZlM2I0OWViZmNkYWNlNmY5 Li4xMTQxOTM5NzRkMzdlMzM0MTdhMWQ2YzM2ZTVmOGU1ZmU0OWU0ZmNiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0KKysr IGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1t CkBAIC00OTcsNyArNDk3LDcgQEAgc3RhdGljIGlkIGRlY29kZU9iamVjdChXS1JlbW90ZU9iamVj dERlY29kZXIgKmRlY29kZXIpCiAgICAgaWYgKG9iamVjdENsYXNzID09IFtOU0ludm9jYXRpb24g Y2xhc3NdKQogICAgICAgICByZXR1cm4gZGVjb2RlSW52b2NhdGlvbihkZWNvZGVyKTsKIAotICAg IFJldGFpblB0cjxpZD4gcmVzdWx0ID0gW29iamVjdENsYXNzIGFsbG9jV2l0aFpvbmU6ZGVjb2Rl ci56b25lXTsKKyAgICBpZCByZXN1bHQgPSBbb2JqZWN0Q2xhc3MgYWxsb2NXaXRoWm9uZTpkZWNv ZGVyLnpvbmVdOwogICAgIGlmICghcmVzdWx0KQogICAgICAgICBbTlNFeGNlcHRpb24gcmFpc2U6 TlNJbnZhbGlkVW5hcmNoaXZlT3BlcmF0aW9uRXhjZXB0aW9uIGZvcm1hdDpAIkNsYXNzIFwiJXNc IiByZXR1cm5lZCBuaWwgZnJvbSArYWxsb2Mgd2hpbGUgYmVpbmcgZGVjb2RlZCIsIGNsYXNzTmFt ZS5kYXRhKCldOwogCkBAIC01MDksNyArNTA5LDcgQEAgc3RhdGljIGlkIGRlY29kZU9iamVjdChX S1JlbW90ZU9iamVjdERlY29kZXIgKmRlY29kZXIpCiAgICAgaWYgKCFyZXN1bHQpCiAgICAgICAg IFtOU0V4Y2VwdGlvbiByYWlzZTpOU0ludmFsaWRVbmFyY2hpdmVPcGVyYXRpb25FeGNlcHRpb24g Zm9ybWF0OkAiT2JqZWN0IG9mIGNsYXNzIFwiJXNcIiByZXR1cm5lZCBuaWwgZnJvbSAtYXdha2VB ZnRlclVzaW5nQ29kZXI6IHdoaWxlIGJlaW5nIGRlY29kZWQiLCBjbGFzc05hbWUuZGF0YSgpXTsK IAotICAgIHJldHVybiBbcmVzdWx0LmxlYWtSZWYoKSBhdXRvcmVsZWFzZV07CisgICAgcmV0dXJu IFtyZXN1bHQgYXV0b3JlbGVhc2VdOwogfQogCiBzdGF0aWMgaWQgZGVjb2RlT2JqZWN0KFdLUmVt b3RlT2JqZWN0RGVjb2RlciAqZGVjb2RlciwgY29uc3QgSW1tdXRhYmxlRGljdGlvbmFyeSogZGlj dGlvbmFyeSwgTlNTZXQgKmFsbG93ZWRDbGFzc2VzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRpb25BY3Rpb24ubW0gYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvbkFjdGlvbi5tbQppbmRleCBkMGJh MTNkNGM4YTM5ODk1ZDk4N2JiYzRlNjFiOWIwNmNmZjZmMzBjLi44Mzc2MTg0ZjEwNjA4YTdkNzIy MDYwZTQ0YTgzYzI0ODNjMzVhMzUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvbkFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvbkFjdGlvbi5tbQpAQCAtMzQsNiArMzQsNyBA QCBAaW1wbGVtZW50YXRpb24gV0tOYXZpZ2F0aW9uQWN0aW9uIHsKICAgICBSZXRhaW5QdHI8V0tG cmFtZUluZm8+IF9zb3VyY2VGcmFtZTsKICAgICBSZXRhaW5QdHI8V0tGcmFtZUluZm8+IF9kZXN0 aW5hdGlvbkZyYW1lOwogICAgIFJldGFpblB0cjxOU1VSTFJlcXVlc3Q+IF9yZXF1ZXN0OworICAg IFJldGFpblB0cjxOU1VSTD4gX29yaWdpbmFsVVJMOwogfQogCiAtIChOU1N0cmluZyAqKWRlc2Ny aXB0aW9uCkBAIC03Miw2ICs3MywxNiBAQCAtICh2b2lkKXNldFJlcXVlc3Q6KE5TVVJMUmVxdWVz dCAqKXJlcXVlc3QKICAgICBfcmVxdWVzdCA9IGFkb3B0TlMoW3JlcXVlc3QgY29weV0pOwogfQog CistICh2b2lkKV9zZXRPcmlnaW5hbFVSTDooTlNVUkwgKilvcmlnaW5hbFVSTAoreworICAgIF9v cmlnaW5hbFVSTCA9IGFkb3B0TlMoW29yaWdpbmFsVVJMIGNvcHldKTsKK30KKworLSAoTlNVUkwg Kilfb3JpZ2luYWxVUkwKK3sKKyAgICByZXR1cm4gX29yaWdpbmFsVVJMLmdldCgpOworfQorCiBA ZW5kCiAKICNlbmRpZgo=