130047 2014-03-10 15:55:31 -0700 Add SPI to run javascript in main frame on WKWebView 2014-03-13 19:02:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P4 Enhancement --- 1 hankesdrielsma webkit-unassigned commit-queue mitz oldest_to_newest 989089 0 hankesdrielsma 2014-03-10 15:55:31 -0700 Expose runJavascript API to WKWebView via SPI for use in Safari. 989097 1 226347 hankesdrielsma 2014-03-10 16:05:28 -0700 Created attachment 226347 Patch 989103 2 226347 mitz 2014-03-10 16:20:55 -0700 Comment on attachment 226347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226347&action=review > Source/WebKit2/ChangeLog:3 > + Add SPI to run javascript in main frame on WKWebView. No need for this. The bug title and URL below suffice. Although this makes for a better title than the bug’s current title. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:856 > + _page->runJavaScriptInMainFrame(scriptString, WebKit::ScriptValueCallback::create([](bool b, WebKit::WebSerializedScriptValue* sv){})); We typically don’t name unused parameters. 989417 3 226433 hankesdrielsma 2014-03-11 09:39:40 -0700 Created attachment 226433 Patch 990240 4 226433 commit-queue 2014-03-13 19:02:15 -0700 Comment on attachment 226433 Patch Clearing flags on attachment: 226433 Committed r165591: <http://trac.webkit.org/changeset/165591> 990241 5 commit-queue 2014-03-13 19:02:18 -0700 All reviewed patches have been landed. Closing bug. 226347 2014-03-10 16:05:28 -0700 2014-03-11 09:39:38 -0700 Patch bug-130047-20140310160528.patch text/plain 2166 hankesdrielsma U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTlhODY1NDY5OThmNThm YjIyMWMxYzIwMzUzM2QxNzhjN2U3ZTYwYi4uZDM1ZDZiNzMzYjRmMzJiZDAyNDUyZWM3Zjk0ZmQ4 OTY4NWQ0ZGM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTEwICBQYXVs IEhhbmtlcyBEcmllbHNtYSAgPHBoZEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIFNQSSB0byBy dW4gamF2YXNjcmlwdCBpbiBtYWluIGZyYW1lIG9uIFdLV2ViVmlldy4KKworICAgICAgICBFeHBv c2UgcnVuSmF2YXNjcmlwdCBBUEkgdG8gV0tXZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAwNDcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3J1bkphdmFTY3JpcHRJbk1haW5GcmFtZTpdKToK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDoKKwogMjAx NC0wMy0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gVGhlIHdlYiBwcm9jZXNzIGNhbiBmaW5pc2ggd2hpbGUgYSBwcmludCBvcGVy YXRpb24gaXMgc3RpbGwgb25nb2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbQppbmRleCBiMDRkMTgwMDNhMGIzYzk4M2EyMDk0NTk5MTliNjU4 NGJjNzgzOGQ5Li5jNGU4ZjNlMTA1NWU2OWY4NjM3NDVjMjliNGQ5MmRkMGM0NmE0YjczIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAt ODUxLDYgKzg1MSwxMSBAQCBzdGF0aWMgaW5saW5lIFdlYkNvcmU6OkxheW91dE1pbGVzdG9uZXMg bGF5b3V0TWlsZXN0b25lcyhfV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZQogICAgIF9wYWdlLT5saXN0 ZW5Gb3JMYXlvdXRNaWxlc3RvbmVzKGxheW91dE1pbGVzdG9uZXMob2JzZXJ2ZWRSZW5kZXJpbmdQ cm9ncmVzc0V2ZW50cykpOwogfQogCistICh2b2lkKV9ydW5KYXZhU2NyaXB0SW5NYWluRnJhbWU6 KE5TU3RyaW5nICopc2NyaXB0U3RyaW5nCit7CisgICAgX3BhZ2UtPnJ1bkphdmFTY3JpcHRJbk1h aW5GcmFtZShzY3JpcHRTdHJpbmcsIFdlYktpdDo6U2NyaXB0VmFsdWVDYWxsYmFjazo6Y3JlYXRl KFtdKGJvb2wgYiwgV2ViS2l0OjpXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUqIHN2KXt9KSk7Cit9 CisKICNwcmFnbWEgbWFyayBpT1Mtc3BlY2lmaWMgbWV0aG9kcwogCiAjaWYgUExBVEZPUk0oSU9T KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXdQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d1ByaXZhdGUuaAppbmRleCA0N2Q1YTViMTc2MmM3YzY1MzVhY2JhOTA1ZGM5M2Q3MzA0ZGQ5YTdm Li5jY2RkYjE4M2QyNThlOTQ4MzY4NGJlY2IwMDJhMWYyOTRiMDJlNDZhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaApA QCAtNzgsNiArNzgsOCBAQCB0eXBlZGVmIE5TX09QVElPTlMoTlNVSW50ZWdlciwgX1dLUmVuZGVy aW5nUHJvZ3Jlc3NFdmVudHMpIHsKIEBwcm9wZXJ0eSAocmVhZG9ubHkpIE5TQ29sb3IgKl9wYWdl RXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3I7CiAjZW5kaWYKIAorLSAodm9pZClfcnVuSmF2YVNjcmlw dEluTWFpbkZyYW1lOihOU1N0cmluZyAqKXNjcmlwdFN0cmluZzsKKwogQGVuZAogCiAjZW5kaWYK 226433 2014-03-11 09:39:40 -0700 2014-03-13 19:02:15 -0700 Patch bug-130047-20140311093939.patch text/plain 2060 hankesdrielsma U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTlhODY1NDY5OThmNThm YjIyMWMxYzIwMzUzM2QxNzhjN2U3ZTYwYi4uMzBjMTZmNWVkM2Q5YTI0MWNjYzViODg1NGQxNTA4 YTFmNzkxOWZkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAzLTExICBQYXVs IEhhbmtlcyBEcmllbHNtYSAgPHBoZEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIFNQSSB0byBy dW4gamF2YXNjcmlwdCBpbiBtYWluIGZyYW1lIG9uIFdLV2ViVmlldworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMDQ3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9ydW5KYXZhU2NyaXB0SW5NYWluRnJh bWU6XSk6CisKIDIwMTQtMDMtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIFRoZSB3ZWIgcHJvY2VzcyBjYW4gZmluaXNoIHdoaWxl IGEgcHJpbnQgb3BlcmF0aW9uIGlzIHN0aWxsIG9uZ29pbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggYjA0ZDE4MDAzYTBiM2M5ODNh MjA5NDU5OTE5YjY1ODRiYzc4MzhkOS4uNTc2Y2I3YmE2MjZjMGUxNmU2Nzk5ZWJlZDE3YjU1M2M5 MWU3NDkxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0KQEAgLTg1MSw2ICs4NTEsMTEgQEAgc3RhdGljIGlubGluZSBXZWJDb3JlOjpMYXlv dXRNaWxlc3RvbmVzIGxheW91dE1pbGVzdG9uZXMoX1dLUmVuZGVyaW5nUHJvZ3Jlc3NFdmUKICAg ICBfcGFnZS0+bGlzdGVuRm9yTGF5b3V0TWlsZXN0b25lcyhsYXlvdXRNaWxlc3RvbmVzKG9ic2Vy dmVkUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHMpKTsKIH0KIAorLSAodm9pZClfcnVuSmF2YVNjcmlw dEluTWFpbkZyYW1lOihOU1N0cmluZyAqKXNjcmlwdFN0cmluZworeworICAgIF9wYWdlLT5ydW5K YXZhU2NyaXB0SW5NYWluRnJhbWUoc2NyaXB0U3RyaW5nLCBXZWJLaXQ6OlNjcmlwdFZhbHVlQ2Fs bGJhY2s6OmNyZWF0ZShbXShib29sLCBXZWJLaXQ6OldlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSop e30pKTsKK30KKwogI3ByYWdtYSBtYXJrIGlPUy1zcGVjaWZpYyBtZXRob2RzCiAKICNpZiBQTEFU Rk9STShJT1MpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlld1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3UHJpdmF0ZS5oCmluZGV4IDQ3ZDVhNWIxNzYyYzdjNjUzNWFjYmE5MDVkYzkzZDcz MDRkZDlhN2YuLmNjZGRiMTgzZDI1OGU5NDgzNjg0YmVjYjAwMmExZjI5NGIwMmU0NmEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0 ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJp dmF0ZS5oCkBAIC03OCw2ICs3OCw4IEBAIHR5cGVkZWYgTlNfT1BUSU9OUyhOU1VJbnRlZ2VyLCBf V0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50cykgewogQHByb3BlcnR5IChyZWFkb25seSkgTlNDb2xv ciAqX3BhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvcjsKICNlbmRpZgogCistICh2b2lkKV9ydW5K YXZhU2NyaXB0SW5NYWluRnJhbWU6KE5TU3RyaW5nICopc2NyaXB0U3RyaW5nOworCiBAZW5kCiAK ICNlbmRpZgo=