130042 2014-03-10 15:05:36 -0700 Web Inspector: console error when clicking AppCache folder tree element 2015-08-04 11:57:28 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bburg burg bburg commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 989064 0 bburg 2014-03-10 15:05:36 -0700 It's trying to make a content view out of it, but that ain't gonna work. It's inside a try-catch block, so it doesn't actually break anything. 989768 1 timothy 2014-03-12 11:48:29 -0700 Sounds like we just need to add the class to the early return in ReourceSidebarPanel._treeElementSelected. Or come up with a special function on these tree elements (isFolder()?) that we can check. 1114049 2 258014 burg 2015-08-01 12:55:01 -0700 Created attachment 258014 Proposed Fix 1114649 3 258014 joepeck 2015-08-04 11:04:29 -0700 Comment on attachment 258014 Proposed Fix This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is not a subclass of FolderTreeElement if it acts like a folder. 1114662 4 bburg 2015-08-04 11:21:24 -0700 (In reply to comment #3) > Comment on attachment 258014 [details] > Proposed Fix > > This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is > not a subclass of FolderTreeElement if it acts like a folder. It probably should be, or we should have a content view for the appcache manifest and change what appears for each frame that uses the same manifest. But there are larger problems with our app cache support (there are no real model objects to speak of; the content view directly unpacks protocol payloads), so I'd defer on further refactoring. 1114684 5 258014 commit-queue 2015-08-04 11:57:25 -0700 Comment on attachment 258014 Proposed Fix Clearing flags on attachment: 258014 Committed r187872: <http://trac.webkit.org/changeset/187872> 1114685 6 commit-queue 2015-08-04 11:57:28 -0700 All reviewed patches have been landed. Closing bug. 258014 2015-08-01 12:55:01 -0700 2015-08-04 11:57:25 -0700 Proposed Fix bug-130042-20150801125458.patch text/plain 2144 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3Njg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 ZmExNDEwMGNhNzkyMjdmOTYxMzNmNWNlYzNmOWExMDI3NWY3MDUxLi5lMDFjMGEzODA4NGNhNDFk NmNkYjNmZDIyZTZmN2Y0ZDFjYjY4ZjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNS0wOC0wMSAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY29uc29sZSBlcnJvciB3aGVuIGNsaWNr aW5nIEFwcENhY2hlIGZvbGRlciB0cmVlIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDA0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TdG9yYWdlU2lk ZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0b3JhZ2VTaWRlYmFyUGFuZWwu X3RyZWVFbGVtZW50U2VsZWN0ZWQpOiBEb24ndCB0cnkgdG8KKyAgICAgICAgY3JlYXRlIGEgY29u dGVudCB2aWV3IGZvciBBcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RUcmVlRWxlbWVudC4gV2UgY2Fu CisgICAgICAgIG9ubHkgY3JlYXRlIGEgY29udGVudCB2aWV3IGZvciBBcHBDYWNoZSBmcmFtZXMu CisKIDIwMTUtMDctMzEgIEJyaWFuIEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1Pgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnZlcnQgdGltZWxpbmUgdmlldyBjbGFzc2VzIHRv IEVTNiBjbGFzc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TdG9yYWdlU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVNpZGViYXJQYW5lbC5qcwppbmRleCBiMjlhYzdj NDMwZjcxMWUyYTk3YWFmNDEyNDEzNzg4YzhlZDI2MzA5Li5hZmQxYmYwOTgxYTA3MTMxOTkxYTQ3 YTgxM2VkODAwMmQ4YWE1ZDk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9TdG9yYWdlU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0b3JhZ2VTaWRlYmFyUGFuZWwuanMKQEAg LTE2NCw3ICsxNjQsOCBAQCBXZWJJbnNwZWN0b3IuU3RvcmFnZVNpZGViYXJQYW5lbCA9IGNsYXNz IFN0b3JhZ2VTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWN0bwogICAgIF90cmVlRWxlbWVu dFNlbGVjdGVkKHRyZWVFbGVtZW50LCBzZWxlY3RlZEJ5VXNlcikKICAgICB7CiAgICAgICAgIGlm ICh0cmVlRWxlbWVudCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Gb2xkZXJUcmVlRWxlbWVudCB8 fCB0cmVlRWxlbWVudCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5EYXRhYmFzZUhvc3RUcmVlRWxl bWVudCB8fAotICAgICAgICAgICAgdHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3Iu SW5kZXhlZERhdGFiYXNlSG9zdFRyZWVFbGVtZW50IHx8IHRyZWVFbGVtZW50IGluc3RhbmNlb2Yg V2ViSW5zcGVjdG9yLkluZGV4ZWREYXRhYmFzZVRyZWVFbGVtZW50KQorICAgICAgICAgICAgdHJl ZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuSW5kZXhlZERhdGFiYXNlSG9zdFRyZWVF bGVtZW50IHx8IHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkluZGV4ZWREYXRh YmFzZVRyZWVFbGVtZW50CisgICAgICAgICAgICB8fCB0cmVlRWxlbWVudCBpbnN0YW5jZW9mIFdl Ykluc3BlY3Rvci5BcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RUcmVlRWxlbWVudCkKICAgICAgICAg ICAgIHJldHVybjsKIAogICAgICAgICBpZiAodHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNw ZWN0b3IuU3RvcmFnZVRyZWVFbGVtZW50IHx8IHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5z cGVjdG9yLkRhdGFiYXNlVGFibGVUcmVlRWxlbWVudCB8fAo=