130034 2014-03-10 12:26:51 -0700 REGRESSION (r159218): FrameView::layout() should destroy TemporaryChange<LayoutPhase> before destroying Ref<FrameView> 2014-03-10 12:56:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 dbates dbates ddkilzer hyatt simon.fraser zalan oldest_to_newest 989024 0 dbates 2014-03-10 12:26:51 -0700 We should always destroy TemporaryChange<LayoutPhase> before destroying Ref<FrameView> in FrameView::layout() so as to ensure that the FrameView exists when we restore the original layout phase value. 989025 1 dbates 2014-03-10 12:27:04 -0700 <rdar://problem/15664288> 989026 2 226330 dbates 2014-03-10 12:30:34 -0700 Created attachment 226330 Patch 989031 3 226330 zalan 2014-03-10 12:50:50 -0700 Comment on attachment 226330 Patch Looks good. 989033 4 dbates 2014-03-10 12:56:49 -0700 Committed r165396: <http://trac.webkit.org/changeset/165396> 226330 2014-03-10 12:30:34 -0700 2014-03-10 12:52:59 -0700 Patch bug-130034-20140310123041.patch text/plain 2333 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQyMTk2MTIzOTcwYmU5 ZGVlYjQ4YWM1Y2QxZjMzOGI3MWEwOTBiOC4uNjVkMDNjZDU2MzdmNTAxZWI3ZjBlYjdhZjdhNmNj NTI4NjlhMDQ3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAzLTEwICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBGcmFtZVZpZXc6OmxheW91 dCgpIHNob3VsZCBkZXN0cm95IFRlbXBvcmFyeUNoYW5nZTxMYXlvdXRQaGFzZT4gYmVmb3JlIGRl c3Ryb3lpbmcgUmVmPEZyYW1lVmlldz4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMDAzNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU2NjQyODg+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hv dWxkIGFsd2F5cyBkZXN0cm95IFRlbXBvcmFyeUNoYW5nZTxMYXlvdXRQaGFzZT4gYmVmb3JlIGRl c3Ryb3lpbmcgUmVmPEZyYW1lVmlldz4KKyAgICAgICAgaW4gRnJhbWVWaWV3OjpsYXlvdXQoKSBz byBhcyB0byBlbnN1cmUgdGhhdCB0aGUgRnJhbWVWaWV3IGV4aXN0cyB3aGVuIHdlIHJlc3RvcmUg dGhlCisgICAgICAgIG9yaWdpbmFsIGxheW91dCBwaGFzZSB2YWx1ZS4KKworICAgICAgICBUaGUg ZXhpc3RpbmcgdGVzdCBmYXN0L2ZyYW1lcy9jcmFzaC1yZW1vdmUtaWZyYW1lLWR1cmluZy1vYmpl Y3QtYmVmb3JlbG9hZC5odG1sIGNvdmVycworICAgICAgICB0aGlzIGNoYW5nZS4gQWx0aG91Z2gg eW91IG11c3QgcnVuIHRoZSB0ZXN0IHdpdGggR3VhcmQgTWFsbG9jIGVuYWJsZWQgKGkuZS4gcnVu LXdlYmtpdC10ZXN0cyAtcikuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmxheW91dCk6IE1vdmUgYWxsb2NhdGlvbiBvZiB2YXJp YWJsZSBwcm90ZWN0IGJlZm9yZSB0aGUgYWxsb2NhdGlvbiBvZgorICAgICAgICB2YXJpYWJsZSBs YXlvdXRQaGFzZVJlc3RvcmVyLiBBZGRpdGlvbmFsbHksIGFkZCBhIHBlcmlvZCB0byB0aGUgZW5k IG9mIHRoZSBjb21tZW50IGFzc29jaWF0ZWQKKyAgICAgICAgd2l0aCB2YXJpYWJsZSBwcm90ZWN0 LgorCiAyMDE0LTAzLTA1ICBSYWR1IFN0YXZpbGEgIDxzdGF2aWxhQGFkb2JlLmNvbT4KIAogICAg ICAgICBbQ1NTIFJlZ2lvbnNdIFNjcm9sbGFibGUgcmVnaW9ucwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwCmluZGV4IGNjYWMxMTFlMTA2N2RlZTMxMzkyMzk4NjNhNzVhMjczMTJjNmUwNTcuLmE0 MmZmOGQxOTU1YjMzYzg4MWViMzg4NTljMzE5ODFlZGE0MzJjODkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKQEAgLTEwNTYsMTMgKzEwNTYsMTMgQEAgdm9pZCBGcmFtZVZpZXc6OmxheW91 dChib29sIGFsbG93U3VidHJlZSkKICAgICBpZiAoaXNJbkxheW91dCgpKQogICAgICAgICByZXR1 cm47CiAKKyAgICAvLyBQcm90ZWN0IHRoZSB2aWV3IGZyb20gYmVpbmcgZGVsZXRlZCBkdXJpbmcg bGF5b3V0IChpbiByZWNhbGNTdHlsZSkuCisgICAgUmVmPEZyYW1lVmlldz4gcHJvdGVjdCgqdGhp cyk7CisKICAgICAvLyBNYW55IG9mIHRoZSB0YXNrcyBwZXJmb3JtZWQgZHVyaW5nIGxheW91dCBj YW4gY2F1c2UgdGhpcyBmdW5jdGlvbiB0byBiZSByZS1lbnRlcmVkLAogICAgIC8vIHNvIHNhdmUg dGhlIGxheW91dCBwaGFzZSBub3cgYW5kIHJlc3RvcmUgaXQgb24gZXhpdC4KICAgICBUZW1wb3Jh cnlDaGFuZ2U8TGF5b3V0UGhhc2U+IGxheW91dFBoYXNlUmVzdG9yZXIobV9sYXlvdXRQaGFzZSwg SW5QcmVMYXlvdXQpOwogCi0gICAgLy8gUHJvdGVjdCB0aGUgdmlldyBmcm9tIGJlaW5nIGRlbGV0 ZWQgZHVyaW5nIGxheW91dCAoaW4gcmVjYWxjU3R5bGUpCi0gICAgUmVmPEZyYW1lVmlldz4gcHJv dGVjdCgqdGhpcyk7Ci0KICAgICAvLyBFdmVyeSBzY3JvbGwgdGhhdCBoYXBwZW5zIGR1cmluZyBs YXlvdXQgaXMgcHJvZ3JhbW1hdGljLgogICAgIFRlbXBvcmFyeUNoYW5nZTxib29sPiBjaGFuZ2VJ blByb2dyYW1tYXRpY1Njcm9sbChtX2luUHJvZ3JhbW1hdGljU2Nyb2xsLCB0cnVlKTsKIAo=