130030 2014-03-10 11:41:12 -0700 writeBarrier in emitPutReplaceStub is unnecessary 2014-03-10 11:49:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 988977 0 mhahnenberg 2014-03-10 11:41:12 -0700 We already emit write barriers for each put-by-id when they're first compiled, so it's redundant to emit a write barrier as part of the repatched code. 988978 1 226321 mhahnenberg 2014-03-10 11:42:28 -0700 Created attachment 226321 Patch 988981 2 226322 mhahnenberg 2014-03-10 11:45:43 -0700 Created attachment 226322 Patch 988985 3 mhahnenberg 2014-03-10 11:49:29 -0700 Committed r165389: <http://trac.webkit.org/changeset/165389> 226321 2014-03-10 11:42:28 -0700 2014-03-10 11:45:41 -0700 Patch bug-130030-20140310113858.patch text/plain 1731 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1Mzg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAzLTEwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgd3JpdGVCYXJyaWVyIGluIGVtaXRQdXRSZXBsYWNlU3R1YiBpcyB1bm5lY2Vzc2Fy eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMDMw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYWxy ZWFkeSBlbWl0IHdyaXRlIGJhcnJpZXJzIGZvciBlYWNoIHB1dC1ieS1pZCB3aGVuIHRoZXkncmUg Zmlyc3QgY29tcGlsZWQsIHNvIGl0J3MgCisgICAgICAgIHJlZHVuZGFudCB0byBlbWl0IGEgd3Jp dGUgYmFycmllciBhcyBwYXJ0IG9mIHRoZSByZXBhdGNoZWQgY29kZS4KKworICAgICAgICAqIGpp dC9SZXBhdGNoLmNwcDoKKyAgICAgICAgKEpTQzo6ZW1pdFB1dFJlcGxhY2VTdHViKToKKwogMjAx NC0wMy0xMCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW1g4 Nl82NF0gU21hbGxlciBjb2RlIGZvciB4b3JfaXIgd2hlbiByZWdpc3RlciBpcyBhY2N1bXVsYXRv ci4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAkocmV2aXNpb24gMTY1 MzgxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODg5LDEwICs4ODksNiBAQCBzdGF0aWMgdm9pZCBlbWl0UHV0UmVwbGFjZVN0dWIo CiAgICAgfQogI2VuZGlmCiAgICAgCi0jaWYgRU5BQkxFKEdHQykKLSAgICBNYWNyb0Fzc2VtYmxl cjo6Q2FsbCB3cml0ZUJhcnJpZXJPcGVyYXRpb24gPSB3cml0ZUJhcnJpZXIoc3R1YkppdCwgYmFz ZUdQUiwgc2NyYXRjaEdQUjEsIHNjcmF0Y2hHUFIyLCBhbGxvY2F0b3IpOwotI2VuZGlmCi0gICAg CiAgICAgTWFjcm9Bc3NlbWJsZXI6Okp1bXAgc3VjY2VzczsKICAgICBNYWNyb0Fzc2VtYmxlcjo6 SnVtcCBmYWlsdXJlOwogICAgIApAQCAtOTA5LDkgKzkwNSw2IEBAIHN0YXRpYyB2b2lkIGVtaXRQ dXRSZXBsYWNlU3R1YigKICAgICB9CiAgICAgCiAgICAgTGlua0J1ZmZlciBwYXRjaEJ1ZmZlcigq dm0sICZzdHViSml0LCBleGVjLT5jb2RlQmxvY2soKSk7Ci0jaWYgRU5BQkxFKEdHQykKLSAgICBw YXRjaEJ1ZmZlci5saW5rKHdyaXRlQmFycmllck9wZXJhdGlvbiwgb3BlcmF0aW9uRmx1c2hXcml0 ZUJhcnJpZXJCdWZmZXIpOwotI2VuZGlmCiAgICAgcGF0Y2hCdWZmZXIubGluayhzdWNjZXNzLCBz dHViSW5mby5jYWxsUmV0dXJuTG9jYXRpb24ubGFiZWxBdE9mZnNldChzdHViSW5mby5wYXRjaC5k ZWx0YUNhbGxUb0RvbmUpKTsKICAgICBwYXRjaEJ1ZmZlci5saW5rKGZhaWx1cmUsIGZhaWx1cmVM YWJlbCk7CiAgICAgICAgICAgICAK 226322 2014-03-10 11:45:43 -0700 2014-03-10 11:48:42 -0700 Patch bug-130030-20140310114213.patch text/plain 2015 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1Mzg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAzLTEwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgd3JpdGVCYXJyaWVyIGluIGVtaXRQdXRSZXBsYWNlU3R1YiBpcyB1bm5lY2Vzc2Fy eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMDMw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYWxy ZWFkeSBlbWl0IHdyaXRlIGJhcnJpZXJzIGZvciBlYWNoIHB1dC1ieS1pZCB3aGVuIHRoZXkncmUg Zmlyc3QgY29tcGlsZWQsIHNvIGl0J3MgCisgICAgICAgIHJlZHVuZGFudCB0byBlbWl0IGEgd3Jp dGUgYmFycmllciBhcyBwYXJ0IG9mIHRoZSByZXBhdGNoZWQgY29kZS4KKworICAgICAgICAqIGpp dC9SZXBhdGNoLmNwcDoKKyAgICAgICAgKEpTQzo6ZW1pdFB1dFJlcGxhY2VTdHViKToKKwogMjAx NC0wMy0xMCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW1g4 Nl82NF0gU21hbGxlciBjb2RlIGZvciB4b3JfaXIgd2hlbiByZWdpc3RlciBpcyBhY2N1bXVsYXRv ci4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAkocmV2aXNpb24gMTY1 MzgxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODU4LDkgKzg1OCw2IEBAIHN0YXRpYyB2b2lkIGVtaXRQdXRSZXBsYWNlU3R1YigK ICAgICBhbGxvY2F0b3IubG9jayh2YWx1ZUdQUik7CiAgICAgCiAgICAgR1BSUmVnIHNjcmF0Y2hH UFIxID0gYWxsb2NhdG9yLmFsbG9jYXRlU2NyYXRjaEdQUigpOwotI2lmIEVOQUJMRShHR0MpCi0g ICAgR1BSUmVnIHNjcmF0Y2hHUFIyID0gYWxsb2NhdG9yLmFsbG9jYXRlU2NyYXRjaEdQUigpOwot I2VuZGlmCiAKICAgICBDQ2FsbEhlbHBlcnMgc3R1YkppdCh2bSwgZXhlYy0+Y29kZUJsb2NrKCkp OwogCkBAIC04ODksMTAgKzg4Niw2IEBAIHN0YXRpYyB2b2lkIGVtaXRQdXRSZXBsYWNlU3R1YigK ICAgICB9CiAjZW5kaWYKICAgICAKLSNpZiBFTkFCTEUoR0dDKQotICAgIE1hY3JvQXNzZW1ibGVy OjpDYWxsIHdyaXRlQmFycmllck9wZXJhdGlvbiA9IHdyaXRlQmFycmllcihzdHViSml0LCBiYXNl R1BSLCBzY3JhdGNoR1BSMSwgc2NyYXRjaEdQUjIsIGFsbG9jYXRvcik7Ci0jZW5kaWYKLSAgICAK ICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBzdWNjZXNzOwogICAgIE1hY3JvQXNzZW1ibGVyOjpK dW1wIGZhaWx1cmU7CiAgICAgCkBAIC05MDksOSArOTAyLDYgQEAgc3RhdGljIHZvaWQgZW1pdFB1 dFJlcGxhY2VTdHViKAogICAgIH0KICAgICAKICAgICBMaW5rQnVmZmVyIHBhdGNoQnVmZmVyKCp2 bSwgJnN0dWJKaXQsIGV4ZWMtPmNvZGVCbG9jaygpKTsKLSNpZiBFTkFCTEUoR0dDKQotICAgIHBh dGNoQnVmZmVyLmxpbmsod3JpdGVCYXJyaWVyT3BlcmF0aW9uLCBvcGVyYXRpb25GbHVzaFdyaXRl QmFycmllckJ1ZmZlcik7Ci0jZW5kaWYKICAgICBwYXRjaEJ1ZmZlci5saW5rKHN1Y2Nlc3MsIHN0 dWJJbmZvLmNhbGxSZXR1cm5Mb2NhdGlvbi5sYWJlbEF0T2Zmc2V0KHN0dWJJbmZvLnBhdGNoLmRl bHRhQ2FsbFRvRG9uZSkpOwogICAgIHBhdGNoQnVmZmVyLmxpbmsoZmFpbHVyZSwgZmFpbHVyZUxh YmVsKTsKICAgICAgICAgICAgIAo=