130025 2014-03-10 09:43:49 -0700 [X86_64] Smaller code for sub_ir when register is accumulator. 2014-03-10 11:51:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kling oldest_to_newest 988908 0 kling 2014-03-10 09:43:49 -0700 [X86_64] Smaller code for sub_ir when register is accumulator. 988910 1 226308 kling 2014-03-10 09:44:25 -0700 Created attachment 226308 Patch 988952 2 226308 msaboff 2014-03-10 10:57:50 -0700 Comment on attachment 226308 Patch What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants? 988963 3 kling 2014-03-10 11:17:37 -0700 (In reply to comment #2) > (From update of attachment 226308 [details]) > What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants? The 8 byte immediate variant adds to AL only, and not the upper part of the accumulator. 988966 4 kling 2014-03-10 11:24:01 -0700 Oh oops, I was thinking about 8-bit, not 8 byte. From reading the Intel manual, it looks like the "ADD r/m32,imm8" variant is the shortest possible instruction in that path. 988988 5 226308 kling 2014-03-10 11:51:20 -0700 Comment on attachment 226308 Patch Clearing flags on attachment: 226308 Committed r165391: <http://trac.webkit.org/changeset/165391> 988989 6 kling 2014-03-10 11:51:22 -0700 All reviewed patches have been landed. Closing bug. 226308 2014-03-10 09:44:25 -0700 2014-03-10 11:51:20 -0700 Patch bug-130025.diff text/plain 2352 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRmMDM3MjguLmM5Y2I4NjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTAzLTEwICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBbWDg2XzY0XSBTbWFsbGVyIGNvZGUgZm9y IHN1Yl9pciB3aGVuIHJlZ2lzdGVyIGlzIGFjY3VtdWxhdG9yLgorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTMwMDI1PgorCisgICAgICAgIEdlbmVyYXRlIHRoZSBzaG9ydGhhbmQgdmVy c2lvbiBvZiAic3ViIGVheCwgaW1tIiB3aGVuIHBvc3NpYmxlLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5o OgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6OnN1YmxfaXIpOgorICAgICAgICAoSlNDOjpY ODZBc3NlbWJsZXI6OnN1YnFfaXIpOgorCisyMDE0LTAzLTEwICBBbmRyZWFzIEtsaW5nICA8YWts aW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBbWDg2XzY0XSBTbWFsbGVyIGNvZGUgZm9yIGFkZF9p ciB3aGVuIHJlZ2lzdGVyIGlzIGFjY3VtdWxhdG9yLgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQu b3JnL2IvMTMwMDI0PgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL1g4NkFzc2VtYmxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZB c3NlbWJsZXIuaAppbmRleCBjODE5MzZjLi42MDQ4NGE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKQEAgLTE5Nyw2ICsxOTcsNyBAQCBwcml2 YXRlOgogICAgICAgICBPUF9BTkRfR3ZFdiAgICAgICAgICAgICAgICAgICAgID0gMHgyMywKICAg ICAgICAgT1BfU1VCX0V2R3YgICAgICAgICAgICAgICAgICAgICA9IDB4MjksCiAgICAgICAgIE9Q X1NVQl9HdkV2ICAgICAgICAgICAgICAgICAgICAgPSAweDJCLAorICAgICAgICBPUF9TVUJfRUFY SXYgICAgICAgICAgICAgICAgICAgID0gMHgyRCwKICAgICAgICAgUFJFX1BSRURJQ1RfQlJBTkNI X05PVF9UQUtFTiAgICA9IDB4MkUsCiAgICAgICAgIE9QX1hPUl9Fdkd2ICAgICAgICAgICAgICAg ICAgICAgPSAweDMxLAogICAgICAgICBPUF9YT1JfR3ZFdiAgICAgICAgICAgICAgICAgICAgID0g MHgzMywKQEAgLTcwMSw3ICs3MDIsMTAgQEAgcHVibGljOgogICAgICAgICAgICAgbV9mb3JtYXR0 ZXIub25lQnl0ZU9wKE9QX0dST1VQMV9FdkliLCBHUk9VUDFfT1BfU1VCLCBkc3QpOwogICAgICAg ICAgICAgbV9mb3JtYXR0ZXIuaW1tZWRpYXRlOChpbW0pOwogICAgICAgICB9IGVsc2UgewotICAg ICAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9wKE9QX0dST1VQMV9Fdkl6LCBHUk9VUDFfT1Bf U1VCLCBkc3QpOworICAgICAgICAgICAgaWYgKGRzdCA9PSBYODZSZWdpc3RlcnM6OmVheCkKKyAg ICAgICAgICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3AoT1BfU1VCX0VBWEl2KTsKKyAgICAg ICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3AoT1BfR1JP VVAxX0V2SXosIEdST1VQMV9PUF9TVUIsIGRzdCk7CiAgICAgICAgICAgICBtX2Zvcm1hdHRlci5p bW1lZGlhdGUzMihpbW0pOwogICAgICAgICB9CiAgICAgfQpAQCAtNzI5LDcgKzczMywxMCBAQCBw dWJsaWM6CiAgICAgICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3A2NChPUF9HUk9VUDFfRXZJ YiwgR1JPVVAxX09QX1NVQiwgZHN0KTsKICAgICAgICAgICAgIG1fZm9ybWF0dGVyLmltbWVkaWF0 ZTgoaW1tKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5 dGVPcDY0KE9QX0dST1VQMV9Fdkl6LCBHUk9VUDFfT1BfU1VCLCBkc3QpOworICAgICAgICAgICAg aWYgKGRzdCA9PSBYODZSZWdpc3RlcnM6OmVheCkKKyAgICAgICAgICAgICAgICBtX2Zvcm1hdHRl ci5vbmVCeXRlT3A2NChPUF9TVUJfRUFYSXYpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcDY0KE9QX0dST1VQMV9Fdkl6LCBHUk9VUDFfT1Bf U1VCLCBkc3QpOwogICAgICAgICAgICAgbV9mb3JtYXR0ZXIuaW1tZWRpYXRlMzIoaW1tKTsKICAg ICAgICAgfQogICAgIH0K