130024 2014-03-10 09:39:28 -0700 [X86_64] Smaller code for add_ir when register is accumulator. 2014-03-10 11:50:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kling oldest_to_newest 988906 0 kling 2014-03-10 09:39:28 -0700 [X86_64] Smaller code for add_ir when register is accumulator. 988907 1 226307 kling 2014-03-10 09:40:23 -0700 Created attachment 226307 Patch 988953 2 226307 msaboff 2014-03-10 11:00:49 -0700 Comment on attachment 226307 Patch What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants? 988964 3 kling 2014-03-10 11:17:49 -0700 (In reply to comment #2) > (From update of attachment 226307 [details]) > What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants? The 8 byte immediate variant adds to AL only, and not the upper part of the accumulator. 988965 4 kling 2014-03-10 11:23:51 -0700 Oh oops, I was thinking about 8-bit, not 8 byte. From reading the Intel manual, it looks like the "ADD r/m32,imm8" variant is the shortest possible instruction in that path. 988986 5 226307 kling 2014-03-10 11:50:41 -0700 Comment on attachment 226307 Patch Clearing flags on attachment: 226307 Committed r165390: <http://trac.webkit.org/changeset/165390> 988987 6 kling 2014-03-10 11:50:43 -0700 All reviewed patches have been landed. Closing bug. 226307 2014-03-10 09:40:23 -0700 2014-03-10 11:50:41 -0700 Patch bug-130024.diff text/plain 2322 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVmOGIzZjIuLjZiM2FjYTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTAzLTEwICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBbWDg2XzY0XSBTbWFsbGVyIGNvZGUgZm9y IGFkZF9pciB3aGVuIHJlZ2lzdGVyIGlzIGFjY3VtdWxhdG9yLgorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTMwMDI0PgorCisgICAgICAgIEdlbmVyYXRlIHRoZSBzaG9ydGhhbmQgdmVy c2lvbiBvZiAiYWRkIGVheCwgaW1tIiB3aGVuIHBvc3NpYmxlLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5o OgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6OmFkZGxfaXIpOgorICAgICAgICAoSlNDOjpY ODZBc3NlbWJsZXI6OmFkZHFfaXIpOgorCisyMDE0LTAzLTEwICBBbmRyZWFzIEtsaW5nICA8YWts aW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBbWDg2XzY0XSBTbWFsbGVyIGNvZGUgZm9yIG9yX2ly IHdoZW4gcmVnaXN0ZXIgaXMgYWNjdW11bGF0b3IuCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMzAwMDc+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvWDg2QXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFz c2VtYmxlci5oCmluZGV4IDA5OTcyYzAuLjUyZWIxYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaApAQCAtMTg4LDYgKzE4OCw3IEBAIHByaXZh dGU6CiAgICAgdHlwZWRlZiBlbnVtIHsKICAgICAgICAgT1BfQUREX0V2R3YgICAgICAgICAgICAg ICAgICAgICA9IDB4MDEsCiAgICAgICAgIE9QX0FERF9HdkV2ICAgICAgICAgICAgICAgICAgICAg PSAweDAzLAorICAgICAgICBPUF9BRERfRUFYSXYgICAgICAgICAgICAgICAgICAgID0gMHgwNSwK ICAgICAgICAgT1BfT1JfRXZHdiAgICAgICAgICAgICAgICAgICAgICA9IDB4MDksCiAgICAgICAg IE9QX09SX0d2RXYgICAgICAgICAgICAgICAgICAgICAgPSAweDBCLAogICAgICAgICBPUF9PUl9F QVhJdiAgICAgICAgICAgICAgICAgICAgID0gMHgwRCwKQEAgLTQxNyw3ICs0MTgsMTAgQEAgcHVi bGljOgogICAgICAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9wKE9QX0dST1VQMV9FdkliLCBH Uk9VUDFfT1BfQURELCBkc3QpOwogICAgICAgICAgICAgbV9mb3JtYXR0ZXIuaW1tZWRpYXRlOChp bW0pOwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9w KE9QX0dST1VQMV9Fdkl6LCBHUk9VUDFfT1BfQURELCBkc3QpOworICAgICAgICAgICAgaWYgKGRz dCA9PSBYODZSZWdpc3RlcnM6OmVheCkKKyAgICAgICAgICAgICAgICBtX2Zvcm1hdHRlci5vbmVC eXRlT3AoT1BfQUREX0VBWEl2KTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBt X2Zvcm1hdHRlci5vbmVCeXRlT3AoT1BfR1JPVVAxX0V2SXosIEdST1VQMV9PUF9BREQsIGRzdCk7 CiAgICAgICAgICAgICBtX2Zvcm1hdHRlci5pbW1lZGlhdGUzMihpbW0pOwogICAgICAgICB9CiAg ICAgfQpAQCAtNDUwLDcgKzQ1NCwxMCBAQCBwdWJsaWM6CiAgICAgICAgICAgICBtX2Zvcm1hdHRl ci5vbmVCeXRlT3A2NChPUF9HUk9VUDFfRXZJYiwgR1JPVVAxX09QX0FERCwgZHN0KTsKICAgICAg ICAgICAgIG1fZm9ybWF0dGVyLmltbWVkaWF0ZTgoaW1tKTsKICAgICAgICAgfSBlbHNlIHsKLSAg ICAgICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcDY0KE9QX0dST1VQMV9Fdkl6LCBHUk9VUDFf T1BfQURELCBkc3QpOworICAgICAgICAgICAgaWYgKGRzdCA9PSBYODZSZWdpc3RlcnM6OmVheCkK KyAgICAgICAgICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3A2NChPUF9BRERfRUFYSXYpOwor ICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcDY0 KE9QX0dST1VQMV9Fdkl6LCBHUk9VUDFfT1BfQURELCBkc3QpOwogICAgICAgICAgICAgbV9mb3Jt YXR0ZXIuaW1tZWRpYXRlMzIoaW1tKTsKICAgICAgICAgfQogICAgIH0K