130017 2014-03-10 04:51:51 -0700 Make ClientRectList.item() argument mandatory and drop [IsIndex] 2022-07-26 21:45:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID BlinkMergeCandidate P2 Normal --- 1 jinwoo7.song jinwoo7.song ahmad.saleem792 ap bfulgham cdumez commit-queue esprehn+autocc kangil.han kondapallykalyan rniwa oldest_to_newest 988869 0 jinwoo7.song 2014-03-10 04:51:51 -0700 From <https://code.google.com/p/chromium/issues/detail?id=336346>: Make ClientRectList.item() argument mandatory and drop [IsIndex] IDL extended attribute to match the latest specification: http://dev.w3.org/csswg/cssom-view/#dom-clientrectlist-item According to the specification, the index argument for ClientRectList.item() is mandatory and we should not throw when the index is negative, as long as it wraps to a valid index value (when calling toUInt32() as per Web IDL specification). Our new behavior is consistent with Firefox 22 as well. Note however that IE10 behaves differently: the argument is optional and passing a negative index throws even if it wraps to a valid index. Note that according to the specification, we should throw an IndexSizeError exception when index is greater than the number of ClientRect objects associated with the object. Blink just returns null in this case and this patch does not change this behavior as it is consistent with Firefox 22. IE10 does throw in this case though. 988871 1 226298 jinwoo7.song 2014-03-10 04:59:10 -0700 Created attachment 226298 Patch 1230829 2 226298 mcatanzaro 2016-09-17 07:16:56 -0700 Comment on attachment 226298 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 1886903 3 ahmad.saleem792 2022-07-26 14:35:22 -0700 This patch was modifying ClientRect.IDL in DOM, which got dropped in this commit: https://github.com/WebKit/WebKit/commit/fbe3ae77406ad5febbdc105d75794f433b60a0b1#diff-5132418c07229447b7c9f71217a9513bed2c82607f63a666947c402b7babcfa8 I am not sure whether this patch landed or not but this do modified the behavior and removed undefined and changed it. https://github.com/WebKit/WebKit/commit/8c7d8ccf45fa9dee315b2ca36e45f0d60f2b27d4 If I am wrong, please ignore my comment and please do the needful. Thanks! 1887000 4 rniwa 2022-07-26 21:45:50 -0700 We don't have this code anymore. 226298 2014-03-10 04:59:10 -0700 2016-09-17 07:16:56 -0700 Patch bug-130017-20140310205902.patch text/plain 5144 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDYzNmY1NjE0NDZjYjY3 Y2IyNzQ2OGZjOTk1ZTY3Mjk1MzgxZGUzMi4uNzVlZmQwYTUxOWQzNDBhMDAwMTJiOGM5M2NmMzNh YWUyOTI3ZDgwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTEwICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBNYWtlIENsaWVu dFJlY3RMaXN0Lml0ZW0oKSBhcmd1bWVudCBtYW5kYXRvcnkgYW5kIGRyb3AgW0lzSW5kZXhdCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAwMTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0 L2RvbS9FbGVtZW50L2NsaWVudC1yZWN0LWxpc3QtYXJndW1lbnQuaHRtbAorCisgICAgICAgIE1l cmdlZCBmcm9tIEJsaW5rIChwYXRjaCBieSBDaHJpc3RvcGhlIER1bWV6KQorICAgICAgICBodHRw czovL2Nocm9taXVtY29kZXJldmlldy5hcHBzcG90LmNvbS8yMjE5MTAwMgorCisgICAgICAgICog ZG9tL0NsaWVudFJlY3RMaXN0LmlkbDoKKwogMjAxNC0wMy0wNiAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBEb24ndCBwZXJmb3JtIGEgcm91bmQt dHJpcCB0aHJvdWdoIFdlYlByb2Nlc3MgYmVmb3JlIGludGVycHJldGluZyBrZXkgZXZlbnRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpZW50UmVjdExpc3QuaWRsIGIvU291cmNl L1dlYkNvcmUvZG9tL0NsaWVudFJlY3RMaXN0LmlkbAppbmRleCAxYWQzYjUzYzFlYjcxYjhmZDkx OTlmMDA5MmE5ZGFjMTIxOTUyOWIwLi4yOGZhNzYwODU4NmI2OWVkNjAzZDNlNDg3YjUxNjk1MGY4 MDE0ZDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpZW50UmVjdExpc3QuaWRs CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9DbGllbnRSZWN0TGlzdC5pZGwKQEAgLTI4LDcgKzI4 LDcgQEAKICAgICBJbXBsZW1lbnRhdGlvbkxhY2tzVlRhYmxlLAogXSBpbnRlcmZhY2UgQ2xpZW50 UmVjdExpc3QgewogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIGxlbmd0aDsK LSAgICBnZXR0ZXIgQ2xpZW50UmVjdCBpdGVtKFtJc0luZGV4LCBEZWZhdWx0PVVuZGVmaW5lZF0g b3B0aW9uYWwgdW5zaWduZWQgbG9uZyBpbmRleCk7CisgICAgZ2V0dGVyIENsaWVudFJlY3QgaXRl bSh1bnNpZ25lZCBsb25nIGluZGV4KTsKICAgICAvLyBGSVhNRTogRml4IGxpc3QgYmVoYXZpb3Ig dG8gYWxsb3cgY3VzdG9tIGV4Y2VwdGlvbnMgdG8gYmUgdGhyb3duLgogfTsKIApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFi OGE3YTI5OTllZWNlNWJiMmJmOTFlN2RjYTc2OWRlZmVkOWJlODEuLmY3MzYyZmM5MzFhZmRlNGE3 MDc2Zjk4MzBjODM2ZjU2OTgxZTcwZWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0wMy0x MCAgSmlud29vIFNvbmcgIDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgTWFr ZSBDbGllbnRSZWN0TGlzdC5pdGVtKCkgYXJndW1lbnQgbWFuZGF0b3J5IGFuZCBkcm9wIFtJc0lu ZGV4XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMw MDE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVy Z2VkIGZyb20gQmxpbmsgKHBhdGNoIGJ5IENocmlzdG9waGUgRHVtZXopCisgICAgICAgIGh0dHBz Oi8vY2hyb21pdW1jb2RlcmV2aWV3LmFwcHNwb3QuY29tLzIyMTkxMDAyCisKKyAgICAgICAgKiBm YXN0L2RvbS9FbGVtZW50L2NsaWVudC1yZWN0LWxpc3QtYXJndW1lbnQtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9FbGVtZW50L2NsaWVudC1yZWN0LWxpc3QtYXJndW1l bnQuaHRtbDogQWRkZWQuCisKIDIwMTQtMDMtMDkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxl LmNvbT4KIAogICAgICAgICBTa2lwIGZhc3Qvd29ya2Vycy93b3JrZXItY29weS1zaGFyZWQtYmxv Yi11cmwuaHRtbCBpbiB3ZWJraXQyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9F bGVtZW50L2NsaWVudC1yZWN0LWxpc3QtYXJndW1lbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9kb20vRWxlbWVudC9jbGllbnQtcmVjdC1saXN0LWFyZ3VtZW50LWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi40MWM2ZGE5MmI4OTBhZGNlYzg5YmMyOTM3MzExZTRlZjg4MDY5ZTQzCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVudC9jbGllbnQtcmVj dC1saXN0LWFyZ3VtZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIyIEBACitUZXN0cyB0aGF0 IHRoZSBDbGllbnRSZWN0TGlzdC5pdGVtKCkgYXJndW1lbnQgaXMgY29ycmVjdGx5IHZhbGlkYXRl ZC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgY2xpZW50UmVjdHMuX19w cm90b19fIGlzIENsaWVudFJlY3RMaXN0LnByb3RvdHlwZQorUEFTUyBjbGllbnRSZWN0cy5sZW5n dGggaXMgMworUEFTUyBjbGllbnRSZWN0cy5pdGVtKDApIGlzIG5vdCBudWxsCitQQVNTIGNsaWVu dFJlY3RzLml0ZW0oMSkgaXMgbm90IG51bGwKK1BBU1MgY2xpZW50UmVjdHMuaXRlbSgyKSBpcyBu b3QgbnVsbAorUEFTUyBjbGllbnRSZWN0cy5pdGVtKCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJv cjogTm90IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIGNsaWVudFJlY3RzLml0ZW0oLTQyOTQ5Njcy OTQpIGlzIGNsaWVudFJlY3RzLml0ZW0oMikKK1BBU1MgY2xpZW50UmVjdHMuaXRlbSgzKSBpcyBu dWxsCitQQVNTIGNsaWVudFJlY3RzLml0ZW0oOTk5KSBpcyBudWxsCitQQVNTIGNsaWVudFJlY3Rz Lml0ZW0oLTEpIGlzIG51bGwKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVT VCBDT01QTEVURQorMTQuIEJsb2NrIGluIGlubGluZQorCitMb3JlbQoraXBzdW0KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0VsZW1lbnQvY2xpZW50LXJlY3QtbGlzdC1hcmd1bWVu dC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVudC9jbGllbnQtcmVjdC1saXN0LWFy Z3VtZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDE3YWE2OWQyZDQ1NWVjOGMwMDkyNTU5NTQ5MzQ2NWEz OWFjZTBlMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0VsZW1lbnQv Y2xpZW50LXJlY3QtbGlzdC1hcmd1bWVudC5odG1sCkBAIC0wLDAgKzEsNDUgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0iaGVscCIgaHJlZj0iaHR0cDovL2Rl di53My5vcmcvY3Nzd2cvY3Nzb20tdmlldy8jZG9tLWNsaWVudHJlY3RsaXN0LWl0ZW0iPgorPHNj cmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzdHls ZT4KKyN0ZXN0QXJlYSB7CisgICAgd2lkdGg6IDMwMHB4OworfQorI2lubmVyIHsKKyAgICB3aWR0 aDogMjAwcHg7CisgICAgaGVpZ2h0OiAyMDBweDsKK30KKy50ZXN0Qm94IHsKKyAgICBiYWNrZ3Jv dW5kLWNvbG9yOiBncmVlbjsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9 InRlc3RBcmVhIj4KKyAgPHA+MTQuIEJsb2NrIGluIGlubGluZTwvcD4gICAgICA8c3BhbiBpZD0i dGVzdEVsZW1lbnQiIGNsYXNzPSJ0ZXN0Qm94Ij5Mb3JlbTxkaXYgaWQ9ImlubmVyIj48L2Rpdj5p cHN1bTwvc3Bhbj4KKzwvZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUZXN0cyB0aGF0IHRo ZSBDbGllbnRSZWN0TGlzdC5pdGVtKCkgYXJndW1lbnQgaXMgY29ycmVjdGx5IHZhbGlkYXRlZC4i KTsKKwordmFyIGNsaWVudFJlY3RzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RFbGVt ZW50IikuZ2V0Q2xpZW50UmVjdHMoKTsKK3Nob3VsZEJlKCJjbGllbnRSZWN0cy5fX3Byb3RvX18i LCAiQ2xpZW50UmVjdExpc3QucHJvdG90eXBlIik7CisKK3Nob3VsZEJlKCJjbGllbnRSZWN0cy5s ZW5ndGgiLCAiMyIpOworc2hvdWxkTm90QmUoImNsaWVudFJlY3RzLml0ZW0oMCkiLCAibnVsbCIp Oworc2hvdWxkTm90QmUoImNsaWVudFJlY3RzLml0ZW0oMSkiLCAibnVsbCIpOworc2hvdWxkTm90 QmUoImNsaWVudFJlY3RzLml0ZW0oMikiLCAibnVsbCIpOworc2hvdWxkVGhyb3coImNsaWVudFJl Y3RzLml0ZW0oKSIsICInVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cyciKTsKK3Nob3Vs ZEJlKCJjbGllbnRSZWN0cy5pdGVtKC00Mjk0OTY3Mjk0KSIsICJjbGllbnRSZWN0cy5pdGVtKDIp Iik7IC8vIC00Mjk0OTY3Mjk0IHdyYXBzIHRvIDIuCisKKy8vIEFjY29yZGluZyB0byB0aGUgc3Bl Y2lmaWNhdGlvbiwgd2Ugc2hvdWxkIHRocm93IGFuIEluZGV4U2l6ZUVycm9yIGV4Y2VwdGlvbiB3 aGVuIGluZGV4IGlzCisvLyBncmVhdGVyIHRoYW4gdGhlIG51bWJlciBvZiBDbGllbnRSZWN0IG9i amVjdHMgYXNzb2NpYXRlZCB3aXRoIHRoZSBvYmplY3QuCisvLyBIb3dldmVyLCB3ZSBjdXJyZW50 bHkganVzdCByZXR1cm4gbnVsbCBsaWtlIEZpcmVmb3ggMjIuCitzaG91bGRCZU51bGwoImNsaWVu dFJlY3RzLml0ZW0oMykiKTsKK3Nob3VsZEJlTnVsbCgiY2xpZW50UmVjdHMuaXRlbSg5OTkpIik7 CitzaG91bGRCZU51bGwoImNsaWVudFJlY3RzLml0ZW0oLTEpIik7CisKKzwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgo=