130016 2014-03-10 04:46:51 -0700 [GTK][CMAKE] gtk-doc HTML documentation is generated by default when building with CMake 2014-03-10 11:30:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia mrobinson bunhere commit-queue gustavo gyuyoung.kim mrobinson rakuco sergio zan oldest_to_newest 988866 0 cgarcia 2014-03-10 04:46:51 -0700 This makes every build a lot slower 988919 1 226310 mrobinson 2014-03-10 09:54:35 -0700 Created attachment 226310 Patch 988922 2 226310 mrobinson 2014-03-10 09:58:43 -0700 Comment on attachment 226310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226310&action=review > Source/PlatformGTK.cmake:-50 > -if (ENABLE_WEBKIT) > - add_dependencies(fake-docs-target WebKit) > -endif () > - > -if (ENABLE_WEBKIT2) > - add_dependencies(fake-docs-target WebKit2) > -endif () I forgot to mention that I also removed these. They are redundant since DocumentationDependencies already includes WebKit1 and WebKit2. 988948 3 226310 cgarcia 2014-03-10 10:44:54 -0700 Comment on attachment 226310 Patch Thanks! 988970 4 226310 mrobinson 2014-03-10 11:30:02 -0700 Comment on attachment 226310 Patch Clearing flags on attachment: 226310 Committed r165386: <http://trac.webkit.org/changeset/165386> 988971 5 mrobinson 2014-03-10 11:30:08 -0700 All reviewed patches have been landed. Closing bug. 226310 2014-03-10 09:54:35 -0700 2014-03-10 11:30:02 -0700 Patch bug-130016-20140310095434.patch text/plain 2754 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm1H VEsuY21ha2UgYi9Tb3VyY2UvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNjRjZjUwZmQ3NDNiNTBk ZDRlMTVhNDFlZDYyZDU5YThiMjUxMGZjMS4uNWE1NWM2MjAyZWY5MWMwYjNiNWRlZmU4MjliMDRl NTgzNTk2MzM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMjksMjYgKzI5LDI2IEBAIGlmIChFTkFCTEVfV0VC S0lUMikKICAgICApCiBlbmRpZiAoKQogCi1hZGRfY3VzdG9tX2NvbW1hbmQoCi0gICAgT1VUUFVU ICIke0NNQUtFX0JJTkFSWV9ESVJ9L2RvY3MtYnVpbGQuc3RhbXAiCi0gICAgREVQRU5EUyAke0Rv Y3VtZW50YXRpb25EZXBlbmRlbmNpZXN9Ci0gICAgQ09NTUFORCBDQz0iJHtDTUFLRV9DX0NPTVBJ TEVSfSIgJHtDTUFLRV9TT1VSQ0VfRElSfS9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jCi0gICAg Q09NTUFORCB0b3VjaCBkb2NzLWJ1aWxkLnN0YW1wCi0gICAgV09SS0lOR19ESVJFQ1RPUlkgIiR7 Q01BS0VfQklOQVJZX0RJUn0iCittYWNybyhBRERfR1RLRE9DX0dFTkVSQVRPUiBfc3RhbXBfbmFt ZSBfZXh0cmFfYXJncykKKyAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCisgICAgICAgIE9VVFBVVCAi JHtDTUFLRV9CSU5BUllfRElSfS8ke19zdGFtcF9uYW1lfSIKKyAgICAgICAgREVQRU5EUyAke0Rv Y3VtZW50YXRpb25EZXBlbmRlbmNpZXN9CisgICAgICAgIENPTU1BTkQgQ0M9IiR7Q01BS0VfQ19D T01QSUxFUn0iICR7Q01BS0VfU09VUkNFX0RJUn0vVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyAk e19leHRyYV9hcmdzfQorICAgICAgICBDT01NQU5EIHRvdWNoICR7X3N0YW1wX25hbWV9CisgICAg ICAgIFdPUktJTkdfRElSRUNUT1JZICIke0NNQUtFX0JJTkFSWV9ESVJ9IgorICAgICkKK2VuZG1h Y3JvKCkKKworYWRkX2d0a2RvY19nZW5lcmF0b3IoImRvY3MtYnVpbGQtbm8taHRtbC5zdGFtcCIg Ii0tc2tpcC1odG1sIikKK2FkZF9jdXN0b21fdGFyZ2V0KGd0a2RvYy1uby1odG1sIEFMTAorICAg IERFUEVORFMgIiR7Q01BS0VfQklOQVJZX0RJUn0vZG9jcy1idWlsZC1uby1odG1sLnN0YW1wIgog KQogCi1hZGRfY3VzdG9tX3RhcmdldChmYWtlLWRvY3MtdGFyZ2V0IEFMTAorYWRkX2d0a2RvY19n ZW5lcmF0b3IoImRvY3MtYnVpbGQuc3RhbXAiICIiKQorYWRkX2N1c3RvbV90YXJnZXQoZ3RrZG9j CiAgICAgREVQRU5EUyAiJHtDTUFLRV9CSU5BUllfRElSfS9kb2NzLWJ1aWxkLnN0YW1wIgogKQog Ci1pZiAoRU5BQkxFX1dFQktJVCkKLSAgICBhZGRfZGVwZW5kZW5jaWVzKGZha2UtZG9jcy10YXJn ZXQgV2ViS2l0KQotZW5kaWYgKCkKLQotaWYgKEVOQUJMRV9XRUJLSVQyKQotICAgIGFkZF9kZXBl bmRlbmNpZXMoZmFrZS1kb2NzLXRhcmdldCBXZWJLaXQyKQotZW5kaWYgKCkKLQogYWRkX2N1c3Rv bV90YXJnZXQoY2hlY2sKICAgICBDT01NQU5EICR7VE9PTFNfRElSfS9TY3JpcHRzL3J1bi1ndGst dGVzdHMKICAgICBDT01NQU5EICR7VE9PTFNfRElSfS9ndGsvY2hlY2stZm9yLXdlYmtpdGRvbS1h cGktYnJlYWtzCkBAIC02MSw2ICs2MSw3IEBAIGlmIChFTkFCTEVfV0VCS0lUIEFORCBFTkFCTEVf V0VCS0lUMikKICAgICAgICAgREVQRU5EUyAke1RPT0xTX0RJUn0vZ3RrL21hbmlmZXN0LnR4dAog ICAgICAgICBERVBFTkRTIFdlYktpdAogICAgICAgICBERVBFTkRTIFdlYktpdDIKKyAgICAgICAg REVQRU5EUyBndGtkb2MKICAgICAgICAgQ09NTUFORCAke1RPT0xTX0RJUn0vZ3RrL21ha2UtZGlz dC5weQogICAgICAgICAgICAgICAgIC0tc291cmNlLWRpcj0ke0NNQUtFX1NPVVJDRV9ESVJ9CiAg ICAgICAgICAgICAgICAgLS1idWlsZC1kaXI9JHtDTUFLRV9CSU5BUllfRElSfQpkaWZmIC0tZ2l0 IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGY0MzNkMmEwZDFhZWJmYzFhYjdhMjI2NTc0 NWUwNTIxZWY1ZjE0ZGUuLjM0YzM3OTgyYzFiMjZhMTZhZDFkZDY4MGNkZDhlMmEwMzQyMDUxZjAg MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNC0wMy0xMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS11bQ01BS0VdIGd0ay1kb2MgSFRNTCBkb2N1bWVudGF0aW9uIGlzIGdlbmVyYXRl ZCBieSBkZWZhdWx0IHdoZW4gYnVpbGRpbmcgd2l0aCBDTWFrZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMDE2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvUGxhdGZvcm1HVEsuY21ha2U6 IEFkZCB0d28gZ3RrZG9jIHRhcmdldHMsIG9uZSB3aGljaCBidWlsZHMgSFRNTCBhbmQgb25lIHdo aWNoCisgICAgICAgIGRvZXNuJ3QuIEFkZCB0aGUgbm9uLUhUTUwgdmVyc2lvbiB0byB0aGUgZGVm YXVsdCB0YXJnZXQsIGJ1dCBub3QgdGhlIEhUTUwgdmVyc2lvbi4gVGhlCisgICAgICAgIEhUTUwg dmVyc2lvbiB3aWxsIHN0aWxsIHJ1biB3aGVuIGJ1aWxkaW5nIHRoZSBkaXN0cmlidXRpb24gdGFy YmFsbC4KKwogMjAxNC0wMy0wOCAgTGFuZHJ5IEJyZXVpbCAgPGxhbmRyeUBvcGVuYnNkLm9yZz4K IAogICAgICAgICBEb24ndCBjaGVjayBmb3Igc2htX29wZW4gb24gbGlicnQgb24gT3BlbkJTRCwg bGliIGRvZXNudCBleGlzdC4K