130015 2014-03-10 04:04:41 -0700 [CSS Regions] Hit-testing is not working properly inside scrollable regions 2014-03-10 11:43:02 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 1 stavila stavila commit-queue darin esprehn+autocc glenn kondapallykalyan simon.fraser WebkitBugTracker oldest_to_newest 988859 0 stavila 2014-03-10 04:04:41 -0700 Hit-testing on elements inside scrollable regions does not take the region's scroll offset into consideration. 988925 1 226313 stavila 2014-03-10 10:05:01 -0700 Created attachment 226313 Patch 988932 2 226313 darin 2014-03-10 10:12:31 -0700 Comment on attachment 226313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226313&action=review > Source/WebCore/rendering/RenderLayer.cpp:6879 > + IntSize scrolledContentOffset = region->fragmentContainer().hasOverflowClip() ? region->fragmentContainer().scrolledContentOffset() : IntSize(); Why would we want to skip the call to scrolledContentOffset is the container does not handle overflow? Wouldn’t the container correctly return 0,0 in that case? This seems mysterious enough that you might want to write a comment. 988934 3 226313 stavila 2014-03-10 10:20:37 -0700 Comment on attachment 226313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226313&action=review >> Source/WebCore/rendering/RenderLayer.cpp:6879 >> + IntSize scrolledContentOffset = region->fragmentContainer().hasOverflowClip() ? region->fragmentContainer().scrolledContentOffset() : IntSize(); > > Why would we want to skip the call to scrolledContentOffset is the container does not handle overflow? Wouldn’t the container correctly return 0,0 in that case? This seems mysterious enough that you might want to write a comment. The first line of the RenderBox::scrolledContentOffset() method is ASSERT(hasOverflowClip()); 988938 4 226313 koivisto 2014-03-10 10:27:58 -0700 Comment on attachment 226313 Patch r=me with the informative comment Darin asked for. 988940 5 stavila 2014-03-10 10:33:10 -0700 After discussing with Antti on IRC, we decided to not add the comment, since throughout the code, every time the scrolledContentOffset is used, it's preceeded by the hasOverflowClip check. I will submit an issue to move the check inside the scrolledContentOffset method itself. 988979 6 226313 commit-queue 2014-03-10 11:42:58 -0700 Comment on attachment 226313 Patch Clearing flags on attachment: 226313 Committed r165388: <http://trac.webkit.org/changeset/165388> 988980 7 commit-queue 2014-03-10 11:43:02 -0700 All reviewed patches have been landed. Closing bug. 226313 2014-03-10 10:05:01 -0700 2014-03-10 11:42:58 -0700 Patch 130015.patch text/plain 9537 stavila ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxNDljNWU0Li4wOWI2YzZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDMt MTAgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVn aW9uc10gSGl0LXRlc3RpbmcgaXMgbm90IHdvcmtpbmcgcHJvcGVybHkgaW5zaWRlIHNjcm9sbGFi bGUgcmVnaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTMwMDE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkZWQgdGVzdCBmb3IgaGl0LXRlc3RpbmcgaW5zaWRlIHNjcm9sbGFibGUgcmVnaW9ucy4K KworICAgICAgICAqIGZhc3QvcmVnaW9ucy9zY3JvbGxhYmxlLXJlZ2lvbnMtaGl0LXRlc3Rpbmct aW5zaWRlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnaW9ucy9zY3Jv bGxhYmxlLXJlZ2lvbnMtaGl0LXRlc3RpbmctaW5zaWRlLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAz LTEwICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1NS ZWdpb25zXSBGaXggYnJva2VuIHBhdGhzIGluIHNvbWUgcmVnaW9ucyB0ZXN0cwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3Njcm9sbGFibGUtcmVnaW9ucy1oaXQtdGVzdGlu Zy1pbnNpZGUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9zY3JvbGxh YmxlLXJlZ2lvbnMtaGl0LXRlc3RpbmctaW5zaWRlLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2M3NWJjNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvcmVnaW9ucy9zY3JvbGxhYmxlLXJlZ2lvbnMtaGl0LXRlc3RpbmctaW5zaWRl LWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw2MCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbCBz dHlsZT0iZm9udDogMTZweC8xLjI1IG1vbm9zcGFjZTsgZm9udC1mYW1pbHk6IEFoZW0iPgorICAg IDxoZWFkPgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgb25sb2FkID0gZnVuY3Rpb24o KSAKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICB2YXIgcmVnaW9uID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInJlZ2lvbiIpOworICAgICAgICAgICAgICAgIHJlZ2lvbi5zY3JvbGxU b3AgKz0gMTUwOworCisgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgewor ICAgICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbygxNDAsIDE2MCk7Cisg ICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigwKTsKKyAgICAgICAgICAg ICAgICAgICAgZXZlbnRTZW5kZXIubGVhcEZvcndhcmQoNTAwKTsKKyAgICAgICAgICAgICAgICAg ICAgZXZlbnRTZW5kZXIubW91c2VVcCgwKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAg ICB9CisgICAgICAgIDwvc2NyaXB0PgorCisgICAgICAgIDxzdHlsZT4KKyAgICAgICAgICAgICNj b250YWluZXIgeworICAgICAgICAgICAgICAgIGJvcmRlcjogMnB4IHNvbGlkIGdyZWVuOworICAg ICAgICAgICAgICAgIGhlaWdodDogMzAwcHg7CisgICAgICAgICAgICAgICAgb3ZlcmZsb3c6IHZp c2libGU7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICNyZWdpb24geworICAgICAgICAg ICAgICAgIHdpZHRoOiA2MDBweDsKKyAgICAgICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OworICAg ICAgICAgICAgICAgIGJvcmRlcjogdGhpY2sgc29saWQgcmVkOworICAgICAgICAgICAgICAgIHBh ZGRpbmc6IDUwcHg7CisgICAgICAgICAgICAgICAgb3ZlcmZsb3c6IHNjcm9sbDsKKyAgICAgICAg ICAgIH0KKworICAgICAgICAgICAgI2lubmVyRGl2IHsKKyAgICAgICAgICAgICAgICB3aWR0aDog MTAwcHg7CisgICAgICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAgICAgICBi YWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisgICAgICAgICAgICAgICAgbWFyZ2luLWxlZnQ6IDMwcHg7 CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICNpbm5lckRpdjpob3ZlcgorICAgICAgICAg ICAgeworICAgICAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOworICAgICAgICAg ICAgfQorICAgICAgICA8L3N0eWxlPgorICAgIDwvaGVhZD4KKworICAgIDxib2R5PgorICAgICAg ICA8YSBzdHlsZT0iZm9udC1zaXplOiAxNHB4IiBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMDE1Ij5bQ1NTIFJlZ2lvbnNdIEhpdC10ZXN0aW5nIGlzIG5v dCB3b3JraW5nIHByb3Blcmx5IGluc2lkZSBzY3JvbGxhYmxlIHJlZ2lvbnM8L2E+CisgICAgICAg IDxwPlRoaXMgdGVzdCBwYXNzZXMgaWYgdGhlIHJlZCBzcXVhcmUgdHVybnMgZ3JlZW4gd2hlbiBo b3ZlcmVkLCBldmVuIGlmIHRoZSByZWdpb24gaXMgc2Nyb2xsZWQuPC9wPgorCisgICAgICAgIDxk aXYgaWQ9InJlZ2lvbiI+CisgICAgICAgICAgICA8ZGl2IGlkPSJjb250YWluZXIiPgorICAgICAg ICAgICAgICAgIDxkaXY+TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNlY3RldHVyIGFk aXBpc2NpbmcgZWxpdC4gUHJhZXNlbnQgaW50ZXJkdW0sIHNhcGllbiB2aXRhZSBmYXVjaWJ1cyBz dXNjaXBpdCwgbWFzc2EgdXJuYSBzYWdpdHRpcyBsaWJlcm8sIGFjIGltcGVyZGlldCBlbGl0IGxh Y3VzIGEgbGlndWxhLiBNYXVyaXMgYSBvcmNpIHNlbS48L2Rpdj4KKyAgICAgICAgICAgICAgICA8 ZGl2IGlkPSJpbm5lckRpdiI+PC9kaXY+CisgICAgICAgICAgICAgICAgPGRpdiBzdHlsZT0iY29s b3I6cmVkIj5Mb3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwgY29uc2VjdGV0dXIgYWRpcGlzY2lu ZyBlbGl0LiBQcmFlc2VudCBpbnRlcmR1bSwgc2FwaWVuIHZpdGFlIGZhdWNpYnVzIHN1c2NpcGl0 LCBtYXNzYSB1cm5hIHNhZ2l0dGlzIGxpYmVybywgYWMgaW1wZXJkaWV0IGVsaXQgbGFjdXMgYSBs aWd1bGEuIE1hdXJpcyBhIG9yY2kgc2VtLiBOdWxsYW0gdWxsYW1jb3JwZXIgb3JuYXJlIHBvcnR0 aXRvci4gTW9yYmkgbGFvcmVldCBwZWxsZW50ZXNxdWUgZGlhbSwgdml0YWUgaGVuZHJlcml0IHNl bSBmcmluZ2lsbGEgaWQuIE1hZWNlbmFzIHJ1dHJ1bSBsYWNpbmlhIGxvYm9ydGlzLiBQcmFlc2Vu dCBlbGl0IGxlY3R1cywgcG9ydHRpdG9yIHNlZCBzZW1wZXIgdmVsLCBmcmluZ2lsbGEgaWQgZG9s b3IuIFNlZCBsYWN1cyBuaXNsLCBydXRydW0gc2l0IGFtZXQgZXVpc21vZCBhLCB2dWxwdXRhdGUg cXVpcyBlbGl0LiBGdXNjZSBjb21tb2RvIGR1aSBxdWlzIGxhY3VzIHZpdmVycmEgdmVsIGVnZXN0 YXMgdmVsaXQgdGVtcHVzLiBEb25lYyB1dCBzYXBpZW4gc2l0IGFtZXQgcHVydXMgbHVjdHVzIGZl cm1lbnR1bS4gRG9uZWMgZWxlaWZlbmQgcHJldGl1bSBuZXF1ZSBxdWlzIGJpYmVuZHVtLiBWZXN0 aWJ1bHVtIGFudGUgaXBzdW0gcHJpbWlzIGluIGZhdWNpYnVzIG9yY2kgbHVjdHVzIGV0IHVsdHJp Y2VzIHBvc3VlcmUgY3ViaWxpYSBDdXJhZTsgTmFtIGNvbmd1ZSBkYXBpYnVzIG1pLCBpZCB1bHRy aWNpZXMgZXN0IHNhZ2l0dGlzIGV0LiBJbnRlZ2VyIHBvc3VlcmUsIGVyb3Mgdml0YWUgbGFvcmVl dCBjb25ndWUsIHRvcnRvciBwdXJ1cyBldWlzbW9kIG5pYmgsIGV1IHBvcnRhIHB1cnVzIGFyY3Ug aWQgdHVycGlzLiBEb25lYyB2aXRhZSB1bHRyaWNpZXMgbmliaC4gTnVsbGFtIGluIHVybmEgZG9s b3IsIGF0IGZyaW5naWxsYSBsb3JlbS4gTG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNl Y3RldHVyIGFkaXBpc2NpbmcgZWxpdC48L2Rpdj4KKyAgICAgICAgICAgIDwvZGl2PgorICAgICAg ICA8L2Rpdj4KKyAgICA8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L3JlZ2lvbnMvc2Nyb2xsYWJsZS1yZWdpb25zLWhpdC10ZXN0aW5nLWluc2lkZS5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3Njcm9sbGFibGUtcmVnaW9ucy1oaXQtdGVzdGluZy1p bnNpZGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jMTZjZmM1Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3Njcm9sbGFibGUtcmVn aW9ucy1oaXQtdGVzdGluZy1pbnNpZGUuaHRtbApAQCAtMCwwICsxLDYyIEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sIHN0eWxlPSJmb250OiAxNnB4LzEuMjUgbW9ub3NwYWNlOyBmb250LWZhbWls eTogQWhlbSI+CisgICAgPGhlYWQ+CisgICAgICAgIDxzY3JpcHQ+CisgICAgICAgICAgICBvbmxv YWQgPSBmdW5jdGlvbigpIAorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHZhciByZWdp b24gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVnaW9uIik7CisgICAgICAgICAgICAgICAg cmVnaW9uLnNjcm9sbFRvcCArPSAxNTA7CisKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmV2 ZW50U2VuZGVyKSB7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRv KDE0MCwgMTYwKTsKKyAgICAgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKDAp OworICAgICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5sZWFwRm9yd2FyZCg1MDApOworICAg ICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKDApOworICAgICAgICAgICAgICAg IH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+CisKKyAgICAgICAgPHN0eWxlPgor ICAgICAgICAgICAgI2NvbnRhaW5lciB7CisgICAgICAgICAgICAgICAgYm9yZGVyOiAycHggc29s aWQgZ3JlZW47CisgICAgICAgICAgICAgICAgaGVpZ2h0OiAzMDBweDsKKyAgICAgICAgICAgICAg ICBvdmVyZmxvdzogdmlzaWJsZTsKKyAgICAgICAgICAgICAgICAtd2Via2l0LWZsb3ctaW50bzog ZmxvdzsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgI3JlZ2lvbiB7CisgICAgICAgICAg ICAgICAgd2lkdGg6IDYwMHB4OworICAgICAgICAgICAgICAgIGhlaWdodDogMjAwcHg7CisgICAg ICAgICAgICAgICAgLXdlYmtpdC1mbG93LWZyb206IGZsb3c7CisgICAgICAgICAgICAgICAgYm9y ZGVyOiB0aGljayBzb2xpZCByZWQ7CisgICAgICAgICAgICAgICAgcGFkZGluZzogNTBweDsKKyAg ICAgICAgICAgICAgICBvdmVyZmxvdzogc2Nyb2xsOworICAgICAgICAgICAgfQorCisgICAgICAg ICAgICAjaW5uZXJEaXYgeworICAgICAgICAgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAg ICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6 IHJlZDsKKyAgICAgICAgICAgICAgICBtYXJnaW4tbGVmdDogMzBweDsKKyAgICAgICAgICAgIH0K KworICAgICAgICAgICAgI2lubmVyRGl2OmhvdmVyCisgICAgICAgICAgICB7CisgICAgICAgICAg ICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAgICAgICAgICB9CisgICAgICAgIDwv c3R5bGU+CisgICAgPC9oZWFkPgorCisgICAgPGJvZHk+CisgICAgICAgIDxhIHN0eWxlPSJmb250 LXNpemU6IDE0cHgiIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzAwMTUiPltDU1MgUmVnaW9uc10gSGl0LXRlc3RpbmcgaXMgbm90IHdvcmtpbmcgcHJvcGVy bHkgaW5zaWRlIHNjcm9sbGFibGUgcmVnaW9uczwvYT4KKyAgICAgICAgPHA+VGhpcyB0ZXN0IHBh c3NlcyBpZiB0aGUgcmVkIHNxdWFyZSB0dXJucyBncmVlbiB3aGVuIGhvdmVyZWQsIGV2ZW4gaWYg dGhlIHJlZ2lvbiBpcyBzY3JvbGxlZC48L3A+CisKKyAgICAgICAgPGRpdiBpZD0icmVnaW9uIj48 L2Rpdj4KKworICAgICAgICA8ZGl2IGlkPSJjb250YWluZXIiPgorICAgICAgICAgICAgPGRpdj5M b3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwgY29uc2VjdGV0dXIgYWRpcGlzY2luZyBlbGl0LiBQ cmFlc2VudCBpbnRlcmR1bSwgc2FwaWVuIHZpdGFlIGZhdWNpYnVzIHN1c2NpcGl0LCBtYXNzYSB1 cm5hIHNhZ2l0dGlzIGxpYmVybywgYWMgaW1wZXJkaWV0IGVsaXQgbGFjdXMgYSBsaWd1bGEuIE1h dXJpcyBhIG9yY2kgc2VtLjwvZGl2PgorICAgICAgICAgICAgPGRpdiBpZD0iaW5uZXJEaXYiPjwv ZGl2PgorICAgICAgICAgICAgPGRpdiBzdHlsZT0iY29sb3I6cmVkIj5Mb3JlbSBpcHN1bSBkb2xv ciBzaXQgYW1ldCwgY29uc2VjdGV0dXIgYWRpcGlzY2luZyBlbGl0LiBQcmFlc2VudCBpbnRlcmR1 bSwgc2FwaWVuIHZpdGFlIGZhdWNpYnVzIHN1c2NpcGl0LCBtYXNzYSB1cm5hIHNhZ2l0dGlzIGxp YmVybywgYWMgaW1wZXJkaWV0IGVsaXQgbGFjdXMgYSBsaWd1bGEuIE1hdXJpcyBhIG9yY2kgc2Vt LiBOdWxsYW0gdWxsYW1jb3JwZXIgb3JuYXJlIHBvcnR0aXRvci4gTW9yYmkgbGFvcmVldCBwZWxs ZW50ZXNxdWUgZGlhbSwgdml0YWUgaGVuZHJlcml0IHNlbSBmcmluZ2lsbGEgaWQuIE1hZWNlbmFz IHJ1dHJ1bSBsYWNpbmlhIGxvYm9ydGlzLiBQcmFlc2VudCBlbGl0IGxlY3R1cywgcG9ydHRpdG9y IHNlZCBzZW1wZXIgdmVsLCBmcmluZ2lsbGEgaWQgZG9sb3IuIFNlZCBsYWN1cyBuaXNsLCBydXRy dW0gc2l0IGFtZXQgZXVpc21vZCBhLCB2dWxwdXRhdGUgcXVpcyBlbGl0LiBGdXNjZSBjb21tb2Rv IGR1aSBxdWlzIGxhY3VzIHZpdmVycmEgdmVsIGVnZXN0YXMgdmVsaXQgdGVtcHVzLiBEb25lYyB1 dCBzYXBpZW4gc2l0IGFtZXQgcHVydXMgbHVjdHVzIGZlcm1lbnR1bS4gRG9uZWMgZWxlaWZlbmQg cHJldGl1bSBuZXF1ZSBxdWlzIGJpYmVuZHVtLiBWZXN0aWJ1bHVtIGFudGUgaXBzdW0gcHJpbWlz IGluIGZhdWNpYnVzIG9yY2kgbHVjdHVzIGV0IHVsdHJpY2VzIHBvc3VlcmUgY3ViaWxpYSBDdXJh ZTsgTmFtIGNvbmd1ZSBkYXBpYnVzIG1pLCBpZCB1bHRyaWNpZXMgZXN0IHNhZ2l0dGlzIGV0LiBJ bnRlZ2VyIHBvc3VlcmUsIGVyb3Mgdml0YWUgbGFvcmVldCBjb25ndWUsIHRvcnRvciBwdXJ1cyBl dWlzbW9kIG5pYmgsIGV1IHBvcnRhIHB1cnVzIGFyY3UgaWQgdHVycGlzLiBEb25lYyB2aXRhZSB1 bHRyaWNpZXMgbmliaC4gTnVsbGFtIGluIHVybmEgZG9sb3IsIGF0IGZyaW5naWxsYSBsb3JlbS4g TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNlY3RldHVyIGFkaXBpc2NpbmcgZWxpdC48 L2Rpdj4KKyAgICAgICAgPC9kaXY+CisgICAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDc1YzIyMDAuLmM1YmZlZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNC0wMy0x MCAgUmFkdSBTdGF2aWxhICA8c3RhdmlsYUBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBSZWdp b25zXSBIaXQtdGVzdGluZyBpcyBub3Qgd29ya2luZyBwcm9wZXJseSBpbnNpZGUgc2Nyb2xsYWJs ZSByZWdpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzAwMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaGVuIGhpdC10ZXN0aW5nIGluc2lkZSB0aGUgZmxvdyB0aHJlYWQncyBsYXllciwgdGhlIHNj cm9sbGVkIG9mZnNldAorICAgICAgICBvZiB0aGUgY3VycmVudCByZWdpb24gbXVzdCBiZSB0YWtl biBpbnRvIGNvbnNpZGVyYXRpb24uCisKKyAgICAgICAgVGVzdDogZmFzdC9yZWdpb25zL3Njcm9s bGFibGUtcmVnaW9ucy1oaXQtdGVzdGluZy1pbnNpZGUuaHRtbAorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjYWxj dWxhdGVDbGlwUmVjdHMpOgorCiAyMDE0LTAzLTEwICBKaW53b28gU29uZyAgPGppbndvbzcuc29u Z0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIGRpc3BhdGNoU3RvcmFnZUV2 ZW50KCkgZnJvbSBTdG9yYWdlQXJlYVN5bmMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCmluZGV4IDZmMjVlMGYuLjAzMzg3Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcApAQCAtNjg3Niw2ICs2ODc2LDcgQEAgUmVuZGVyTGF5ZXIqIFJl bmRlckxheWVyOjpoaXRUZXN0Rmxvd1RocmVhZElmUmVnaW9uRm9yRnJhZ21lbnRzKGNvbnN0IExh eWVyRnJhZ20KICAgICB9CiAKICAgICBMYXlvdXRSZWN0IHJlZ2lvbkNvbnRlbnRCb3ggPSB0b1Jl bmRlckJsb2NrRmxvdygmcmVuZGVyZXIoKSktPmNvbnRlbnRCb3hSZWN0KCk7CisgICAgSW50U2l6 ZSBzY3JvbGxlZENvbnRlbnRPZmZzZXQgPSByZWdpb24tPmZyYWdtZW50Q29udGFpbmVyKCkuaGFz T3ZlcmZsb3dDbGlwKCkgPyByZWdpb24tPmZyYWdtZW50Q29udGFpbmVyKCkuc2Nyb2xsZWRDb250 ZW50T2Zmc2V0KCkgOiBJbnRTaXplKCk7CiAKICAgICBSZW5kZXJMYXllciogcmVzdWx0TGF5ZXIg PSAwOwogICAgIGZvciAoaW50IGkgPSBmcmFnbWVudHMuc2l6ZSgpIC0gMTsgaSA+PSAwOyAtLWkp IHsKQEAgLTY4ODQsNyArNjg4NSw3IEBAIFJlbmRlckxheWVyKiBSZW5kZXJMYXllcjo6aGl0VGVz dEZsb3dUaHJlYWRJZlJlZ2lvbkZvckZyYWdtZW50cyhjb25zdCBMYXllckZyYWdtCiAgICAgICAg IGlmICghZnJhZ21lbnQuYmFja2dyb3VuZFJlY3QuaW50ZXJzZWN0cyhoaXRUZXN0TG9jYXRpb24p KQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgTGF5b3V0U2l6ZSBoaXRUZXN0T2Zm c2V0ID0gcG9ydGlvbkxvY2F0aW9uIC0gKGZyYWdtZW50LmxheWVyQm91bmRzLmxvY2F0aW9uKCkg KyByZWdpb25Db250ZW50Qm94LmxvY2F0aW9uKCkpOworICAgICAgICBMYXlvdXRTaXplIGhpdFRl c3RPZmZzZXQgPSBwb3J0aW9uTG9jYXRpb24gLSAoZnJhZ21lbnQubGF5ZXJCb3VuZHMubG9jYXRp b24oKSArIHJlZ2lvbkNvbnRlbnRCb3gubG9jYXRpb24oKSkgKyBzY3JvbGxlZENvbnRlbnRPZmZz ZXQ7CiAKICAgICAgICAgLy8gQWx3YXlzIGlnbm9yZSBjbGlwcGluZywgc2luY2UgdGhlIFJlbmRl ckZsb3dUaHJlYWQgaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCB0aGUgYm91bmRzIG9mIHRoZSBGcmFt ZVZpZXcuCiAgICAgICAgIEhpdFRlc3RSZXF1ZXN0IG5ld1JlcXVlc3QocmVxdWVzdC50eXBlKCkg fCBIaXRUZXN0UmVxdWVzdDo6SWdub3JlQ2xpcHBpbmcgfCBIaXRUZXN0UmVxdWVzdDo6RGlzYWxs b3dTaGFkb3dDb250ZW50KTsK