130000 2014-03-09 21:38:09 -0700 AudioBufferSourceNode stop attribute shouldn't throw exception in finished state 2014-03-16 20:42:09 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 praveen.j webkit-unassigned cdumez commit-queue crogers dev_sachin eric.carlson glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 988797 0 praveen.j 2014-03-09 21:38:09 -0700 AudioBufferSourceNode may go to FINISHED_STATE even before stop method is called. AudioBufferSource will render silence if data is played completely and is not looping. In these cases, finish() is called which sets source node to FINISHED_STATE without waiting for stop call. A call to "stop" method after this shouldn't throw exception. This issue can be observed in http://www.kiddnation.com/wp-content/themes/kiddnation/flappyalfinal/ 988798 1 226278 praveen.j 2014-03-09 21:59:55 -0700 Created attachment 226278 Patch Patch provided here ensures that call to "stop" method when source is in FINISHED_STATE won't trigger exception. 990517 2 226278 jer.noble 2014-03-14 09:28:43 -0700 Comment on attachment 226278 Patch r=me 990532 3 226278 commit-queue 2014-03-14 10:01:36 -0700 Comment on attachment 226278 Patch Rejecting attachment 226278 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 226278, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ostname `svn.webkit.org': Host not found (http://svn.webkit.org) at /usr/share/git-core/perl/Git/SVN.pm line 697 Died at Tools/Scripts/update-webkit line 123. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': Could not resolve hostname `svn.webkit.org': Host not found (http://svn.webkit.org) at /usr/share/git-core/perl/Git/SVN.pm line 697 Died at Tools/Scripts/update-webkit line 123. Full output: http://webkit-queues.appspot.com/results/6162593727119360 991076 4 226278 gyuyoung.kim 2014-03-16 20:42:00 -0700 Comment on attachment 226278 Patch Clearing flags on attachment: 226278 Committed r165716: <http://trac.webkit.org/changeset/165716> 991077 5 gyuyoung.kim 2014-03-16 20:42:09 -0700 All reviewed patches have been landed. Closing bug. 226278 2014-03-09 21:59:55 -0700 2014-03-16 20:42:00 -0700 Patch WebAudio-130000.txt text/plain 1672 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTM1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTA5ICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIEF1ZGlvQnVmZmVy U291cmNlTm9kZSBzdG9wIGF0dHJpYnV0ZSBzaG91bGRuJ3QgdGhyb3cgZXhjZXB0aW9uIGluIGZp bmlzaGVkIHN0YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMwMDAwLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEF1ZGlvQnVmZmVyU291cmNlTm9kZSBtYXkgZ28gdG8gRklOSVNIRURfU1RBVEUgZXZl biBiZWZvcmUgInN0b3AiIG1ldGhvZCBpcyBjYWxsZWQgCisgICAgICAgIGFzIHNpbGVuY2UgcmVu ZGVyZWQgYWZ0ZXIgYXVkaW8gZGF0YSBpcyBwbGF5ZWQgb3V0IHdoZW4gaXRzIG5vdCBsb29waW5n LgorICAgICAgICBBIGNhbGwgdG8gInN0b3AiIG1ldGhvZCBhZnRlciB0aGlzIHNob3VsZG4ndCB0 aHJvdyBleGNlcHRpb24uCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvU2NoZWR1 bGVkU291cmNlTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1NjaGVkdWxlZFNvdXJj ZU5vZGU6OnN0b3ApOgorCiAyMDE0LTAzLTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIFtNYWNdIERvbid0IHBlcmZvcm0gYSByb3VuZC10cmlwIHRocm91 Z2ggV2ViUHJvY2VzcyBiZWZvcmUgaW50ZXJwcmV0aW5nIGtleSBldmVudHMKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvU2NoZWR1 bGVkU291cmNlTm9kZS5jcHAJKHJldmlzaW9uIDE2NTM1OCkKKysrIFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViYXVkaW8vQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTU2LDcgKzE1Niw3IEBAIHZvaWQgQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpzdGFy dChkb3UKIHZvaWQgQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpzdG9wKGRvdWJsZSB3aGVuLCBF eGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotICAgIGlm ICghKG1fcGxheWJhY2tTdGF0ZSA9PSBTQ0hFRFVMRURfU1RBVEUgfHwgbV9wbGF5YmFja1N0YXRl ID09IFBMQVlJTkdfU1RBVEUpIHx8IChtX2VuZFRpbWUgIT0gVW5rbm93blRpbWUpKSB7CisgICAg aWYgKChtX3BsYXliYWNrU3RhdGUgPT0gVU5TQ0hFRFVMRURfU1RBVEUpIHx8IChtX2VuZFRpbWUg IT0gVW5rbm93blRpbWUpKSB7CiAgICAgICAgIGVjID0gSU5WQUxJRF9TVEFURV9FUlI7CiAgICAg ICAgIHJldHVybjsKICAgICB9Cg==