<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>129998</bug_id>
          
          <creation_ts>2014-03-09 20:08:47 -0700</creation_ts>
          <short_desc>GPRInfo::toIndex should return InvalidIndex for non-temp registers on ARM64</short_desc>
          <delta_ts>2014-03-09 23:51:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>112840</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>barraclough</cc>
    
    <cc>ggaren</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>mmirman</cc>
    
    <cc>msaboff</cc>
    
    <cc>nrotem</cc>
    
    <cc>oliver</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>988789</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-03-09 20:08:47 -0700</bug_when>
    <thetext>Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>988791</commentid>
    <comment_count>1</comment_count>
      <attachid>226276</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-03-09 20:12:06 -0700</bug_when>
    <thetext>Created attachment 226276
the patch

Still running tests to confirm that this is ok.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>988792</commentid>
    <comment_count>2</comment_count>
      <attachid>226276</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2014-03-09 20:17:17 -0700</bug_when>
    <thetext>Comment on attachment 226276
the patch

Do we need to ASSERT(index &lt;= regT15) in toRegister() to match this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>988793</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-03-09 20:19:19 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 226276 [details])
&gt; Do we need to ASSERT(index &lt;= regT15) in toRegister() to match this?

I suppose we could add one.  I&apos;m not sure how much good it would do, though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>988813</commentid>
    <comment_count>4</comment_count>
      <attachid>226276</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-03-09 23:48:04 -0700</bug_when>
    <thetext>Comment on attachment 226276
the patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>988814</commentid>
    <comment_count>5</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-03-09 23:51:34 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/165362</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>226276</attachid>
            <date>2014-03-09 20:12:06 -0700</date>
            <delta_ts>2014-03-09 23:48:04 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>blah.patch</filename>
            <type>text/plain</type>
            <size>1874</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MzU4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA
CisyMDE0LTAzLTA5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
R1BSSW5mbzo6dG9JbmRleCBzaG91bGQgcmV0dXJuIEludmFsaWRJbmRleCBmb3Igbm9uLXRlbXAg
cmVnaXN0ZXJzIG9uIEFSTTY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0xMjk5OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KyAgICAgICAgCisgICAgICAgIE5vdCBvbmx5IGlzIHRoYXQgdGhlIGVzdGFibGlzaGVkIGNvbnRy
YWN0LCBidXQgdGhpcyBpcyB1c2VkIHRvIHNpZ25hbCB0bworICAgICAgICBTY3JhdGNoUmVnaXN0
ZXJBbGxvY2F0b3IgdGhhdCB0aGUgcmVnaXN0ZXIgZG9lc24ndCBuZWVkIGxvY2tpbmcgc2luY2Ug
aXQgaXNuJ3QgYSByZWdpc3RlcgorICAgICAgICB0aGF0IHRoaXMgYWxsb2NhdG9yIHdvdWxkIHVz
ZS4gSW4gdGhlIEZUTCwgd2UgbWF5IGhhdmUgYW4gaW5saW5lIGNhY2hlIHdoZXJlIExMVk0gaGFk
IHVzZWQKKyAgICAgICAgc29tZSBub24tdGVtcCByZWdpc3RlciAoaS5lLiBhIHJlZ2lzdGVyIHRo
YXQgSlNDIGl0c2VsZiB3b3VsZG4ndCBoYXZlIHVzZWQpLiBUaGlzIGlzIHRvdGFsbHkKKyAgICAg
ICAgZmluZSBidXQgcHJldmlvdXNseSBpdCB3b3VsZCBoYXZlIGxlZCB0byBlaXRoZXIgYW4gYXNz
ZXJ0aW9uIGZhaWx1cmUsIG9yIGRhdGEgY29ycnVwdGlvbiwgaW4KKyAgICAgICAgdGhlIFNjcmF0
Y2hSZWdpc3RlckFsbG9jYXRvci4KKworICAgICAgICAqIGppdC9HUFJJbmZvLmg6CisgICAgICAg
IChKU0M6OkdQUkluZm86OnRvSW5kZXgpOgorCiAyMDE0LTAzLTA5ICBGaWxpcCBQaXpsbyAgPGZw
aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgRlRMIGZhaWxzIHRoZSBuZXcgZXF1YWxzLW1hc3F1
ZXJhZGVyIHN0cmljdEVxdWFsQ29uc3RhbnQgdGVzdApJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL2ppdC9HUFJJbmZvLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pp
dC9HUFJJbmZvLmgJKHJldmlzaW9uIDE2NTM1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q
aXQvR1BSSW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHly
aWdodCAoQykgMjAxMSwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBD
b3B5cmlnaHQgKEMpIDIwMTEsIDIwMTMsIDIwMTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy
dmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkg
Zm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy
b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC02MDEsNiArNjAxLDggQEAg
cHVibGljOgogICAgIH0KICAgICBzdGF0aWMgdW5zaWduZWQgdG9JbmRleChHUFJSZWcgcmVnKQog
ICAgIHsKKyAgICAgICAgaWYgKHJlZyA+IHJlZ1QxNSkKKyAgICAgICAgICAgIHJldHVybiBJbnZh
bGlkSW5kZXg7CiAgICAgICAgIHJldHVybiAodW5zaWduZWQpcmVnOwogICAgIH0KIAo=
</data>
<flag name="review"
          id="250492"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>