129995 2014-03-09 16:36:44 -0700 Short-circuit JSGlobalObjectInspectorController when not inspecting. 2014-03-13 16:52:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling ggaren joepeck kling timothy oldest_to_newest 988756 0 kling 2014-03-09 16:36:44 -0700 We're hitting symbolication pretty hard below JSGlobalObjectInspectorController::reportAPIException() on DYEB. 988757 1 226261 kling 2014-03-09 16:37:13 -0700 Created attachment 226261 Patch 988761 2 226261 ggaren 2014-03-09 17:39:59 -0700 Comment on attachment 226261 Patch Should we check m_consoleAgent->enabled() instead? That seems a little closer to the code we're guarding. 988768 3 kling 2014-03-09 18:42:49 -0700 (In reply to comment #2) > (From update of attachment 226261 [details]) > Should we check m_consoleAgent->enabled() instead? That seems a little closer to the code we're guarding. SGTM. I'll land with that change :) 988769 4 kling 2014-03-09 18:51:57 -0700 Committed r165357: <http://trac.webkit.org/changeset/165357> 988936 5 joepeck 2014-03-10 10:22:46 -0700 How were you actually seeing this in DYEB? Any backtrace would do. reportAPIException is supposed to be used for JSC API exceptions. If we are triggering this frequently, is it on purpose or is it something we are doing in WebCore / Browser level that triggers an exception that we could avoid? 989557 6 joepeck 2014-03-12 01:16:28 -0700 (In reply to comment #5) > How were you actually seeing this in DYEB? Any backtrace would do. Did we find out what the exception actually was? 990201 7 kling 2014-03-13 16:52:24 -0700 (In reply to comment #6) > (In reply to comment #5) > > How were you actually seeing this in DYEB? Any backtrace would do. > > Did we find out what the exception actually was? Nope. :| Rolled this out in <https://trac.webkit.org/r165575> since now I can't get an exception to show up anymore. 226261 2014-03-09 16:37:13 -0700 2014-03-09 17:39:59 -0700 Patch bug-129995.diff text/plain 1558 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNiMDNjN2UuLjk4Y2UyNzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTA5ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBTaG9ydC1jaXJjdWl0IEpTR2xvYmFsT2Jq ZWN0SW5zcGVjdG9yQ29udHJvbGxlciB3aGVuIG5vdCBpbnNwZWN0aW5nLgorICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMTI5OTk1PgorCisgICAgICAgIEFkZCBhbiBlYXJseSByZXR1cm4g aW4gcmVwb3J0QVBJRXhjZXB0aW9uKCkgd2hlbiB0aGVyZSdzIG5vIGZyb250LWVuZAorICAgICAg ICBjb25uZWN0ZWQuIFRoaXMgYXZvaWRzIGV4cGVuc2l2ZSBzeW1ib2xpY2F0aW9uIGR1cmluZyBl eGNlcHRpb25zLgorCisgICAgICAgIH4zJSBwcm9ncmVzc2lvbiBvbiBEWUVCIG9uIG15IE1CUC4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoSW5z cGVjdG9yOjpKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OnJlcG9ydEFQSUV4Y2Vw dGlvbik6CisKIDIwMTQtMDMtMDggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIDMyLWJpdCB4ODYgaGFuZGxlVW5jYXVnaHRFeGNlcHRpb24gcmV0dXJucyB0byB3cm9u ZyBsb2NhdGlvbiBhZnRlciBhIHN0YWNrIG92ZXJmbG93LgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3Bl Y3RvckNvbnRyb2xsZXIuY3BwCmluZGV4IDA1OWM2OTkuLjYyMWI1OWYwIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2Jh bE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0xNDEsNiArMTQxLDkgQEAgdm9pZCBK U0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmFwcGVuZEFQSUJhY2t0cmFjZShTY3Jp cHRDYWxsU3RhY2sqIGNhbGwKIAogdm9pZCBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xs ZXI6OnJlcG9ydEFQSUV4Y2VwdGlvbihFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgZXhjZXB0aW9u KQogeworICAgIGlmICghbV9pbnNwZWN0b3JGcm9udGVuZENoYW5uZWwpCisgICAgICAgIHJldHVy bjsKKwogICAgIGlmIChpc1Rlcm1pbmF0ZWRFeGVjdXRpb25FeGNlcHRpb24oZXhjZXB0aW9uKSkK ICAgICAgICAgcmV0dXJuOwogCg==