129984 2014-03-08 18:02:05 -0800 Inline the trivial parts of GC deferral. 2014-03-09 18:41:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue ggaren kling mhahnenberg rniwa simon.fraser oldest_to_newest 988667 0 kling 2014-03-08 18:02:05 -0800 DYEB spends about 1.5% in DeferGC. Inlining everything but collect() looks like a 1% progression on my MBP. 988668 1 226243 kling 2014-03-08 18:03:05 -0800 Created attachment 226243 Patch 988742 2 226243 ggaren 2014-03-09 12:24:05 -0700 Comment on attachment 226243 Patch r=me 988747 3 226243 commit-queue 2014-03-09 14:01:43 -0700 Comment on attachment 226243 Patch Clearing flags on attachment: 226243 Committed r165355: <http://trac.webkit.org/changeset/165355> 988748 4 commit-queue 2014-03-09 14:01:47 -0700 All reviewed patches have been landed. Closing bug. 988762 5 simon.fraser 2014-03-09 18:00:46 -0700 One test crashing (in thread 2043!) after this: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r165356%20(13132)/results.html 988767 6 kling 2014-03-09 18:41:59 -0700 (In reply to comment #5) > One test crashing (in thread 2043!) after this: > http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r165356%20(13132)/results.html AFAICT that was crashing prior to this change, too. 226243 2014-03-08 18:03:05 -0800 2014-03-09 14:01:43 -0700 Patch bug-129984.diff text/plain 3356 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNiMDNjN2UuLjRjNDFmM2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAzLTA4ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBJbmxpbmUgdGhlIHRyaXZpYWwgcGFydHMg b2YgR0MgZGVmZXJyYWwuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjk5ODQ+CisK KyAgICAgICAgTWFkZSBtb3N0IG9mIHRoZSBmdW5jdGlvbnMgY2FsbGVkIGJ5IHRoZSBEZWZlckdD IFJBSUkgb2JqZWN0IGlubGluZQorICAgICAgICB0byBhdm9pZCBmdW5jdGlvbiBjYWxsIG92ZXJo ZWFkLgorCisgICAgICAgIExvb2tzIGxpa2UgfjElIHByb2dyZXNzaW9uIG9uIERZRUIuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBoZWFwL0hlYXAu Y3BwOgorICAgICAgICAqIGhlYXAvSGVhcC5oOgorICAgICAgICAoSlNDOjpIZWFwOjppbmNyZW1l bnREZWZlcnJhbERlcHRoKToKKyAgICAgICAgKEpTQzo6SGVhcDo6ZGVjcmVtZW50RGVmZXJyYWxE ZXB0aCk6CisgICAgICAgIChKU0M6OkhlYXA6OmNvbGxlY3RJZk5lY2Vzc2FyeU9yRGVmZXIpOgor ICAgICAgICAoSlNDOjpIZWFwOjpkZWNyZW1lbnREZWZlcnJhbERlcHRoQW5kR0NJZk5lZWRlZCk6 CisKIDIwMTQtMDMtMDggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IDMyLWJpdCB4ODYgaGFuZGxlVW5jYXVnaHRFeGNlcHRpb24gcmV0dXJucyB0byB3cm9uZyBsb2Nh dGlvbiBhZnRlciBhIHN0YWNrIG92ZXJmbG93LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNw cAppbmRleCA2Zjk5OGI4Li5jY2U3ZjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaGVhcC9IZWFwLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNw cApAQCAtOTE2LDE4ICs5MTYsNiBAQCB2b2lkIEhlYXA6OmNvbGxlY3QoKQogICAgIH0KIH0KIAot Ym9vbCBIZWFwOjpjb2xsZWN0SWZOZWNlc3NhcnlPckRlZmVyKCkKLXsKLSAgICBpZiAoaXNEZWZl cnJlZCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBpZiAoIXNob3VsZENvbGxlY3Qo KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgY29sbGVjdCgpOwotICAgIHJldHVybiB0 cnVlOwotfQotCiB2b2lkIEhlYXA6OnN1c3BlbmRDb21waWxlclRocmVhZHMoKQogewogI2lmIEVO QUJMRShERkdfSklUKQpAQCAtMTIwMSwyNiArMTE4OSw2IEBAIHZvaWQgSGVhcDo6em9tYmlmeURl YWRPYmplY3RzKCkKICAgICBtX29iamVjdFNwYWNlLmZvckVhY2hEZWFkQ2VsbDxab21iaWZ5Pihp dGVyYXRpb25TY29wZSk7CiB9CiAKLXZvaWQgSGVhcDo6aW5jcmVtZW50RGVmZXJyYWxEZXB0aCgp Ci17Ci0gICAgUkVMRUFTRV9BU1NFUlQobV9kZWZlcnJhbERlcHRoIDwgMTAwKTsgLy8gU2FuaXR5 IGNoZWNrIHRvIG1ha2Ugc3VyZSB0aGlzIGRvZXNuJ3QgZ2V0IHJpZGljdWxvdXMuCi0gICAgCi0g ICAgbV9kZWZlcnJhbERlcHRoKys7Ci19Ci0KLXZvaWQgSGVhcDo6ZGVjcmVtZW50RGVmZXJyYWxE ZXB0aCgpCi17Ci0gICAgUkVMRUFTRV9BU1NFUlQobV9kZWZlcnJhbERlcHRoID49IDEpOwotICAg IAotICAgIG1fZGVmZXJyYWxEZXB0aC0tOwotfQotCi12b2lkIEhlYXA6OmRlY3JlbWVudERlZmVy cmFsRGVwdGhBbmRHQ0lmTmVlZGVkKCkKLXsKLSAgICBkZWNyZW1lbnREZWZlcnJhbERlcHRoKCk7 Ci0gICAgY29sbGVjdElmTmVjZXNzYXJ5T3JEZWZlcigpOwotfQotCiB2b2lkIEhlYXA6OndyaXRl QmFycmllcihjb25zdCBKU0NlbGwqIGZyb20pCiB7CiAjaWYgRU5BQkxFKEdHQykKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL0hlYXAuaAppbmRleCBjZjIzZTJjLi40ZTI1ZTgyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvSGVhcC5oCkBAIC0zMDEsOSArMzAxLDkgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAg ICAgSlNTdGFjayYgc3RhY2soKTsKICAgICAgICAgCi0gICAgICAgIEpTX0VYUE9SVF9QUklWQVRF IHZvaWQgaW5jcmVtZW50RGVmZXJyYWxEZXB0aCgpOworICAgICAgICB2b2lkIGluY3JlbWVudERl ZmVycmFsRGVwdGgoKTsKICAgICAgICAgdm9pZCBkZWNyZW1lbnREZWZlcnJhbERlcHRoKCk7Ci0g ICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgZGVjcmVtZW50RGVmZXJyYWxEZXB0aEFuZEdD SWZOZWVkZWQoKTsKKyAgICAgICAgdm9pZCBkZWNyZW1lbnREZWZlcnJhbERlcHRoQW5kR0NJZk5l ZWRlZCgpOwogCiAgICAgICAgIGNvbnN0IEhlYXBUeXBlIG1faGVhcFR5cGU7CiAgICAgICAgIGNv bnN0IHNpemVfdCBtX3JhbVNpemU7CkBAIC01NDUsNiArNTQ1LDM3IEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgIH0KICNlbmRpZgogCisKK2lubGluZSB2b2lkIEhlYXA6OmluY3JlbWVudERlZmVycmFs RGVwdGgoKQoreworICAgIFJFTEVBU0VfQVNTRVJUKG1fZGVmZXJyYWxEZXB0aCA8IDEwMCk7IC8v IFNhbml0eSBjaGVjayB0byBtYWtlIHN1cmUgdGhpcyBkb2Vzbid0IGdldCByaWRpY3Vsb3VzLgor ICAgIG1fZGVmZXJyYWxEZXB0aCsrOworfQorCitpbmxpbmUgdm9pZCBIZWFwOjpkZWNyZW1lbnRE ZWZlcnJhbERlcHRoKCkKK3sKKyAgICBSRUxFQVNFX0FTU0VSVChtX2RlZmVycmFsRGVwdGggPj0g MSk7CisgICAgbV9kZWZlcnJhbERlcHRoLS07Cit9CisKK2lubGluZSBib29sIEhlYXA6OmNvbGxl Y3RJZk5lY2Vzc2FyeU9yRGVmZXIoKQoreworICAgIGlmIChpc0RlZmVycmVkKCkpCisgICAgICAg IHJldHVybiBmYWxzZTsKKworICAgIGlmICghc2hvdWxkQ29sbGVjdCgpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICBjb2xsZWN0KCk7CisgICAgcmV0dXJuIHRydWU7Cit9CisKK2lubGlu ZSB2b2lkIEhlYXA6OmRlY3JlbWVudERlZmVycmFsRGVwdGhBbmRHQ0lmTmVlZGVkKCkKK3sKKyAg ICBkZWNyZW1lbnREZWZlcnJhbERlcHRoKCk7CisgICAgY29sbGVjdElmTmVjZXNzYXJ5T3JEZWZl cigpOworfQorCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAogI2VuZGlmIC8vIEhlYXBfaAo=