129982 2014-03-08 17:19:38 -0800 RenderElement::valueForLength() callers misuse bool parameter. 2014-03-08 18:33:12 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 988658 0 zalan 2014-03-08 17:19:38 -0800 Do not pass RenderView* as bool (percentage) LayoutUnit valueForLength(const Length&, LayoutUnit maximumValue, bool roundPercentages = false) const; 988663 1 226242 zalan 2014-03-08 17:40:07 -0800 Created attachment 226242 Patch 988666 2 226242 kling 2014-03-08 17:41:31 -0800 Comment on attachment 226242 Patch Wut. r=me 988674 3 226242 commit-queue 2014-03-08 18:33:10 -0800 Comment on attachment 226242 Patch Clearing flags on attachment: 226242 Committed r165346: <http://trac.webkit.org/changeset/165346> 988676 4 commit-queue 2014-03-08 18:33:12 -0800 All reviewed patches have been landed. Closing bug. 226242 2014-03-08 17:40:07 -0800 2014-03-08 18:33:10 -0800 Patch bug-129982-20140308173953.patch text/plain 3492 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODk4OTk1ZTU1NGE2MWQ2 ZWY4N2Q1NGFmOTdlYTBmNzVkMTBiZTY1NC4uZDY5NjQyMWU0NDQxMGQxYjRhZjRiNDAzODQ3OTQ2 M2IwMTBjZGEwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAzLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVuZGVyRWxlbWVudDo6dmFs dWVGb3JMZW5ndGgoKSBjYWxsZXJzIG1pc3VzZSBib29sIHBhcmFtZXRlci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTk4MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBib2d1cyBSZW5kZXJW aWV3KiBwYXJhbWV0ZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZVBlcmNlbnRhZ2VMb2dpY2FsSGVpZ2h0 KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJFbGVtZW50OjpyZXBhaW50QWZ0ZXJMYXlvdXRJZk5lZWRlZCk6CisKKzIwMTQt MDMtMDggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKwogICAgICAgICBTdWJwaXhl bCByZW5kZXJpbmc6IFNpbXBsZSBjb21wb3NpdGluZyBjb250YWluZXIgbGF5ZXIgKGlzU2ltcGxl Q29udGFpbmVyQ29tcG9zaXRpbmdMYXllcikgcGFpbnRzIHRvIHdyb25nIHBvc2l0aW9uLgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODYxCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggYWY0NWJiNjA5NTMwZTg4N2Q3 MDI2MGNhNzQ5ZWQ4NWIzYmNjNjg4Yi4uMWRiYzI2MWNmMjQxMjgxZDZhNmZmNmRlZGUyZDg4YzJi N2VjOWFiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTI3NzUs NyArMjc3NSw3IEBAIExheW91dFVuaXQgUmVuZGVyQm94Ojpjb21wdXRlUGVyY2VudGFnZUxvZ2lj YWxIZWlnaHQoY29uc3QgTGVuZ3RoJiBoZWlnaHQpIGNvbnN0CiAgICAgICAgICAgICBhdmFpbGFi bGVIZWlnaHQgPSBzdGQ6Om1heDxMYXlvdXRVbml0PigwLCBjb250ZW50Qm94SGVpZ2h0KTsKICAg ICAgICAgfQogICAgIH0gZWxzZSBpZiAoY2JzdHlsZS5sb2dpY2FsSGVpZ2h0KCkuaXNWaWV3cG9y dFBlcmNlbnRhZ2UoKSkgewotICAgICAgICBMYXlvdXRVbml0IGhlaWdodFdpdGhTY3JvbGxiYXIg PSB2YWx1ZUZvckxlbmd0aChjYnN0eWxlLmxvZ2ljYWxIZWlnaHQoKSwgMCwgJnZpZXcoKSk7Cisg ICAgICAgIExheW91dFVuaXQgaGVpZ2h0V2l0aFNjcm9sbGJhciA9IHZhbHVlRm9yTGVuZ3RoKGNi c3R5bGUubG9naWNhbEhlaWdodCgpLCAwKTsKICAgICAgICAgaWYgKGhlaWdodFdpdGhTY3JvbGxi YXIgIT0gLTEpIHsKICAgICAgICAgICAgIExheW91dFVuaXQgY29udGVudEJveEhlaWdodFdpdGhT Y3JvbGxiYXIgPSBjYi0+YWRqdXN0Q29udGVudEJveExvZ2ljYWxIZWlnaHRGb3JCb3hTaXppbmco aGVpZ2h0V2l0aFNjcm9sbGJhcik7CiAgICAgICAgICAgICAvLyBXZSBuZWVkIHRvIGFkanVzdCBm b3IgbWluL21heCBoZWlnaHQgYmVjYXVzZSB0aGlzIG1ldGhvZCBkb2VzIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCmluZGV4IDc3NTg2ZTlkMGNmMzQxZWViYjgy MGZiZTc1ZGE1NmZiYWQ5YmJiZjIuLmIwZGJhNWU3N2VkNDI0ZTE3ODVhYWYzNTEyNTRmYThmYjVm MjZkNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKQEAg LTEyNzcsNyArMTI3Nyw4IEBAIGJvb2wgUmVuZGVyRWxlbWVudDo6cmVwYWludEFmdGVyTGF5b3V0 SWZOZWVkZWQoY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCogcmVwCiAgICAgICAgIExheW91 dFVuaXQgYm9yZGVyQm90dG9tID0gaXNCb3goKSA/IHRvUmVuZGVyQm94KHRoaXMpLT5ib3JkZXJC b3R0b20oKSA6IExheW91dFVuaXQ6OmZyb21QaXhlbCgwKTsKICAgICAgICAgTGF5b3V0VW5pdCBi b3hIZWlnaHQgPSBpc0JveCgpID8gdG9SZW5kZXJCb3godGhpcyktPmhlaWdodCgpIDogTGF5b3V0 VW5pdCgpOwogICAgICAgICBMYXlvdXRVbml0IG1pbkluc2V0Qm90dG9tU2hhZG93RXh0ZW50ID0g c3RkOjptaW48TGF5b3V0VW5pdD4oLWluc2V0U2hhZG93RXh0ZW50LmJvdHRvbSgpLCBzdGQ6Om1p bjxMYXlvdXRVbml0PihuZXdCb3VuZHMuaGVpZ2h0KCksIG9sZEJvdW5kcy5oZWlnaHQoKSkpOwot ICAgICAgICBMYXlvdXRVbml0IGJvcmRlckhlaWdodCA9IHN0ZDo6bWF4PExheW91dFVuaXQ+KGJv cmRlckJvdHRvbSwgc3RkOjptYXg8TGF5b3V0VW5pdD4odmFsdWVGb3JMZW5ndGgoc3R5bGUoKS5i b3JkZXJCb3R0b21MZWZ0UmFkaXVzKCkuaGVpZ2h0KCksIGJveEhlaWdodCksIHZhbHVlRm9yTGVu Z3RoKHN0eWxlKCkuYm9yZGVyQm90dG9tUmlnaHRSYWRpdXMoKS5oZWlnaHQoKSwgYm94SGVpZ2h0 LCAmdmlldygpKSkpOworICAgICAgICBMYXlvdXRVbml0IGJvcmRlckhlaWdodCA9IHN0ZDo6bWF4 PExheW91dFVuaXQ+KGJvcmRlckJvdHRvbSwgc3RkOjptYXg8TGF5b3V0VW5pdD4odmFsdWVGb3JM ZW5ndGgoc3R5bGUoKS5ib3JkZXJCb3R0b21MZWZ0UmFkaXVzKCkuaGVpZ2h0KCksIGJveEhlaWdo dCksCisgICAgICAgICAgICB2YWx1ZUZvckxlbmd0aChzdHlsZSgpLmJvcmRlckJvdHRvbVJpZ2h0 UmFkaXVzKCkuaGVpZ2h0KCksIGJveEhlaWdodCkpKTsKICAgICAgICAgTGF5b3V0VW5pdCBkZWNv cmF0aW9uc0hlaWdodCA9IHN0ZDo6bWF4PExheW91dFVuaXQ+KC1vdXRsaW5lU3R5bGUub3V0bGlu ZU9mZnNldCgpLCBib3JkZXJIZWlnaHQgKyBtaW5JbnNldEJvdHRvbVNoYWRvd0V4dGVudCkgKyBz dGQ6Om1heDxMYXlvdXRVbml0PihvdXRsaW5lV2lkdGgsIHNoYWRvd0JvdHRvbSk7CiAgICAgICAg IExheW91dFJlY3QgYm90dG9tUmVjdChuZXdPdXRsaW5lQm94LngoKSwKICAgICAgICAgICAgIHN0 ZDo6bWluKG5ld091dGxpbmVCb3gubWF4WSgpLCBvbGRPdXRsaW5lQm94Lm1heFkoKSkgLSBkZWNv cmF0aW9uc0hlaWdodCwK