129972 2014-03-08 11:19:16 -0800 Build failure on OpenBSD in gtest 2014-03-10 14:51:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 landry webkit-unassigned ajacoutot commit-queue oldest_to_newest 988583 0 landry 2014-03-08 11:19:16 -0800 CXX Source/ThirdParty/gtest/src/Libraries_libgtest_la-gtest-all.lo In file included from /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40:0, from /src/WebKit/Source/ThirdParty/gtest/include/gtest/gtest.h:57, from ../../../src/WebKit/Source/ThirdParty/gtest/src/gtest-all.cc:39: /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::IsATTY(int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1349:45: error: 'isatty' was not declared in this scope inline int IsATTY(int fd) { return isatty(fd); } ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::RmDir(const char*)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1355:53: error: 'rmdir' was not declared in this scope inline int RmDir(const char* dir) { return rmdir(dir); } ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::ChDir(const char*)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1377:53: error: 'chdir' was not declared in this scope inline int ChDir(const char* dir) { return chdir(dir); } ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Read(int, void*, unsigned int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1391:46: error: 'read' was not declared in this scope return static_cast<int>(read(fd, buf, count)); ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Write(int, const void*, unsigned int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1394:47: error: 'write' was not declared in this scope return static_cast<int>(write(fd, buf, count)); ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Close(int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1396:43: error: 'close' was not declared in this scope inline int Close(int fd) { return close(fd); } 988584 1 226220 landry 2014-03-08 11:22:28 -0800 Created attachment 226220 Patch 988841 2 226220 ossy 2014-03-10 02:50:16 -0700 Comment on attachment 226220 Patch LGTM, r=me. Please send this patch to the upstream gtest too not to have this problem again once gtest is updated in the WebKit repository. 988842 3 226220 commit-queue 2014-03-10 02:52:16 -0700 Comment on attachment 226220 Patch Rejecting attachment 226220 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 226220, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/ThirdParty/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5137805000835072 989060 4 landry 2014-03-10 14:51:15 -0700 It is already partly upstream, cf https://code.google.com/p/googletest/source/browse/trunk/include/gtest/internal/gtest-port.h#328 What's needed for the commit bot to be smart and add the reviewer line to the patch and autoland things ? Is there still manual fiddling to do ? 226220 2014-03-08 11:22:28 -0800 2014-03-10 02:52:16 -0700 Patch bug-129972-20140308202227.patch text/plain 1846 landry U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggNmE0ZDM1YTQ0 N2Q2MDVmOTljYzlhMWI3MmM0NDdiODFiNzdkZmY1MS4uNGMyYThiMGQ2NjkxMDM0YjgzY2MxMjVl Y2VjMmQxMjZhZDBmOGNiOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDEyIEBACiAyMDE0 LTAzLTA4ICBMYW5kcnkgQnJldWlsICA8bGFuZHJ5QG9wZW5ic2Qub3JnPgogCisgICAgICAgIEZp eCBndGVzdCBidWlsZCBvbiBPcGVuQlNEL05ldEJTRC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTk3MgorCisgICAgICAgICogZ3Rlc3QvaW5jbHVk ZS9ndGVzdC9pbnRlcm5hbC9ndGVzdC1wb3J0Lmg6CisKKzIwMTQtMDMtMDggIExhbmRyeSBCcmV1 aWwgIDxsYW5kcnlAb3BlbmJzZC5vcmc+CisKICAgICAgICAgRml4IGxldmVsZGIgYnVpbGQgb24g T3BlbkJTRC9OZXRCU0QgYnkgdXNpbmcgdGhlIEZyZWVCU0QgY29kZXBhdGhzLgogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5OTY2CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L2luY2x1ZGUvZ3Rlc3QvaW50ZXJuYWwvZ3Rlc3Qt cG9ydC5oIGIvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvaW5jbHVkZS9ndGVzdC9pbnRlcm5hbC9n dGVzdC1wb3J0LmgKaW5kZXggZThjNmFlMGQ3ZWI2ZWZhYzE0M2ZmOTQ4NzE5YWY5ZjNhZTA2Mzdm Yy4uMmM4ODk4ZjY2YjU0ZjIxNTliMGE1ZjdhMjNiMWRhMThmNjJmZTlkYyAxMDA2NDQKLS0tIGEv U291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvaW5jbHVkZS9ndGVzdC9pbnRlcm5hbC9ndGVzdC1wb3J0 LmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvaW5jbHVkZS9ndGVzdC9pbnRlcm5hbC9n dGVzdC1wb3J0LmgKQEAgLTIyNSw2ICsyMjUsMTAgQEAKICNkZWZpbmUgR1RFU1RfT1NfSFVSRCAx CiAjZWxpZiBkZWZpbmVkKF9fRnJlZUJTRF9fKSB8fCBkZWZpbmVkKF9fRHJhZ29uRmx5X18pIHx8 IGRlZmluZWQoX19GcmVlQlNEX2tlcm5lbF9fKQogI2RlZmluZSBHVEVTVF9PU19GUkVFQlNEIDEK KyNlbGlmIGRlZmluZWQgX19PcGVuQlNEX18KKyNkZWZpbmUgR1RFU1RfT1NfT1BFTkJTRCAxCisj ZWxpZiBkZWZpbmVkIF9fTmV0QlNEX18KKyNkZWZpbmUgR1RFU1RfT1NfTkVUQlNEIDEKICNlbGlm IGRlZmluZWQgX19NVlNfXwogI2RlZmluZSBHVEVTVF9PU19aT1MgMQogI2VsaWYgZGVmaW5lZChf X3N1bikgJiYgZGVmaW5lZChfX1NWUjQpCkBAIC0yMzQsNyArMjM4LDcgQEAKICNlbmRpZiAgLy8g X19DWUdXSU5fXwogCiAjaWYgR1RFU1RfT1NfQ1lHV0lOIHx8IEdURVNUX09TX0xJTlVYIHx8IEdU RVNUX09TX01BQyB8fCBHVEVTVF9PU19TWU1CSUFOIHx8IFwKLSAgICBHVEVTVF9PU19TT0xBUklT IHx8IEdURVNUX09TX0FJWCB8fCBHVEVTVF9PU19GUkVFQlNEIHx8IEdURVNUX09TX0hVUkQKKyAg ICBHVEVTVF9PU19TT0xBUklTIHx8IEdURVNUX09TX0FJWCB8fCBHVEVTVF9PU19GUkVFQlNEIHx8 IEdURVNUX09TX09QRU5CU0QgfHwgR1RFU1RfT1NfTkVUQlNEIHx8IEdURVNUX09TX0hVUkQKIAog Ly8gT24gc29tZSBwbGF0Zm9ybXMsIDxyZWdleC5oPiBuZWVkcyBzb21lb25lIHRvIGRlZmluZSBz aXplX3QsIGFuZAogLy8gd29uJ3QgY29tcGlsZSBvdGhlcndpc2UuICBXZSBjYW4gI2luY2x1ZGUg aXQgaGVyZSBhcyB3ZSBhbHJlYWR5Cg==