129971 2014-03-08 11:15:20 -0800 Use std::isnan in profiler/ProfileNode.cpp to fix build failure on OpenBSD 2016-01-27 15:04:55 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 landry webkit-unassigned commit-queue joepeck oldest_to_newest 988579 0 landry 2014-03-08 11:15:20 -0800 Build fail if using isnan() directly. Use std::isnan as it's consistent all over webkit's source code.. 988582 1 226219 landry 2014-03-08 11:17:26 -0800 Created attachment 226219 Patch 988598 2 226219 ggaren 2014-03-08 12:11:51 -0800 Comment on attachment 226219 Patch r=me 988599 3 226219 commit-queue 2014-03-08 12:12:46 -0800 Comment on attachment 226219 Patch Rejecting attachment 226219 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226219, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5200201748840448 1159460 4 joepeck 2016-01-27 15:04:55 -0800 Looks like this landed a long time ago. 226219 2014-03-08 11:17:26 -0800 2014-03-08 12:12:46 -0800 Patch bug-129971-20140308201725.patch text/plain 1646 landry U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZTJlMjcyYWUzMDZjMjJkZWE5YWFlNjFlNTc4MjMyMzkyMzdiYmFkLi41NWUzMTE4OTM5MjEyZjc2 MmJiYWE2MjM0MzcwMjNkODA2NGEzNTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNC0wMy0wOCAgTGFuZHJ5IEJyZXVpbCAgPGxhbmRyeUBvcGVuYnNkLm9y Zz4KKworICAgICAgICBVc2Ugc3RkOjppc25hbiBpbnN0ZWFkIG9mIGlzbmFuKCkgdG8gZml4IGEg YnVpbGQgZmFpbHVyZSBvbiBPcGVuQlNELgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI5OTcxCisKKyAgICAgICAgKiBwcm9maWxlci9Qcm9maWxlTm9k ZS5jcHA6CisgICAgICAgIChKU0M6OlByb2ZpbGVOb2RlOjpzdG9wUHJvZmlsaW5nKToKKyAgICAg ICAgKEpTQzo6UHJvZmlsZU5vZGU6OmVuZEFuZFJlY29yZENhbGwpOgorCiAyMDE0LTAzLTA4ICBM YW5kcnkgQnJldWlsIDxsYW5kcnlAb3BlbmJzZC5vcmc+CiAKICAgICAgICAgVXNlIHB0aHJlYWRf c3RhY2tzZWdfbnAoKSB0byBmaW5kIHRoZSBzdGFjayBib3VuZHMgb24gT3BlbkJTRC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Qcm9maWxlTm9kZS5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcHJvZmlsZXIvUHJvZmlsZU5vZGUuY3BwCmluZGV4IDE2Y2Iy NGM1Yzc4NzA3ZWQwMTVkYzEyYzNiOTM3NjE1OTE4OGMxZDcuLmY1OTRhZTkyNzliMjFkODkxOWUy OGFkNTI4YzczYzg3ZTgxZTFkODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9w cm9maWxlci9Qcm9maWxlTm9kZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Byb2Zp bGVyL1Byb2ZpbGVOb2RlLmNwcApAQCAtMTIzLDcgKzEyMyw3IEBAIHZvaWQgUHJvZmlsZU5vZGU6 OnN0b3BQcm9maWxpbmcoKQogewogICAgIEFTU0VSVCghbV9jYWxscy5pc0VtcHR5KCkpOwogCi0g ICAgaWYgKGlzbmFuKG1fY2FsbHMubGFzdCgpLnRvdGFsVGltZSgpKSkKKyAgICBpZiAoc3RkOjpp c25hbihtX2NhbGxzLmxhc3QoKS50b3RhbFRpbWUoKSkpCiAgICAgICAgIGVuZEFuZFJlY29yZENh bGwoKTsKIAogICAgIC8vIEJlY2F1c2Ugd2UgaXRlcmF0ZSBpbiBwb3N0IG9yZGVyIGFsbCBvZiBv dXIgY2hpbGRyZW4gaGF2ZSBiZWVuIHN0b3BwZWQgYmVmb3JlIHVzLgpAQCAtMTQ3LDcgKzE0Nyw3 IEBAIFByb2ZpbGVOb2RlKiBQcm9maWxlTm9kZTo6dHJhdmVyc2VOZXh0Tm9kZVBvc3RPcmRlcigp IGNvbnN0CiB2b2lkIFByb2ZpbGVOb2RlOjplbmRBbmRSZWNvcmRDYWxsKCkKIHsKICAgICBDYWxs JiBsYXN0ID0gbGFzdENhbGwoKTsKLSAgICBBU1NFUlQoaXNuYW4obGFzdC50b3RhbFRpbWUoKSkp OworICAgIEFTU0VSVChzdGQ6OmlzbmFuKGxhc3QudG90YWxUaW1lKCkpKTsKIAogICAgIGxhc3Qu c2V0VG90YWxUaW1lKGN1cnJlbnRUaW1lKCkgLSBsYXN0LnN0YXJ0VGltZSgpKTsKIAo=