129970 2014-03-08 11:06:55 -0800 AX: Trailing semicolon in Tools/DumpRenderTree/AccessibilityUIElement.cpp since bug 129039 2022-10-09 13:46:17 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 129039 1 landry webkit-unassigned ahmad.saleem792 cfleizach commit-queue webkit-bug-importer oldest_to_newest 988576 0 landry 2014-03-08 11:06:55 -0800 - if (argumentCount == 1); + if (argumentCount == 1) indexNumber = JSValueToNumber(context, arguments[0], exception); 988577 1 226218 landry 2014-03-08 11:11:41 -0800 Created attachment 226218 Patch 988578 2 landry 2014-03-08 11:14:47 -0800 The gcc warning was: ../../../src/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:1213:28: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] if (argumentCount == 1); 994909 3 landry 2014-03-27 06:34:03 -0700 Can someone land this please? Pretty trivial.. 994910 4 webkit-bug-importer 2014-03-27 06:34:13 -0700 <rdar://problem/16443615> 994941 5 226218 ap 2014-03-27 09:36:57 -0700 Comment on attachment 226218 Patch > Can someone land this please? Pretty trivial.. Another way to ask would be to mark the patch with cq? flag. 994942 6 226218 commit-queue 2014-03-27 09:38:16 -0700 Comment on attachment 226218 Patch Rejecting attachment 226218 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226218, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5457624170496000 995075 7 landry 2014-03-27 14:58:43 -0700 That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome. 995340 8 cfleizach 2014-03-28 09:09:14 -0700 (In reply to comment #7) > That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome. You don't have to manually add the reviewed by line. If you leave in the Reviewed By OOPS line, the CQ will auto fix that for you. However if you delete that line, you'll get failures like this 995619 9 landry 2014-03-29 15:36:17 -0700 (In reply to comment #8) > (In reply to comment #7) > > That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome. > > You don't have to manually add the reviewed by line. If you leave in the Reviewed By OOPS line, the CQ will auto fix that for you. However if you delete that line, you'll get failures like this Hah, thanks for pointing that out, wasnt obvious. i'll try to keep it in mind for next patches. 1904379 10 ahmad.saleem792 2022-10-09 13:46:17 -0700 Seems to be done already: https://github.com/WebKit/WebKit/blob/335a5587c31289a3a8043e4c460f7488c59e947b/Tools/DumpRenderTree/AccessibilityUIElement.cpp#L138 Marking this as "RESOLVED CONFIGURATION CHANGED", Thanks! 226218 2014-03-08 11:11:41 -0800 2014-03-27 09:38:16 -0700 Patch bug-129970-20140308201140.patch text/plain 1389 landry U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmM0ZWUzMmY2ODRkYTZkZTQ5OGU3MGI4MjI3ODRjZDdk NzljNzFjMS4uMzJlZDk4ZmM3NDYxMDFjYWU3ZDJhMWY4MGU2MzcwMWRiNzg2ZWRkNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEx IEBACisyMDE0LTAzLTA4ICBMYW5kcnkgQnJldWlsICA8bGFuZHJ5QG9wZW5ic2Qub3JnPgorCisg ICAgICAgIFJlbW92ZSB0cmFpbGluZyBzZW1pY29sb24gYWZ0ZXIgaWYuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk5NzAKKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwOgorICAgICAgICAoc2V0U2Vs ZWN0ZWRDaGlsZEF0SW5kZXhDYWxsYmFjayk6CisKIDIwMTQtMDMtMDYgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBXZWJLaXQyIGJlZm9yZSBi dWlsZGluZyBXZWJLaXQKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0FjY2Vzc2li aWxpdHlVSUVsZW1lbnQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJ RWxlbWVudC5jcHAKaW5kZXggMWI2OTUxMGEzODVkZGJjNDNkNDdjYjBiMjcwMWRiZDAxM2I0MTMy OC4uOTM5Mjk2OGFlNzFlZThlMTM2YWE4YmJhMzQ1NzQwY2IwMjNiZjczOSAxMDA2NDQKLS0tIGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5jcHAKKysrIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5jcHAKQEAgLTEyMTAsNyAr MTIxMCw3IEBAIHN0YXRpYyBKU1ZhbHVlUmVmIHNlbnRlbmNlQXRPZmZzZXRDYWxsYmFjayhKU0Nv bnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVuCiBzdGF0aWMgSlNWYWx1ZVJlZiBzZXRT ZWxlY3RlZENoaWxkQXRJbmRleENhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVj dFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291 bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikK IHsKICAgICBpbnQgaW5kZXhOdW1iZXIgPSAtMTsKLSAgICBpZiAoYXJndW1lbnRDb3VudCA9PSAx KTsKKyAgICBpZiAoYXJndW1lbnRDb3VudCA9PSAxKQogICAgICAgICBpbmRleE51bWJlciA9IEpT VmFsdWVUb051bWJlcihjb250ZXh0LCBhcmd1bWVudHNbMF0sIGV4Y2VwdGlvbik7CiAKICAgICBp ZiAoaW5kZXhOdW1iZXIgPj0gMCkK