129963 2014-03-08 01:35:49 -0800 Enable DFG_JIT and LLINT on OpenBSD & NetBSD 2015-02-26 06:24:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 landry webkit-unassigned ajacoutot ajacoutot benjamin cmarcelo commit-queue oldest_to_newest 988531 0 landry 2014-03-08 01:35:49 -0800 +++ This bug was initially created as a clone of Bug #128898 +++ Let's just follow freebsd on that one, it works just fine on OpenBSD, and the build breaks otherwise anyway. 988533 1 226206 landry 2014-03-08 01:44:44 -0800 Created attachment 226206 Enable DFG_JIT and LLINT 988571 2 226206 ggaren 2014-03-08 10:50:42 -0800 Comment on attachment 226206 Enable DFG_JIT and LLINT r=me 994911 3 landry 2014-03-27 06:34:32 -0700 What's needed for this to land now ? 1007390 4 226206 zan 2014-05-07 11:44:53 -0700 Comment on attachment 226206 Enable DFG_JIT and LLINT Let's try landing then. 1007391 5 226206 commit-queue 2014-05-07 11:46:30 -0700 Comment on attachment 226206 Enable DFG_JIT and LLINT Rejecting attachment 226206 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 226206, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5352869498716160 1072357 6 226206 ossy 2015-02-26 06:24:14 -0800 Comment on attachment 226206 Enable DFG_JIT and LLINT View in context: https://bugs.webkit.org/attachment.cgi?id=226206&action=review Please update the title of the bug and the patch, if you still would like to enable DFG JIT. > Source/WTF/ChangeLog:3 > + Enable DFG_JIT and LLINT on OpenBSD and NetBSD Please update it. > Source/WTF/ChangeLog:6 > + Reviewed by Nobody(yet). Please don't change the original "Reviewed by NOBODY (OOPS!)." line, because it is needed for commit queue to be able fill the name of the reviewer. > Source/WTF/wtf/Platform.h:706 > - && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD) || OS(WINDOWS)) \ > + && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD) || OS(OPENBSD) || OS(NETBSD) || OS(WINDOWS)) \ > && ((OS(DARWIN) && !PLATFORM(EFL)) || PLATFORM(GTK) || PLATFORM(WIN)) \ > && (CPU(X86) || CPU(X86_64) || CPU(ARM_THUMB2) || CPU(ARM_TRADITIONAL) || CPU(ARM64) || CPU(MIPS) || CPU(SH4)) > #define ENABLE_LLINT 1 LLINT can't be disabled anymore and that's why the patch doesn't apply anymore. 226206 2014-03-08 01:44:44 -0800 2015-02-26 06:24:14 -0800 Enable DFG_JIT and LLINT bug-129963-20140308104443.patch text/plain 1834 landry U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkNjdkZmI3NmNmMGVkNTkyZDdlYWI5 MzAxZDZlNTE2MDQ2NTJkZWEuLjcyMzNmMWYzNWQ4MDdlZmFmZDg5M2ZiZTFjNmQ4NzYzZjNlNWE2 NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDMtNzggTGFuZHJ5IEJyZXVpbCAgPGxhbmRy eUBvcGVuYnNkLm9yZz4KKworICAgICAgICBFbmFibGUgREZHX0pJVCBhbmQgTExJTlQgb24gT3Bl bkJTRCBhbmQgTmV0QlNECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjk5NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOb2JvZHkoeWV0KS4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE0LTAzLTA3ICBMYW5kcnkgQnJldWlsICA8bGFu ZHJ5QG9wZW5ic2Qub3JnPgogCiAgICAgICAgIFJldmVydCBidWcgMTk5NzUsIG5vdyB0aGF0IGdj YyA0LjcgaXMgcmVxdWlyZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o IGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCA4YjYxYWI0NjU3MjhkMTA2OWFhMzdl MDNmMzUzMzQ0OWU3MzJjZDczLi4wYzI1Y2UxN2QxZmNjNDQ5NWRhZTBiOWM0NjU2YTFjOWY4Mjcy MTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmgKQEAgLTcwMCwxNSArNzAwLDE1IEBACiAgICBsb3ctbGV2ZWwgaW50 ZXJwcmV0ZXIuICovCiAjaWYgIWRlZmluZWQoRU5BQkxFX0xMSU5UKSBcCiAgICAgJiYgRU5BQkxF KEpJVCkgXAotICAgICYmIChPUyhEQVJXSU4pIHx8IE9TKExJTlVYKSB8fCBPUyhGUkVFQlNEKSB8 fCBPUyhXSU5ET1dTKSkgXAorICAgICYmIChPUyhEQVJXSU4pIHx8IE9TKExJTlVYKSB8fCBPUyhG UkVFQlNEKSB8fCBPUyhPUEVOQlNEKSB8fCBPUyhORVRCU0QpIHx8IE9TKFdJTkRPV1MpKSBcCiAg ICAgJiYgKChPUyhEQVJXSU4pICYmICFQTEFURk9STShFRkwpKSB8fCBQTEFURk9STShHVEspIHx8 IFBMQVRGT1JNKFdJTikpIFwKICAgICAmJiAoQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkgfHwgQ1BV KEFSTV9USFVNQjIpIHx8IENQVShBUk1fVFJBRElUSU9OQUwpIHx8IENQVShBUk02NCkgfHwgQ1BV KE1JUFMpIHx8IENQVShTSDQpKQogI2RlZmluZSBFTkFCTEVfTExJTlQgMQogI2VuZGlmCiAKICNp ZiAhZGVmaW5lZChFTkFCTEVfREZHX0pJVCkgJiYgRU5BQkxFKEpJVCkgJiYgIUNPTVBJTEVSKE1T VkMpCi0vKiBFbmFibGUgdGhlIERGRyBKSVQgb24gWDg2IGFuZCBYODZfNjQuICBPbmx5IHRlc3Rl ZCBvbiBNYWMsIEdOVS9MaW51eCBhbmQgRnJlZUJTRC4gKi8KLSNpZiAoQ1BVKFg4NikgfHwgQ1BV KFg4Nl82NCkpICYmIChPUyhEQVJXSU4pIHx8IE9TKExJTlVYKSB8fCBPUyhGUkVFQlNEKSkKKy8q IEVuYWJsZSB0aGUgREZHIEpJVCBvbiBYODYgYW5kIFg4Nl82NC4gIE9ubHkgdGVzdGVkIG9uIE1h YywgR05VL0xpbnV4IGFuZCBCU0QuICovCisjaWYgKENQVShYODYpIHx8IENQVShYODZfNjQpKSAm JiAoT1MoREFSV0lOKSB8fCBPUyhMSU5VWCkgfHwgT1MoRlJFRUJTRCkgfHwgT1MoT1BFTkJTRCkg fHwgT1MoTkVUQlNEKSkKICNkZWZpbmUgRU5BQkxFX0RGR19KSVQgMQogI2VuZGlmCiAvKiBFbmFi bGUgdGhlIERGRyBKSVQgb24gQVJNdjcuICBPbmx5IHRlc3RlZCBvbiBpT1MgYW5kIFF0L0dUSysg TGludXguICovCg==