129949 2014-03-07 17:52:38 -0800 [iOS WebKit2] Keyboard accessory comes up when I click a link 2014-03-07 18:03:10 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 988456 0 enrica 2014-03-07 17:52:38 -0800 this happens in any page, just clicking a link <rdar://problem/16265305> 988458 1 226193 enrica 2014-03-07 17:55:55 -0800 Created attachment 226193 Patch 988460 2 226193 enrica 2014-03-07 17:56:40 -0800 Comment on attachment 226193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226193&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:765 > + I just noticed the wrong indentation of the switch. I'll fix it. 988464 3 enrica 2014-03-07 18:03:10 -0800 Committed revision 165311. 226193 2014-03-07 17:55:55 -0800 2014-03-07 17:57:36 -0800 Patch accessoryviewonlywhenneeded.txt text/plain 2194 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTMwNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTA3ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyBXZWJLaXQyXSBLZXli b2FyZCBhY2Nlc3NvcnkgY29tZXMgdXAgd2hlbiBJIGNsaWNrIGEgbGluay4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTk0OQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTYyNjUzMDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBjcmVhdGUgdGhlIGFjY2Vzc29yeSB2aWV3IG9ubHkg d2hlbiBuZWVkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyByZXF1aXJlc0FjY2Vzc29yeVZp ZXddKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBpbnB1dEFjY2Vzc29yeVZpZXddKToKKwog MjAxNC0wMy0wNyAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAg IFtpT1MgV2ViS2l0Ml0gTG9uZy1wcmVzcyBvbiBhIGxpbmsgc2hvd3MganVzdCAiQ29weSIuCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTY1MzA0KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkK QEAgLTczNSw4ICs3MzUsMzkgQEAgLSAodm9pZClfZGlkRW5kU2Nyb2xsaW5nT3Jab29taW5nCiAg ICAgW190ZXh0U2VsZWN0aW9uQXNzaXN0YW50IGRpZEVuZFNjcm9sbGluZ092ZXJmbG93XTsKIH0K IAorLSAoQk9PTClyZXF1aXJlc0FjY2Vzc29yeVZpZXcKK3sKKyAgICBzd2l0Y2ggKF9hc3Npc3Rl ZE5vZGVJbmZvcm1hdGlvbi5lbGVtZW50VHlwZSkgeworICAgICAgICBjYXNlIFdLVHlwZU5vbmU6 CisgICAgICAgICAgICByZXR1cm4gTk87CisgICAgICAgIGNhc2UgV0tUeXBlVGV4dDoKKyAgICAg ICAgY2FzZSBXS1R5cGVQYXNzd29yZDoKKyAgICAgICAgY2FzZSBXS1R5cGVTZWFyY2g6CisgICAg ICAgIGNhc2UgV0tUeXBlRW1haWw6CisgICAgICAgIGNhc2UgV0tUeXBlVVJMOgorICAgICAgICBj YXNlIFdLVHlwZVBob25lOgorICAgICAgICBjYXNlIFdLVHlwZU51bWJlcjoKKyAgICAgICAgY2Fz ZSBXS1R5cGVOdW1iZXJQYWQ6CisgICAgICAgICAgICByZXR1cm4gWUVTOworICAgICAgICBjYXNl IFdLVHlwZUNvbnRlbnRFZGl0YWJsZToKKyAgICAgICAgY2FzZSBXS1R5cGVUZXh0QXJlYToKKyAg ICAgICAgICAgIHJldHVybiBZRVM7CisgICAgICAgIGNhc2UgV0tUeXBlU2VsZWN0OgorICAgICAg ICBjYXNlIFdLVHlwZURhdGU6CisgICAgICAgIGNhc2UgV0tUeXBlRGF0ZVRpbWU6CisgICAgICAg IGNhc2UgV0tUeXBlRGF0ZVRpbWVMb2NhbDoKKyAgICAgICAgY2FzZSBXS1R5cGVNb250aDoKKyAg ICAgICAgY2FzZSBXS1R5cGVXZWVrOgorICAgICAgICBjYXNlIFdLVHlwZVRpbWU6CisgICAgICAg ICAgICByZXR1cm4gIVVJQ3VycmVudFVzZXJJbnRlcmZhY2VJZGlvbUlzUGFkKCk7CisgICAgfQor fQorCiAtIChVSVZpZXcgKilpbnB1dEFjY2Vzc29yeVZpZXcKIHsKKyAgICBpZiAoIVtzZWxmIHJl cXVpcmVzQWNjZXNzb3J5Vmlld10pCisgICAgICAgIHJldHVybiBuaWw7CisKICAgICBpZiAoIV9m b3JtQWNjZXNzb3J5VmlldykgewogICAgICAgICBfZm9ybUFjY2Vzc29yeVZpZXcgPSBhZG9wdE5T KFtbVUlXZWJGb3JtQWNjZXNzb3J5IGFsbG9jXSBpbml0XSk7CiAgICAgICAgIFtfZm9ybUFjY2Vz c29yeVZpZXcgc2V0RGVsZWdhdGU6c2VsZl07Cg==