129945 2014-03-07 17:17:09 -0800 .cfi directives in LowLevelInterpreter.cpp are providing no benefit 2014-03-07 19:28:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 988448 0 msaboff 2014-03-07 17:17:09 -0800 The .cfi (call frame information) directives in llint/LowLevelInterpreter.cpp currently only wrap the LLInt assembly language with .cfi_startproc and .cfi_endproc. The other .cfi unwind directives have been disabled and aren't providing any benefit. 988459 1 226194 msaboff 2014-03-07 17:56:11 -0800 Created attachment 226194 Patch 988469 2 226194 mark.lam 2014-03-07 18:30:13 -0800 Comment on attachment 226194 Patch r=me 988481 3 msaboff 2014-03-07 19:28:05 -0800 Committed r165320: <http://trac.webkit.org/changeset/165320> 226194 2014-03-07 17:56:11 -0800 2014-03-07 18:30:12 -0800 Patch 129945.patch text/plain 2375 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MzA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAzLTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIC5jZmkgZGlyZWN0aXZlcyBpbiBMb3dMZXZlbEludGVycHJldGVyLmNwcCBhcmUgcHJvdmlk aW5nIG5vIGJlbmVmaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyOTk0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZWQgLmNmaSBkaXJlY3RpdmUuICBWZXJpZmllZCB0aGF0IHN0YWNrIHRyYWNl cyBkaWRuJ3QgcmVncmVzcyBpbiBjcmFzaCByZXBvcnRlcgorICAgICAgICBvciBpbiBsbGRiLgor CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHA6CisKIDIwMTQtMDMtMDcg IE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBDb250aW51ZSBoYW5n cyB3aGVuIHBlcmZvcm1pbmcgZm9yLW9mIG92ZXIgYXJndW1lbnRzCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCShyZXZp c2lvbiAxNjUyMTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5MiwxNyArNDkyLDggQEAgSlNWYWx1ZSBD TG9vcDo6ZXhlY3V0ZShPcGNvZGVJRCBlbnRyeU9wYwogLy8KIAogLy8gVGhlc2UgYXJlIGZvciBi dWlsZGluZyBhbiBpbnRlcnByZXRlciBmcm9tIGdlbmVyYXRlZCBhc3NlbWJseSBjb2RlOgotI2lm IENQVShYODZfNjQpICYmIENPTVBJTEVSKENMQU5HKQotI2RlZmluZSBPRkZMSU5FX0FTTV9CRUdJ TiAgIGFzbSAoICAgICAgICAgICAgICAgIFwKLSAgICAiLmNmaV9zdGFydHByb2NcbiIKLQotI2Rl ZmluZSBPRkZMSU5FX0FTTV9FTkQgICAgICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICAiLmNm aV9lbmRwcm9jXG4iICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgKTsKLSNlbHNlCiAjZGVmaW5lIE9GRkxJTkVfQVNNX0JFR0lOICAgYXNt ICgKICNkZWZpbmUgT0ZGTElORV9BU01fRU5EICAgICApOwotI2VuZGlmCiAKICNkZWZpbmUgT0ZG TElORV9BU01fT1BDT0RFX0xBQkVMKF9fb3Bjb2RlKSBPRkZMSU5FX0FTTV9HTE9CQUxfTEFCRUwo bGxpbnRfIyNfX29wY29kZSkKICNkZWZpbmUgT0ZGTElORV9BU01fR0xVRV9MQUJFTChfX29wY29k ZSkgICBPRkZMSU5FX0FTTV9HTE9CQUxfTEFCRUwoX19vcGNvZGUpCkBAIC01MTUsMTUgKzUwNiw2 IEBAIEpTVmFsdWUgQ0xvb3A6OmV4ZWN1dGUoT3Bjb2RlSUQgZW50cnlPcGMKICAgICAiLnRodW1i XG4iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgIi50aHVtYl9mdW5j ICIgVEhVTUJfRlVOQ19QQVJBTShsYWJlbCkgIlxuIiAgXAogICAgIFNZTUJPTF9TVFJJTkcobGFi ZWwpICI6XG4iCi0jZWxpZiBDUFUoWFhYODZfNjQpICYmIENPTVBJTEVSKENMQU5HKQotI2RlZmlu ZSBPRkZMSU5FX0FTTV9HTE9CQUxfTEFCRUwobGFiZWwpICAgICAgICAgXAotICAgICIudGV4dFxu IiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICIuZ2xvYmwgIiBTWU1C T0xfU1RSSU5HKGxhYmVsKSAiXG4iICAgICAgICAgXAotICAgIEhJREVfU1lNQk9MKGxhYmVsKSAi XG4iICAgICAgICAgICAgICAgICAgICAgXAotICAgIFNZTUJPTF9TVFJJTkcobGFiZWwpICI6XG4i ICAgICAgICAgICAgICAgICAgXAotICAgICIuY2ZpX2RlZl9jZmFfb2Zmc2V0IDE2XG4iICAgICAg ICAgICAgICAgICAgXAotICAgICIuY2ZpX29mZnNldCAlcmJwLCAtMTZcbiIgICAgICAgICAgICAg ICAgICAgXAotICAgICIuY2ZpX2RlZl9jZmFfcmVnaXN0ZXIgcmJwXG4iCiAjZWxzZQogI2RlZmlu ZSBPRkZMSU5FX0FTTV9HTE9CQUxfTEFCRUwobGFiZWwpICAgICAgICAgXAogICAgICIudGV4dFxu IiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo=