129938 2014-03-07 16:52:09 -0800 [iOS WebKit2] Long-press on a link shows just "Copy" 2014-03-07 17:11:37 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 988429 0 enrica 2014-03-07 16:52:09 -0800 This happens on any link on a page. Accidentally removed a ! when adding a FIXME comment. <rdar://problem/16266054> 988431 1 226186 enrica 2014-03-07 16:57:49 -0800 Created attachment 226186 Patch 988433 2 226186 benjamin 2014-03-07 17:01:22 -0800 Comment on attachment 226186 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226186&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1474 > + Blank line here. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1481 > + info.title = element->getAttribute(HTMLNames::titleAttr).string(); This could be a fastGetAttribute(), HTMLNames::titleAttr cannot be animated. 988443 3 enrica 2014-03-07 17:11:31 -0800 Committed revision 165305. 226186 2014-03-07 16:57:49 -0800 2014-03-07 17:01:21 -0800 Patch carefulwithfixme.txt text/plain 2969 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTMwMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTA3ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyBXZWJLaXQyXSBMb25n LXByZXNzIG9uIGEgbGluayBzaG93cyBqdXN0ICJDb3B5Ii4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTkzOAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTYyNjYwNTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2hlbiBhZGRpbmcgYSBGSVhNRSBjb21tZW50LCBJIGFjY2lkZW50YWxseSByZW1vdmVk IHRoZSAhIG9uCisgICAgICAgIHRoZSBpZiAoIWVsZW1lbnQpIGNvbmRpdGlvbi4KKworICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbik6CisKIDIwMTQtMDMtMDcgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE2 NDg0Nyk6IFByZXNzaW5nIHRoZSBjb21tYW5kIGtleSB3aGlsZSBob3ZlcmluZyBhbiBlbGVtZW50 IGNhdXNlcyBpdCB0byB1bi1ob3ZlcgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2aXNpb24gMTY1MjczKQorKysg U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNDY2LDI0ICsxNDY2LDIyIEBAIHZvaWQgV2ViUGFnZTo6Z2V0UG9zaXRp b25JbmZvcm1hdGlvbihjb24KICAgICAgICAgaW5mby5jbGlja2FibGVFbGVtZW50TmFtZSA9IGhp dE5vZGUtPm5vZGVOYW1lKCk7CiAKICAgICAgICAgRWxlbWVudCogZWxlbWVudCA9IGhpdE5vZGUt PmlzRWxlbWVudE5vZGUoKSA/IHRvRWxlbWVudChoaXROb2RlKSA6IDA7Ci0gICAgICAgIC8vIEZJ WE1FOiBzaG91bGQgbm90IHJldHVybiBoZXJlIGJ1dCBkbyB3aGF0IGlzIHVuZGVyIGlmICghZWxl bWVudElzTGlua09ySW1hZ2UpCi0gICAgICAgIGlmIChlbGVtZW50KQotICAgICAgICAgICAgcmV0 dXJuOwotCi0gICAgICAgIEVsZW1lbnQqIGxpbmtFbGVtZW50ID0gbnVsbHB0cjsKLSAgICAgICAg aWYgKGVsZW1lbnQtPnJlbmRlcmVyKCkgJiYgZWxlbWVudC0+cmVuZGVyZXIoKS0+aXNSZW5kZXJJ bWFnZSgpKSB7Ci0gICAgICAgICAgICBlbGVtZW50SXNMaW5rT3JJbWFnZSA9IHRydWU7Ci0gICAg ICAgICAgICBsaW5rRWxlbWVudCA9IGNvbnRhaW5pbmdMaW5rRWxlbWVudChlbGVtZW50KTsKLQot ICAgICAgICB9IGVsc2UgaWYgKGVsZW1lbnQtPmlzTGluaygpKSB7Ci0gICAgICAgICAgICBsaW5r RWxlbWVudCA9IGVsZW1lbnQ7Ci0gICAgICAgICAgICBlbGVtZW50SXNMaW5rT3JJbWFnZSA9IHRy dWU7CisgICAgICAgIGlmIChlbGVtZW50KSB7CisgICAgICAgICAgICBFbGVtZW50KiBsaW5rRWxl bWVudCA9IG51bGxwdHI7CisgICAgICAgICAgICBpZiAoZWxlbWVudC0+cmVuZGVyZXIoKSAmJiBl bGVtZW50LT5yZW5kZXJlcigpLT5pc1JlbmRlckltYWdlKCkpIHsKKyAgICAgICAgICAgICAgICBl bGVtZW50SXNMaW5rT3JJbWFnZSA9IHRydWU7CisgICAgICAgICAgICAgICAgbGlua0VsZW1lbnQg PSBjb250YWluaW5nTGlua0VsZW1lbnQoZWxlbWVudCk7CisKKyAgICAgICAgICAgIH0gZWxzZSBp ZiAoZWxlbWVudC0+aXNMaW5rKCkpIHsKKyAgICAgICAgICAgICAgICBsaW5rRWxlbWVudCA9IGVs ZW1lbnQ7CisgICAgICAgICAgICAgICAgZWxlbWVudElzTGlua09ySW1hZ2UgPSB0cnVlOworICAg ICAgICAgICAgfQorICAgICAgICAgICAgaWYgKGxpbmtFbGVtZW50KQorICAgICAgICAgICAgICAg IGluZm8udXJsID0gbGlua0VsZW1lbnQtPmRvY3VtZW50KCkuY29tcGxldGVVUkwoc3RyaXBMZWFk aW5nQW5kVHJhaWxpbmdIVE1MU3BhY2VzKGxpbmtFbGVtZW50LT5nZXRBdHRyaWJ1dGUoSFRNTE5h bWVzOjpocmVmQXR0cikpKTsKKyAgICAgICAgICAgIGluZm8udGl0bGUgPSBlbGVtZW50LT5nZXRB dHRyaWJ1dGUoSFRNTE5hbWVzOjp0aXRsZUF0dHIpLnN0cmluZygpOworICAgICAgICAgICAgaWYg KGVsZW1lbnQtPnJlbmRlcmVyKCkpCisgICAgICAgICAgICAgICAgaW5mby5ib3VuZHMgPSBlbGVt ZW50LT5yZW5kZXJlcigpLT5hYnNvbHV0ZUJvdW5kaW5nQm94UmVjdCh0cnVlKTsKICAgICAgICAg fQotICAgICAgICBpZiAobGlua0VsZW1lbnQpCi0gICAgICAgICAgICBpbmZvLnVybCA9IGxpbmtF bGVtZW50LT5kb2N1bWVudCgpLmNvbXBsZXRlVVJMKHN0cmlwTGVhZGluZ0FuZFRyYWlsaW5nSFRN TFNwYWNlcyhsaW5rRWxlbWVudC0+Z2V0QXR0cmlidXRlKEhUTUxOYW1lczo6aHJlZkF0dHIpKSk7 Ci0gICAgICAgIGluZm8udGl0bGUgPSBlbGVtZW50LT5nZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjp0 aXRsZUF0dHIpLnN0cmluZygpOwotICAgICAgICBpZiAoZWxlbWVudC0+cmVuZGVyZXIoKSkKLSAg ICAgICAgICAgIGluZm8uYm91bmRzID0gZWxlbWVudC0+cmVuZGVyZXIoKS0+YWJzb2x1dGVCb3Vu ZGluZ0JveFJlY3QodHJ1ZSk7CiAgICAgfQogCiAgICAgaWYgKCFlbGVtZW50SXNMaW5rT3JJbWFn ZSkgewo=