129927 2014-03-07 15:06:02 -0800 Revert bug 19975 2015-02-26 07:21:37 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Other RESOLVED FIXED P2 Normal --- 1 landry ossy ajacoutot ajacoutot benjamin cmarcelo commit-queue ossy oldest_to_newest 988376 0 landry 2014-03-07 15:06:02 -0800 Now that gcc 4.7 is required bug 19975 gets in the way. 988380 1 226173 landry 2014-03-07 15:09:24 -0800 Created attachment 226173 Revert bug 19975 seems mail.webkit.org is down.. 988381 2 commit-queue 2014-03-07 15:11:18 -0800 Attachment 226173 did not pass style-queue: ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 988521 3 226205 landry 2014-03-08 01:12:13 -0800 Created attachment 226205 Revert bug 19975 Add bug URL 988523 4 landry 2014-03-08 01:14:32 -0800 *** Bug 129922 has been marked as a duplicate of this bug. *** 988525 5 landry 2014-03-08 01:14:41 -0800 *** Bug 129923 has been marked as a duplicate of this bug. *** 988527 6 landry 2014-03-08 01:14:49 -0800 *** Bug 129924 has been marked as a duplicate of this bug. *** 988529 7 landry 2014-03-08 01:14:57 -0800 *** Bug 129925 has been marked as a duplicate of this bug. *** 988535 8 landry 2014-03-08 01:47:42 -0800 Forgot to explain: now on openbsd the build fails without this patch because isfinite and signbit are defined twice. 988612 9 226205 kling 2014-03-08 13:31:08 -0800 Comment on attachment 226205 Revert bug 19975 r=me 988613 10 226205 commit-queue 2014-03-08 13:32:49 -0800 Comment on attachment 226205 Revert bug 19975 Rejecting attachment 226205 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226205, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4913826214445056 1002209 11 ajacoutot 2014-04-19 05:43:30 -0700 Hi. What's the hold for this patch? This is preventing me from building WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe. Thanks :-) 1072358 12 247424 ossy 2015-02-26 06:27:36 -0800 Created attachment 247424 Patch for landing 1072359 13 ossy 2015-02-26 06:29:02 -0800 (In reply to comment #11) > Hi. What's the hold for this patch? This is preventing me from building > WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe. > Thanks :-) The problem was that you removed this line "Reviewed by NOBODY (OOPS!).". 1072360 14 247425 ossy 2015-02-26 06:30:05 -0800 Created attachment 247425 Patch for landing 1072376 15 247425 commit-queue 2015-02-26 07:21:32 -0800 Comment on attachment 247425 Patch for landing Clearing flags on attachment: 247425 Committed r180674: <http://trac.webkit.org/changeset/180674> 1072377 16 commit-queue 2015-02-26 07:21:37 -0800 All reviewed patches have been landed. Closing bug. 226173 2014-03-07 15:09:24 -0800 2014-03-08 01:12:13 -0800 Revert bug 19975 0001-Revert-bug-19975-now-that-gcc-4.7-is-required.patch text/plain 1534 landry RnJvbSA4NDFkZDkyNzFiZTRlNDY3ZDM1YjIzMGQ2YjJkZGU1MjUwNDVhMDI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYW5kcnkgQnJldWlsIDxsYW5kcnlAb3BlbmJzZC5vcmc+CkRh dGU6IFNhdCwgOCBNYXIgMjAxNCAwMDowNDo0NiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVy dCBidWcgMTk5NzUsIG5vdyB0aGF0IGdjYyA0LjcgaXMgcmVxdWlyZWQuCgotLS0KIFNvdXJjZS9X VEYvQ2hhbmdlTG9nICAgICAgICB8ICA4ICsrKysrKysrCiBTb3VyY2UvV1RGL3d0Zi9NYXRoRXh0 cmFzLmggfCAxNSAtLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25z KCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBi L1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMxY2E5YTQuLmNkNjdkZmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTEgQEAKKzIwMTQtMDMtMDcgIExhbmRyeSBCcmV1aWwgIDxsYW5kcnlAb3BlbmJzZC5vcmc+ CisKKyAgICAgICAgUmV2ZXJ0IGJ1ZyAxOTk3NSwgbm93IHRoYXQgZ2NjIDQuNyBpcyByZXF1aXJl ZC4KKworICAgICAgICBpc2Zpbml0ZSgpIGFuZCBzaWduYml0KCkgYXJlIHByb3ZpZGVkIGJ5IGdj YydzIGNtYXRoIGhlYWRlci4KKworICAgICAgICAqIHd0Zi9NYXRoRXh0cmFzLmg6CisKIDIwMTQt MDMtMDYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgSlND IHNob3VsZCBkaXNhYmxlIHRoZSBKSVQgd2hlbiBidWlsZGluZyBmb3IgQVJNdjdrCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0 cmFzLmgKaW5kZXggYjZmNDFkMC4uZWE2MjU5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv TWF0aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaApAQCAtOTQsMjEg Kzk0LDYgQEAgaW5saW5lIGJvb2wgaXNpbmYoZG91YmxlIHgpIHsgcmV0dXJuICFmaW5pdGUoeCkg JiYgIWlzbmFuZCh4KTsgfQogCiAjZW5kaWYKIAotI2lmIE9TKE9QRU5CU0QpCi0KLW5hbWVzcGFj ZSBzdGQgewotCi0jaWZuZGVmIGlzZmluaXRlCi1pbmxpbmUgYm9vbCBpc2Zpbml0ZShkb3VibGUg eCkgeyByZXR1cm4gZmluaXRlKHgpOyB9Ci0jZW5kaWYKLSNpZm5kZWYgc2lnbmJpdAotaW5saW5l IGJvb2wgc2lnbmJpdChkb3VibGUgeCkgeyBzdHJ1Y3QgaWVlZV9kb3VibGUgKnAgPSAoc3RydWN0 IGllZWVfZG91YmxlICopJng7IHJldHVybiBwLT5kYmxfc2lnbjsgfQotI2VuZGlmCi0KLX0gLy8g bmFtZXNwYWNlIHN0ZAotCi0jZW5kaWYKLQogI2lmIENPTVBJTEVSKE1TVkMpCiAKIC8vIFdvcmsg YXJvdW5kIGEgYnVnIGluIFdpbiwgd2hlcmUgYXRhbjIoKy1pbmZpbml0eSwgKy1pbmZpbml0eSkg eWllbGRzIE5hTiBpbnN0ZWFkIG9mIHNwZWNpZmljIHZhbHVlcy4KLS0gCjEuOC41LjMKCg== 226205 2014-03-08 01:12:13 -0800 2015-02-26 06:27:23 -0800 Revert bug 19975 0001-Revert-bug-19975-now-that-gcc-4.7-is-required.patch text/plain 1588 landry RnJvbSA4NDFkZDkyNzFiZTRlNDY3ZDM1YjIzMGQ2YjJkZGU1MjUwNDVhMDI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYW5kcnkgQnJldWlsIDxsYW5kcnlAb3BlbmJzZC5vcmc+CkRh dGU6IFNhdCwgOCBNYXIgMjAxNCAwMDowNDo0NiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVy dCBidWcgMTk5NzUsIG5vdyB0aGF0IGdjYyA0LjcgaXMgcmVxdWlyZWQuCgotLS0KIFNvdXJjZS9X VEYvQ2hhbmdlTG9nICAgICAgICB8ICA4ICsrKysrKysrCiBTb3VyY2UvV1RGL3d0Zi9NYXRoRXh0 cmFzLmggfCAxNSAtLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25z KCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBi L1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMxY2E5YTQuLmNkNjdkZmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTEgQEAKKzIwMTQtMDMtMDcgIExhbmRyeSBCcmV1aWwgIDxsYW5kcnlAb3BlbmJzZC5vcmc+ CisKKyAgICAgICAgUmV2ZXJ0IGJ1ZyAxOTk3NSwgbm93IHRoYXQgZ2NjIDQuNyBpcyByZXF1aXJl ZC4KKworICAgICAgICBpc2Zpbml0ZSgpIGFuZCBzaWduYml0KCkgYXJlIHByb3ZpZGVkIGJ5IGdj YydzIGNtYXRoIGhlYWRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyOTkyNworICAgICAgICAqIHd0Zi9NYXRoRXh0cmFzLmg6CisKIDIwMTQtMDMt MDYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIHNo b3VsZCBkaXNhYmxlIHRoZSBKSVQgd2hlbiBidWlsZGluZyBmb3IgQVJNdjdrCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFz LmgKaW5kZXggYjZmNDFkMC4uZWE2MjU5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWF0 aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaApAQCAtOTQsMjEgKzk0 LDYgQEAgaW5saW5lIGJvb2wgaXNpbmYoZG91YmxlIHgpIHsgcmV0dXJuICFmaW5pdGUoeCkgJiYg IWlzbmFuZCh4KTsgfQogCiAjZW5kaWYKIAotI2lmIE9TKE9QRU5CU0QpCi0KLW5hbWVzcGFjZSBz dGQgewotCi0jaWZuZGVmIGlzZmluaXRlCi1pbmxpbmUgYm9vbCBpc2Zpbml0ZShkb3VibGUgeCkg eyByZXR1cm4gZmluaXRlKHgpOyB9Ci0jZW5kaWYKLSNpZm5kZWYgc2lnbmJpdAotaW5saW5lIGJv b2wgc2lnbmJpdChkb3VibGUgeCkgeyBzdHJ1Y3QgaWVlZV9kb3VibGUgKnAgPSAoc3RydWN0IGll ZWVfZG91YmxlICopJng7IHJldHVybiBwLT5kYmxfc2lnbjsgfQotI2VuZGlmCi0KLX0gLy8gbmFt ZXNwYWNlIHN0ZAotCi0jZW5kaWYKLQogI2lmIENPTVBJTEVSKE1TVkMpCiAKIC8vIFdvcmsgYXJv dW5kIGEgYnVnIGluIFdpbiwgd2hlcmUgYXRhbjIoKy1pbmZpbml0eSwgKy1pbmZpbml0eSkgeWll bGRzIE5hTiBpbnN0ZWFkIG9mIHNwZWNpZmljIHZhbHVlcy4KLS0gCjEuOC41LjMKCg== 247424 2015-02-26 06:27:36 -0800 2015-02-26 06:29:31 -0800 Patch for landing bug-129927-20150226062722.patch text/plain 1469 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkwYzI0MmM5ZmQ2ZDZhZmE3OTYxMTMw ZDNjMzQ5MTJmOTY2ZDVjZGIuLjlmMDM0M2M4ZjQ2NmUyYzZlN2ZhOGU2ZDc1ZTkyMGE4YWUwODVl MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDItMjYgIExhbmRyeSBCcmV1aWwgIDxsYW5k cnlAb3BlbmJzZC5vcmc+CisKKyAgICAgICAgUmV2ZXJ0IGJ1ZyAxOTk3NSwgbm93IHRoYXQgZ2Nj IDQuNyBpcyByZXF1aXJlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyOTkyNworCisgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisK KyAgICAgICAgaXNmaW5pdGUoKSBhbmQgc2lnbmJpdCgpIGFyZSBwcm92aWRlZCBieSBnY2MncyBj bWF0aCBoZWFkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjk5MjcKKyAgICAgICAgKiB3dGYvTWF0aEV4dHJhcy5oOgorCiAyMDE1LTAyLTI2ICBD c2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVU5SRUFDSEFC TEVfRk9SX1BMQVRGT1JNKCkgc2hvdWxkIGJlIHJlbGVhc2UgYXNzZXJ0CmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgK aW5kZXggOGEzN2ZjN2VmZWFiZWNhMTc2NWQ3ZjVjY2QwMjc3Yjc4N2EwNGE1Mi4uMDRiNzM1NTVl M2I3M2Y3ZTAzMTFkZTYyY2I0Nzg0ZTI5NDMxYTBhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvTWF0aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaApAQCAtMTAy LDIxICsxMDIsNiBAQCBpbmxpbmUgYm9vbCBpc2luZihkb3VibGUgeCkgeyByZXR1cm4gIWZpbml0 ZSh4KSAmJiAhaXNuYW5kKHgpOyB9CiAKICNlbmRpZgogCi0jaWYgT1MoT1BFTkJTRCkKLQotbmFt ZXNwYWNlIHN0ZCB7Ci0KLSNpZm5kZWYgaXNmaW5pdGUKLWlubGluZSBib29sIGlzZmluaXRlKGRv dWJsZSB4KSB7IHJldHVybiBmaW5pdGUoeCk7IH0KLSNlbmRpZgotI2lmbmRlZiBzaWduYml0Ci1p bmxpbmUgYm9vbCBzaWduYml0KGRvdWJsZSB4KSB7IHN0cnVjdCBpZWVlX2RvdWJsZSAqcCA9IChz dHJ1Y3QgaWVlZV9kb3VibGUgKikmeDsgcmV0dXJuIHAtPmRibF9zaWduOyB9Ci0jZW5kaWYKLQot fSAvLyBuYW1lc3BhY2Ugc3RkCi0KLSNlbmRpZgotCiAjaWYgQ09NUElMRVIoTVNWQykKIAogLy8g V29yayBhcm91bmQgYSBidWcgaW4gV2luLCB3aGVyZSBhdGFuMigrLWluZmluaXR5LCArLWluZmlu aXR5KSB5aWVsZHMgTmFOIGluc3RlYWQgb2Ygc3BlY2lmaWMgdmFsdWVzLgo= 247425 2015-02-26 06:30:05 -0800 2015-02-26 07:21:32 -0800 Patch for landing bug-129927-20150226062951.patch text/plain 1415 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkwYzI0MmM5ZmQ2ZDZhZmE3OTYxMTMw ZDNjMzQ5MTJmOTY2ZDVjZGIuLjYyNjRjMTc1NGExMTZhNTA1ZDc3NmZkZmFhZGNhZjdmZTJhNjM4 M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDItMjYgIExhbmRyeSBCcmV1aWwgIDxsYW5k cnlAb3BlbmJzZC5vcmc+CisKKyAgICAgICAgUmV2ZXJ0IGJ1ZyAxOTk3NSwgbm93IHRoYXQgZ2Nj IDQuNyBpcyByZXF1aXJlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyOTkyNworCisgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisK KyAgICAgICAgaXNmaW5pdGUoKSBhbmQgc2lnbmJpdCgpIGFyZSBwcm92aWRlZCBieSBnY2MncyBj bWF0aCBoZWFkZXIuCisKKyAgICAgICAgKiB3dGYvTWF0aEV4dHJhcy5oOgorCiAyMDE1LTAyLTI2 ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVU5SRUFD SEFCTEVfRk9SX1BMQVRGT1JNKCkgc2hvdWxkIGJlIHJlbGVhc2UgYXNzZXJ0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFz LmgKaW5kZXggOGEzN2ZjN2VmZWFiZWNhMTc2NWQ3ZjVjY2QwMjc3Yjc4N2EwNGE1Mi4uMDRiNzM1 NTVlM2I3M2Y3ZTAzMTFkZTYyY2I0Nzg0ZTI5NDMxYTBhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvTWF0aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaApAQCAt MTAyLDIxICsxMDIsNiBAQCBpbmxpbmUgYm9vbCBpc2luZihkb3VibGUgeCkgeyByZXR1cm4gIWZp bml0ZSh4KSAmJiAhaXNuYW5kKHgpOyB9CiAKICNlbmRpZgogCi0jaWYgT1MoT1BFTkJTRCkKLQot bmFtZXNwYWNlIHN0ZCB7Ci0KLSNpZm5kZWYgaXNmaW5pdGUKLWlubGluZSBib29sIGlzZmluaXRl KGRvdWJsZSB4KSB7IHJldHVybiBmaW5pdGUoeCk7IH0KLSNlbmRpZgotI2lmbmRlZiBzaWduYml0 Ci1pbmxpbmUgYm9vbCBzaWduYml0KGRvdWJsZSB4KSB7IHN0cnVjdCBpZWVlX2RvdWJsZSAqcCA9 IChzdHJ1Y3QgaWVlZV9kb3VibGUgKikmeDsgcmV0dXJuIHAtPmRibF9zaWduOyB9Ci0jZW5kaWYK LQotfSAvLyBuYW1lc3BhY2Ugc3RkCi0KLSNlbmRpZgotCiAjaWYgQ09NUElMRVIoTVNWQykKIAog Ly8gV29yayBhcm91bmQgYSBidWcgaW4gV2luLCB3aGVyZSBhdGFuMigrLWluZmluaXR5LCArLWlu ZmluaXR5KSB5aWVsZHMgTmFOIGluc3RlYWQgb2Ygc3BlY2lmaWMgdmFsdWVzLgo=