129915 2014-03-07 14:24:55 -0800 Continue hangs when performing for-of over arguments 2014-03-07 17:12:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 988346 0 oliver 2014-03-07 14:24:55 -0800 Continue hangs when performing for-of over arguments 988350 1 oliver 2014-03-07 14:29:55 -0800 *** Bug 129917 has been marked as a duplicate of this bug. *** 988353 2 oliver 2014-03-07 14:30:08 -0800 *** Bug 129916 has been marked as a duplicate of this bug. *** 988415 3 226183 oliver 2014-03-07 16:18:06 -0800 Created attachment 226183 Patch 988420 4 226183 ggaren 2014-03-07 16:35:33 -0800 Comment on attachment 226183 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226183&action=review r=me > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2451 > + emitJump(loopCondition.get()); Our other looping nodes prefer to emit op_less twice -- once at the head of the loop, and once at the tail. That makes the CFG more amenable to optimization. 988445 5 oliver 2014-03-07 17:12:21 -0800 Committed r165306: <http://trac.webkit.org/changeset/165306> 226183 2014-03-07 16:18:06 -0800 2014-03-07 16:35:33 -0800 Patch bug-129915-20140307161814.patch text/plain 4836 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Mjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NmVmNmVmODA2ODJjZTEzYzcwYmRkMjgzOTY3ODZjZDM5N2YyMDRkLi4wYTAzN2EyMzY1NDY0ODM5 ZDUzYjJlOTJkOWNkMzQxYzA1NGU3Njg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMy0wNyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIENvbnRpbnVlIGhhbmdzIHdoZW4gcGVyZm9ybWluZyBmb3Itb2Ygb3ZlciBhcmd1 bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy OTkxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFB1 dCB0aGUgY29udGludWUgbGFiZWwgaW4gdGhlIHJpZ2h0IHBsYWNlCisKKyAgICAgICAgKiBieXRl Y29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdl bmVyYXRvcjo6ZW1pdEVudW1lcmF0aW9uKToKKwogMjAxNC0wMy0wNyAgcGVhdm9Ab3V0bG9vay5j b20gIDxwZWF2b0BvdXRsb29rLmNvbT4KIAogICAgICAgICBbV2luNjRdIENvbXBpbGUgZXJyb3Ig YWZ0ZXIgcjE2NTEyOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29t cGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKaW5kZXggYmYzZDg0MGY4MmZiZTdlMDFiYjdh NTdlZWRlY2JkNjdjMmI1NzE4My4uNjQwNTc1YmE0YzlkYjlkMDA1N2QwOGY2MDAwYmI0NzIxZGZj ZDdjOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRl Y29kZUdlbmVyYXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxl ci9CeXRlY29kZUdlbmVyYXRvci5jcHAKQEAgLTI0NDYsMTYgKzI0NDYsMTcgQEAgdm9pZCBCeXRl Y29kZUdlbmVyYXRvcjo6ZW1pdEVudW1lcmF0aW9uKFRocm93YWJsZUV4cHJlc3Npb25EYXRhKiBu b2RlLCBFeHByZXNzaW8KICAgICAgICAgTGFiZWxTY29wZVB0ciBzY29wZSA9IG5ld0xhYmVsU2Nv cGUoTGFiZWxTY29wZTo6TG9vcCk7CiAgICAgICAgIFJlZlB0cjxSZWdpc3RlcklEPiB2YWx1ZSA9 IGVtaXRMb2FkKG5ld1RlbXBvcmFyeSgpLCBqc1VuZGVmaW5lZCgpKTsKICAgICAgICAgCi0gICAg ICAgIGVtaXRKdW1wKHNjb3BlLT5jb250aW51ZVRhcmdldCgpKTsKLSAgICAgICAgCisgICAgICAg IFJlZlB0cjxMYWJlbD4gbG9vcENvbmRpdGlvbiA9IG5ld0xhYmVsKCk7CiAgICAgICAgIFJlZlB0 cjxMYWJlbD4gbG9vcFN0YXJ0ID0gbmV3TGFiZWwoKTsKKyAgICAgICAgZW1pdEp1bXAobG9vcENv bmRpdGlvbi5nZXQoKSk7CiAgICAgICAgIGVtaXRMYWJlbChsb29wU3RhcnQuZ2V0KCkpOwogICAg ICAgICBlbWl0TG9vcEhpbnQoKTsKICAgICAgICAgZW1pdEdldEFyZ3VtZW50QnlWYWwodmFsdWUu Z2V0KCksIHVuY2hlY2tlZFJlZ2lzdGVyRm9yQXJndW1lbnRzKCksIGluZGV4LmdldCgpKTsKICAg ICAgICAgY2FsbEJhY2soKnRoaXMsIHZhbHVlLmdldCgpKTsKLSAgICAgICAgZW1pdEluYyhpbmRl eC5nZXQoKSk7CisgICAgCiAgICAgICAgIGVtaXRMYWJlbChzY29wZS0+Y29udGludWVUYXJnZXQo KSk7Ci0KKyAgICAgICAgZW1pdEluYyhpbmRleC5nZXQoKSk7CisgICAgICAgIGVtaXRMYWJlbChs b29wQ29uZGl0aW9uLmdldCgpKTsKICAgICAgICAgUmVmUHRyPFJlZ2lzdGVySUQ+IGxlbmd0aCA9 IGVtaXRHZXRBcmd1bWVudHNMZW5ndGgobmV3VGVtcG9yYXJ5KCksIHVuY2hlY2tlZFJlZ2lzdGVy Rm9yQXJndW1lbnRzKCkpOwogICAgICAgICBlbWl0SnVtcElmVHJ1ZShlbWl0RXF1YWxpdHlPcChv cF9sZXNzLCBuZXdUZW1wb3JhcnkoKSwgaW5kZXguZ2V0KCksIGxlbmd0aC5nZXQoKSksIGxvb3BT dGFydC5nZXQoKSk7CiAgICAgICAgIGVtaXRMYWJlbChzY29wZS0+YnJlYWtUYXJnZXQoKSk7CmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggY2Q2ZTc5NDI3ZTA1YTMzMTA4ZTUyOGFlNDQzYjEyMGI1ZDc0YWQ2ZC4uMjU2M2UzODRm MmRlZDUzMjk1NGM1ZDI1NmJmNDNjMjdkNTUwOGQyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisy MDE0LTAzLTA3ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29u dGludWUgaGFuZ3Mgd2hlbiBwZXJmb3JtaW5nIGZvci1vZiBvdmVyIGFyZ3VtZW50cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5OTE1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3RzCisKKyAg ICAgICAgKiBqcy9mb3Itb2YtYXJndW1lbnRzLWNvbnRpbnVlLWhhbmctZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBqcy9mb3Itb2YtYXJndW1lbnRzLWNvbnRpbnVlLWhhbmcuaHRtbDog QWRkZWQuCisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL2Zvci1vZi1hcmd1bWVudHMtY29udGlu dWUtaGFuZy5qczogQWRkZWQuCisgICAgICAgICh0ZXN0KToKKwogMjAxNC0wMy0wNyAgQmVhciBU cmF2aXMgIDxiZXRyYXZpc0BhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBTaGFwZXNdIENvcnJl Y3RseSBzZXJpYWxpemUgZWxsaXBzZSBwb3NpdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2pzL2Zvci1vZi1hcmd1bWVudHMtY29udGludWUtaGFuZy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9qcy9mb3Itb2YtYXJndW1lbnRzLWNvbnRpbnVlLWhhbmctZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmRhZGQ5NzkxM2UzNjgyOWY3YWQ4ZDIzNjMwNjIxYzQxYWZhNDBkNzAKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9qcy9mb3Itb2YtYXJndW1lbnRzLWNvbnRpbnVlLWhhbmct ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTMgQEAKK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHdlIGRv bid0IGhhbmcgd2UgdXNlIGNvbnRpbnVlIGluc2lkZSBhIGZvci1vZiBvdmVyIGFyZ3VtZW50cwor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB0ZXN0KCkgaXMgMAorUEFTUyB0 ZXN0KDEpIGlzIDEKK1BBU1MgdGVzdCgxLDIpIGlzIDIKK1BBU1MgdGVzdCgxLDIsMykgaXMgMwor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2pzL2Zvci1vZi1hcmd1bWVudHMtY29udGludWUtaGFuZy5odG1s IGIvTGF5b3V0VGVzdHMvanMvZm9yLW9mLWFyZ3VtZW50cy1jb250aW51ZS1oYW5nLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uZTAwOTZjNjgzMTc3ODM1MzA2OTdkZTdjOTQzMDhiZTZhYmIzZTg5NAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2pzL2Zvci1vZi1hcmd1bWVudHMtY29udGludWUtaGFu Zy5odG1sCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8v RFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2Vz L2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdCBzcmM9 InNjcmlwdC10ZXN0cy9mb3Itb2YtYXJndW1lbnRzLWNvbnRpbnVlLWhhbmcuanMiPjwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3Rz L2Zvci1vZi1hcmd1bWVudHMtY29udGludWUtaGFuZy5qcyBiL0xheW91dFRlc3RzL2pzL3Njcmlw dC10ZXN0cy9mb3Itb2YtYXJndW1lbnRzLWNvbnRpbnVlLWhhbmcuanMKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZThj ZGVmMjliYmIyMzE3ZmY0OWNlOTMxOWM1OGM4MzZlMDdlMDBkYwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9mb3Itb2YtYXJndW1lbnRzLWNvbnRpbnVlLWhh bmcuanMKQEAgLTAsMCArMSwxNSBAQAorZGVzY3JpcHRpb24oCisiVGhpcyB0ZXN0IG1ha2VzIHN1 cmUgd2UgZG9uJ3QgaGFuZyB3ZSB1c2UgY29udGludWUgaW5zaWRlIGEgZm9yLW9mIG92ZXIgYXJn dW1lbnRzIgorKTsKKworZnVuY3Rpb24gdGVzdCgpIHsKKwl2YXIgY291bnQgPSAwOworCWZvciAo dmFyIGEgb2YgYXJndW1lbnRzKQorCQljb3VudCsrOworCXJldHVybiBjb3VudDsKK30KKworc2hv dWxkQmUoInRlc3QoKSIsICIwIikKK3Nob3VsZEJlKCJ0ZXN0KDEpIiwgIjEiKQorc2hvdWxkQmUo InRlc3QoMSwyKSIsICIyIikKK3Nob3VsZEJlKCJ0ZXN0KDEsMiwzKSIsICIzIikK