129912 2014-03-07 13:56:58 -0800 [iOS] Don't call scrollOffsetForFixedPosition a second time if we have no header and footer layers 2014-03-08 20:58:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser andersca cmarcelo commit-queue jamesr luiz simon.fraser tonikitoo oldest_to_newest 988333 0 simon.fraser 2014-03-07 13:56:58 -0800 [iOS] Don't call scrollOffsetForFixedPosition a second time if we have no header and footer layers 988335 1 226165 simon.fraser 2014-03-07 13:57:19 -0800 Created attachment 226165 Patch 988692 2 simon.fraser 2014-03-08 20:58:42 -0800 http://trac.webkit.org/changeset/165348 226165 2014-03-07 13:57:19 -0800 2014-03-07 14:04:57 -0800 Patch bug-129912-20140307135720.patch text/plain 3587 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmVkZmQ5Y2U3M2IyN2E1 MDQ3NjU0M2Y2YjMwYmRmMGFhMDc5Yzg4Ny4uNjZlY2Y4NTA2OGI0MzU0N2Q5MzgwOTI5MzI0MjVh MDU1M2Q4N2U0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIERvbid0 IGNhbGwgc2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlvbiBhIHNlY29uZCB0aW1lIGlmIHdlIGhh dmUgbm8gaGVhZGVyIGFuZCBmb290ZXIgbGF5ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk5MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCBleHRyYSB3b3JrIGlmIHdlIGhhdmUgbm8gaGVh ZGVyIG9yIGZvb3RlciBsYXllcnMuCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9pb3MvU2Ny b2xsaW5nVHJlZVNjcm9sbGluZ05vZGVJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxp bmdUcmVlU2Nyb2xsaW5nTm9kZUlPUzo6c2V0U2Nyb2xsTGF5ZXJQb3NpdGlvbik6CisKIDIwMTQt MDMtMDcgIEJlYXIgVHJhdmlzICA8YmV0cmF2aXNAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1Mg U2hhcGVzXSBDb3JyZWN0bHkgc2VyaWFsaXplIGVsbGlwc2UgcG9zaXRpb25zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9pb3MvU2Nyb2xsaW5nVHJlZVNjcm9sbGlu Z05vZGVJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9pb3MvU2Nyb2xsaW5n VHJlZVNjcm9sbGluZ05vZGVJT1MubW0KaW5kZXggMTFmOTJhMTdmMTY3YTE0N2ZmNjA2ODM5MjI1 MjZlMmJhZDZkYjk0MS4uNTY2NzRlNDYxMTI1Mzg1MGE5OGNkOWM4OTA2NmIzYjM4YjA4NTk1MiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvaW9zL1Njcm9sbGluZ1Ry ZWVTY3JvbGxpbmdOb2RlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L2lvcy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZUlPUy5tbQpAQCAtMTQxLDE5ICsxNDEsMjEg QEAgdm9pZCBTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZUlPUzo6c2V0U2Nyb2xsTGF5ZXJQb3Np dGlvbihjb25zdCBGbG9hdFBvaW50JiBwb3MKICAgICBpZiAobV9jb3VudGVyU2Nyb2xsaW5nTGF5 ZXIpCiAgICAgICAgIG1fY291bnRlclNjcm9sbGluZ0xheWVyLmdldCgpLnBvc2l0aW9uID0gRmxv YXRQb2ludChzY3JvbGxPZmZzZXRGb3JGaXhlZENoaWxkcmVuKTsKIAotICAgIC8vIEdlbmVyYWxs eSB0aGUgYmFubmVycyBzaG91bGQgaGF2ZSB0aGUgc2FtZSBob3Jpem9udGFsLXBvc2l0aW9uIGNv bXB1dGF0aW9uIGFzIGEgZml4ZWQgZWxlbWVudC4gSG93ZXZlciwKLSAgICAvLyB0aGUgYmFubmVy cyBhcmUgbm90IGFmZmVjdGVkIGJ5IHRoZSBmcmFtZVNjYWxlRmFjdG9yKCksIHNvIGlmIHRoZXJl IGlzIGN1cnJlbnRseSBhIG5vbi0xIGZyYW1lU2NhbGVGYWN0b3IoKQotICAgIC8vIHRoZW4gd2Ug c2hvdWxkIHJlY29tcHV0ZSBzY3JvbGxPZmZzZXRGb3JGaXhlZENoaWxkcmVuIGZvciB0aGUgYmFu bmVyIHdpdGggYSBzY2FsZSBmYWN0b3Igb2YgMS4KLSAgICBmbG9hdCBob3Jpem9udGFsU2Nyb2xs T2Zmc2V0Rm9yQmFubmVyID0gc2Nyb2xsT2Zmc2V0Rm9yRml4ZWRDaGlsZHJlbi53aWR0aCgpOwot ICAgIGlmIChmcmFtZVNjYWxlRmFjdG9yKCkgIT0gMSkKLSAgICAgICAgaG9yaXpvbnRhbFNjcm9s bE9mZnNldEZvckJhbm5lciA9IEZyYW1lVmlldzo6c2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlv bihlbmNsb3NpbmdJbnRSZWN0KHZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RSZWN0KCkpLCB0b3Rh bENvbnRlbnRzU2l6ZSgpLCBmbG9vcmVkSW50UG9pbnQoc2Nyb2xsT2Zmc2V0KSwgc2Nyb2xsT3Jp Z2luKCksIDEsIGZhbHNlLCBiZWhhdmlvckZvckZpeGVkLCBoZWFkZXJIZWlnaHQoKSwgZm9vdGVy SGVpZ2h0KCkpLndpZHRoKCk7Ci0KLSAgICBpZiAobV9oZWFkZXJMYXllcikKLSAgICAgICAgbV9o ZWFkZXJMYXllci5nZXQoKS5wb3NpdGlvbiA9IEZsb2F0UG9pbnQoaG9yaXpvbnRhbFNjcm9sbE9m ZnNldEZvckJhbm5lciwgMCk7Ci0KLSAgICBpZiAobV9mb290ZXJMYXllcikKLSAgICAgICAgbV9m b290ZXJMYXllci5nZXQoKS5wb3NpdGlvbiA9IEZsb2F0UG9pbnQoaG9yaXpvbnRhbFNjcm9sbE9m ZnNldEZvckJhbm5lciwgdG90YWxDb250ZW50c1NpemUoKS5oZWlnaHQoKSAtIGZvb3RlckhlaWdo dCgpKTsKLQorICAgIGlmIChtX2hlYWRlckxheWVyIHx8IG1fZm9vdGVyTGF5ZXIpIHsKKyAgICAg ICAgLy8gR2VuZXJhbGx5IHRoZSBiYW5uZXJzIHNob3VsZCBoYXZlIHRoZSBzYW1lIGhvcml6b250 YWwtcG9zaXRpb24gY29tcHV0YXRpb24gYXMgYSBmaXhlZCBlbGVtZW50LiBIb3dldmVyLAorICAg ICAgICAvLyB0aGUgYmFubmVycyBhcmUgbm90IGFmZmVjdGVkIGJ5IHRoZSBmcmFtZVNjYWxlRmFj dG9yKCksIHNvIGlmIHRoZXJlIGlzIGN1cnJlbnRseSBhIG5vbi0xIGZyYW1lU2NhbGVGYWN0b3Io KQorICAgICAgICAvLyB0aGVuIHdlIHNob3VsZCByZWNvbXB1dGUgc2Nyb2xsT2Zmc2V0Rm9yRml4 ZWRDaGlsZHJlbiBmb3IgdGhlIGJhbm5lciB3aXRoIGEgc2NhbGUgZmFjdG9yIG9mIDEuCisgICAg ICAgIGZsb2F0IGhvcml6b250YWxTY3JvbGxPZmZzZXRGb3JCYW5uZXIgPSBzY3JvbGxPZmZzZXRG b3JGaXhlZENoaWxkcmVuLndpZHRoKCk7CisgICAgICAgIGlmIChmcmFtZVNjYWxlRmFjdG9yKCkg IT0gMSkKKyAgICAgICAgICAgIGhvcml6b250YWxTY3JvbGxPZmZzZXRGb3JCYW5uZXIgPSBGcmFt ZVZpZXc6OnNjcm9sbE9mZnNldEZvckZpeGVkUG9zaXRpb24oZW5jbG9zaW5nSW50UmVjdCh2aWV3 cG9ydENvbnN0cmFpbmVkT2JqZWN0UmVjdCgpKSwgdG90YWxDb250ZW50c1NpemUoKSwgZmxvb3Jl ZEludFBvaW50KHNjcm9sbE9mZnNldCksIHNjcm9sbE9yaWdpbigpLCAxLCBmYWxzZSwgYmVoYXZp b3JGb3JGaXhlZCwgaGVhZGVySGVpZ2h0KCksIGZvb3RlckhlaWdodCgpKS53aWR0aCgpOworCisg ICAgICAgIGlmIChtX2hlYWRlckxheWVyKQorICAgICAgICAgICAgbV9oZWFkZXJMYXllci5nZXQo KS5wb3NpdGlvbiA9IEZsb2F0UG9pbnQoaG9yaXpvbnRhbFNjcm9sbE9mZnNldEZvckJhbm5lciwg MCk7CisKKyAgICAgICAgaWYgKG1fZm9vdGVyTGF5ZXIpCisgICAgICAgICAgICBtX2Zvb3Rlckxh eWVyLmdldCgpLnBvc2l0aW9uID0gRmxvYXRQb2ludChob3Jpem9udGFsU2Nyb2xsT2Zmc2V0Rm9y QmFubmVyLCB0b3RhbENvbnRlbnRzU2l6ZSgpLmhlaWdodCgpIC0gZm9vdGVySGVpZ2h0KCkpOwor ICAgIH0KKyAgICAKICAgICBpZiAoIW1fY2hpbGRyZW4pCiAgICAgICAgIHJldHVybjsKIAo=