129908 2014-03-07 13:35:56 -0800 [Mac] Notify system malloc of fake memory pressure. 2014-03-07 14:10:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue kling oldest_to_newest 988315 0 kling 2014-03-07 13:35:56 -0800 After fixing the leak in r165252, I was surprised to find that it didn't show up on memory test bots. It turns out that while the memory is now getting freed, the system malloc implementation doesn't actually release pages back to the OS until there is memory pressure. Since we are just faking the memory pressure on bots, we have to let system malloc in on the fun, so we can get representative numbers. With this change, we should finally see the effect of not leaking the URLRequest object tree. 988318 1 226160 kling 2014-03-07 13:40:13 -0800 Created attachment 226160 Patch 988342 2 226160 kling 2014-03-07 14:10:14 -0800 Comment on attachment 226160 Patch Clearing flags on attachment: 226160 Committed r165292: <http://trac.webkit.org/changeset/165292> 988343 3 kling 2014-03-07 14:10:19 -0800 All reviewed patches have been landed. Closing bug. 226160 2014-03-07 13:40:13 -0800 2014-03-07 14:10:11 -0800 Patch bug-129908.diff text/plain 3975 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYmRkZmJiLi4xMWJhYmFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTQtMDMtMDcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtNYWNdIE5vdGlmeSBzeXN0ZW0gbWFsbG9jIG9mIGZha2UgbWVtb3J5IHByZXNzdXJlLgor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI5OTA4PgorCisgICAgICAgIEFmdGVyIGZp eGluZyB0aGUgbGVhayBpbiByMTY1MjUyLCBJIHdhcyBzdXJwcmlzZWQgdG8gZmluZCB0aGF0IGl0 IGRpZG4ndAorICAgICAgICBzaG93IHVwIG9uIG1lbW9yeSB0ZXN0IGJvdHMuIEl0IHR1cm5zIG91 dCB0aGF0IHdoaWxlIHRoZSBtZW1vcnkgaXMgbm93CisgICAgICAgIGdldHRpbmcgZnJlZWQsIHRo ZSBzeXN0ZW0gbWFsbG9jIGltcGxlbWVudGF0aW9uIGRvZXNuJ3QgYWN0dWFsbHkgcmVsZWFzZQor ICAgICAgICBwYWdlcyBiYWNrIHRvIHRoZSBPUyB1bnRpbCB0aGVyZSBpcyBtZW1vcnkgcHJlc3N1 cmUuCisKKyAgICAgICAgU2luY2Ugd2UgYXJlIGp1c3QgZmFraW5nIHRoZSBtZW1vcnkgcHJlc3N1 cmUgb24gYm90cywgd2UgaGF2ZSB0byBsZXQKKyAgICAgICAgc3lzdGVtIG1hbGxvYyBpbiBvbiB0 aGUgZnVuLCBzbyB3ZSBjYW4gZ2V0IHJlcHJlc2VudGF0aXZlIG51bWJlcnMuCisgICAgICAgIFdp dGggdGhpcyBjaGFuZ2UsIHdlIHNob3VsZCBmaW5hbGx5IHNlZSB0aGUgZWZmZWN0IG9mIG5vdCBs ZWFraW5nIHRoZQorICAgICAgICBVUkxSZXF1ZXN0IG9iamVjdCB0cmVlLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL01lbW9y eVByZXNzdXJlSGFuZGxlck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeVByZXNzdXJl SGFuZGxlcjo6aW5zdGFsbCk6CisKKyAgICAgICAgICAgIFRlbGwgc3lzdGVtIG1hbGxvYyB0aGF0 IHdlIGFyZSB1bmRlciBmYWtlIG1lbW9yeSBwcmVzc3VyZS4KKwogMjAxNC0wMy0wNyAgSmlud29v IFNvbmcgIDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgT3B0aW1pemUgY29s bGVjdGlvbkxhc3QoKSBhbmQgY29sbGVjdGlvblRyYXZlcnNlQmFja3dhcmQoKSBpbiBMaXZlTm9k ZUxpc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9NZW1vcnlQcmVz c3VyZUhhbmRsZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5UHJl c3N1cmVIYW5kbGVyTWFjLm1tCmluZGV4IDExNTY1OGQuLmI3MjdkMzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9NZW1vcnlQcmVzc3VyZUhhbmRsZXJNYWMubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5t bQpAQCAtMzksNiArMzksNyBAQAogI2ltcG9ydCA8d3RmL0N1cnJlbnRUaW1lLmg+CiAjaW1wb3J0 IDx3dGYvRmFzdE1hbGxvYy5oPgogI2ltcG9ydCA8d3RmL0Z1bmN0aW9uYWwuaD4KKyNpbXBvcnQg PG1hbGxvYy9tYWxsb2MuaD4KIAogI2lmICFQTEFURk9STShJT1MpCiAjaW1wb3J0ICJXZWJDb3Jl U3lzdGVtSW50ZXJmYWNlLmgiCkBAIC04NSw2ICs4Niw3IEBAIHZvaWQgTWVtb3J5UHJlc3N1cmVI YW5kbGVyOjppbnN0YWxsKCkKICAgICBub3RpZnlfcmVnaXN0ZXJfZGlzcGF0Y2goIm9yZy5XZWJL aXQubG93TWVtb3J5IiwgJl9ub3RpZnlUb2tlbiwgZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwg XihpbnQpIHsKICAgICAgICAgbWVtb3J5UHJlc3N1cmVIYW5kbGVyKCkucmVzcG9uZFRvTWVtb3J5 UHJlc3N1cmUoKTsKICAgICAgICAgZ2NDb250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3RTb29uKCk7 CisgICAgICAgIG1hbGxvY196b25lX3ByZXNzdXJlX3JlbGllZihudWxscHRyLCAwKTsKICAgICB9 KTsKIAogICAgIG1faW5zdGFsbGVkID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBjNDZiMGNkLi5jM2I0 ODM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDMtMDcgIEFuZHJlYXMgS2xp bmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIE5vdGlmeSBzeXN0ZW0gbWFs bG9jIG9mIGZha2UgbWVtb3J5IHByZXNzdXJlLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTI5OTA4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogTmV0d29ya1Byb2Nlc3MvbWFjL05ldHdvcmtQcm9jZXNzTWFjLm1tOgorICAgICAgICAo V2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3Mp OgorCisgICAgICAgICAgICBMaXN0ZW4gZm9yIHRoZSBmYWtlIG1lbW9yeSBwcmVzc3VyZSBub3Rp ZmljYXRpb24gYW5kIHJlc3BvbmQgYnkKKyAgICAgICAgICAgIGp1c3QgZm9yd2FyZGluZyB0byBz eXN0ZW0gbWFsbG9jLiBXZSBkb24ndCBkbyB0aGUgZnVsbCBXZWJDb3JlCisgICAgICAgICAgICBt ZW1vcnkgcHJlc3N1cmUgaGFuZGxpbmcgaGVyZSwgc2luY2UgdGhhdCB3aWxsIGNhdXNlIHN0dWZm IHRoYXQKKyAgICAgICAgICAgIHRoZSBuZXR3b3JrIHByb2Nlc3MgZG9lc24ndCBuZWVkIHRvIGdl dCBpbnN0YW50aWF0ZWQuCisKIDIwMTQtMDMtMDYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgW01hY10gQWxsb3cgY29tLmFwcGxlLkdTU0NyZWQgaW4gV2Vi S2l0IHNhbmRib3ggcHJvZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL21hYy9OZXR3b3JrUHJvY2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL21hYy9OZXR3b3JrUHJvY2Vzc01hYy5tbQppbmRleCBiMjQ5ZmFhLi43ODM0MTEwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9tYWMvTmV0d29ya1Byb2Nl c3NNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvbWFjL05ldHdvcmtQ cm9jZXNzTWFjLm1tCkBAIC00Miw2ICs0Miw4IEBACiAjaW1wb3J0IDxtYWNoL2hvc3RfaW5mby5o PgogI2ltcG9ydCA8bWFjaC9tYWNoLmg+CiAjaW1wb3J0IDxtYWNoL21hY2hfZXJyb3IuaD4KKyNp bXBvcnQgPG1hbGxvYy9tYWxsb2MuaD4KKyNpbXBvcnQgPG5vdGlmeS5oPgogI2ltcG9ydCA8c3lz ZXhpdHMuaD4KICNpbXBvcnQgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCkBAIC0xMTIsNiArMTE0 LDExIEBAIHN0YXRpYyB2b2lkIG92ZXJyaWRlU3lzdGVtUHJveGllcyhjb25zdCBTdHJpbmcmIGh0 dHBQcm94eSwgY29uc3QgU3RyaW5nJiBodHRwc1ByCiAKIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnBs YXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKGNvbnN0IE5ldHdvcmtQcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQogeworICAgIHN0YXRpYyBpbnQgbm90aWZ5VG9rZW47 CisgICAgbm90aWZ5X3JlZ2lzdGVyX2Rpc3BhdGNoKCJvcmcuV2ViS2l0Lmxvd01lbW9yeSIsICZu b3RpZnlUb2tlbiwgZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXihpbnQpIHsKKyAgICAgICAg bWFsbG9jX3pvbmVfcHJlc3N1cmVfcmVsaWVmKG51bGxwdHIsIDApOworICAgIH0pOworCiAgICAg bV9kaXNrQ2FjaGVEaXJlY3RvcnkgPSBwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeTsKIAog ICAgIGlmICghbV9kaXNrQ2FjaGVEaXJlY3RvcnkuaXNOdWxsKCkpIHsK