129904 2014-03-07 13:06:47 -0800 REGRESSION(165267): Broke a webkitpy unit tests 2014-03-07 13:27:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson commit-queue glenn oldest_to_newest 988291 0 mrobinson 2014-03-07 13:06:47 -0800 gtk.py used to assume that the build was an autotools build unless it could prove otherwise. Now that CMake is the default, we should assume it's a CMake build unless proven otherwise. This matters because it changes the expected results on systems where we can detect neither a CMake or an autotools build. We should assume a CMake build so that "--gtk" is used instead of "--gtkautotools" for invoking commands. 988293 1 226153 mrobinson 2014-03-07 13:09:37 -0800 Created attachment 226153 Patch 988295 2 226153 jhoneycutt 2014-03-07 13:17:28 -0800 Comment on attachment 226153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226153&action=review r=me > Tools/Scripts/webkitpy/port/gtk.py:57 > def _is_cmake_build(self): > - return os.path.exists(self._build_path('CMakeCache.txt')) > + return not os.path.exists(self._build_path('config.log')) A comment about this would help readability. 988307 3 mrobinson 2014-03-07 13:27:10 -0800 Committed r165284: <http://trac.webkit.org/changeset/165284> 226153 2014-03-07 13:09:37 -0800 2014-03-07 13:17:27 -0800 Patch bug-129904-20140307130936.patch text/plain 1417 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjJiYjc5MTcyY2MyYjJlZWFlYmY3ODk3MjRhMmFjYTg2 OWI2MGFmMi4uMzg0ZjcyYWVhY2I3Mjc1NmNiNWQ3NWZhYTQ3ZTM0NDZjZWRiMmY4MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDE0LTAzLTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K IAorICAgICAgICBSRUdSRVNTSU9OKDE2NTI2Nyk6IEJyb2tlIGEgd2Via2l0cHkgdW5pdCB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5OTA0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5OiBGbGlwIHRoZSBkZWZhdWx0IHRlc3QgdG8gYXNzdW1l IENNYWtlIGJ5IGRlZmF1bHQuCisgICAgICAgIChHdGtQb3J0Ll9pc19jbWFrZV9idWlsZCk6CisK KzIwMTQtMDMtMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCiAg ICAgICAgIFtHVEtdIHNoOiAxOiBuaW5qYTogbm90IGZvdW5kIHByaW50ZWQgdG8gY29uc29sZSB3 aGVuIHVzaW5nIGJ1aWxkLXdlYmtpdAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI5OTAyCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC9ndGsucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CmluZGV4 IDdjNzg5MjVkMmZhYzQxNWM1M2I1MGYxYWExNjYwZTBjMzMwZWZhNTguLjBkZTAxNzRmMDAzMTE4 YTNmZDc4ZDhkN2NmNWFhOTQzZTQ3MmZiYmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5w eQpAQCAtNTQsNyArNTQsNyBAQCBjbGFzcyBHdGtQb3J0KFBvcnQpOgogICAgICAgICAgICAgICAg IHJhaXNlIFZhbHVlRXJyb3IoJ3VzZSAtLXdyYXBwZXI9XCJ2YWxncmluZFwiIGZvciBtZW1vcnkg bGVhayBkZXRlY3Rpb24gb24gR1RLJykKIAogICAgIGRlZiBfaXNfY21ha2VfYnVpbGQoc2VsZik6 Ci0gICAgICAgIHJldHVybiBvcy5wYXRoLmV4aXN0cyhzZWxmLl9idWlsZF9wYXRoKCdDTWFrZUNh Y2hlLnR4dCcpKQorICAgICAgICByZXR1cm4gbm90IG9zLnBhdGguZXhpc3RzKHNlbGYuX2J1aWxk X3BhdGgoJ2NvbmZpZy5sb2cnKSkKIAogICAgIGRlZiBfYnVpbHRfZXhlY3V0YWJsZXNfcGF0aChz ZWxmLCAqcGF0aCk6CiAgICAgICAgIGlmIHNlbGYuX2lzX2NtYWtlX2J1aWxkKCk6Cg==