129902 2014-03-07 12:54:46 -0800 [GTK] Improve ninja detection in webkitdirs.pm 2014-03-15 15:44:58 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson commit-queue dbates jberta.u-szeged ossy oldest_to_newest 988283 0 mrobinson 2014-03-07 12:54:46 -0800 We should avoid this spurious output. 988285 1 226152 mrobinson 2014-03-07 12:57:03 -0800 Created attachment 226152 Patch 990242 2 dbates 2014-03-13 19:02:28 -0700 This issue was fixed in <http://trac.webkit.org/changeset/165541> (bug #130129). Maybe it would be better to use which(1) to detect whether ninja is in the user's path as opposed to calling ninja and redirecting stderr (thereby silencing the "command not found" error) as in the aforementioned change set? 990351 3 226152 ossy 2014-03-14 01:46:59 -0700 Comment on attachment 226152 Patch It is really better fix than r165541, r=me. (but cq-, because it is in conflict with r165541.) 990505 4 mrobinson 2014-03-14 09:01:49 -0700 I think this is a good bug to switch to 'which' and also to detect ninja-build as well (as it is called on Fedora). 990779 5 226790 mrobinson 2014-03-14 19:07:39 -0700 Created attachment 226790 Patch 990894 6 226790 mrobinson 2014-03-15 15:44:54 -0700 Comment on attachment 226790 Patch Clearing flags on attachment: 226790 Committed r165684: <http://trac.webkit.org/changeset/165684> 990895 7 mrobinson 2014-03-15 15:44:58 -0700 All reviewed patches have been landed. Closing bug. 226152 2014-03-07 12:57:03 -0800 2014-03-14 19:07:29 -0700 Patch bug-129902-20140307125702.patch text/plain 1139 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODYyZjFhYzIxNzBjM2JmM2MzYTE3MDIwZDMzMDYwNDNl YzdlNmQ2Yi4uYjJiYjc5MTcyY2MyYjJlZWFlYmY3ODk3MjRhMmFjYTg2OWI2MGFmMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0 IEBACiAyMDE0LTAzLTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K IAorICAgICAgICBbR1RLXSBzaDogMTogbmluamE6IG5vdCBmb3VuZCBwcmludGVkIHRvIGNvbnNv bGUgd2hlbiB1c2luZyBidWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyOTkwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOiBVc2UgJ3doaWNoJyBp bnN0ZWFkIG9mIHRyeWluZyB0byBydW4gbmluamEgZGlyZWN0bHkuCisKKzIwMTQtMDMtMDcgIE1h cnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIGJ1 aWQtd2Via2l0IHNob3VsZCB1c2UgQ01ha2UgYnkgZGVmYXVsdAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODU1CiAKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRl eCBmYTI3ZDc0ZjM5MjMzYWNmNTdhMjk2ODJkYzRhZDI5OTdlMzkyZjdiLi5lY2Q4YjNlYjcyY2Mw NTIzZmIxNDhiZTU3NDAzNzI5N2U1MzJjMDE0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xOTcxLDcg KzE5NzEsNyBAQCBzdWIgcmVtb3ZlQ01ha2VDYWNoZShAKQogCiBzdWIgY2FuVXNlTmluamEoQCkK IHsKLSAgICBzeXN0ZW0oJ25pbmphIC0tdmVyc2lvbiA+IC9kZXYvbnVsbCcpOworICAgIHN5c3Rl bSgnd2hpY2ggbmluamEgPiAvZGV2L251bGwnKTsKICAgICByZXR1cm4gJD8gPT0gMDsKIH0KIAo= 226790 2014-03-14 19:07:39 -0700 2014-03-15 15:44:53 -0700 Patch bug-129902-20140314190711.patch text/plain 1315 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGVlM2IzYmUzYzM3NjE5YjBkZmZhYWVmOTk2MGRkNDAx NTlhODU1Mi4uN2M5MWM0ZTRhYjYzNmZiNmFmYzAwOWE2OGE4N2M1YmMxYzM0ODJiOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTAzLTE0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBJbXByb3ZlIG5pbmphIGRldGVjdGlvbiBpbiB3ZWJraXRkaXJzLnBt CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk5MDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNhblVzZU5pbmphKTogVXNlIHdoaWNoIGluc3Rl YWQgb2YgdHJ5aW5nIHRvIGludm9rZSBuaW5qYSBkaXJlY3RseS4gVGhpcyBhbHNvIGFsbG93cwor ICAgICAgICB1cyB0byBsb29rIGZvciBuaW5qYS1idWlsZCBhcyB3ZWxsLgorCiAyMDE0LTAzLTE0 ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgU29tZXRpbWVzIHdl IG5lZWQgdG8gYmUgZXhwbGljaXQgYWJvdXQgdGhlIFNESyB3aGVuIHJ1bm5pbmcgcmFubGliIG9u IERhcndpbgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGJhYmEzZDRhZGQ5YmY4MzJkMDgyNTJmMDc1OTBi NDU3ODExNTdiNjIuLjZmOGI3YTA5NWNkMGFkNWNiYTVlZjdhMDg1YjE0Y2Y0N2I3NGVmMjcgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0KQEAgLTE5NzMsNyArMTk3Myw4IEBAIHN1YiByZW1vdmVDTWFrZUNhY2hl KEApCiAKIHN1YiBjYW5Vc2VOaW5qYShAKQogewotICAgIHN5c3RlbSgnbmluamEgLS12ZXJzaW9u ID4gL2Rldi9udWxsIDI+JjEnKTsKKyAgICAjIFRlc3QgYm90aCBuaW5qYSBhbmQgbmluamEtYnVp bGQuIEZlZG9yYSB1c2VzIG5pbmphLWJ1aWxkIGFuZCBoYXMgcGF0Y2hlZCBDTWFrZSB0byBhbHNv IGNhbGwgbmluamEtYnVpbGQuCisgICAgc3lzdGVtKCd3aGljaCBuaW5qYSA+IC9kZXYvbnVsbCB8 fCB3aGljaCBuaW5qYS1idWlsZCA+IC9kZXYvbnVsbCcpOwogICAgIHJldHVybiAkPyA9PSAwOwog fQogCg==