129886 2014-03-07 08:57:44 -0800 run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner 2014-03-28 13:45:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue fpizlo oldest_to_newest 988177 0 mhahnenberg 2014-03-07 08:57:44 -0800 It should. 988216 1 226137 mhahnenberg 2014-03-07 10:37:18 -0800 Created attachment 226137 Patch 988223 2 226137 mark.lam 2014-03-07 11:03:43 -0800 Comment on attachment 226137 Patch r=me 988242 3 226137 commit-queue 2014-03-07 11:34:36 -0800 Comment on attachment 226137 Patch Clearing flags on attachment: 226137 Committed r165274: <http://trac.webkit.org/changeset/165274> 988243 4 commit-queue 2014-03-07 11:34:37 -0800 All reviewed patches have been landed. Closing bug. 995439 5 fpizlo 2014-03-28 13:45:05 -0700 This made all error reporting super ugly because of the way that "1>&2" was added. Apparently when you add it without a space after the prefixCommand(), it somehow tells shell to duplicate the output. Don't ask why. Anyway, the moral of the story is: if you make changes to error handling in run-jsc-stress-tests you should test the error handling by locally breaking a test. I'll fix it. 226137 2014-03-07 10:37:18 -0800 2014-03-07 11:34:36 -0800 Patch bug-129886-20140307103716.patch text/plain 6618 mhahnenberg SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NTI2OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE0LTAzLTA3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CisKKyAgICAgICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgZG9lc24ndCBlYWdlcmx5IHJl cG9ydCB0ZXN0IGZhaWx1cmVzIHdoZW4gdXNpbmcgdGhlIHNoZWxsIHJ1bm5lcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODg2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2pzYy1zdHJl c3MtdGVzdC1oZWxwZXJzL3NoZWxsLXJ1bm5lci5zaDogQWRkZWQgYSAidmVyYm9zZSIgbW9kZSB0 byB0aGUgc2hlbGwgcnVubmVyLgorICAgICAgICBJZiB3ZSdyZSBpbiB2ZXJib3NlIG1vZGUsIHRo ZW4gd2UgZG9uJ3QgcmVkaXJlY3QgYW55IG91dHB1dCB3aGVuIHJ1bm5pbmcgZWFjaCB0ZXN0LiBJ ZiB3ZSdyZSBub3QKKyAgICAgICAgaW4gdmVyYm9zZSBtb2RlIHRoZW4gd2UgcmVkaXJlY3Qgc3Rk b3V0IHRvIC9kZXYvbnVsbCBhbmQgYWxsb3cgYW55IHN0ZGVyciBvdXRwdXQgdGhyb3VnaC4KKyAg ICAgICAgKiBTY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzOiBSZWRpcmVjdCBhbnkgc29ydCBv ZiBlcnJvciBvdXRwdXQgdG8gc3RkZXJyIHNvIHRoYXQgaXQgd2lsbCAKKyAgICAgICAgbWFrZSBp dCB0aHJvdWdoIHdoZW4gaW4gbm9uLXZlcmJvc2UgbW9kZS4KKwogMjAxNC0wMy0wNyAgTWFydGlu IFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gYnVpZC13 ZWJraXQgc2hvdWxkIHVzZSBDTWFrZSBieSBkZWZhdWx0CkluZGV4OiBUb29scy9TY3JpcHRzL3J1 bi1qc2Mtc3RyZXNzLXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1z dHJlc3MtdGVzdHMJKHJldmlzaW9uIDE2NTI2OSkKKysrIFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1z dHJlc3MtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTI3Niw3ICsyNzYsNyBAQCBkZWYgc2ltcGxl RXJyb3JIYW5kbGVyCiAgICAgICAgIHwgb3V0cCwgcGxhbiB8CiAgICAgICAgIG91dHAucHV0cyAi aWYgdGVzdCAtZSAje3BsYW4uZmFpbEZpbGV9IgogICAgICAgICBvdXRwLnB1dHMgInRoZW4iCi0g ICAgICAgIG91dHAucHV0cyAiICAgIChlY2hvIEVSUk9SOiBVbmV4cGVjdGVkIGV4aXQgY29kZTog YGNhdCAje3BsYW4uZmFpbEZpbGV9YCkgfCAiICsgcHJlZml4Q29tbWFuZChwbGFuLm5hbWUpCisg ICAgICAgIG91dHAucHV0cyAiICAgIChlY2hvIEVSUk9SOiBVbmV4cGVjdGVkIGV4aXQgY29kZTog YGNhdCAje3BsYW4uZmFpbEZpbGV9YCkgfCAiICsgcHJlZml4Q29tbWFuZChwbGFuLm5hbWUpICsg IjE+JjIiCiAgICAgICAgIG91dHAucHV0cyAiICAgICIgKyBwbGFuLmZhaWxDb21tYW5kCiAgICAg ICAgIG91dHAucHV0cyAiZWxzZSIKICAgICAgICAgb3V0cC5wdXRzICIgICAgIiArIHBsYW4uc3Vj Y2Vzc0NvbW1hbmQKQEAgLTI5Myw3ICsyOTMsNyBAQCBkZWYgZGlmZkVycm9ySGFuZGxlcihleHBl Y3RlZEZpbGVuYW1lKQogICAgICAgICAKICAgICAgICAgb3V0cC5wdXRzICJpZiB0ZXN0IC1lICN7 cGxhbi5mYWlsRmlsZX0iCiAgICAgICAgIG91dHAucHV0cyAidGhlbiIKLSAgICAgICAgb3V0cC5w dXRzICIgICAgKGNhdCAje291dHB1dEZpbGVuYW1lfSAmJiBlY2hvIEVSUk9SOiBVbmV4cGVjdGVk IGV4aXQgY29kZTogYGNhdCAje3BsYW4uZmFpbEZpbGV9YCkgfCAiICsgcHJlZml4Q29tbWFuZChw bGFuLm5hbWUpCisgICAgICAgIG91dHAucHV0cyAiICAgIChjYXQgI3tvdXRwdXRGaWxlbmFtZX0g JiYgZWNobyBFUlJPUjogVW5leHBlY3RlZCBleGl0IGNvZGU6IGBjYXQgI3twbGFuLmZhaWxGaWxl fWApIHwgIiArIHByZWZpeENvbW1hbmQocGxhbi5uYW1lKSArICIxPiYyIgogICAgICAgICBvdXRw LnB1dHMgIiAgICAiICsgcGxhbi5mYWlsQ29tbWFuZAogICAgICAgICBvdXRwLnB1dHMgImVsaWYg dGVzdCAtZSAuLi8je1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoZXhwZWN0ZWRGaWxlbmFtZSl9Igog ICAgICAgICBvdXRwLnB1dHMgInRoZW4iCkBAIC0zMDIsMTEgKzMwMiwxMSBAQCBkZWYgZGlmZkVy cm9ySGFuZGxlcihleHBlY3RlZEZpbGVuYW1lKQogICAgICAgICBvdXRwLnB1dHMgIiAgICB0aGVu IgogICAgICAgICBvdXRwLnB1dHMgIiAgICAiICsgcGxhbi5zdWNjZXNzQ29tbWFuZAogICAgICAg ICBvdXRwLnB1dHMgIiAgICBlbHNlIgotICAgICAgICBvdXRwLnB1dHMgIiAgICAgICAgKGVjaG8g XCJESUZGIEZBSUxVUkUhXCIgJiYgY2F0ICN7ZGlmZkZpbGVuYW1lfSkgfCAiICsgcHJlZml4Q29t bWFuZChwbGFuLm5hbWUpCisgICAgICAgIG91dHAucHV0cyAiICAgICAgICAoZWNobyBcIkRJRkYg RkFJTFVSRSFcIiAmJiBjYXQgI3tkaWZmRmlsZW5hbWV9KSB8ICIgKyBwcmVmaXhDb21tYW5kKHBs YW4ubmFtZSkgKyAiMT4mMiIKICAgICAgICAgb3V0cC5wdXRzICIgICAgICAgICIgKyBwbGFuLmZh aWxDb21tYW5kCiAgICAgICAgIG91dHAucHV0cyAiICAgIGZpIgogICAgICAgICBvdXRwLnB1dHMg ImVsc2UiCi0gICAgICAgIG91dHAucHV0cyAiICAgIChlY2hvIFwiTk8gRVhQRUNUQVRJT04hXCIg JiYgY2F0ICN7b3V0cHV0RmlsZW5hbWV9KSB8ICIgKyBwcmVmaXhDb21tYW5kKHBsYW4ubmFtZSkK KyAgICAgICAgb3V0cC5wdXRzICIgICAgKGVjaG8gXCJOTyBFWFBFQ1RBVElPTiFcIiAmJiBjYXQg I3tvdXRwdXRGaWxlbmFtZX0pIHwgIiArIHByZWZpeENvbW1hbmQocGxhbi5uYW1lKSArICIxPiYy IgogICAgICAgICBvdXRwLnB1dHMgIiAgICAiICsgcGxhbi5mYWlsQ29tbWFuZAogICAgICAgICBv dXRwLnB1dHMgImZpIgogICAgIH0KQEAgLTMyMSwxMSArMzIxLDExIEBAIGRlZiBtb3ppbGxhRXJy b3JIYW5kbGVyCiAKICAgICAgICAgb3V0cC5wdXRzICJpZiB0ZXN0IC1lICN7cGxhbi5mYWlsRmls ZX0iCiAgICAgICAgIG91dHAucHV0cyAidGhlbiIKLSAgICAgICAgb3V0cC5wdXRzICIgICAgKGNh dCAje291dHB1dEZpbGVuYW1lfSAmJiBlY2hvIEVSUk9SOiBVbmV4cGVjdGVkIGV4aXQgY29kZTog YGNhdCAje3BsYW4uZmFpbEZpbGV9YCkgfCAiICsgcHJlZml4Q29tbWFuZChwbGFuLm5hbWUpCisg ICAgICAgIG91dHAucHV0cyAiICAgIChjYXQgI3tvdXRwdXRGaWxlbmFtZX0gJiYgZWNobyBFUlJP UjogVW5leHBlY3RlZCBleGl0IGNvZGU6IGBjYXQgI3twbGFuLmZhaWxGaWxlfWApIHwgIiArIHBy ZWZpeENvbW1hbmQocGxhbi5uYW1lKSArICIxPiYyIgogICAgICAgICBvdXRwLnB1dHMgIiAgICAi ICsgcGxhbi5mYWlsQ29tbWFuZAogICAgICAgICBvdXRwLnB1dHMgImVsaWYgZ3JlcCAtaSAtcSBm YWlsZWQhICN7b3V0cHV0RmlsZW5hbWV9IgogICAgICAgICBvdXRwLnB1dHMgInRoZW4iCi0gICAg ICAgIG91dHAucHV0cyAiICAgIChlY2hvIERldGVjdGVkIGZhaWx1cmVzOiAmJiBjYXQgI3tvdXRw dXRGaWxlbmFtZX0pIHwgIiArIHByZWZpeENvbW1hbmQocGxhbi5uYW1lKQorICAgICAgICBvdXRw LnB1dHMgIiAgICAoZWNobyBEZXRlY3RlZCBmYWlsdXJlczogJiYgY2F0ICN7b3V0cHV0RmlsZW5h bWV9KSB8ICIgKyBwcmVmaXhDb21tYW5kKHBsYW4ubmFtZSkgKyAiMT4mMiIKICAgICAgICAgb3V0 cC5wdXRzICIgICAgIiArIHBsYW4uZmFpbENvbW1hbmQKICAgICAgICAgb3V0cC5wdXRzICJlbHNl IgogICAgICAgICBvdXRwLnB1dHMgIiAgICAiICsgcGxhbi5zdWNjZXNzQ29tbWFuZApAQCAtMzQ3 LDcgKzM0Nyw3IEBAIGRlZiBtb3ppbGxhRmFpbEVycm9ySGFuZGxlcgogICAgICAgICBvdXRwLnB1 dHMgInRoZW4iCiAgICAgICAgIG91dHAucHV0cyAiICAgICIgKyBwbGFuLnN1Y2Nlc3NDb21tYW5k CiAgICAgICAgIG91dHAucHV0cyAiZWxzZSIKLSAgICAgICAgb3V0cC5wdXRzICIgICAgKGVjaG8g Tk9USUNFOiBZb3UgbWFkZSB0aGlzIHRlc3QgcGFzcywgYnV0IGl0IHdhcyBleHBlY3RlZCB0byBm YWlsKSB8ICIgKyBwcmVmaXhDb21tYW5kKHBsYW4ubmFtZSkKKyAgICAgICAgb3V0cC5wdXRzICIg ICAgKGVjaG8gTk9USUNFOiBZb3UgbWFkZSB0aGlzIHRlc3QgcGFzcywgYnV0IGl0IHdhcyBleHBl Y3RlZCB0byBmYWlsKSB8ICIgKyBwcmVmaXhDb21tYW5kKHBsYW4ubmFtZSkgKyAiMT4mMiIKICAg ICAgICAgb3V0cC5wdXRzICIgICAgIiArIHBsYW4uZmFpbENvbW1hbmQKICAgICAgICAgb3V0cC5w dXRzICJmaSIKICAgICB9CkBAIC0zNjYsMTcgKzM2NiwxNyBAQCBkZWYgbW96aWxsYUV4aXQzRXJy b3JIYW5kbGVyCiAgICAgICAgIG91dHAucHV0cyAiICAgIHRoZW4iCiAgICAgICAgIG91dHAucHV0 cyAiICAgICAgICBpZiBncmVwIC1pIC1xIGZhaWxlZCEgI3tvdXRwdXRGaWxlbmFtZX0iCiAgICAg ICAgIG91dHAucHV0cyAiICAgICAgICB0aGVuIgotICAgICAgICBvdXRwLnB1dHMgIiAgICAgICAg ICAgIChlY2hvIERldGVjdGVkIGZhaWx1cmVzOiAmJiBjYXQgI3tvdXRwdXRGaWxlbmFtZX0pIHwg IiArIHByZWZpeENvbW1hbmQocGxhbi5uYW1lKQorICAgICAgICBvdXRwLnB1dHMgIiAgICAgICAg ICAgIChlY2hvIERldGVjdGVkIGZhaWx1cmVzOiAmJiBjYXQgI3tvdXRwdXRGaWxlbmFtZX0pIHwg IiArIHByZWZpeENvbW1hbmQocGxhbi5uYW1lKSArICIxPiYyIgogICAgICAgICBvdXRwLnB1dHMg IiAgICAgICAgICAgICIgKyBwbGFuLmZhaWxDb21tYW5kCiAgICAgICAgIG91dHAucHV0cyAiICAg ICAgICBlbHNlIgogICAgICAgICBvdXRwLnB1dHMgIiAgICAgICAgICAgICIgKyBwbGFuLnN1Y2Nl c3NDb21tYW5kCiAgICAgICAgIG91dHAucHV0cyAiICAgICAgICBmaSIKICAgICAgICAgb3V0cC5w dXRzICIgICAgZWxzZSIKLSAgICAgICAgb3V0cC5wdXRzICIgICAgICAgIChjYXQgI3tvdXRwdXRG aWxlbmFtZX0gJiYgZWNobyBFUlJPUjogVW5leHBlY3RlZCBleGl0IGNvZGU6IGBjYXQgI3twbGFu LmZhaWxGaWxlfWApIHwgIiArIHByZWZpeENvbW1hbmQocGxhbi5uYW1lKQorICAgICAgICBvdXRw LnB1dHMgIiAgICAgICAgKGNhdCAje291dHB1dEZpbGVuYW1lfSAmJiBlY2hvIEVSUk9SOiBVbmV4 cGVjdGVkIGV4aXQgY29kZTogYGNhdCAje3BsYW4uZmFpbEZpbGV9YCkgfCAiICsgcHJlZml4Q29t bWFuZChwbGFuLm5hbWUpICsgIjE+JjIiCiAgICAgICAgIG91dHAucHV0cyAiICAgICAgICAiICsg cGxhbi5mYWlsQ29tbWFuZAogICAgICAgICBvdXRwLnB1dHMgIiAgICBmaSIKICAgICAgICAgb3V0 cC5wdXRzICJlbHNlIgotICAgICAgICBvdXRwLnB1dHMgIiAgICAoY2F0ICN7b3V0cHV0RmlsZW5h bWV9ICYmIGVjaG8gRVJST1I6IFRlc3QgZXhwZWN0ZWQgdG8gZmFpbCwgYnV0IHJldHVybmVkIHN1 Y2Nlc3NmdWxseSkgfCAiICsgcHJlZml4Q29tbWFuZChwbGFuLm5hbWUpCisgICAgICAgIG91dHAu cHV0cyAiICAgIChjYXQgI3tvdXRwdXRGaWxlbmFtZX0gJiYgZWNobyBFUlJPUjogVGVzdCBleHBl Y3RlZCB0byBmYWlsLCBidXQgcmV0dXJuZWQgc3VjY2Vzc2Z1bGx5KSB8ICIgKyBwcmVmaXhDb21t YW5kKHBsYW4ubmFtZSkgKyAiMT4mMiIKICAgICAgICAgb3V0cC5wdXRzICIgICAgIiArIHBsYW4u ZmFpbENvbW1hbmQKICAgICAgICAgb3V0cC5wdXRzICJmaSIKICAgICB9CkluZGV4OiBUb29scy9T Y3JpcHRzL2pzYy1zdHJlc3MtdGVzdC1oZWxwZXJzL3NoZWxsLXJ1bm5lci5zaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL2pzYy1zdHJlc3MtdGVzdC1oZWxwZXJzL3NoZWxsLXJ1bm5lci5z aAkocmV2aXNpb24gMTY1MjY5KQorKysgVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVs cGVycy9zaGVsbC1ydW5uZXIuc2gJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDE1IEBAIHRo ZW4KICAgICBmaQogZmkKIAorVkVSQk9TRT0wCit3aGlsZSBnZXRvcHRzICJ2IiBPUFRJT04KK2Rv CisgICAgY2FzZSAkT1BUSU9OIGluCisgICAgICAgIHYpIFZFUkJPU0U9MQorICAgICAgICAgICAg OzsKKyAgICBlc2FjCitkb25lCisKIGluZGV4RmlsZT0iLmluZGV4IgogdGVzdExpc3Q9Ii5hbGxf dGVzdHMudHh0IgogdGVtcEZpbGU9Ii50ZW1wLnR4dCIKQEAgLTcxLDcgKzgwLDcgQEAgZG8KICAg ICAgICAgICAgIG12ICR7dGVtcEZpbGV9ICR7dGVzdExpc3R9CiAgICAgICAgICAgICB1bmxvY2tf dGVzdF9saXN0CiAKLSAgICAgICAgICAgIHNoICR7bmV4dFRlc3R9ID4gL2Rldi9udWxsCisgICAg ICAgICAgICBbICRWRVJCT1NFIC1lcSAxIF0gJiYgc2ggJHtuZXh0VGVzdH0gfHwgc2ggJHtuZXh0 VGVzdH0gMT4gL2Rldi9udWxsCiAKICAgICAgICAgICAgIGxvY2tfdGVzdF9saXN0CiAgICAgICAg IGRvbmUK