129879 2014-03-07 06:51:12 -0800 Geoclue2 based backend should provide the right desktop ID 2017-08-24 01:45:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mario aperez aperez berto bugs-noreply buildbot cedric.bellegarde cgarcia clopez gustavo mcatanzaro zeeshanak oldest_to_newest 988146 0 mario 2014-03-07 06:51:12 -0800 According to the discussion that happened in bug 120185, we need to provide a better string than the output of g_get_prgname() as the desktop ID for geoclue2, so the app embedding WebKit is properly identified. See the conversation in bug 120185 (from comment 59 to 65) for more details. 1341515 1 clopez 2017-08-23 06:10:12 -0700 *** Bug 175824 has been marked as a duplicate of this bug. *** 1341516 2 clopez 2017-08-23 06:13:05 -0700 I wonder if its even possible to provide the right desktop ID on all cases? I think we can at least document this on our API and leave the job of providing the right desktop ID to the application using the API (ir should know better). 1341517 3 zeeshanak 2017-08-23 06:28:36 -0700 (In reply to Carlos Alberto Lopez Perez from comment #2) > I wonder if its even possible to provide the right desktop ID on all cases? The only place where it really matters is sandboxed apps running inside flatpak and there you're required to have a desktop ID AFAIK. For cases where it doesn't make sense, just invent a desktop ID and install a very basic .desktop file for it. > I think we can at least document this on our API and leave the job of > providing the right desktop ID to the application using the API (ir should > know better). I agree. 1341522 4 mcatanzaro 2017-08-23 07:04:00 -0700 (In reply to Carlos Alberto Lopez Perez from comment #2) > I wonder if its even possible to provide the right desktop ID on all cases? No it's not possible, not unless we add new API. That's not needed, because it's easier to just require that g_get_prgname() match the desktop ID. I think we should change nothing and just document this somewhere. 1341525 5 zeeshanak 2017-08-23 07:21:04 -0700 (In reply to Michael Catanzaro from comment #4) > (In reply to Carlos Alberto Lopez Perez from comment #2) > > I wonder if its even possible to provide the right desktop ID on all cases? > > No it's not possible, not unless we add new API. That's not needed, because > it's easier to just require that g_get_prgname() match the desktop ID. I > think we should change nothing and just document this somewhere. Oh sorry I completely misunderstood. I thought the question was if all apps can provide the desktop ID. I agree, apps should be doing this. 1341528 6 aperez 2017-08-23 07:47:03 -0700 (In reply to Michael Catanzaro from comment #4) > (In reply to Carlos Alberto Lopez Perez from comment #2) > > I wonder if its even possible to provide the right desktop ID on all cases? > > No it's not possible, not unless we add new API. That's not needed, because > it's easier to just require that g_get_prgname() match the desktop ID. I > think we should change nothing and just document this somewhere. There is a much better way than using g_get_prgname() — GApplication (https://developer.gnome.org/gio/stable/GApplication.html): const char* appid = nullptr; GApplication* app = g_application_get_default(); if (app) { appid = g_application_get_application_id(app); } // Maybe add a fall-back to g_get_prgname() This allows different values for the application identifier, and the program name. It is very common that they are different. Example: the program name for Epiphany is “epiphany” (the name of the binary on disk), and the application identifier is “org.gnome.Epiphany”. We should use GApplcation when GLib 2.32+ is available, and document that setting an application identifier using GApplication/GtkApplication is needed for geolocation to work. 1341775 7 318916 aperez 2017-08-23 14:09:32 -0700 Created attachment 318916 Patch Tentative patch. Do we want to document the need to set an application identifier, preferrably via GApplication/GtkApplication, for things to work correctly? If yes, where in the documentation would that go? 1341800 8 318916 mcatanzaro 2017-08-23 14:49:47 -0700 Comment on attachment 318916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318916&action=review > Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp:141 > + // also fall-back to our old behaviour of using g_get_prgname(). fallback behavior 1341801 9 mcatanzaro 2017-08-23 14:51:14 -0700 This won't work for Epiphany web applications, but Epiphany is on the whitelist so that's OK. I don't think there's really any good place to document this. 1341837 10 aperez 2017-08-23 15:56:51 -0700 (In reply to Michael Catanzaro from comment #8) > Comment on attachment 318916 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318916&action=review > > > Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp:141 > > + // also fall-back to our old behaviour of using g_get_prgname(). > > fallback Right, it's an actual word without a dash, and I'll change it also in the ChangeLog. > behavior Mmh, “behaviour” is correct → http://www.wordreference.com/definition/behaviour I'll post an updated version with some notes for developers in the documentation page for WebKitGeolocationPermissionRequest — it is the the only place in the API documentation where geolocation is mentioned. 1341839 11 318934 aperez 2017-08-23 16:00:10 -0700 Created attachment 318934 Patch Version with notes for developers added. The location is not great, but it is the only place in the whole API reference where geolocation is mentioned. Better than nothing, I presume :-D 1341840 12 buildbot 2017-08-23 16:02:05 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1341843 13 aperez 2017-08-23 16:05:57 -0700 JFTR: The usage of GApplication is unconditional because GApplication appeared in GLib 2.28, and WebKitGTK+ already requires GLib 2.36 — we don't need to add guards in the code for this. 1341908 14 mcatanzaro 2017-08-23 17:42:35 -0700 (In reply to Adrian Perez from comment #10) > > behavior > > Mmh, “behaviour” is correct → > http://www.wordreference.com/definition/behaviour That's British. We use American English in WebKit, with the exception of Source/WebCore/platform/gtk/po/en_GB.po, which is a real thing. But I'm afraid we can't provide .po files for source code comments. :) > I'll post an updated version with some notes for developers in the > documentation page for WebKitGeolocationPermissionRequest — it is the > the only place in the API documentation where geolocation is mentioned. Good idea. 1341910 15 318934 mcatanzaro 2017-08-23 17:46:18 -0700 Comment on attachment 318934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318934&action=review > Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp:141 > + // also fallback to our old behaviour of using g_get_prgname(). So I would still prefer if you changed the spelling. > Source/WebKit/UIProcess/API/glib/WebKitGeolocationPermissionRequest.cpp:43 > + * ## Developer Notes All of the documentation is developer notes, so this heading is useless. I'd just remove it. > Source/WebKit/UIProcess/API/glib/WebKitGeolocationPermissionRequest.cpp:58 > + * during initialization *might* be needed when the name of the executable It will be needed, not "might." 1341988 16 318974 aperez 2017-08-24 01:21:02 -0700 Created attachment 318974 Patch Updated with Michael's latest review suggestions. 1341991 17 aperez 2017-08-24 01:45:26 -0700 Committed r221132: <http://trac.webkit.org/changeset/221132> 318916 2017-08-23 14:09:32 -0700 2017-08-23 16:00:05 -0700 Patch bug-129879-20170824000930.patch text/plain 2343 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjUyN2NkYTJjNmEzYTEw YjNjZmE1YTMzMzdkNmQzYWU4ZWRhMzAyMS4uNmVjMzJhM2U5NGM5MmY0MTAxYWQyYmE2MjExMTlh YmRiZWExNzUwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTIzICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgR2VvY2x1 ZTIgYmFzZWQgYmFja2VuZCBzaG91bGQgcHJvdmlkZSB0aGUgcmlnaHQgZGVza3RvcCBJRAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODc5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n ZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9jbHVlLmNwcDoKKyAgICAgICAgKEdlb2xvY2F0 aW9uUHJvdmlkZXJHZW9jbHVlOjpjcmVhdGVHZW9jbHVlQ2xpZW50UHJveHlDYWxsYmFjayk6IFRy eSBmaXJzdCBvYnRhaW5pbmcgdGhlIGFwcGxpY2F0aW9uCisgICAgICAgIGlkZW50aWZpZXIgdXNp bmcgR0FwcGxpY2F0aW9uIGZpcnN0LCBrZWVwaW5nIGEgZmFsbC1iYWNrIHRvIHRoZSB2YWx1ZSBy ZXR1cm5lZCBieSBnX2dldF9wcmduYW1lKCkuCisKIDIwMTctMDgtMjMgIEFuZHkgRXN0ZXMgIDxh ZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtQYXltZW50IFJlcXVlc3RdIFVwZGF0ZSB0byAi SW4gRGV2ZWxvcG1lbnQiIGluIGZlYXR1cmVzLmpzb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dlb2NsdWUvR2VvbG9jYXRpb25Qcm92aWRlckdlb2NsdWUuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2VvY2x1ZS9HZW9sb2NhdGlvblByb3ZpZGVyR2VvY2x1ZS5j cHAKaW5kZXggMDViYzY3MmI1MjViNzY4MDY1Y2U2MmMxN2E2MjBjOGVhY2UyY2ZlYi4uYmEwYmUx NDNiNGI1MTdhOWE5M2NjNWNhNWY4YmI3NzUwMmE5ZTk5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ2VvY2x1ZS9HZW9sb2NhdGlvblByb3ZpZGVyR2VvY2x1ZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2VvY2x1ZS9HZW9sb2NhdGlvblByb3ZpZGVyR2Vv Y2x1ZS5jcHAKQEAgLTEzNywxMCArMTM3LDE2IEBAIHZvaWQgR2VvbG9jYXRpb25Qcm92aWRlckdl b2NsdWU6OmNyZWF0ZUdlb2NsdWVDbGllbnRQcm94eUNhbGxiYWNrKEdPYmplY3QqLCBHQXN5CiAK ICAgICAvLyBHZW9jbHVlMiByZXF1aXJlcyB0aGUgY2xpZW50IHRvIHByb3ZpZGUgYSBkZXNrdG9w IElEIGZvciBzZWN1cml0eQogICAgIC8vIHJlYXNvbnMsIHdoaWNoIHNob3VsZCBpZGVudGlmeSB0 aGUgYXBwbGljYXRpb24gcmVxdWVzdGluZyB0aGUgbG9jYXRpb24uCi0gICAgLy8gRklYTUU6IFdl IHByb3ZpZGUgdGhlIHByb2dyYW0gbmFtZSBhcyB0aGUgZGVza3RvcCBJRCBmb3Igbm93IGJ1dCwg aW4gYW4gaWRlYWwgd29ybGQsCi0gICAgLy8gd2Ugc2hvdWxkIHByb3ZpZGUgYSBwcm9wZXIgImFw cGxpY2F0aW9uIElEIiAobm9ybWFsbHkgdGhlIG5hbWUgb2YgYSAuZGVza3RvcCBmaWxlKS4KLSAg ICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODc5Ci0gICAg Z2VvY2x1ZV9jbGllbnRfc2V0X2Rlc2t0b3BfaWQocHJvdmlkZXItPm1fY2xpZW50UHJveHkuZ2V0 KCksIGdfZ2V0X3ByZ25hbWUoKSk7CisgICAgLy8gV2UgdXNlIHRoZSBhcHBsaWNhdGlvbiBJRCBj b25maWd1cmVkIGZvciB0aGUgZGVmYXVsdCBHQXBwbGljYXRpb24sIGFuZAorICAgIC8vIGFsc28g ZmFsbC1iYWNrIHRvIG91ciBvbGQgYmVoYXZpb3VyIG9mIHVzaW5nIGdfZ2V0X3ByZ25hbWUoKS4K KyAgICBjb25zdCBjaGFyKiBhcHBJZCA9IG51bGxwdHI7CisgICAgR0FwcGxpY2F0aW9uKiBkZWZh dWx0QXBwID0gZ19hcHBsaWNhdGlvbl9nZXRfZGVmYXVsdCgpOworICAgIGlmIChkZWZhdWx0QXBw KQorICAgICAgICBhcHBJZCA9IGdfYXBwbGljYXRpb25fZ2V0X2FwcGxpY2F0aW9uX2lkKGRlZmF1 bHRBcHApOworICAgIGlmICghYXBwSWQpCisgICAgICAgIGFwcElkID0gZ19nZXRfcHJnbmFtZSgp OworCisgICAgZ2VvY2x1ZV9jbGllbnRfc2V0X2Rlc2t0b3BfaWQocHJvdmlkZXItPm1fY2xpZW50 UHJveHkuZ2V0KCksIGFwcElkKTsKIAogICAgIHByb3ZpZGVyLT5zdGFydEdlb2NsdWVDbGllbnQo KTsKIH0K 318934 2017-08-23 16:00:10 -0700 2017-08-24 01:20:58 -0700 Patch bug-129879-20170824020009.patch text/plain 3926 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjUyN2NkYTJjNmEzYTEw YjNjZmE1YTMzMzdkNmQzYWU4ZWRhMzAyMS4uMjU0MTRjMjFlMTNhNWZjZjBkYzNkMjZlYzI2ZjI1 MTkzZDRiN2FkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTIzICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgR2VvY2x1 ZTIgYmFzZWQgYmFja2VuZCBzaG91bGQgcHJvdmlkZSB0aGUgcmlnaHQgZGVza3RvcCBJRAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODc5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n ZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9jbHVlLmNwcDoKKyAgICAgICAgKEdlb2xvY2F0 aW9uUHJvdmlkZXJHZW9jbHVlOjpjcmVhdGVHZW9jbHVlQ2xpZW50UHJveHlDYWxsYmFjayk6IFRy eSBmaXJzdCBvYnRhaW5pbmcgdGhlIGFwcGxpY2F0aW9uCisgICAgICAgIGlkZW50aWZpZXIgdXNp bmcgR0FwcGxpY2F0aW9uIGZpcnN0LCBrZWVwaW5nIGEgZmFsbGJhY2sgdG8gdGhlIHZhbHVlIHJl dHVybmVkIGJ5IGdfZ2V0X3ByZ25hbWUoKS4KKwogMjAxNy0wOC0yMyAgQW5keSBFc3RlcyAgPGFl c3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1BheW1lbnQgUmVxdWVzdF0gVXBkYXRlIHRvICJJ biBEZXZlbG9wbWVudCIgaW4gZmVhdHVyZXMuanNvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ2VvY2x1ZS9HZW9sb2NhdGlvblByb3ZpZGVyR2VvY2x1ZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9nZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9jbHVlLmNw cAppbmRleCAwNWJjNjcyYjUyNWI3NjgwNjVjZTYyYzE3YTYyMGM4ZWFjZTJjZmViLi5lMTA0ZGFk NTljMDIzZmQ2YzE4NWNiZWIyZjc0NGM3NDgzZTM0ZTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9nZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9jbHVlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9j bHVlLmNwcApAQCAtMTM3LDEwICsxMzcsMTYgQEAgdm9pZCBHZW9sb2NhdGlvblByb3ZpZGVyR2Vv Y2x1ZTo6Y3JlYXRlR2VvY2x1ZUNsaWVudFByb3h5Q2FsbGJhY2soR09iamVjdCosIEdBc3kKIAog ICAgIC8vIEdlb2NsdWUyIHJlcXVpcmVzIHRoZSBjbGllbnQgdG8gcHJvdmlkZSBhIGRlc2t0b3Ag SUQgZm9yIHNlY3VyaXR5CiAgICAgLy8gcmVhc29ucywgd2hpY2ggc2hvdWxkIGlkZW50aWZ5IHRo ZSBhcHBsaWNhdGlvbiByZXF1ZXN0aW5nIHRoZSBsb2NhdGlvbi4KLSAgICAvLyBGSVhNRTogV2Ug cHJvdmlkZSB0aGUgcHJvZ3JhbSBuYW1lIGFzIHRoZSBkZXNrdG9wIElEIGZvciBub3cgYnV0LCBp biBhbiBpZGVhbCB3b3JsZCwKLSAgICAvLyB3ZSBzaG91bGQgcHJvdmlkZSBhIHByb3BlciAiYXBw bGljYXRpb24gSUQiIChub3JtYWxseSB0aGUgbmFtZSBvZiBhIC5kZXNrdG9wIGZpbGUpLgotICAg IC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4NzkKLSAgICBn ZW9jbHVlX2NsaWVudF9zZXRfZGVza3RvcF9pZChwcm92aWRlci0+bV9jbGllbnRQcm94eS5nZXQo KSwgZ19nZXRfcHJnbmFtZSgpKTsKKyAgICAvLyBXZSB1c2UgdGhlIGFwcGxpY2F0aW9uIElEIGNv bmZpZ3VyZWQgZm9yIHRoZSBkZWZhdWx0IEdBcHBsaWNhdGlvbiwgYW5kCisgICAgLy8gYWxzbyBm YWxsYmFjayB0byBvdXIgb2xkIGJlaGF2aW91ciBvZiB1c2luZyBnX2dldF9wcmduYW1lKCkuCisg ICAgY29uc3QgY2hhciogYXBwSWQgPSBudWxscHRyOworICAgIEdBcHBsaWNhdGlvbiogZGVmYXVs dEFwcCA9IGdfYXBwbGljYXRpb25fZ2V0X2RlZmF1bHQoKTsKKyAgICBpZiAoZGVmYXVsdEFwcCkK KyAgICAgICAgYXBwSWQgPSBnX2FwcGxpY2F0aW9uX2dldF9hcHBsaWNhdGlvbl9pZChkZWZhdWx0 QXBwKTsKKyAgICBpZiAoIWFwcElkKQorICAgICAgICBhcHBJZCA9IGdfZ2V0X3ByZ25hbWUoKTsK KworICAgIGdlb2NsdWVfY2xpZW50X3NldF9kZXNrdG9wX2lkKHByb3ZpZGVyLT5tX2NsaWVudFBy b3h5LmdldCgpLCBhcHBJZCk7CiAKICAgICBwcm92aWRlci0+c3RhcnRHZW9jbHVlQ2xpZW50KCk7 CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRH ZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdEdlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3QuY3BwCmluZGV4IGZi MzhkZjA2MDQyZjE2NmEwNzZiY2VjZWE2ZjY2NjZhZDVjMTNlMjAuLjNkZjNiMzgwNDE2MGI3ZGUy YzZmN2I1ZGQwYTBmNWFhOGZjODU0N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9nbGliL1dlYktpdEdlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdEdlb2xvY2F0aW9uUGVybWlz c2lvblJlcXVlc3QuY3BwCkBAIC0zOSw2ICszOSwyNCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0 OwogICoKICAqIFdoZW4gYSBXZWJLaXRHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0IGlzIG5v dCBoYW5kbGVkIGJ5IHRoZSB1c2VyLAogICogaXQgaXMgZGVuaWVkIGJ5IGRlZmF1bHQuCisgKgor ICogIyMgRGV2ZWxvcGVyIE5vdGVzCisgKgorICogV2hlbiBlbWJlZGRpbmcgd2ViIHZpZXdzIGlu IHlvdXIgYXBwbGljYXRpb24sIHlvdSAqbXVzdCogY29uZmlndXJlIGFuCisgKiBhcHBsaWNhdGlv biBpZGVudGlmaWVyIHRvIGFsbG93IHdlYiBjb250ZW50IHRvIHVzZSBnZW9sb2NhdGlvbiBzZXJ2 aWNlcy4KKyAqIFRoZSBpZGVudGlmaWVyICptdXN0KiBtYXRjaCB0aGUgbmFtZSBvZiB0aGUgYC5k ZXNrdG9wYCBmaWxlIHdoaWNoIGRlc2NyaWJlcworICogdGhlIGFwcGxpY2F0aW9uLCBzYW5zIHRo ZSBzdWZmaXguCisgKgorICogSWYgeW91ciBhcHBsaWNhdGlvbiB1c2VzICNHQXBwbGljYXRpb24g KG9yIGFueSBzdWJjbGFzcyBsaWtlCisgKiAjR3RrQXBwbGljYXRpb24pLCBXZWJLaXQgd2lsbCBh dXRvbWF0aWNhbGx5IHVzZSB0aGUgaWRlbnRpZmllciByZXR1cm5lZCBieQorICogZ19hcHBsaWNh dGlvbl9nZXRfYXBwbGljYXRpb25faWQoKS4gVGhpcyBpcyB0aGUgcmVjb21tZW5kZWQgYXBwcm9h Y2ggZm9yCisgKiBlbmFibGluZyBnZW9sb2NhdGlvbiBpbiBhcHBsaWNhdGlvbnMuCisgKgorICog SWYgYW4gaWRlbnRpZmllciBjYW5ub3QgYmUgb2J0YWluZWQgdGhyb3VnaCAjR0FwcGxpY2F0aW9u LCB0aGUgdmFsdWUKKyAqIHJldHVybmVkIGJ5IGdfZ2V0X3ByZ25hbWUoKSB3aWxsIGJlIHVzZWQg aW5zdGVhZCBhcyBhIGZhbGxiYWNrLiBGb3IKKyAqIHByb2dyYW1zIHdoaWNoIGNhbm5vdCB1c2Ug I0dBcHBsaWNhdGlvbiwgY2FsbGluZyBnX3NldF9wcmduYW1lKCkgZWFybHkKKyAqIGR1cmluZyBp bml0aWFsaXphdGlvbiAqbWlnaHQqIGJlIG5lZWRlZCB3aGVuIHRoZSBuYW1lIG9mIHRoZSBleGVj dXRhYmxlCisgKiBvbiBkaXNrIGRvZXMgbm90IG1hdGNoIHRoZSBuYW1lIG9mIGEgdmFsaWQgYC5k ZXNrdG9wYCBmaWxlLgogICovCiAKIHN0YXRpYyB2b2lkIHdlYmtpdF9wZXJtaXNzaW9uX3JlcXVl c3RfaW50ZXJmYWNlX2luaXQoV2ViS2l0UGVybWlzc2lvblJlcXVlc3RJZmFjZSopOwo= 318974 2017-08-24 01:21:02 -0700 2017-08-24 01:21:02 -0700 Patch bug-129879-20170824112101.patch text/plain 3904 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRiMTE1NTFiYmYxNDQ2 ODViNWExNWZlZTY1NGFkM2MyZTdmMzY5ZC4uYTlhNGY5ZGM1Nzk2M2NhYzA5NGI1YTRjMjYyNTZi NTM0Y2VjZDBkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTIzICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgR2VvY2x1 ZTIgYmFzZWQgYmFja2VuZCBzaG91bGQgcHJvdmlkZSB0aGUgcmlnaHQgZGVza3RvcCBJRAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODc5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTWljaGFlbCBDYXRhbnphcm8uCisKKyAgICAgICAgKiBwbGF0Zm9y bS9nZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9jbHVlLmNwcDoKKyAgICAgICAgKEdlb2xv Y2F0aW9uUHJvdmlkZXJHZW9jbHVlOjpjcmVhdGVHZW9jbHVlQ2xpZW50UHJveHlDYWxsYmFjayk6 IFRyeSBmaXJzdCBvYnRhaW5pbmcgdGhlIGFwcGxpY2F0aW9uCisgICAgICAgIGlkZW50aWZpZXIg dXNpbmcgR0FwcGxpY2F0aW9uIGZpcnN0LCBrZWVwaW5nIGEgZmFsbGJhY2sgdG8gdGhlIHZhbHVl IHJldHVybmVkIGJ5IGdfZ2V0X3ByZ25hbWUoKS4KKwogMjAxNy0wOC0yNCAgWmFuIERvYmVyc2Vr ICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0VNRV0gSW1wbGVtZW50IEhUTUxN ZWRpYUVsZW1lbnQgZGlzcGF0Y2ggb2YgdGhlIG9uZW5jcnlwdGVkIGV2ZW50CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9j bHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dlb2NsdWUvR2VvbG9jYXRpb25Qcm92 aWRlckdlb2NsdWUuY3BwCmluZGV4IDA1YmM2NzJiNTI1Yjc2ODA2NWNlNjJjMTdhNjIwYzhlYWNl MmNmZWIuLjRhMTYyMjAyNDBhNDIyM2Y2ZDkxOWJhOWE3MmM0Mzk1ODc1MjdjZDggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dlb2NsdWUvR2VvbG9jYXRpb25Qcm92aWRlckdl b2NsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dlb2NsdWUvR2VvbG9jYXRp b25Qcm92aWRlckdlb2NsdWUuY3BwCkBAIC0xMzcsMTAgKzEzNywxNiBAQCB2b2lkIEdlb2xvY2F0 aW9uUHJvdmlkZXJHZW9jbHVlOjpjcmVhdGVHZW9jbHVlQ2xpZW50UHJveHlDYWxsYmFjayhHT2Jq ZWN0KiwgR0FzeQogCiAgICAgLy8gR2VvY2x1ZTIgcmVxdWlyZXMgdGhlIGNsaWVudCB0byBwcm92 aWRlIGEgZGVza3RvcCBJRCBmb3Igc2VjdXJpdHkKICAgICAvLyByZWFzb25zLCB3aGljaCBzaG91 bGQgaWRlbnRpZnkgdGhlIGFwcGxpY2F0aW9uIHJlcXVlc3RpbmcgdGhlIGxvY2F0aW9uLgotICAg IC8vIEZJWE1FOiBXZSBwcm92aWRlIHRoZSBwcm9ncmFtIG5hbWUgYXMgdGhlIGRlc2t0b3AgSUQg Zm9yIG5vdyBidXQsIGluIGFuIGlkZWFsIHdvcmxkLAotICAgIC8vIHdlIHNob3VsZCBwcm92aWRl IGEgcHJvcGVyICJhcHBsaWNhdGlvbiBJRCIgKG5vcm1hbGx5IHRoZSBuYW1lIG9mIGEgLmRlc2t0 b3AgZmlsZSkuCi0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyOTg3OQotICAgIGdlb2NsdWVfY2xpZW50X3NldF9kZXNrdG9wX2lkKHByb3ZpZGVyLT5tX2Ns aWVudFByb3h5LmdldCgpLCBnX2dldF9wcmduYW1lKCkpOworICAgIC8vIFdlIHVzZSB0aGUgYXBw bGljYXRpb24gSUQgY29uZmlndXJlZCBmb3IgdGhlIGRlZmF1bHQgR0FwcGxpY2F0aW9uLCBhbmQK KyAgICAvLyBhbHNvIGZhbGxiYWNrIHRvIG91ciBvbGQgYmVoYXZpb3Igb2YgdXNpbmcgZ19nZXRf cHJnbmFtZSgpLgorICAgIGNvbnN0IGNoYXIqIGFwcElkID0gbnVsbHB0cjsKKyAgICBHQXBwbGlj YXRpb24qIGRlZmF1bHRBcHAgPSBnX2FwcGxpY2F0aW9uX2dldF9kZWZhdWx0KCk7CisgICAgaWYg KGRlZmF1bHRBcHApCisgICAgICAgIGFwcElkID0gZ19hcHBsaWNhdGlvbl9nZXRfYXBwbGljYXRp b25faWQoZGVmYXVsdEFwcCk7CisgICAgaWYgKCFhcHBJZCkKKyAgICAgICAgYXBwSWQgPSBnX2dl dF9wcmduYW1lKCk7CisKKyAgICBnZW9jbHVlX2NsaWVudF9zZXRfZGVza3RvcF9pZChwcm92aWRl ci0+bV9jbGllbnRQcm94eS5nZXQoKSwgYXBwSWQpOwogCiAgICAgcHJvdmlkZXItPnN0YXJ0R2Vv Y2x1ZUNsaWVudCgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2dsaWIvV2ViS2l0R2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0 LmNwcAppbmRleCBmYjM4ZGYwNjA0MmYxNjZhMDc2YmNlY2VhNmY2NjY2YWQ1YzEzZTIwLi5hMzhl NjJkODY3ZTE3M2I0ZjYwOTQ1NTRhY2EzM2QyZjVmYmMzYTcxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1 ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRHZW9s b2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0LmNwcApAQCAtMzksNiArMzksMjIgQEAgdXNpbmcgbmFt ZXNwYWNlIFdlYktpdDsKICAqCiAgKiBXaGVuIGEgV2ViS2l0R2VvbG9jYXRpb25QZXJtaXNzaW9u UmVxdWVzdCBpcyBub3QgaGFuZGxlZCBieSB0aGUgdXNlciwKICAqIGl0IGlzIGRlbmllZCBieSBk ZWZhdWx0LgorICoKKyAqIFdoZW4gZW1iZWRkaW5nIHdlYiB2aWV3cyBpbiB5b3VyIGFwcGxpY2F0 aW9uLCB5b3UgKm11c3QqIGNvbmZpZ3VyZSBhbgorICogYXBwbGljYXRpb24gaWRlbnRpZmllciB0 byBhbGxvdyB3ZWIgY29udGVudCB0byB1c2UgZ2VvbG9jYXRpb24gc2VydmljZXMuCisgKiBUaGUg aWRlbnRpZmllciAqbXVzdCogbWF0Y2ggdGhlIG5hbWUgb2YgdGhlIGAuZGVza3RvcGAgZmlsZSB3 aGljaCBkZXNjcmliZXMKKyAqIHRoZSBhcHBsaWNhdGlvbiwgc2FucyB0aGUgc3VmZml4LgorICoK KyAqIElmIHlvdXIgYXBwbGljYXRpb24gdXNlcyAjR0FwcGxpY2F0aW9uIChvciBhbnkgc3ViY2xh c3MgbGlrZQorICogI0d0a0FwcGxpY2F0aW9uKSwgV2ViS2l0IHdpbGwgYXV0b21hdGljYWxseSB1 c2UgdGhlIGlkZW50aWZpZXIgcmV0dXJuZWQgYnkKKyAqIGdfYXBwbGljYXRpb25fZ2V0X2FwcGxp Y2F0aW9uX2lkKCkuIFRoaXMgaXMgdGhlIHJlY29tbWVuZGVkIGFwcHJvYWNoIGZvcgorICogZW5h YmxpbmcgZ2VvbG9jYXRpb24gaW4gYXBwbGljYXRpb25zLgorICoKKyAqIElmIGFuIGlkZW50aWZp ZXIgY2Fubm90IGJlIG9idGFpbmVkIHRocm91Z2ggI0dBcHBsaWNhdGlvbiwgdGhlIHZhbHVlCisg KiByZXR1cm5lZCBieSBnX2dldF9wcmduYW1lKCkgd2lsbCBiZSB1c2VkIGluc3RlYWQgYXMgYSBm YWxsYmFjay4gRm9yCisgKiBwcm9ncmFtcyB3aGljaCBjYW5ub3QgdXNlICNHQXBwbGljYXRpb24s IGNhbGxpbmcgZ19zZXRfcHJnbmFtZSgpIGVhcmx5CisgKiBkdXJpbmcgaW5pdGlhbGl6YXRpb24g aXMgbmVlZGVkIHdoZW4gdGhlIG5hbWUgb2YgdGhlIGV4ZWN1dGFibGUgb24gZGlzaworICogZG9l cyBub3QgbWF0Y2ggdGhlIG5hbWUgb2YgYSB2YWxpZCBgLmRlc2t0b3BgIGZpbGUuCiAgKi8KIAog c3RhdGljIHZvaWQgd2Via2l0X3Blcm1pc3Npb25fcmVxdWVzdF9pbnRlcmZhY2VfaW5pdChXZWJL aXRQZXJtaXNzaW9uUmVxdWVzdElmYWNlKik7Cg==