129876 2014-03-07 04:07:02 -0800 Syntax error in the sandbox profile for Adobe Flash plugin 2014-03-18 09:29:24 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac (Intel) OS X 10.8 RESOLVED INVALID P2 Normal --- 1 i.am.rodionovd webkit-unassigned andersca ap commit-queue eric.carlson ggaren glenn ike jer.noble philipj sam scooper sergio oldest_to_newest 988111 0 i.am.rodionovd 2014-03-07 04:07:02 -0800 Syntax error in file Source/WebKit2/Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb, line 31: a regex string literal should start with a «#» (number) sign. >> 31: (home-library-regex "/Application Support/Macromedia/ss\.(cfg|cfn|sgn)$")) 988120 1 226116 i.am.rodionovd 2014-03-07 04:45:25 -0800 Created attachment 226116 Patch fixing this bug 988543 2 226212 i.am.rodionovd 2014-03-08 03:08:35 -0800 Created attachment 226212 The proper patch for the bug 988568 3 226212 ggaren 2014-03-08 10:48:10 -0800 Comment on attachment 226212 The proper patch for the bug View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review > Source/WebKit2/ChangeLog:8 > + A regex string literal should start with a «#» (numbert) sign (line 31). Please us ASCII quotes. "numbert" should be "number". 988569 4 ggaren 2014-03-08 10:48:19 -0800 *use 988573 5 226216 i.am.rodionovd 2014-03-08 11:01:36 -0800 Created attachment 226216 Fixed proper patch 988574 6 i.am.rodionovd 2014-03-08 11:03:02 -0800 (In reply to comment #3) > (From update of attachment 226212 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review > > > Source/WebKit2/ChangeLog:8 > > + A regex string literal should start with a «#» (numbert) sign (line 31). > > Please us ASCII quotes. > > "numbert" should be "number". Sorry for that, fixed now with the last patch @ 2014-03-08 11:01 PST 988616 7 ap 2014-03-08 13:37:56 -0800 What is the observable consequence of this issue? Is it that we allow reading from e.g. ~/Library/Application Support/Macromedia/ss<any single character>cfg? If it's an actual syntax error, then I'm not sure how it is detected - the profile compiles successfully when loading Flash. Is the error you posted printed out by some verification tool? 988718 8 ike 2014-03-09 01:04:41 -0800 This is not an error. 989143 9 226216 sam 2014-03-10 18:02:43 -0700 Comment on attachment 226216 Fixed proper patch r-ing given Ivan's comment. 991691 10 ap 2014-03-18 09:29:24 -0700 (In reply to comment #8) > This is not an error. Is it a mistake that would be good to fix? It seems to me that the patch is correct, despite the report lacking a rationale. 226116 2014-03-07 04:45:25 -0800 2014-03-08 11:01:36 -0800 Patch fixing this bug 129876.patch text/plain 646 i.am.rodionovd SW5kZXg6IGNvbS5tYWNyb21lZGlhLkZsYXNoIFBsYXllci5wbHVnaW4uc2IKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gY29tLm1hY3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdpbi5zYgkocmV2aXNpb24gMTYzOTMx KQorKysgY29tLm1hY3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdpbi5zYgkod29ya2luZyBjb3B5 KQpAQCAtMjgsNyArMjgsNyBAQAogKGFsbG93IGZpbGUtcmVhZCoKICAgICAobGl0ZXJhbCAiL0xp YnJhcnkvUHJlZmVyZW5jZVBhbmVzL0ZsYXNoIFBsYXllci5wcmVmUGFuZSIpCiAgICAgKGhvbWUt bGlicmFyeS1saXRlcmFsICIvUHJlZmVyZW5jZVBhbmVzL0ZsYXNoIFBsYXllci5wcmVmUGFuZSIp Ci0gICAgKGhvbWUtbGlicmFyeS1yZWdleCAiL0FwcGxpY2F0aW9uIFN1cHBvcnQvTWFjcm9tZWRp YS9zc1wuKGNmZ3xjZm58c2duKSQiKSkKKyAgICAoaG9tZS1saWJyYXJ5LXJlZ2V4ICMiL0FwcGxp Y2F0aW9uIFN1cHBvcnQvTWFjcm9tZWRpYS9zc1wuKGNmZ3xjZm58c2duKSQiKSkKIAogKGFsbG93 IGZpbGUtcmVhZCogZmlsZS13cml0ZSoKICAgICAobW91bnQtcmVsYXRpdmUtcmVnZXggIyJeL1wu VGVtcG9yYXJ5SXRlbXMvIikpCg== 226212 2014-03-08 03:08:35 -0800 2014-03-08 11:01:36 -0800 The proper patch for the bug text.patch text/plain 1519 i.am.rodionovd U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2VjZmE4MS4uMTNhZDVm MSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAzLTA4ICBEbWl0cnkgUm9kaW9ub3YgIDxpLmFtLnJvZGlvbm92ZEBnbWFpbC5jb20+ CisKKyAgICAgICAgU3ludGF4IGVycm9yIGluIHRoZSBzYW5kYm94IHByb2ZpbGUgZm9yIEFkb2Jl IEZsYXNoIHBsdWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI5ODc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQSByZWdleCBzdHJpbmcgbGl0ZXJhbCBzaG91bGQgc3RhcnQgd2l0aCBhIMKrI8K7IChu dW1iZXJ0KSBzaWduIChsaW5lIDMxKS4KKworICAgICAgICAqIFJlc291cmNlcy9QbHVnSW5TYW5k Ym94UHJvZmlsZXMvY29tLm1hY3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdpbi5zYjoKKwogMjAx NC0wMy0wOCAgQWFyb24gR29sZGVuICA8Z29sZGVuQGlua2xpbmcuY29tPgogCiAgICAgICAgIFBy ZXZlbnQgcHJvY2Vzc2VzIHNwYXduZWQgYnkgV2ViUHJvY2VzcyBmcm9tIHRyeWluZyB0byBpbnNl cnQgdGhlIFNlY0l0ZW0gc2hpbS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1Jlc291cmNl cy9QbHVnSW5TYW5kYm94UHJvZmlsZXMvY29tLm1hY3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdp bi5zYiBiL1NvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9QbHVnSW5TYW5kYm94UHJvZmlsZXMvY29t Lm1hY3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdpbi5zYgppbmRleCAzMTk4OGFhLi42ZWY3MWE4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9SZXNvdXJjZXMvUGx1Z0luU2FuZGJveFByb2Zp bGVzL2NvbS5tYWNyb21lZGlhLkZsYXNoIFBsYXllci5wbHVnaW4uc2IJCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1Jlc291cmNlcy9QbHVnSW5TYW5kYm94UHJvZmlsZXMvY29tLm1hY3JvbWVkaWEuRmxh c2ggUGxheWVyLnBsdWdpbi5zYgpAQCAtMjgsNyArMjgsNyBAQAogKGFsbG93IGZpbGUtcmVhZCoK ICAgICAobGl0ZXJhbCAiL0xpYnJhcnkvUHJlZmVyZW5jZVBhbmVzL0ZsYXNoIFBsYXllci5wcmVm UGFuZSIpCiAgICAgKGhvbWUtbGlicmFyeS1saXRlcmFsICIvUHJlZmVyZW5jZVBhbmVzL0ZsYXNo IFBsYXllci5wcmVmUGFuZSIpCi0gICAgKGhvbWUtbGlicmFyeS1yZWdleCAiL0FwcGxpY2F0aW9u IFN1cHBvcnQvTWFjcm9tZWRpYS9zc1wuKGNmZ3xjZm58c2duKSQiKSkKKyAgICAoaG9tZS1saWJy YXJ5LXJlZ2V4ICMiL0FwcGxpY2F0aW9uIFN1cHBvcnQvTWFjcm9tZWRpYS9zc1wuKGNmZ3xjZm58 c2duKSQiKSkKIAogKGFsbG93IGZpbGUtcmVhZCogZmlsZS13cml0ZSoKICAgICAobW91bnQtcmVs YXRpdmUtcmVnZXggIyJeL1wuVGVtcG9yYXJ5SXRlbXMvIikpCg== 226216 2014-03-08 11:01:36 -0800 2014-03-10 18:02:42 -0700 Fixed proper patch text.patch text/plain 1517 i.am.rodionovd U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2VjZmE4MS4uMTNhZDVm MSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAzLTA4ICBEbWl0cnkgUm9kaW9ub3YgIDxpLmFtLnJvZGlvbm92ZEBnbWFpbC5jb20+ CisKKyAgICAgICAgU3ludGF4IGVycm9yIGluIHRoZSBzYW5kYm94IHByb2ZpbGUgZm9yIEFkb2Jl IEZsYXNoIHBsdWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI5ODc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQSByZWdleCBzdHJpbmcgbGl0ZXJhbCBzaG91bGQgc3RhcnQgd2l0aCBhICIjIiAobnVt YmVyKSBzaWduIChsaW5lIDMxKS4KKworICAgICAgICAqIFJlc291cmNlcy9QbHVnSW5TYW5kYm94 UHJvZmlsZXMvY29tLm1hY3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdpbi5zYjoKKwogMjAxNC0w My0wOCAgQWFyb24gR29sZGVuICA8Z29sZGVuQGlua2xpbmcuY29tPgogCiAgICAgICAgIFByZXZl bnQgcHJvY2Vzc2VzIHNwYXduZWQgYnkgV2ViUHJvY2VzcyBmcm9tIHRyeWluZyB0byBpbnNlcnQg dGhlIFNlY0l0ZW0gc2hpbS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9Q bHVnSW5TYW5kYm94UHJvZmlsZXMvY29tLm1hY3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdpbi5z YiBiL1NvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9QbHVnSW5TYW5kYm94UHJvZmlsZXMvY29tLm1h Y3JvbWVkaWEuRmxhc2ggUGxheWVyLnBsdWdpbi5zYgppbmRleCAzMTk4OGFhLi42ZWY3MWE4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9SZXNvdXJjZXMvUGx1Z0luU2FuZGJveFByb2ZpbGVz L2NvbS5tYWNyb21lZGlhLkZsYXNoIFBsYXllci5wbHVnaW4uc2IgIAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9SZXNvdXJjZXMvUGx1Z0luU2FuZGJveFByb2ZpbGVzL2NvbS5tYWNyb21lZGlhLkZsYXNo IFBsYXllci5wbHVnaW4uc2IKQEAgLTI4LDcgKzI4LDcgQEAKIChhbGxvdyBmaWxlLXJlYWQqCiAg ICAgKGxpdGVyYWwgIi9MaWJyYXJ5L1ByZWZlcmVuY2VQYW5lcy9GbGFzaCBQbGF5ZXIucHJlZlBh bmUiKQogICAgIChob21lLWxpYnJhcnktbGl0ZXJhbCAiL1ByZWZlcmVuY2VQYW5lcy9GbGFzaCBQ bGF5ZXIucHJlZlBhbmUiKQotICAgIChob21lLWxpYnJhcnktcmVnZXggIi9BcHBsaWNhdGlvbiBT dXBwb3J0L01hY3JvbWVkaWEvc3NcLihjZmd8Y2ZufHNnbikkIikpCisgICAgKGhvbWUtbGlicmFy eS1yZWdleCAjIi9BcHBsaWNhdGlvbiBTdXBwb3J0L01hY3JvbWVkaWEvc3NcLihjZmd8Y2ZufHNn bikkIikpCiAKIChhbGxvdyBmaWxlLXJlYWQqIGZpbGUtd3JpdGUqCiAgICAgKG1vdW50LXJlbGF0 aXZlLXJlZ2V4ICMiXi9cLlRlbXBvcmFyeUl0ZW1zLyIpKQo=