129872 2014-03-07 02:48:07 -0800 REGRESSION (r164847): Pressing the command key while hovering an element causes it to un-hover 2014-03-07 18:48:53 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton ap andersca ap commit-queue oldest_to_newest 988088 0 226103 thorton 2014-03-07 02:48:07 -0800 Created attachment 226103 repro https://bugs.webkit.org/show_bug.cgi?id=129455 Steps to Reproduce: 1. Load the attached test case. 2. Hover the box. It will turn green. 3. Press the command key. Expected: The box should remain green. Actual: The box goes back to being red, as if it were un-hovered. This breaks the user's ability to cmd-click on links in menus that appear on hover. 988248 1 226145 ap 2014-03-07 12:01:54 -0800 Created attachment 226145 proposed fix 988390 2 226145 commit-queue 2014-03-07 15:40:21 -0800 Comment on attachment 226145 proposed fix Rejecting attachment 226145 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 226145, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: a/WKViewPrivate.h Hunk #1 FAILED at 68. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h.rej patching file Source/WebKit2/UIProcess/API/mac/WKView.mm Hunk #1 FAILED at 2133. Hunk #2 FAILED at 3070. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/mac/WKView.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5679527615266816 988472 3 ap 2014-03-07 18:48:53 -0800 Commit queue landed this patch, and failed when trying to land it again (probably because bug mail was broken today). 226103 2014-03-07 02:48:07 -0800 2014-03-07 02:48:07 -0800 repro hover.html text/html 134 thorton PHN0eWxlPmRpdjpob3ZlciB7YmFja2dyb3VuZC1jb2xvcjogZ3JlZW4gIWltcG9ydGFudDt9PC9z dHlsZT4KPGRpdiBzdHlsZT0id2lkdGg6IDUwMHB4OyBoZWlnaHQ6IDUwMHB4OyBiYWNrZ3JvdW5k LWNvbG9yOiByZWQ7Ij48L2Rpdj4= 226145 2014-03-07 12:01:54 -0800 2014-03-07 15:40:21 -0800 proposed fix FakeEvent.txt text/plain 2985 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTI3NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAzLTA3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNjQ4 NDcpOiBQcmVzc2luZyB0aGUgY29tbWFuZCBrZXkgd2hpbGUgaG92ZXJpbmcgYW4gZWxlbWVudCBj YXVzZXMgaXQgdG8gdW4taG92ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyOTg3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmg6IENoYW5n ZXMgaW4gcGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdEN1cnJlbnRNb3VzZUxvY2F0aW9uCisgICAg ICAgIHdlcmUgYWxzbyBub3QgY29ycmVjdCwgYmVjYXVzZSB0aGUgY3VycmVudCBldmVudCBjb3Vs ZCBiZSBhIGtleWJvYXJkIG9uZSAoQ21kK0N0cmwrRCkuCisgICAgICAgIEJ1dCB0aGlzIFNQSSBp cyB1bnVzZWQsIGFuZCBjYW4gYmUgc2ltcGx5IHJlbW92ZWQuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW06ICgtW1dLVmlldyBfcG9zdEZha2VNb3VzZU1vdmVkRXZlbnRG b3JGbGFnc0NoYW5nZWRFdmVudDpdKToKKyAgICAgICAgbG9jYXRpb25JbldpbmRvdyBpcyB1bmRl ZmluZWQgZm9yIGtleWJvYXJkIGV2ZW50cywgc28gd2UgaGF2ZSB0byB1c2UgY3VycmVudCBsb2Nh dGlvbi4KKyAgICAgICAgVGhhbmtmdWxseSwgdGhlcmUgaXMgYSBtZXRob2QgdGhhdCByZXR1cm5z IHRoZSBsb2NhdGlvbiBpbiBhcHByb3ByaWF0ZSBjb29yZGluYXRlCisgICAgICAgIHNwYWNlLCB1 bmxpa2UgK1tOU0V2ZW50IG1vdXNlTG9jYXRpb25dIHRoYXQgd2UgdXNlZCBiZWZvcmUuCisKIDIw MTQtMDMtMDcgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAg ICAgSW5pdGlhbGl6ZSBuZXcgV0tTSSBmdW5jdGlvbnMgZm9yIFdlYktpdDIKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oCShy ZXZpc2lvbiAxNjUyNjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL Vmlld1ByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNyArNjgsNiBAQAogLSAodm9pZCll bmFibGVGcmFtZVNpemVVcGRhdGVzOwogLSAoQk9PTClmcmFtZVNpemVVcGRhdGVzRGlzYWJsZWQ7 CiAKLS0gKHZvaWQpcGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdEN1cnJlbnRNb3VzZUxvY2F0aW9u OwogKyAodm9pZCloaWRlV29yZERlZmluaXRpb25XaW5kb3c7CiAKIEBwcm9wZXJ0eSAocmVhZHdy aXRlKSBDR0Zsb2F0IG1pbmltdW1MYXlvdXRXaWR0aDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDE2NTI2OSkKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjEz Myw3ICsyMTMzLDcgQEAgLSAoTlNWaWV3ICopaGl0VGVzdDooTlNQb2ludClwb2ludAogCiAtICh2 b2lkKV9wb3N0RmFrZU1vdXNlTW92ZWRFdmVudEZvckZsYWdzQ2hhbmdlZEV2ZW50OihOU0V2ZW50 ICopZmxhZ3NDaGFuZ2VkRXZlbnQKIHsKLSAgICBOU0V2ZW50ICpmYWtlRXZlbnQgPSBbTlNFdmVu dCBtb3VzZUV2ZW50V2l0aFR5cGU6TlNNb3VzZU1vdmVkIGxvY2F0aW9uOmZsYWdzQ2hhbmdlZEV2 ZW50LmxvY2F0aW9uSW5XaW5kb3cKKyAgICBOU0V2ZW50ICpmYWtlRXZlbnQgPSBbTlNFdmVudCBt b3VzZUV2ZW50V2l0aFR5cGU6TlNNb3VzZU1vdmVkIGxvY2F0aW9uOltbZmxhZ3NDaGFuZ2VkRXZl bnQgd2luZG93XSBtb3VzZUxvY2F0aW9uT3V0c2lkZU9mRXZlbnRTdHJlYW1dCiAgICAgICAgIG1v ZGlmaWVyRmxhZ3M6W2ZsYWdzQ2hhbmdlZEV2ZW50IG1vZGlmaWVyRmxhZ3NdIHRpbWVzdGFtcDpb ZmxhZ3NDaGFuZ2VkRXZlbnQgdGltZXN0YW1wXSB3aW5kb3dOdW1iZXI6W2ZsYWdzQ2hhbmdlZEV2 ZW50IHdpbmRvd051bWJlcl0KICAgICAgICAgY29udGV4dDpbZmxhZ3NDaGFuZ2VkRXZlbnQgY29u dGV4dF0gZXZlbnROdW1iZXI6MCBjbGlja0NvdW50OjAgcHJlc3N1cmU6MF07CiAgICAgTmF0aXZl V2ViTW91c2VFdmVudCB3ZWJFdmVudChmYWtlRXZlbnQsIHNlbGYpOwpAQCAtMzA3MCwxMSArMzA3 MCw2IEBAIC0gKEJPT0wpZnJhbWVTaXplVXBkYXRlc0Rpc2FibGVkCiAgICAgcmV0dXJuIF9kYXRh LT5fZnJhbWVTaXplVXBkYXRlc0Rpc2FibGVkQ291bnQgPiAwOwogfQogCi0tICh2b2lkKXBlcmZv cm1EaWN0aW9uYXJ5TG9va3VwQXRDdXJyZW50TW91c2VMb2NhdGlvbgotewotICAgIF9kYXRhLT5f cGFnZS0+cGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdExvY2F0aW9uKFtzZWxmIGNvbnZlcnRQb2lu dDpbW05TQXBwIGN1cnJlbnRFdmVudF0gbG9jYXRpb25JbldpbmRvd10gZnJvbVZpZXc6bmlsXSk7 Ci19Ci0KICsgKHZvaWQpaGlkZVdvcmREZWZpbml0aW9uV2luZG93CiB7CiAgICAgV0tIaWRlV29y ZERlZmluaXRpb25XaW5kb3coKTsK