129869 2014-03-07 01:49:11 -0800 [GTK] Runtime error when page is closed while print operation is in progress 2014-03-12 11:27:08 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned andersca oldest_to_newest 988076 0 cgarcia 2014-03-07 01:49:11 -0800 It doesn't always happen, but it can be easily reproduced running test /webkit2/WebKitPrintOperation/close-after-print $ Programs/TestWebKitAPI/WebKit2Gtk/TestPrinting -p /webkit2/WebKitPrintOperation/close-after-print /webkit2/WebKitPrintOperation/close-after-print: OK pure virtual method called terminate called without an active exception This happens because the page is closed when the pages have been printed, but print job is still ongoing sending the data to the printer. When print job finishes, we try to notify the UI process sending the print callback message using WebPage::send(), but the web page object has been destroyed. The virtual method it complains about is probably MessageSender::messageSenderDestinationID() used by send(). Since our print operation is always asynchronous, we need a way to notify the web page when the print operation has actually finished to clean it up, but also notify the print operation when the page has been closed to not try to notify the UI process in that case. 988077 1 226099 cgarcia 2014-03-07 01:57:33 -0800 Created attachment 226099 Patch 988194 2 226099 mrobinson 2014-03-07 09:39:16 -0800 Comment on attachment 226099 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226099&action=review GTK+ bits look good to me. I'll leave the rest to the WebKit2 owners. > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:418 > +void WebPrintOperationGtk::disconnectFromPage() Maybe call this didDisconnectFromPage or notifyDisconnectFromPage since the disconnection actually happens earlier? 988200 3 cgarcia 2014-03-07 09:52:09 -0800 (In reply to comment #2) > (From update of attachment 226099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226099&action=review > > GTK+ bits look good to me. I'll leave the rest to the WebKit2 owners. Thanks for the review. > > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:418 > > +void WebPrintOperationGtk::disconnectFromPage() > > Maybe call this didDisconnectFromPage or notifyDisconnectFromPage since the disconnection actually happens earlier? I followed other similar existing methods that are disconnectFromPage. This happens when the page is closed, and is telling the print operation to disconnect from the page. It's consistent with WebColorChooser::disconnectFromPage(), WebPopupMenu::disconnectFromPage(), WebOpenPanelResultListener::disconnectFromPage(), etc. 989748 4 cgarcia 2014-03-12 11:27:08 -0700 Committed r165489: <http://trac.webkit.org/changeset/165489> 226099 2014-03-07 01:57:33 -0800 2014-03-12 10:21:27 -0700 Patch wk2-close-after-print.diff text/plain 6770 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlOWFmNjJmLi5iNjExZTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsNDMg QEAKIDIwMTQtMDMtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFJ1bnRpbWUgZXJyb3Igd2hlbiBwYWdlIGlzIGNsb3NlZCB3aGls ZSBwcmludCBvcGVyYXRpb24gaXMgaW4gcHJvZ3Jlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTg2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWV0aW1lcyB3aGVuIHRoZSBwYWdlIGlzIGNsb3Nl ZCByaWdodCBhZnRlciBwcmludGluZyB0aGUgd2ViCisgICAgICAgIHByb2Nlc3MgYWJvcnRzIHdp dGggdGhlIHJ1bnRpbWUgbWVzc2FnZSAicHVyZSB2aXJ0dWFsIG1ldGhvZAorICAgICAgICBjYWxs ZWQgdGVybWluYXRlIGNhbGxlZCB3aXRob3V0IGFuIGFjdGl2ZSBleGNlcHRpb24iLgorICAgICAg ICBUaGlzIGhhcHBlbnMgYmVjYXVzZSB0aGUgcGFnZSBpcyBjbG9zZWQgd2hlbiB0aGUgcGFnZXMg aGF2ZSBiZWVuCisgICAgICAgIHByaW50ZWQsIGJ1dCBwcmludCBqb2IgaXMgc3RpbGwgb25nb2lu ZyBzZW5kaW5nIHRoZSBkYXRhIHRvIHRoZQorICAgICAgICBwcmludGVyLiBXaGVuIHByaW50IGpv YiBmaW5pc2hlcywgd2UgdHJ5IHRvIG5vdGlmeSB0aGUgVUkgcHJvY2VzcworICAgICAgICBzZW5k aW5nIHRoZSBwcmludCBjYWxsYmFjayBtZXNzYWdlIHVzaW5nIFdlYlBhZ2U6OnNlbmQoKSwgYnV0 IHRoZQorICAgICAgICB3ZWIgcGFnZSBvYmplY3QgaGFzIGJlZW4gZGVzdHJveWVkLiBUaGUgdmly dHVhbCBtZXRob2QgaXQgY29tcGxhaW5zCisgICAgICAgIGFib3V0IGlzIHByb2JhYmx5IE1lc3Nh Z2VTZW5kZXI6Om1lc3NhZ2VTZW5kZXJEZXN0aW5hdGlvbklEKCkgdXNlZAorICAgICAgICBieSBz ZW5kKCkuIFNpbmNlIG91ciBwcmludCBvcGVyYXRpb24gaXMgYWx3YXlzIGFzeW5jaHJvbm91cywg d2UKKyAgICAgICAgbmVlZCBhIHdheSB0byBub3RpZnkgdGhlIHdlYiBwYWdlIHdoZW4gdGhlIHBy aW50IG9wZXJhdGlvbiBoYXMKKyAgICAgICAgYWN0dWFsbHkgZmluaXNoZWQgdG8gY2xlYW4gaXQg dXAsIGJ1dCBhbHNvIG5vdGlmeSB0aGUgcHJpbnQKKyAgICAgICAgb3BlcmF0aW9uIHdoZW4gdGhl IHBhZ2UgaGFzIGJlZW4gY2xvc2VkIHRvIG5vdCB0cnkgdG8gbm90aWZ5IHRoZQorICAgICAgICBV SSBwcm9jZXNzIGluIHRoYXQgY2FzZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Y2xvc2UpOiBDYWxsIGRpc2Nv bm5lY3RGcm9tUGFnZSB0byBub3RpZnkgdGhlCisgICAgICAgIHByaW50IG9wZXJhdGlvbiBpbiBj YXNlIHRoZXJlJ3MgYW4gb25nb2luZyBwcmludCBqb2IuCisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2U6OmVuZFByaW50aW5nKTogRG8gbm90IGNsZWFudXAgdGhlIHByaW50IG9wZXJhdGlvbgorICAg ICAgICBoZXJlLCBzaW5jZSB0aGUgcHJpbnQgb3BlcnRhdGlvbiBtaWdodCBub3QgaGF2ZSBmaW5p c2hlZCB5ZXQuCisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmRpZEZpbmlzaFByaW50T3BlcmF0 aW9uKTogU2VuZAorICAgICAgICBQcmludEZpbmlzaGVkQ2FsbGJhY2sgbWVzc2FnZSB0byB0aGUg VWkgcHJvY2VzcyBhbmQgY2xlYW51cCB0aGUKKyAgICAgICAgcHJpbnQgb3BlcmF0aW9uLgorICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmg6CisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlByaW50T3BlcmF0aW9uR3RrOjpkaXNjb25uZWN0RnJvbVBhZ2UpOiBTZXQgbV93ZWJQYWdl CisgICAgICAgIHRvIG51bGxwdHIuCisgICAgICAgIChXZWJLaXQ6OldlYlByaW50T3BlcmF0aW9u R3RrOjpwcmludERvbmUpOiBDYWxsCisgICAgICAgIGRpZEZpbmlzaFByaW50T3BlcmF0aW9uKCkg aXMgdGhlIHdlYiBwYWdlIGhhc24ndCBiZWVuIGNsb3NlZC4KKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmg6CisKKzIwMTQtMDMtMDcgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFVz ZSBmaW5hbCBhbmQgb3ZlcnJpZGUgaW4gV2ViUHJpbnRPcGVyYXRpb25HdGsKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTg2OAogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggOGQ3ZWNhNC4uMDVl NjdmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cApAQCAtODM5LDYgKzgzOSwxMyBAQCB2b2lkIFdlYlBhZ2U6OmNsb3NlKCkKICAgICB9CiAjZW5k aWYKIAorI2lmIFBMQVRGT1JNKEdUSykKKyAgICBpZiAobV9wcmludE9wZXJhdGlvbikgeworICAg ICAgICBtX3ByaW50T3BlcmF0aW9uLT5kaXNjb25uZWN0RnJvbVBhZ2UoKTsKKyAgICAgICAgbV9w cmludE9wZXJhdGlvbiA9IG51bGxwdHI7CisgICAgfQorI2VuZGlmCisKICAgICBtX3NhbmRib3hF eHRlbnNpb25UcmFja2VyLmludmFsaWRhdGUoKTsKIAogI2lmIEVOQUJMRShQUklNQVJZX1NOQVBT SE9UVEVEX1BMVUdJTl9IRVVSSVNUSUMpCkBAIC0zMzg1LDkgKzMzOTIsNiBAQCB2b2lkIFdlYlBh Z2U6OmJlZ2luUHJpbnRpbmcodWludDY0X3QgZnJhbWVJRCwgY29uc3QgUHJpbnRJbmZvJiBwcmlu dEluZm8pCiB2b2lkIFdlYlBhZ2U6OmVuZFByaW50aW5nKCkKIHsKICAgICBkcmF3aW5nQXJlYSgp LT5zZXRMYXllclRyZWVTdGF0ZUlzRnJvemVuKGZhbHNlKTsKLSNpZiBQTEFURk9STShHVEspCi0g ICAgbV9wcmludE9wZXJhdGlvbiA9IDA7Ci0jZW5kaWYKICAgICBtX3ByaW50Q29udGV4dCA9IG51 bGxwdHI7CiB9CiAKQEAgLTM1MTMsNyArMzUxNyw2IEBAIHZvaWQgV2ViUGFnZTo6ZHJhd1BhZ2Vz VG9QREYodWludDY0X3QgZnJhbWVJRCwgY29uc3QgUHJpbnRJbmZvJiBwcmludEluZm8sIHVpbnQz CiB9CiAKICNlbGlmIFBMQVRGT1JNKEdUSykKLQogdm9pZCBXZWJQYWdlOjpkcmF3UGFnZXNGb3JQ cmludGluZyh1aW50NjRfdCBmcmFtZUlELCBjb25zdCBQcmludEluZm8mIHByaW50SW5mbywgdWlu dDY0X3QgY2FsbGJhY2tJRCkKIHsKICAgICBiZWdpblByaW50aW5nKGZyYW1lSUQsIHByaW50SW5m byk7CkBAIC0zNTI0LDYgKzM1MjcsMTIgQEAgdm9pZCBXZWJQYWdlOjpkcmF3UGFnZXNGb3JQcmlu dGluZyh1aW50NjRfdCBmcmFtZUlELCBjb25zdCBQcmludEluZm8mIHByaW50SW5mbywKIAogICAg IHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6Vm9pZENhbGxiYWNrKGNhbGxiYWNrSUQpKTsK IH0KKwordm9pZCBXZWJQYWdlOjpkaWRGaW5pc2hQcmludE9wZXJhdGlvbihjb25zdCBXZWJDb3Jl OjpSZXNvdXJjZUVycm9yJiBlcnJvciwgdWludDY0X3QgY2FsbGJhY2tJRCkKK3sKKyAgICBzZW5k KE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlByaW50RmluaXNoZWRDYWxsYmFjayhlcnJvciwgY2Fs bGJhY2tJRCkpOworICAgIG1fcHJpbnRPcGVyYXRpb24gPSBudWxscHRyOworfQogI2VuZGlmCiAK IHZvaWQgV2ViUGFnZTo6c2F2ZVBERlRvRmlsZUluRG93bmxvYWRzRm9sZGVyKGNvbnN0IFN0cmlu ZyYgc3VnZ2VzdGVkRmlsZW5hbWUsIGNvbnN0IFN0cmluZyYgb3JpZ2luYXRpbmdVUkxTdHJpbmcs IGNvbnN0IHVpbnQ4X3QqIGRhdGEsIHVuc2lnbmVkIGxvbmcgc2l6ZSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IGE5ODMzNTkuLjJkYTM1ZDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAtNTc5LDYg KzU3OSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGRyYXdQYWdlc1RvUERGKHVpbnQ2NF90IGZyYW1l SUQsIGNvbnN0IFByaW50SW5mbyYsIHVpbnQzMl90IGZpcnN0LCB1aW50MzJfdCBjb3VudCwgdWlu dDY0X3QgY2FsbGJhY2tJRCk7CiAjZWxpZiBQTEFURk9STShHVEspCiAgICAgdm9pZCBkcmF3UGFn ZXNGb3JQcmludGluZyh1aW50NjRfdCBmcmFtZUlELCBjb25zdCBQcmludEluZm8mLCB1aW50NjRf dCBjYWxsYmFja0lEKTsKKyAgICB2b2lkIGRpZEZpbmlzaFByaW50T3BlcmF0aW9uKGNvbnN0IFdl YkNvcmU6OlJlc291cmNlRXJyb3ImLCB1aW50NjRfdCBjYWxsYmFja0lEKTsKICNlbmRpZgogCiAg ICAgdm9pZCBzZXRNZWRpYVZvbHVtZShmbG9hdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUHJpbnRPcGVyYXRpb25HdGsuY3Bw CmluZGV4IGI3ZTQ5ZGQuLmE5Yzc3Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9ndGsvV2ViUHJpbnRPcGVyYXRpb25HdGsuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUHJpbnRPcGVyYXRpb25HdGsuY3BwCkBA IC00MTUsNiArNDE1LDExIEBAIFdlYlByaW50T3BlcmF0aW9uR3RrOjp+V2ViUHJpbnRPcGVyYXRp b25HdGsoKQogICAgICAgICBnX3NvdXJjZV9yZW1vdmUobV9wcmludFBhZ2VzSWRsZUlkKTsKIH0K IAordm9pZCBXZWJQcmludE9wZXJhdGlvbkd0azo6ZGlzY29ubmVjdEZyb21QYWdlKCkKK3sKKyAg ICBtX3dlYlBhZ2UgPSBudWxscHRyOworfQorCiBpbnQgV2ViUHJpbnRPcGVyYXRpb25HdGs6OnBh Z2VDb3VudCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fcHJpbnRDb250ZXh0ID8gbV9wcmludENv bnRleHQtPnBhZ2VDb3VudCgpIDogMDsKQEAgLTY5NCw4ICs2OTksOSBAQCB2b2lkIFdlYlByaW50 T3BlcmF0aW9uR3RrOjpwcmludERvbmUoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYgZXJy b3IpCiAgICAgICAgIGdfc291cmNlX3JlbW92ZShtX3ByaW50UGFnZXNJZGxlSWQpOwogICAgIG1f cHJpbnRQYWdlc0lkbGVJZCA9IDA7CiAKLSAgICAvLyBQcmludCBmaW5pc2hlZCBvciBmYWlsZWQs IG5vdGlmeSB0aGUgVUkgcHJvY2VzcyB0aGF0IHdlIGFyZSBkb25lLgotICAgIG1fd2ViUGFnZS0+ c2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpQcmludEZpbmlzaGVkQ2FsbGJhY2soZXJyb3Is IG1fY2FsbGJhY2tJRCkpOworICAgIC8vIFByaW50IGZpbmlzaGVkIG9yIGZhaWxlZCwgbm90aWZ5 IHRoZSBVSSBwcm9jZXNzIHRoYXQgd2UgYXJlIGRvbmUgaWYgdGhlIHBhZ2UgaGFzbid0IGJlZW4g Y2xvc2VkLgorICAgIGlmIChtX3dlYlBhZ2UpCisgICAgICAgIG1fd2ViUGFnZS0+ZGlkRmluaXNo UHJpbnRPcGVyYXRpb24oZXJyb3IsIG1fY2FsbGJhY2tJRCk7CiB9CiAKIHZvaWQgV2ViUHJpbnRP cGVyYXRpb25HdGs6OnByaW50KGNhaXJvX3N1cmZhY2VfdCogc3VyZmFjZSwgZG91YmxlIHhEUEks IGRvdWJsZSB5RFBJKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5oCmluZGV4IDQzOGYzNDcuLmMyMDFh MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2Vi UHJpbnRPcGVyYXRpb25HdGsuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmgKQEAgLTczLDYgKzczLDggQEAgcHVibGljOgog ICAgIGJvb2wgY29sbGF0ZUNvcGllcygpIGNvbnN0IHsgcmV0dXJuIG1fY29sbGF0ZUNvcGllczsg fQogICAgIGRvdWJsZSBzY2FsZSgpIGNvbnN0IHsgcmV0dXJuIG1fc2NhbGU7IH0KIAorICAgIHZv aWQgZGlzY29ubmVjdEZyb21QYWdlKCk7CisKICAgICB2aXJ0dWFsIHZvaWQgc3RhcnRQcmludChX ZWJDb3JlOjpQcmludENvbnRleHQqLCB1aW50NjRfdCBjYWxsYmFja0lEKSA9IDA7CiAKIHByb3Rl Y3RlZDoKQEAgLTkzLDYgKzk1LDcgQEAgcHJvdGVjdGVkOgogICAgIHZvaWQgcHJlcGFyZUNvbnRl eHRUb0RyYXcoKTsKICAgICB2b2lkIHByaW50UGFnZXNEb25lKCk7CiAgICAgdm9pZCBwcmludERv bmUoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpOworICAgIHZvaWQgc2VuZFByaW50Rmlu aXNoZWQoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpOwogICAgIFdlYkNvcmU6OlVSTCBm cmFtZVVSTCgpIGNvbnN0OwogCiAgICAgV2ViUGFnZSogbV93ZWJQYWdlOwo=