129868 2014-03-07 01:13:42 -0800 [GTK] Use final and override in WebPrintOperationGtk 2014-03-07 05:32:21 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 988067 0 cgarcia 2014-03-07 01:13:42 -0800 ssia 988068 1 226094 cgarcia 2014-03-07 01:16:38 -0800 Created attachment 226094 Patch 988101 2 226094 svillar 2014-03-07 03:21:49 -0800 Comment on attachment 226094 Patch Nice! 988136 3 cgarcia 2014-03-07 05:32:21 -0800 Committed r165259: <http://trac.webkit.org/changeset/165259> 226094 2014-03-07 01:16:38 -0800 2014-03-07 03:21:49 -0800 Patch wk2-print-op-final-override.diff text/plain 3232 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzYWJiNmZmLi5lOWFmNjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDMtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFVzZSBmaW5hbCBhbmQgb3ZlcnJpZGUgaW4gV2ViUHJpbnRPcGVy YXRpb25HdGsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyOTg2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHA6CisKIDIw MTQtMDMtMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIENsb3NlIHRoZSBwYWdlIHdoZW4gdGhlIHZpZXcgaXMgZGlzcG9zZWQgaW5z dGVhZCBvZiB3aGVuIGZpbmFsaXplZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcAppbmRleCA0 MDQ2OWU2Li5iN2U0OWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcApAQCAtNTIsNyAr NTIsNyBAQAogbmFtZXNwYWNlIFdlYktpdCB7CiAKICNpZmRlZiBIQVZFX0dUS19VTklYX1BSSU5U SU5HCi1jbGFzcyBXZWJQcmludE9wZXJhdGlvbkd0a1VuaXg6IHB1YmxpYyBXZWJQcmludE9wZXJh dGlvbkd0ayB7CitjbGFzcyBXZWJQcmludE9wZXJhdGlvbkd0a1VuaXggZmluYWw6IHB1YmxpYyBX ZWJQcmludE9wZXJhdGlvbkd0ayB7CiBwdWJsaWM6CiAgICAgV2ViUHJpbnRPcGVyYXRpb25HdGtV bml4KFdlYlBhZ2UqIHBhZ2UsIGNvbnN0IFByaW50SW5mbyYgcHJpbnRJbmZvKQogICAgICAgICA6 IFdlYlByaW50T3BlcmF0aW9uR3RrKHBhZ2UsIHByaW50SW5mbykKQEAgLTYwLDcgKzYwLDcgQEAg cHVibGljOgogICAgIHsKICAgICB9CiAKLSAgICB2b2lkIHN0YXJ0UHJpbnQoV2ViQ29yZTo6UHJp bnRDb250ZXh0KiBwcmludENvbnRleHQsIHVpbnQ2NF90IGNhbGxiYWNrSUQpCisgICAgdm9pZCBz dGFydFByaW50KFdlYkNvcmU6OlByaW50Q29udGV4dCogcHJpbnRDb250ZXh0LCB1aW50NjRfdCBj YWxsYmFja0lEKSBvdmVycmlkZQogICAgIHsKICAgICAgICAgbV9wcmludENvbnRleHQgPSBwcmlu dENvbnRleHQ7CiAgICAgICAgIG1fY2FsbGJhY2tJRCA9IGNhbGxiYWNrSUQ7CkBAIC0xMDMsNyAr MTAzLDcgQEAgcHVibGljOgogICAgICAgICBwcmludChzdXJmYWNlLCA3MiwgNzIpOwogICAgIH0K IAotICAgIHZvaWQgc3RhcnRQYWdlKGNhaXJvX3QqIGNyKQorICAgIHZvaWQgc3RhcnRQYWdlKGNh aXJvX3QqIGNyKSBvdmVycmlkZQogICAgIHsKICAgICAgICAgaWYgKCFjdXJyZW50UGFnZUlzRmly c3RQYWdlT2ZTaGVldCgpKQogICAgICAgICAgIHJldHVybjsKQEAgLTEzMiw3ICsxMzIsNyBAQCBw dWJsaWM6CiAgICAgICAgICAgICBjYWlyb19wZGZfc3VyZmFjZV9zZXRfc2l6ZShzdXJmYWNlLCB3 aWR0aCwgaGVpZ2h0KTsKICAgICB9CiAKLSAgICB2b2lkIGVuZFBhZ2UoY2Fpcm9fdCogY3IpCisg ICAgdm9pZCBlbmRQYWdlKGNhaXJvX3QqIGNyKSBvdmVycmlkZQogICAgIHsKICAgICAgICAgaWYg KGN1cnJlbnRQYWdlSXNMYXN0UGFnZU9mU2hlZXQoKSkKICAgICAgICAgICAgIGNhaXJvX3Nob3df cGFnZShjcik7CkBAIC0xNDksNyArMTQ5LDcgQEAgcHVibGljOgogICAgICAgICBwcmludE9wZXJh dGlvbi0+ZGVyZWYoKTsKICAgICB9CiAKLSAgICB2b2lkIGVuZFByaW50KCkKKyAgICB2b2lkIGVu ZFByaW50KCkgb3ZlcnJpZGUKICAgICB7CiAgICAgICAgIGNhaXJvX3N1cmZhY2VfZmluaXNoKGd0 a19wcmludF9qb2JfZ2V0X3N1cmZhY2UobV9wcmludEpvYi5nZXQoKSwgMCkpOwogICAgICAgICAv LyBNYWtlIHN1cmUgdGhlIG9wZXJhdGlvbiBpcyBhbGl2ZSB1bnRpbCB0aGUgam9iIGlzIHNlbnQu CkBAIC0xNjMsMzEgKzE2MywzMSBAQCBwdWJsaWM6CiAjZW5kaWYKIAogI2lmZGVmIEdfT1NfV0lO MzIKLWNsYXNzIFdlYlByaW50T3BlcmF0aW9uR3RrV2luMzI6IHB1YmxpYyBXZWJQcmludE9wZXJh dGlvbkd0ayB7CitjbGFzcyBXZWJQcmludE9wZXJhdGlvbkd0a1dpbjMyIGZpbmFsOiBwdWJsaWMg V2ViUHJpbnRPcGVyYXRpb25HdGsgewogcHVibGljOgogICAgIFdlYlByaW50T3BlcmF0aW9uR3Rr V2luMzIoV2ViUGFnZSogcGFnZSwgY29uc3QgUHJpbnRJbmZvJiBwcmludEluZm8pCiAgICAgICAg IDogV2ViUHJpbnRPcGVyYXRpb25HdGsocGFnZSwgcHJpbnRJbmZvKQogICAgIHsKICAgICB9CiAK LSAgICB2b2lkIHN0YXJ0UHJpbnQoV2ViQ29yZTo6UHJpbnRDb250ZXh0KiBwcmludENvbnRleHQs IHVpbnQ2NF90IGNhbGxiYWNrSUQpCisgICAgdm9pZCBzdGFydFByaW50KFdlYkNvcmU6OlByaW50 Q29udGV4dCogcHJpbnRDb250ZXh0LCB1aW50NjRfdCBjYWxsYmFja0lEKSBvdmVycmlkZQogICAg IHsKICAgICAgICAgbV9wcmludENvbnRleHQgPSBwcmludENvbnRleHQ7CiAgICAgICAgIG1fY2Fs bGJhY2tJRCA9IGNhbGxiYWNrSUQ7CiAgICAgICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgfQog Ci0gICAgdm9pZCBzdGFydFBhZ2UoY2Fpcm9fdCogY3IpCisgICAgdm9pZCBzdGFydFBhZ2UoY2Fp cm9fdCogY3IpIG92ZXJyaWRlCiAgICAgewogICAgICAgICBub3RJbXBsZW1lbnRlZCgpOwogICAg IH0KIAotICAgIHZvaWQgZW5kUGFnZShjYWlyb190KiBjcikKKyAgICB2b2lkIGVuZFBhZ2UoY2Fp cm9fdCogY3IpIG92ZXJyaWRlCiAgICAgewogICAgICAgICBub3RJbXBsZW1lbnRlZCgpOwogICAg IH0KIAotICAgIHZvaWQgZW5kUHJpbnQoKQorICAgIHZvaWQgZW5kUHJpbnQoKSBvdmVycmlkZQog ICAgIHsKICAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKICAgICB9Cg==