129865 2014-03-06 22:59:19 -0800 FLT should call fmod directly on platforms where LLVM cannot relocate the libcall 2014-03-07 12:13:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 atrick webkit-unassigned commit-queue fpizlo ggaren mark.lam mhahnenberg msaboff oldest_to_newest 988047 0 atrick 2014-03-06 22:59:19 -0800 Posting a patch shortly. 988049 1 226089 atrick 2014-03-06 23:13:41 -0800 Created attachment 226089 Patch 988178 2 226089 commit-queue 2014-03-07 08:58:06 -0800 Comment on attachment 226089 Patch Clearing flags on attachment: 226089 Committed r165264: <http://trac.webkit.org/changeset/165264> 988179 3 commit-queue 2014-03-07 08:58:08 -0800 All reviewed patches have been landed. Closing bug. 988219 4 226089 ggaren 2014-03-07 10:43:14 -0800 Comment on attachment 226089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226089&action=review > Source/JavaScriptCore/ftl/FTLOutput.h:132 > + // FIXME: LLVM may soften float operations be expanding them to libcalls. "by" 988234 5 atrick 2014-03-07 11:23:34 -0800 Reopening to attach new patch. 988235 6 226140 atrick 2014-03-07 11:23:36 -0800 Created attachment 226140 Patch 988253 7 226140 commit-queue 2014-03-07 12:13:42 -0800 Comment on attachment 226140 Patch Clearing flags on attachment: 226140 Committed r165275: <http://trac.webkit.org/changeset/165275> 988254 8 commit-queue 2014-03-07 12:13:46 -0800 All reviewed patches have been landed. Closing bug. 226089 2014-03-06 23:13:41 -0800 2014-03-07 11:23:17 -0800 Patch bug-129865-20140306231340.patch text/plain 2706 atrick SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MjUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAzLTA2ICBBbmRyZXcgVHJpY2sgIDxhdHJpY2tAYXBwbGUuY29tPgorCisgICAgICAg IEZMVCBzaG91bGQgY2FsbCBmbW9kIGRpcmVjdGx5IG9uIHBsYXRmb3JtcyB3aGVyZSBMTFZNIGNh bm5vdCByZWxvY2F0ZSB0aGUgbGliY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmdGwvRlRMSW50cmluc2ljUmVwb3NpdG9yeS5oOgorICAgICAg ICAqIGZ0bC9GVExPdXRwdXQuaDoKKyAgICAgICAgKEpTQzo6RlRMOjpPdXRwdXQ6OmRvdWJsZVJl bSk6CisKIDIwMTQtMDMtMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAg ICAgICBJZiB0aGUgRlRMIGlzIGJ1aWxkLXRpbWUgZW5hYmxlZCB0aGVuIGl0IHNob3VsZCBiZSBy dW4tdGltZSBlbmFibGVkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExJbnRy aW5zaWNSZXBvc2l0b3J5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExJbnRyaW5zaWNSZXBvc2l0b3J5LmgJKHJldmlzaW9uIDE2NTIxMCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMSW50cmluc2ljUmVwb3NpdG9yeS5oCSh3b3JraW5nIGNvcHkp CkBAIC01OSw2ICs1OSw3IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgRlRMIHsKICAgICBt YWNybyhDX0pJVE9wZXJhdGlvbl9FSnNzSnNzSnNzLCBmdW5jdGlvblR5cGUoaW50UHRyLCBpbnRQ dHIsIGludFB0ciwgaW50UHRyLCBpbnRQdHIpKSBcCiAgICAgbWFjcm8oQ19KSVRPcGVyYXRpb25f RVN0LCBmdW5jdGlvblR5cGUoaW50UHRyLCBpbnRQdHIsIGludFB0cikpIFwKICAgICBtYWNybyhE X0pJVE9wZXJhdGlvbl9ELCBmdW5jdGlvblR5cGUoZG91YmxlVHlwZSwgZG91YmxlVHlwZSkpIFwK KyAgICBtYWNybyhEX0pJVE9wZXJhdGlvbl9ERCwgZnVuY3Rpb25UeXBlKGRvdWJsZVR5cGUsIGRv dWJsZVR5cGUsIGRvdWJsZVR5cGUpKSBcCiAgICAgbWFjcm8oSV9KSVRPcGVyYXRpb25fRUpzcywg ZnVuY3Rpb25UeXBlKGludFB0ciwgaW50UHRyLCBpbnRQdHIpKSBcCiAgICAgbWFjcm8oSl9KSVRP cGVyYXRpb25fRSwgZnVuY3Rpb25UeXBlKGludDY0LCBpbnRQdHIpKSBcCiAgICAgbWFjcm8oSl9K SVRPcGVyYXRpb25fRUEsIGZ1bmN0aW9uVHlwZShpbnQ2NCwgaW50UHRyLCBpbnRQdHIpKSBcCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE91dHB1dC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3V0cHV0LmgJKHJldmlzaW9uIDE2NTIxMCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3V0cHV0LmgJKHdvcmtpbmcgY29weSkK QEAgLTEyNyw3ICsxMjcsMTMgQEAgcHVibGljOgogICAgIExWYWx1ZSBkb3VibGVTdWIoTFZhbHVl IGxlZnQsIExWYWx1ZSByaWdodCkgeyByZXR1cm4gYnVpbGRGU3ViKG1fYnVpbGRlciwgbGVmdCwg cmlnaHQpOyB9CiAgICAgTFZhbHVlIGRvdWJsZU11bChMVmFsdWUgbGVmdCwgTFZhbHVlIHJpZ2h0 KSB7IHJldHVybiBidWlsZEZNdWwobV9idWlsZGVyLCBsZWZ0LCByaWdodCk7IH0KICAgICBMVmFs dWUgZG91YmxlRGl2KExWYWx1ZSBsZWZ0LCBMVmFsdWUgcmlnaHQpIHsgcmV0dXJuIGJ1aWxkRkRp dihtX2J1aWxkZXIsIGxlZnQsIHJpZ2h0KTsgfQotICAgIExWYWx1ZSBkb3VibGVSZW0oTFZhbHVl IGxlZnQsIExWYWx1ZSByaWdodCkgeyByZXR1cm4gYnVpbGRGUmVtKG1fYnVpbGRlciwgbGVmdCwg cmlnaHQpOyB9CisgICAgTFZhbHVlIGRvdWJsZVJlbShMVmFsdWUgbGVmdCwgTFZhbHVlIHJpZ2h0 KQorICAgIHsKKyAgICAgICAgLy8gRklYTUU6IExMVk0gbWF5IHNvZnRlbiBmbG9hdCBvcGVyYXRp b25zIGJlIGV4cGFuZGluZyB0aGVtIHRvIGxpYmNhbGxzLgorICAgICAgICAvLyBXZSBjYW5ub3Qg YWxsb3cgdGhhdCBvbiBhbGwgcGxhdGZvcm1zIHlldC4KKyAgICAgICAgLy8gPHJkYXI6Ly8xNjE5 NjQxMj4gTWFjaE8gbGFyZ2UgY29kZSBtb2RlbCBzdXBwb3J0LgorICAgICAgICByZXR1cm4gaXNY ODYoKSA/IGJ1aWxkRlJlbShtX2J1aWxkZXIsIGxlZnQsIHJpZ2h0KSA6IGNhbGwob3BlcmF0aW9u KGZtb2QpLCBsZWZ0LCByaWdodCk7CisgICAgfQogICAgIExWYWx1ZSBkb3VibGVOZWcoTFZhbHVl IHZhbHVlKSB7IHJldHVybiBidWlsZEZOZWcobV9idWlsZGVyLCB2YWx1ZSk7IH0KIAogICAgIExW YWx1ZSBiaXRBbmQoTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkgeyByZXR1cm4gYnVpbGRBbmQo bV9idWlsZGVyLCBsZWZ0LCByaWdodCk7IH0K 226140 2014-03-07 11:23:36 -0800 2014-03-07 12:13:42 -0800 Patch bug-129865-20140307112335.patch text/plain 1459 atrick SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MjczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAzLTA3ICBBbmRyZXcgVHJpY2sgIDxhdHJpY2tAYXBwbGUuY29tPgorCisgICAgICAg IENvcnJlY3QgYSBjb21tZW50IHR5cG8gZnJvbToKKyAgICAgICAgRkxUIHNob3VsZCBjYWxsIGZt b2QgZGlyZWN0bHkgb24gcGxhdGZvcm1zIHdoZXJlIExMVk0gY2Fubm90IHJlbG9jYXRlIHRoZSBs aWJjYWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mjk4NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZ0bC9GVExPdXRwdXQuaDoKKyAgICAgICAgKEpTQzo6RlRMOjpPdXRwdXQ6OmRvdWJsZVJlbSk6 CisKIDIwMTQtMDMtMDcgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K IAogICAgICAgICBVc2UgT3duUHRyIGluIFN0cnVjdHVyZUlEVGFibGUKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMT3V0cHV0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExPdXRwdXQuaAkocmV2aXNpb24gMTY1MjczKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExPdXRwdXQuaAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDcgKzEy OSw3IEBAIHB1YmxpYzoKICAgICBMVmFsdWUgZG91YmxlRGl2KExWYWx1ZSBsZWZ0LCBMVmFsdWUg cmlnaHQpIHsgcmV0dXJuIGJ1aWxkRkRpdihtX2J1aWxkZXIsIGxlZnQsIHJpZ2h0KTsgfQogICAg IExWYWx1ZSBkb3VibGVSZW0oTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkKICAgICB7Ci0gICAg ICAgIC8vIEZJWE1FOiBMTFZNIG1heSBzb2Z0ZW4gZmxvYXQgb3BlcmF0aW9ucyBiZSBleHBhbmRp bmcgdGhlbSB0byBsaWJjYWxscy4KKyAgICAgICAgLy8gRklYTUU6IExMVk0gbWF5IHNvZnRlbiBm bG9hdCBvcGVyYXRpb25zIGJ5IGV4cGFuZGluZyB0aGVtIHRvIGxpYmNhbGxzLgogICAgICAgICAv LyBXZSBjYW5ub3QgYWxsb3cgdGhhdCBvbiBhbGwgcGxhdGZvcm1zIHlldC4KICAgICAgICAgLy8g PHJkYXI6Ly8xNjE5NjQxMj4gTWFjaE8gbGFyZ2UgY29kZSBtb2RlbCBzdXBwb3J0LgogICAgICAg ICByZXR1cm4gaXNYODYoKSA/IGJ1aWxkRlJlbShtX2J1aWxkZXIsIGxlZnQsIHJpZ2h0KSA6IGNh bGwob3BlcmF0aW9uKGZtb2QpLCBsZWZ0LCByaWdodCk7Cg==