129864 2014-03-06 22:13:38 -0800 Crash shortly after loading certain web pages 2014-03-08 00:27:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aegolden webkit-unassigned andersca commit-queue oldest_to_newest 988035 0 aegolden 2014-03-06 22:13:38 -0800 On "TOT" (I'm on commit c165e52), if I run Tools/Scripts/build-webkit --debug then Tools/Scripts/debug-safari --target-web-process and start loading web pages, pretty quickly I get the following crash. I've reproduced the crash loading google.com, stackoverflow.com, penny-arcade.com, and qwantz.com, even bugs.webkit.org. Oddly, I did not get the crash when I loaded www.webkit.org. The "didReceiveMessageFromInjectedBundle" call in the stack made me think it might be some extension issue, but I've uninstalled my Safari extensions and the crash persists. Previously I had installed AdBlock. Process: SafariForWebKitDevelopment [42652] Path: /Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment Identifier: com.apple.Safari Version: 6.1 (8537.71) Build Info: WebBrowser-7537071000000000~2 Code Type: X86-64 (Native) Parent Process: WebProcess [42649] User ID: 501 Date/Time: 2014-03-06 22:03:07.362 -0800 OS Version: Mac OS X 10.8.5 (12F45) Report Version: 10 Interval Since Last Report: 280533 sec Crashes Since Last Report: 51 Per-App Interval Since Last Report: 270765 sec Per-App Crashes Since Last Report: 23 Anonymous UUID: 23B030E1-A6C7-1FCB-07F6-BAEC7758EAE4 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Application Specific Information: Process Model: Single Web Process Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 ??? 000000000000000000 0 + 0 1 SecItemShim.dylib 0x0000000100005dcc WebKit::shimSecItemCopyMatching(__CFDictionary const*, void const**) + 44 2 com.apple.Safari.framework 0x000000010034217b getPasswordAndItem + 227 3 com.apple.Safari.framework 0x0000000100342265 WBSGetKeychainPassword + 20 4 com.apple.Safari.framework 0x000000010019de47 encryptionKey(signed char) + 85 5 com.apple.Safari.framework 0x000000010019dde4 -[FormDataController verifyKeychainAccessWithContentViewController:] + 80 6 com.apple.Safari.framework 0x000000010019bf5b -[FormDataController preFillActiveOrFirstLoginFormInViewController:metadataProvider:] + 347 7 com.apple.Safari.framework 0x000000010007fb51 Safari::BrowserContentViewController::didCollectFormMetadataForPreFillingForm(Safari::WK::Array const&, Safari::WK::Array const&) + 165 8 com.apple.Safari.framework 0x0000000100094b54 Safari::BrowserContentViewController::handleMessage(Safari::WK::String const&, Safari::WK::Type const&) + 872 9 com.apple.Safari.framework 0x000000010009c114 Safari::BrowserContextInjectedBundleClient::dispatchMessage(Safari::WK::String const&, Safari::WK::Type const&) + 48 10 com.apple.Safari.framework 0x0000000100115bc2 Safari::WK::didReceiveMessageFromInjectedBundle(OpaqueWKContext const*, OpaqueWKString const*, void const*, void const*) + 90 11 com.apple.WebKit2 0x0000000102f7075b WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle(WebKit::WebContext*, WTF::String const&, API::Object*) + 155 (WebContextInjectedBundleClient.cpp:41) 12 com.apple.WebKit2 0x0000000102f4e39d WebKit::WebContext::didReceiveMessageFromInjectedBundle(WTF::String const&, API::Object*) + 61 (WebContext.cpp:840) 13 com.apple.WebKit2 0x0000000102f4ed40 WebKit::WebContext::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) + 480 (WebContext.cpp:1043) 14 com.apple.WebKit2 0x0000000102f4edd7 non-virtual thunk to WebKit::WebContext::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) + 55 (WebContext.cpp:1048) 15 com.apple.WebKit2 0x0000000102ced4a8 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection*, IPC::MessageDecoder&) + 216 (MessageReceiverMap.cpp:83) 16 com.apple.WebKit2 0x0000000102f4eaf7 WebKit::WebContext::dispatchMessage(IPC::Connection*, IPC::MessageDecoder&) + 55 (WebContext.cpp:1018) 17 com.apple.WebKit2 0x00000001031eddde WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) + 110 (WebProcessProxy.cpp:355) 18 com.apple.WebKit2 0x00000001031edec7 non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) + 55 (WebProcessProxy.cpp:364) 19 com.apple.WebKit2 0x0000000102b35333 IPC::Connection::dispatchMessage(IPC::MessageDecoder&) + 51 (Connection.cpp:777) 20 com.apple.WebKit2 0x0000000102b2d470 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 368 (Connection.cpp:797) 21 com.apple.WebKit2 0x0000000102b350c1 IPC::Connection::dispatchOneMessage() + 1377 (Connection.cpp:823) 22 com.apple.WebKit2 0x0000000102b432c2 WTF::FunctionWrapper<void (IPC::Connection::*)()>::operator()(IPC::Connection*) + 114 (Functional.h:218) 23 com.apple.WebKit2 0x0000000102b43245 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (IPC::Connection::*)()>, void (IPC::Connection*)>::operator()() + 53 (Functional.h:496) 24 com.apple.WebKit2 0x0000000102b4afd2 WTF::Function<void ()>::operator()() const + 114 (Functional.h:704) 25 com.apple.WebKit2 0x0000000102b4af4c std::__1::__function::__func<WTF::Function<void ()>, std::__1::allocator<WTF::Function<void ()> >, void ()()>::operator()() + 60 (functional:1059) 26 com.apple.JavaScriptCore 0x000000010110d26a std::__1::function<void ()>::operator()() const + 26 (functional:1435) 27 com.apple.JavaScriptCore 0x000000010111c834 WTF::RunLoop::performWork() + 276 (RunLoop.cpp:106) 28 com.apple.JavaScriptCore 0x000000010111dcd4 WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38) 29 com.apple.CoreFoundation 0x00007fff97b3bb31 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 30 com.apple.CoreFoundation 0x00007fff97b3b455 __CFRunLoopDoSources0 + 245 31 com.apple.CoreFoundation 0x00007fff97b5e7f5 __CFRunLoopRun + 789 32 com.apple.CoreFoundation 0x00007fff97b5e0e2 CFRunLoopRunSpecific + 290 33 com.apple.HIToolbox 0x00007fff930bbeb4 RunCurrentEventLoopInMode + 209 34 com.apple.HIToolbox 0x00007fff930bbc52 ReceiveNextEventCommon + 356 35 com.apple.HIToolbox 0x00007fff930bbae3 BlockUntilNextEventMatchingListInMode + 62 36 com.apple.AppKit 0x00007fff934e2533 _DPSNextEvent + 685 37 com.apple.AppKit 0x00007fff934e1df2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128 38 com.apple.Safari.framework 0x00000001000664cf -[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 161 39 com.apple.AppKit 0x00007fff934d91a3 -[NSApplication run] + 517 40 com.apple.AppKit 0x00007fff9347dbd6 NSApplicationMain + 869 41 com.apple.Safari.framework 0x00000001002294fc SafariMain + 266 42 libdyld.dylib 0x00007fff929337e1 start + 1 988039 1 226086 aegolden 2014-03-06 22:28:48 -0800 Created attachment 226086 Patch prevents shimSecItem{CopyMatching,Add,Update,Delete} from trying to use NULL implementations Patch prevents the crash by guarding various methods against calling implementations from the secItemShimCallbacks struct when those implementations are NULL. I'm actually not sure what the most appropriate OSStatus return value is when the callback is NULL. errSecUnimplemented seemed pretty good, but maybe there's a better/more standard one. 988041 2 226088 aegolden 2014-03-06 22:38:34 -0800 Created attachment 226088 Same as the other patch, but remembered to include a new ChangeLog entry. 988042 3 andersca 2014-03-06 22:41:07 -0800 I don't think this is correct. A null shim function indicates a serious problem (like the initialization function never being called). 988053 4 aegolden 2014-03-06 23:50:57 -0800 Is it weird that shimSecItemCopyMatching is being called from the SafariForWebKitDevelopment process itself? I see WebKitSecItemShimInitialize called from within the child WebProcess, but not from within the SafariForWebKitDevelopment process. 988262 5 aegolden 2014-03-07 12:24:41 -0800 The bug disappeared when I rolled back my local patch. I wonder if when I got past the crash the first time (with the r- patch) some state was saved that prevents the troublesome code path from executing on subsequent launches. 988311 6 aegolden 2014-03-07 13:28:53 -0800 I was able to reproduce the bug again by running Tools/Scripts/debug-safari --target-web-process instead of Tools/Scripts/run-safari --debug. The WebProcess is hitting the shim initializer (WebKitSecItemShimInitialize) with non-NULL callbacks, but the SafariForWebkitDevelopment process *itself* is calling shimSecItemCopyMatching, and the shim struct used by the SafariForWebkitDevelopment process is empty (all callbacks NULL). 988444 7 226189 aegolden 2014-03-07 17:12:14 -0800 Created attachment 226189 Prevents processes spawned by WebProcess from trying to insert SecItem shim. The trouble here is that SafariForWebkitDevelopment (spawned by WebProcess) is *itself* trying to call functions in SecItemShimLibrary.mm, but the secItemShimCallbacks struct is initialized only in the WebProcess. The spawned processes shouldn't be in this code at all. 988518 8 226189 commit-queue 2014-03-08 00:27:17 -0800 Comment on attachment 226189 Prevents processes spawned by WebProcess from trying to insert SecItem shim. Clearing flags on attachment: 226189 Committed r165329: <http://trac.webkit.org/changeset/165329> 988519 9 commit-queue 2014-03-08 00:27:19 -0800 All reviewed patches have been landed. Closing bug. 226086 2014-03-06 22:28:48 -0800 2014-03-07 17:12:14 -0800 Patch prevents shimSecItem{CopyMatching,Add,Update,Delete} from trying to use NULL implementations patch.txt text/plain 1697 aegolden ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1NlY0l0ZW1TaGltTGli cmFyeS5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1NlY0l0ZW1TaGltTGlicmFy eS5tbQppbmRleCA2NWUwNmY1Li4zYjhjOTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL21hYy9TZWNJdGVtU2hpbUxpYnJhcnkubW0KKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9tYWMvU2VjSXRlbVNoaW1MaWJyYXJ5Lm1tCkBAIC0zOSwyMiArMzksMzggQEAg c3RhdGljIFNlY0l0ZW1TaGltQ2FsbGJhY2tzIHNlY0l0ZW1TaGltQ2FsbGJhY2tzOwogCiBzdGF0 aWMgT1NTdGF0dXMgc2hpbVNlY0l0ZW1Db3B5TWF0Y2hpbmcoQ0ZEaWN0aW9uYXJ5UmVmIHF1ZXJ5 LCBDRlR5cGVSZWYqIHJlc3VsdCkKIHsKLSAgICByZXR1cm4gc2VjSXRlbVNoaW1DYWxsYmFja3Mu c2VjSXRlbUNvcHlNYXRjaGluZyhxdWVyeSwgcmVzdWx0KTsKKyAgICBpZiAoc2VjSXRlbVNoaW1D YWxsYmFja3Muc2VjSXRlbUNvcHlNYXRjaGluZykgeworICAgICAgICByZXR1cm4gc2VjSXRlbVNo aW1DYWxsYmFja3Muc2VjSXRlbUNvcHlNYXRjaGluZyhxdWVyeSwgcmVzdWx0KTsKKyAgICB9IGVs c2UgeworICAgICAgICByZXR1cm4gZXJyU2VjVW5pbXBsZW1lbnRlZDsKKyAgICB9CiB9CiAKIHN0 YXRpYyBPU1N0YXR1cyBzaGltU2VjSXRlbUFkZChDRkRpY3Rpb25hcnlSZWYgcXVlcnksIENGVHlw ZVJlZiogcmVzdWx0KQogewotICAgIHJldHVybiBzZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVt QWRkKHF1ZXJ5LCByZXN1bHQpOworICAgIGlmIChzZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVt QWRkKSB7CisgICAgICAgIHJldHVybiBzZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVtQWRkKHF1 ZXJ5LCByZXN1bHQpOworICAgIH0gZWxzZSB7CisgICAgICAgIHJldHVybiBlcnJTZWNVbmltcGxl bWVudGVkOworICAgIH0KIH0KIAogc3RhdGljIE9TU3RhdHVzIHNoaW1TZWNJdGVtVXBkYXRlKENG RGljdGlvbmFyeVJlZiBxdWVyeSwgQ0ZEaWN0aW9uYXJ5UmVmIGF0dHJpYnV0ZXNUb1VwZGF0ZSkK IHsKLSAgICByZXR1cm4gc2VjSXRlbVNoaW1DYWxsYmFja3Muc2VjSXRlbVVwZGF0ZShxdWVyeSwg YXR0cmlidXRlc1RvVXBkYXRlKTsKKyAgICBpZiAoc2VjSXRlbVNoaW1DYWxsYmFja3Muc2VjSXRl bVVwZGF0ZSkgeworICAgICAgICByZXR1cm4gc2VjSXRlbVNoaW1DYWxsYmFja3Muc2VjSXRlbVVw ZGF0ZShxdWVyeSwgYXR0cmlidXRlc1RvVXBkYXRlKTsKKyAgICB9IGVsc2UgeworICAgICAgICBy ZXR1cm4gZXJyU2VjVW5pbXBsZW1lbnRlZDsKKyAgICB9CiB9CiAKIHN0YXRpYyBPU1N0YXR1cyBz aGltU2VjSXRlbURlbGV0ZShDRkRpY3Rpb25hcnlSZWYgcXVlcnkpCiB7Ci0gICAgcmV0dXJuIHNl Y0l0ZW1TaGltQ2FsbGJhY2tzLnNlY0l0ZW1EZWxldGUocXVlcnkpOworICAgIGlmIChzZWNJdGVt U2hpbUNhbGxiYWNrcy5zZWNJdGVtRGVsZXRlKSB7CisgICAgICAgIHJldHVybiBzZWNJdGVtU2hp bUNhbGxiYWNrcy5zZWNJdGVtRGVsZXRlKHF1ZXJ5KTsKKyAgICB9IGVsc2UgeworICAgICAgICBy ZXR1cm4gZXJyU2VjVW5pbXBsZW1lbnRlZDsKKyAgICB9CiB9CiAKIERZTERfSU5URVJQT1NFKHNo aW1TZWNJdGVtQ29weU1hdGNoaW5nLCBTZWNJdGVtQ29weU1hdGNoaW5nKQo= 226088 2014-03-06 22:38:34 -0800 2014-03-07 17:12:14 -0800 Same as the other patch, but remembered to include a new ChangeLog entry. PatchWithChangeLog.txt text/plain 2410 aegolden ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ZjE3YzZkLi5iYjhlOTVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDMtMDYgIEFhcm9uIEdvbGRlbiAgPGdvbGRlbkBpbmtsaW5nLmNvbT4KKworICAg ICAgICBQYXRjaCBwcmV2ZW50cyBzaGltU2VjSXRlbSogZnJvbSBjYWxsaW5nIE5VTEwgZnVuY3Rp b25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4 NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YlByb2Nlc3MvbWFjL1NlY0l0ZW1TaGltTGlicmFyeS5tbToKKyAgICAgICAgKFdlYktpdDo6c2hp bVNlY0l0ZW1Db3B5TWF0Y2hpbmcpOgorICAgICAgICAoV2ViS2l0OjpzaGltU2VjSXRlbUFkZCk6 CisgICAgICAgIChXZWJLaXQ6OnNoaW1TZWNJdGVtVXBkYXRlKToKKyAgICAgICAgKFdlYktpdDo6 c2hpbVNlY0l0ZW1EZWxldGUpOgorCiAyMDE0LTAzLTA2ICBIeW93b24gS2ltICA8aHcxMDA4Lmtp bUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBNb3ZlIEV2YXNHTCBjbGFzc2VzIGZyb20g V2ViS2l0IHRvIFdlYkNvcmUgbmFtZXNwYWNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9tYWMvU2VjSXRlbVNoaW1MaWJyYXJ5Lm1tIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9tYWMvU2VjSXRlbVNoaW1MaWJyYXJ5Lm1tCmluZGV4IDY1ZTA2ZjUuLjNiOGM5M2Qg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1NlY0l0ZW1TaGltTGli cmFyeS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9TZWNJdGVtU2hpbUxp YnJhcnkubW0KQEAgLTM5LDIyICszOSwzOCBAQCBzdGF0aWMgU2VjSXRlbVNoaW1DYWxsYmFja3Mg c2VjSXRlbVNoaW1DYWxsYmFja3M7CiAKIHN0YXRpYyBPU1N0YXR1cyBzaGltU2VjSXRlbUNvcHlN YXRjaGluZyhDRkRpY3Rpb25hcnlSZWYgcXVlcnksIENGVHlwZVJlZiogcmVzdWx0KQogewotICAg IHJldHVybiBzZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVtQ29weU1hdGNoaW5nKHF1ZXJ5LCBy ZXN1bHQpOworICAgIGlmIChzZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVtQ29weU1hdGNoaW5n KSB7CisgICAgICAgIHJldHVybiBzZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVtQ29weU1hdGNo aW5nKHF1ZXJ5LCByZXN1bHQpOworICAgIH0gZWxzZSB7CisgICAgICAgIHJldHVybiBlcnJTZWNV bmltcGxlbWVudGVkOworICAgIH0KIH0KIAogc3RhdGljIE9TU3RhdHVzIHNoaW1TZWNJdGVtQWRk KENGRGljdGlvbmFyeVJlZiBxdWVyeSwgQ0ZUeXBlUmVmKiByZXN1bHQpCiB7Ci0gICAgcmV0dXJu IHNlY0l0ZW1TaGltQ2FsbGJhY2tzLnNlY0l0ZW1BZGQocXVlcnksIHJlc3VsdCk7CisgICAgaWYg KHNlY0l0ZW1TaGltQ2FsbGJhY2tzLnNlY0l0ZW1BZGQpIHsKKyAgICAgICAgcmV0dXJuIHNlY0l0 ZW1TaGltQ2FsbGJhY2tzLnNlY0l0ZW1BZGQocXVlcnksIHJlc3VsdCk7CisgICAgfSBlbHNlIHsK KyAgICAgICAgcmV0dXJuIGVyclNlY1VuaW1wbGVtZW50ZWQ7CisgICAgfQogfQogCiBzdGF0aWMg T1NTdGF0dXMgc2hpbVNlY0l0ZW1VcGRhdGUoQ0ZEaWN0aW9uYXJ5UmVmIHF1ZXJ5LCBDRkRpY3Rp b25hcnlSZWYgYXR0cmlidXRlc1RvVXBkYXRlKQogewotICAgIHJldHVybiBzZWNJdGVtU2hpbUNh bGxiYWNrcy5zZWNJdGVtVXBkYXRlKHF1ZXJ5LCBhdHRyaWJ1dGVzVG9VcGRhdGUpOworICAgIGlm IChzZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVtVXBkYXRlKSB7CisgICAgICAgIHJldHVybiBz ZWNJdGVtU2hpbUNhbGxiYWNrcy5zZWNJdGVtVXBkYXRlKHF1ZXJ5LCBhdHRyaWJ1dGVzVG9VcGRh dGUpOworICAgIH0gZWxzZSB7CisgICAgICAgIHJldHVybiBlcnJTZWNVbmltcGxlbWVudGVkOwor ICAgIH0KIH0KIAogc3RhdGljIE9TU3RhdHVzIHNoaW1TZWNJdGVtRGVsZXRlKENGRGljdGlvbmFy eVJlZiBxdWVyeSkKIHsKLSAgICByZXR1cm4gc2VjSXRlbVNoaW1DYWxsYmFja3Muc2VjSXRlbURl bGV0ZShxdWVyeSk7CisgICAgaWYgKHNlY0l0ZW1TaGltQ2FsbGJhY2tzLnNlY0l0ZW1EZWxldGUp IHsKKyAgICAgICAgcmV0dXJuIHNlY0l0ZW1TaGltQ2FsbGJhY2tzLnNlY0l0ZW1EZWxldGUocXVl cnkpOworICAgIH0gZWxzZSB7CisgICAgICAgIHJldHVybiBlcnJTZWNVbmltcGxlbWVudGVkOwor ICAgIH0KIH0KIAogRFlMRF9JTlRFUlBPU0Uoc2hpbVNlY0l0ZW1Db3B5TWF0Y2hpbmcsIFNlY0l0 ZW1Db3B5TWF0Y2hpbmcpCg== 226189 2014-03-07 17:12:14 -0800 2014-03-08 00:27:17 -0800 Prevents processes spawned by WebProcess from trying to insert SecItem shim. PreventSecItemShimInsertionInSpawnedProcess.txt text/plain 1823 aegolden ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwODg4NmI5Li5mZmY4YzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMDMtMDcgIEFhcm9uIEdvbGRlbiAgPGdvbGRlbkBpbmtsaW5nLmNvbT4KKworICAg ICAgICBQcmV2ZW50IHByb2Nlc3NlcyBzcGF3bmVkIGJ5IFdlYlByb2Nlc3MgZnJvbSB0cnlpbmcg dG8gaW5zZXJ0IHRoZSBTZWNJdGVtIHNoaW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvRW50cnlQb2ludC9tYWMvTGVnYWN5UHJv Y2Vzcy9XZWJDb250ZW50UHJvY2Vzc01haW4ubW06CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRl bnRQcm9jZXNzTWFpbkRlbGVnYXRlOjpkb1ByZUluaXRpYWxpemF0aW9uV29yayk6CisKIDIwMTQt MDMtMDcgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBs YWNlIHNldFN5c3RlbVdlYkdMTG9hZFBvbGljeSBBUEkgd2l0aCBtZXRob2RzIHRvIHF1ZXJ5IGZv ciBXZWJHTCBibG9ja2luZyBwb2xpY3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL0VudHJ5UG9pbnQvbWFjL0xlZ2FjeVByb2Nlc3MvV2ViQ29udGVudFByb2Nlc3NNYWlu Lm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9FbnRyeVBvaW50L21hYy9MZWdhY3lQcm9j ZXNzL1dlYkNvbnRlbnRQcm9jZXNzTWFpbi5tbQppbmRleCAyNzEzZDBlLi45YWRlOTEzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0VudHJ5UG9pbnQvbWFjL0xlZ2FjeVBy b2Nlc3MvV2ViQ29udGVudFByb2Nlc3NNYWluLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvRW50cnlQb2ludC9tYWMvTGVnYWN5UHJvY2Vzcy9XZWJDb250ZW50UHJvY2Vzc01haW4u bW0KQEAgLTY2LDkgKzY2LDEwIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBkb1ByZUlu aXRpYWxpemF0aW9uV29yaygpCiAgICAgewotICAgICAgICAvLyBSZW1vdmUgdGhlIFdlYlByb2Nl c3Mgc2hpbSBmcm9tIHRoZSBEWUxEX0lOU0VSVF9MSUJSQVJJRVMgZW52aXJvbm1lbnQgdmFyaWFi bGUgc28gYW55IHByb2Nlc3NlcyBzcGF3bmVkIGJ5Ci0gICAgICAgIC8vIHRoZSBXZWJQcm9jZXNz IGRvbid0IHRyeSB0byBpbnNlcnQgdGhlIHNoaW0gYW5kIGNyYXNoLgorICAgICAgICAvLyBSZW1v dmUgdGhlIFdlYlByb2Nlc3MgYW5kIFNlY0l0ZW0gc2hpbXMgZnJvbSB0aGUgRFlMRF9JTlNFUlRf TElCUkFSSUVTIGVudmlyb25tZW50IHZhcmlhYmxlIHNvIGFueSBwcm9jZXNzZXMKKyAgICAgICAg Ly8gc3Bhd25lZCBieSB0aGUgV2ViUHJvY2VzcyBkb24ndCB0cnkgdG8gaW5zZXJ0IHRoZSBzaGlt cyBhbmQgY3Jhc2guCiAgICAgICAgIEVudmlyb25tZW50VXRpbGl0aWVzOjpzdHJpcFZhbHVlc0Vu ZGluZ1dpdGhTdHJpbmcoIkRZTERfSU5TRVJUX0xJQlJBUklFUyIsICIvV2ViUHJvY2Vzc1NoaW0u ZHlsaWIiKTsKKyAgICAgICAgRW52aXJvbm1lbnRVdGlsaXRpZXM6OnN0cmlwVmFsdWVzRW5kaW5n V2l0aFN0cmluZygiRFlMRF9JTlNFUlRfTElCUkFSSUVTIiwgIi9TZWNJdGVtU2hpbS5keWxpYiIp OwogICAgIAogI2lmIFVTRShBUFBLSVQpCiAgICAgICAgIC8vIEluaXRpYWxpemUgQXBwS2l0Lgo=