129858 2014-03-06 18:27:09 -0800 JSGlobalContextRelease incorrectly handles saving/restoring IdentifierTable 2014-03-06 19:24:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 987992 0 mhahnenberg 2014-03-06 18:27:09 -0800 It was correct (but really ugly) prior to the combining of APIEntryShim and JSLock, but now it ends up overwriting the IdentifierTable. 987993 1 mhahnenberg 2014-03-06 18:27:52 -0800 <rdar://problem/15511394> 987994 2 226073 mhahnenberg 2014-03-06 18:29:57 -0800 Created attachment 226073 Patch 987996 3 226073 mark.lam 2014-03-06 18:40:05 -0800 Comment on attachment 226073 Patch r=me 987999 4 226073 commit-queue 2014-03-06 19:24:10 -0800 Comment on attachment 226073 Patch Clearing flags on attachment: 226073 Committed r165244: <http://trac.webkit.org/changeset/165244> 988000 5 commit-queue 2014-03-06 19:24:11 -0800 All reviewed patches have been landed. Closing bug. 226073 2014-03-06 18:29:57 -0800 2014-03-06 19:24:10 -0800 Patch bug-129858-20140306182912.patch text/plain 2031 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MjQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAzLTA2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSlNHbG9iYWxDb250ZXh0UmVsZWFzZSBpbmNvcnJlY3RseSBoYW5kbGVzIHNhdmlu Zy9yZXN0b3JpbmcgSWRlbnRpZmllclRhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJdCB3YXMgY29ycmVjdCAoYnV0IHJlYWxseSB1Z2x5KSBwcmlv ciB0byB0aGUgY29tYmluaW5nIG9mIEFQSUVudHJ5U2hpbSBhbmQgSlNMb2NrLCAKKyAgICAgICAg YnV0IG5vdyBpdCBlbmRzIHVwIG92ZXJ3cml0aW5nIHRoZSBJZGVudGlmaWVyVGFibGUgdGhhdCBK U0xvY2sganVzdCByZXN0b3JlZC4KKworICAgICAgICAqIEFQSS9KU0NvbnRleHRSZWYuY3BwOgor ICAgICAgICAoSlNHbG9iYWxDb250ZXh0UmVsZWFzZSk6CisKIDIwMTQtMDMtMDYgIE9saXZlciBI dW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggRlRMIGJ1aWxkLgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0UmVmLmNwcAkocmV2aXNpb24gMTY1 MjM0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNTUsMjEgKzE1NSwxNCBAQCBKU0dsb2JhbENvbnRleHRSZWYgSlNHbG9i YWxDb250ZXh0UmV0YWluCiAKIHZvaWQgSlNHbG9iYWxDb250ZXh0UmVsZWFzZShKU0dsb2JhbENv bnRleHRSZWYgY3R4KQogewotICAgIElkZW50aWZpZXJUYWJsZSogc2F2ZWRJZGVudGlmaWVyVGFi bGU7CiAgICAgRXhlY1N0YXRlKiBleGVjID0gdG9KUyhjdHgpOwotICAgIHsKLSAgICAgICAgSlNM b2NrSG9sZGVyIGxvY2tlcihleGVjKTsKLQotICAgICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwot ICAgICAgICBzYXZlZElkZW50aWZpZXJUYWJsZSA9IHd0ZlRocmVhZERhdGEoKS5zZXRDdXJyZW50 SWRlbnRpZmllclRhYmxlKHZtLmlkZW50aWZpZXJUYWJsZSk7Ci0KLSAgICAgICAgYm9vbCBwcm90 ZWN0Q291bnRJc1plcm8gPSBIZWFwOjpoZWFwKGV4ZWMtPnZtRW50cnlHbG9iYWxPYmplY3QoKSkt PnVucHJvdGVjdChleGVjLT52bUVudHJ5R2xvYmFsT2JqZWN0KCkpOwotICAgICAgICBpZiAocHJv dGVjdENvdW50SXNaZXJvKQotICAgICAgICAgICAgdm0uaGVhcC5yZXBvcnRBYmFuZG9uZWRPYmpl Y3RHcmFwaCgpOwotICAgICAgICB2bS5kZXJlZigpOwotICAgIH0KKyAgICBKU0xvY2tIb2xkZXIg bG9ja2VyKGV4ZWMpOwogCi0gICAgd3RmVGhyZWFkRGF0YSgpLnNldEN1cnJlbnRJZGVudGlmaWVy VGFibGUoc2F2ZWRJZGVudGlmaWVyVGFibGUpOworICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7Cisg ICAgYm9vbCBwcm90ZWN0Q291bnRJc1plcm8gPSBIZWFwOjpoZWFwKGV4ZWMtPnZtRW50cnlHbG9i YWxPYmplY3QoKSktPnVucHJvdGVjdChleGVjLT52bUVudHJ5R2xvYmFsT2JqZWN0KCkpOworICAg IGlmIChwcm90ZWN0Q291bnRJc1plcm8pCisgICAgICAgIHZtLmhlYXAucmVwb3J0QWJhbmRvbmVk T2JqZWN0R3JhcGgoKTsKKyAgICB2bS5kZXJlZigpOwogfQogCiBKU09iamVjdFJlZiBKU0NvbnRl eHRHZXRHbG9iYWxPYmplY3QoSlNDb250ZXh0UmVmIGN0eCkK