129855 2014-03-06 17:47:02 -0800 [GTK] buid-webkit should use CMake by default 2014-03-07 09:21:57 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson commit-queue dbates glenn pnormand oldest_to_newest 987972 0 mrobinson 2014-03-06 17:47:02 -0800 Developers and bots should use CMake by default when building WebKitGTK+. 988175 1 226130 mrobinson 2014-03-07 08:51:34 -0800 Created attachment 226130 Patch 988185 2 226130 cgarcia 2014-03-07 09:12:19 -0800 Comment on attachment 226130 Patch Ok, let's see how it goes, fingers crossed here. 988190 3 226130 mrobinson 2014-03-07 09:21:54 -0800 Comment on attachment 226130 Patch Clearing flags on attachment: 226130 Committed r165267: <http://trac.webkit.org/changeset/165267> 988191 4 mrobinson 2014-03-07 09:21:57 -0800 All reviewed patches have been landed. Closing bug. 226130 2014-03-07 08:51:34 -0800 2014-03-07 09:21:54 -0800 Patch bug-129855-20140307085134.patch text/plain 3304 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjExYjhmYjYyYTMwNmVmMTczN2NjOGE3Nzc0MDgyNTU5 ZDU1MGMyMi4uYTQ2YTViZmE0ZTYzN2JiOTNiYTNmNTE0ZGFhYTUyNTI4YjI0ZjA0ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTAzLTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBidWlkLXdlYmtpdCBzaG91bGQgdXNlIENNYWtlIGJ5IGRlZmF1bHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTg1NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgdGhl IENNYWtlIGJ1aWxkIHRoZSBkZWZhdWx0IEdUSysgYnVpbGQgd2hlbiB1c2luZyBidWlsZC13ZWJr aXQuIFRoaXMgd2lsbAorICAgICAgICBlbnN1cmUgdGhhdCBhbGwgYm90cyBhcmUgdXNpbmcgQ01h a2UuIFdlIGRvIHRoaXMgYnkgc3dhcHBpbmcgLS1ndGsgYW5kIC0tZ3RrY21ha2UsCisgICAgICAg IHNvIHRoYXQgd2UgaGF2ZSAtLWd0ayBhbmQgLS1ndGthdXRvdG9vbHMuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdGRpcnMucG06IFN3YXAgLS1ndGtjbWFrZS8tLWd0ayBmb3IgLS1ndGsvLS1n dGthdXRvdG9vbHMuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weTogRGl0 dG8uCisKIDIwMTQtMDMtMDYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtDTWFrZV0gW0dUS10gQnVpbGQgd2l0aCBuaW5qYSB3aGVuIGl0IGlzIGF2 YWlsYWJsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDZkMDY3NDlhNDJlY2U1NTRlZjE4ZWVlNGY4ZGYw MzdhOTUyM2ExYjcuLmZhMjdkNzRmMzkyMzNhY2Y1N2EyOTY4MmRjNGFkMjk5N2UzOTJmN2IgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0KQEAgLTM3NCw4ICszNzQsOCBAQCBzdWIgYXJndW1lbnRzRm9yQ29uZmln dXJhdGlvbigpCiAgICAgcHVzaChAYXJncywgJy0tcmVsZWFzZScpIGlmICgkY29uZmlndXJhdGlv biA9fiAiXlJlbGVhc2UiKTsKICAgICBwdXNoKEBhcmdzLCAnLS0zMi1iaXQnKSBpZiAoJGFyY2hp dGVjdHVyZSBuZSAieDg2XzY0IiBhbmQgIWlzV2luNjQoKSk7CiAgICAgcHVzaChAYXJncywgJy0t NjQtYml0JykgaWYgKGlzV2luNjQoKSk7Ci0gICAgcHVzaChAYXJncywgJy0tZ3RrJykgaWYgaXNH dGtBdXRvdG9vbHMoKTsKLSAgICBwdXNoKEBhcmdzLCAnLS1ndGtjbWFrZScpIGlmIGlzR3RrQ01h a2UoKTsKKyAgICBwdXNoKEBhcmdzLCAnLS1ndGthdXRvdG9vbHMnKSBpZiBpc0d0a0F1dG90b29s cygpOworICAgIHB1c2goQGFyZ3MsICctLWd0aycpIGlmIGlzR3RrQ01ha2UoKTsKICAgICBwdXNo KEBhcmdzLCAnLS1lZmwnKSBpZiBpc0VmbCgpOwogICAgIHB1c2goQGFyZ3MsICctLXdpbmNhaXJv JykgaWYgaXNXaW5DYWlybygpOwogICAgIHB1c2goQGFyZ3MsICctLXdpbmNlJykgaWYgaXNXaW5D RSgpOwpAQCAtOTQ1LDcgKzk0NSw3IEBAIHN1YiBpc0VmbCgpCiBzdWIgZGV0ZXJtaW5lSXNHdGtD TWFrZSgpCiB7CiAgICAgcmV0dXJuIGlmIGRlZmluZWQoJGlzR3RrQ01ha2UpOwotICAgICRpc0d0 a0NNYWtlID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLWd0a2NtYWtlIik7 CisgICAgJGlzR3RrQ01ha2UgPSBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0t Z3RrIik7CiB9CiAKIHN1YiBpc0d0a0NNYWtlKCkKQEAgLTk2OCw3ICs5NjgsNyBAQCBzdWIgaXNH dGsoKQogc3ViIGRldGVybWluZUlzR3RrQXV0b3Rvb2xzKCkKIHsKICAgICByZXR1cm4gaWYgZGVm aW5lZCgkaXNHdGtBdXRvdG9vbHMpOwotICAgICRpc0d0a0F1dG90b29scyA9IGNoZWNrRm9yQXJn dW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1ndGsiKTsKKyAgICAkaXNHdGtBdXRvdG9vbHMgPSBj aGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0tZ3RrYXV0b3Rvb2xzIik7CiB9CiAK IHN1YiBpc1dpbkNFKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9n dGsucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CmluZGV4IGJiM2MzMDA0 YTg2MjViMjJhZWEyYzFhMDk1Yzk5M2ZkZThiMTUzNjEuLjdjNzg5MjVkMmZhYzQxNWM1M2I1MGYx YWExNjYwZTBjMzMwZWZhNTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weQpAQCAtNzMs OSArNzMsOSBAQCBjbGFzcyBHdGtQb3J0KFBvcnQpOgogCiAgICAgZGVmIF9wb3J0X2ZsYWdfZm9y X3NjcmlwdHMoc2VsZik6CiAgICAgICAgIGlmIHNlbGYuX2lzX2NtYWtlX2J1aWxkKCk6Ci0gICAg ICAgICAgICByZXR1cm4gIi0tZ3RrY21ha2UiCi0gICAgICAgIGVsc2U6CiAgICAgICAgICAgICBy ZXR1cm4gIi0tZ3RrIgorICAgICAgICBlbHNlOgorICAgICAgICAgICAgcmV0dXJuICItLWd0a2F1 dG90b29scyIKIAogICAgIEBtZW1vaXplZAogICAgIGRlZiBfZHJpdmVyX2NsYXNzKHNlbGYpOgpA QCAtMjE1LDkgKzIxNSw5IEBAIGNsYXNzIEd0a1BvcnQoUG9ydCk6CiAgICAgZGVmIGJ1aWxkX3dl YmtpdF9jb21tYW5kKHNlbGYsIGJ1aWxkX3N0eWxlPU5vbmUpOgogICAgICAgICBjb21tYW5kID0g c3VwZXIoR3RrUG9ydCwgc2VsZikuYnVpbGRfd2Via2l0X2NvbW1hbmQoYnVpbGRfc3R5bGUpCiAg ICAgICAgIGlmIHNlbGYuX2lzX2NtYWtlX2J1aWxkKCk6Ci0gICAgICAgICAgICBjb21tYW5kLmV4 dGVuZChbIi0tZ3RrY21ha2UiLCAiLS11cGRhdGUtZ3RrIl0pCi0gICAgICAgIGVsc2U6CiAgICAg ICAgICAgICBjb21tYW5kLmV4dGVuZChbIi0tZ3RrIiwgIi0tdXBkYXRlLWd0ayJdKQorICAgICAg ICBlbHNlOgorICAgICAgICAgICAgY29tbWFuZC5leHRlbmQoWyItLWd0a2F1dG90b29scyIsICIt LXVwZGF0ZS1ndGsiXSkKIAogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ3dlYmtpdF90ZXN0 X3J1bm5lcicpOgogICAgICAgICAgICAgY29tbWFuZC5hcHBlbmQoIi0tbm8td2Via2l0MSIpCg==