129842 2014-03-06 16:10:54 -0800 [CSS Shapes] polygon y-value calc() args serialize incorrectly 2014-04-04 16:26:12 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98664 1 rhauck zoltan commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard zoltan oldest_to_newest 987930 0 rhauck 2014-03-06 16:10:54 -0800 The attached tests file tests a polygon that has a calc() y-value: polygon(10px calc(10in)) The inline style is serialized as: polygon(nonzero, calc(10in) 0.000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000022278417114) The correct serialization should be: polygon(10px calc(10in) The computed style is serializes as: polygon(nonzero, 960px ) The correct serialization should be: polygon(10px 960px) For both of these cases, the default fill-rule should also be omitted - that's logged as a separate bug: https://bugs.webkit.org/show_bug.cgi?id=129840. Note: I tested this with polygons with multiple vertices and it reproduces wherever the calc() y-value is on the arg list. Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing 987931 1 226058 rhauck 2014-03-06 16:11:17 -0800 Created attachment 226058 Test case for bug 997716 2 228626 zoltan 2014-04-04 15:44:58 -0700 Created attachment 228626 Patch 997722 3 228626 bjonesbe 2014-04-04 15:54:14 -0700 Comment on attachment 228626 Patch Global state is evil. Good catch. r=me 997744 4 228626 commit-queue 2014-04-04 16:26:08 -0700 Comment on attachment 228626 Patch Clearing flags on attachment: 228626 Committed r166813: <http://trac.webkit.org/changeset/166813> 997745 5 commit-queue 2014-04-04 16:26:12 -0700 All reviewed patches have been landed. Closing bug. 226058 2014-03-06 16:11:17 -0800 2014-03-06 16:11:17 -0800 Test case for bug parsing-shape-outside-polygon-calc-args.html text/html 1182 rhauck PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+CiAgICAgICAgPHNjcmlw dCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+ CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj cmlwdCI+CiAgICAgICAgICAgIHNldHVwKGZ1bmN0aW9uICgpIHsKICAgICAgICAgICAgICAgIHZh ciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKICAgICAgICAgICAgICAgIGRp di5pZCA9ICd0ZXN0JzsKICAgICAgICAgICAgICAgIGRpdi5zdHlsZS5zZXRQcm9wZXJ0eSgnLXdl YmtpdC1zaGFwZS1vdXRzaWRlJywgJ3BvbHlnb24oMTBweCBjYWxjKDEwaW4pKScpOwogICAgICAg ICAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkaXYpOwogICAgICAgICAgICB9KTsK ICAgICAgICAgICAgdGVzdChmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgIHZhciBkaXYgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpOwogICAgICAgICAgICAgICAgdmFyIGFjdHVh bCA9IGRpdi5zdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCctd2Via2l0LXNoYXBlLW91dHNpZGUnKTsK ICAgICAgICAgICAgICAgIGFzc2VydF9lcXVhbHMoYWN0dWFsLCAncG9seWdvbigxMHB4IGNhbGMo MTBpbikpJyk7CiAgICAgICAgICAgIH0sICdpbmxpbmUgc3R5bGUnKTsKICAgICAgICAgICAgdGVz dChmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgIHZhciBkaXYgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgndGVzdCcpOwogICAgICAgICAgICAgICAgdmFyIHN0eWxlID0gZ2V0Q29tcHV0ZWRT dHlsZShkaXYpOwogICAgICAgICAgICAgICAgdmFyIGFjdHVhbCA9IHN0eWxlLmdldFByb3BlcnR5 VmFsdWUoJy13ZWJraXQtc2hhcGUtb3V0c2lkZScpOwogICAgICAgICAgICAgICAgYXNzZXJ0X2Vx dWFscyhhY3R1YWwsICdwb2x5Z29uKDEwcHggOTYwcHgnKTsKICAgICAgICAgICAgICAgIGRvY3Vt ZW50LmJvZHkucmVtb3ZlQ2hpbGQoZGl2KTsKICAgICAgICAgICAgfSwgJ2NvbXB1dGVkIHN0eWxl Jyk7CiAgICAgICAgPC9zY3JpcHQ+CiAgICA8L2JvZHk+CjwvaHRtbD4K 228626 2014-04-04 15:44:58 -0700 2014-04-04 16:26:07 -0700 Patch fixcalc.patch text/plain 4987 zoltan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZGJmMzc3Li4wNTQ0M2E4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDQt MDQgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBT aGFwZXNdIHBvbHlnb24geS12YWx1ZSBjYWxjKCkgYXJncyBzZXJpYWxpemUgaW5jb3JyZWN0bHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTg0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9z aGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLW91dHNpZGUtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIGZhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy10ZXN0LXV0aWxzLmpzOgorCiAyMDE0LTA0 LTA0ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1NS ZWdpb25zXSBSZWdpb24ncyBiZWhhdmlvdXIgbm90IHVwZGF0ZWQgd2hlbiBiZWNvbWluZyB2YWxp ZCBmcm9tIGludmFsaWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNp bmcvcGFyc2luZy1zaGFwZS1vdXRzaWRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv c2hhcGVzL3BhcnNpbmcvcGFyc2luZy1zaGFwZS1vdXRzaWRlLWV4cGVjdGVkLnR4dAppbmRleCA1 MTA4ODdiLi43Njg5MTY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJz aW5nL3BhcnNpbmctc2hhcGUtb3V0c2lkZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLW91dHNpZGUtZXhwZWN0ZWQudHh0CkBA IC0xMjcsNiArMTI3LDEwIEBAIFBBU1MgZ2V0Q1NTVGV4dCgiLXdlYmtpdC1zaGFwZS1vdXRzaWRl IiwgInBvbHlnb24oZXZlbm9kZCwgMTBweCAyMHB4LCAzMHB4IDQwcHgsCiBQQVNTIGdldENvbXB1 dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1vdXRzaWRlIiwgInBvbHlnb24oZXZlbm9kZCwg MTBweCAyMHB4LCAzMHB4IDQwcHgsIDQwcHggNTBweCkiKSBpcyAicG9seWdvbihldmVub2RkLCAx MHB4IDIwcHgsIDMwcHggNDBweCwgNDBweCA1MHB4KSIKIFBBU1MgZ2V0Q1NTVGV4dCgiLXdlYmtp dC1zaGFwZS1vdXRzaWRlIiwgInBvbHlnb24obm9uemVybywgMTBweCAyMHB4LCAzMHB4IDQwcHgs IDQwcHggNTBweCkiKSBpcyAicG9seWdvbigxMHB4IDIwcHgsIDMwcHggNDBweCwgNDBweCA1MHB4 KSIKIFBBU1MgZ2V0Q29tcHV0ZWRTdHlsZVZhbHVlKCItd2Via2l0LXNoYXBlLW91dHNpZGUiLCAi cG9seWdvbihub256ZXJvLCAxMHB4IDIwcHgsIDMwcHggNDBweCwgNDBweCA1MHB4KSIpIGlzICJw b2x5Z29uKDEwcHggMjBweCwgMzBweCA0MHB4LCA0MHB4IDUwcHgpIgorUEFTUyBnZXRDU1NUZXh0 KCItd2Via2l0LXNoYXBlLW91dHNpZGUiLCAicG9seWdvbigxMHB4IGNhbGMoMTBpbikpIikgaXMg InBvbHlnb24oMTBweCBjYWxjKDEwaW4pKSIKK1BBU1MgZ2V0Q29tcHV0ZWRTdHlsZVZhbHVlKCIt d2Via2l0LXNoYXBlLW91dHNpZGUiLCAicG9seWdvbigxMHB4IGNhbGMoMTBpbikpIikgaXMgInBv bHlnb24oMTBweCA5NjBweCkiCitQQVNTIGdldENTU1RleHQoIi13ZWJraXQtc2hhcGUtb3V0c2lk ZSIsICJwb2x5Z29uKGNhbGMoMTBpbikgMTBweCkiKSBpcyAicG9seWdvbihjYWxjKDEwaW4pIDEw cHgpIgorUEFTUyBnZXRDb21wdXRlZFN0eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUtb3V0c2lkZSIs ICJwb2x5Z29uKGNhbGMoMTBpbikgMTBweCkiKSBpcyAicG9seWdvbig5NjBweCAxMHB4KSIKIFBB U1MgZ2V0Q1NTVGV4dCgiLXdlYmtpdC1zaGFwZS1vdXRzaWRlIiwgImNvbnRlbnQtYm94IikgaXMg ImNvbnRlbnQtYm94IgogUEFTUyBnZXRDb21wdXRlZFN0eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUt b3V0c2lkZSIsICJjb250ZW50LWJveCIpIGlzICJjb250ZW50LWJveCIKIFBBU1MgZ2V0Q1NTVGV4 dCgiLXdlYmtpdC1zaGFwZS1vdXRzaWRlIiwgInBhZGRpbmctYm94IikgaXMgInBhZGRpbmctYm94 IgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXRl c3QtdXRpbHMuanMgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctdGVz dC11dGlscy5qcwppbmRleCA3NGIxMzI1Li4xZWU3ZGEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctdGVzdC11dGlscy5qcworKysgYi9MYXlvdXRU ZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctdGVzdC11dGlscy5qcwpAQCAtNzEsNiAr NzEsOCBAQCB2YXIgdmFsaWRTaGFwZVZhbHVlcyA9IFsKICAgICBbInBvbHlnb24oMTBweCAyMHB4 LCAzMHB4IDQwcHgsIDQwcHggNTBweCkiLCAicG9seWdvbigxMHB4IDIwcHgsIDMwcHggNDBweCwg NDBweCA1MHB4KSJdLAogICAgIFsicG9seWdvbihldmVub2RkLCAxMHB4IDIwcHgsIDMwcHggNDBw eCwgNDBweCA1MHB4KSIsICJwb2x5Z29uKGV2ZW5vZGQsIDEwcHggMjBweCwgMzBweCA0MHB4LCA0 MHB4IDUwcHgpIl0sCiAgICAgWyJwb2x5Z29uKG5vbnplcm8sIDEwcHggMjBweCwgMzBweCA0MHB4 LCA0MHB4IDUwcHgpIiwgInBvbHlnb24oMTBweCAyMHB4LCAzMHB4IDQwcHgsIDQwcHggNTBweCki XSwKKyAgICBbInBvbHlnb24oMTBweCBjYWxjKDEwaW4pKSIsICJwb2x5Z29uKDEwcHggY2FsYygx MGluKSkiLCAicG9seWdvbigxMHB4IDk2MHB4KSJdLAorICAgIFsicG9seWdvbihjYWxjKDEwaW4p IDEwcHgpIiwgInBvbHlnb24oY2FsYygxMGluKSAxMHB4KSIsICJwb2x5Z29uKDk2MHB4IDEwcHgp Il0sCiAKICAgICAiY29udGVudC1ib3giLAogICAgICJwYWRkaW5nLWJveCIsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggYzFhYzc3Yy4uNTZlYjM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA0 LTA0ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtDU1Mg U2hhcGVzXSBwb2x5Z29uIHktdmFsdWUgY2FsYygpIGFyZ3Mgc2VyaWFsaXplIGluY29ycmVjdGx5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4NDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29k ZSBoaXQgQVNTRVJUKGlzQ2FsY3VsYXRpb24odmFsdWUpKSBpbiBDU1NQYXJzZXI6OmNyZWF0ZVBy aW1pdGl2ZU51bWJlcmljVmFsdWUsIGJlY2F1c2UKKyAgICAgICAgQ1NTUGFyc2VyOjp2YWxpZFVu aXQgaGFkIGJlZW4gY2FsbGVkIG9uIGJvdGggY29vcmRpbmF0ZXMsIHdoaWNoIHNldCB0aGUgdmFs dWUgZm9yIG1fcGFyc2VkQ2FsY3VsYXRpb24sCisgICAgICAgIGJ1dCBvbmx5IG9uZSBvZiB0aGUg Y29vcmRpbmF0ZXMgd2FzIGNhbGN1bGF0aW9uIHZhbHVlLiBJIHJlb3JkZXJlZCBjYWxsaW5nIHZh bHVkVW5pdCBhbmQKKyAgICAgICAgY3JlYXRlUHJpbWl0aXZlTnVtYmVyaWNWYWx1ZSB0byBiZSBj YWxsZWQgaW4gdGhlIGNvcnJlY3Qgb3JkZXIgb24gdGhlIGNvb3JkaW5hdGVzLgorCisgICAgICAg IEkgYWRkZWQgdGhlIG5ldyB0ZXN0IGNhc2UgdG8gcGFyc2luZy10ZXN0LXV0aWxzLmpzLgorCisg ICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6 OnBhcnNlQmFzaWNTaGFwZVBvbHlnb24pOgorCiAyMDE0LTA0LTA0ICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIFVucmV2aWV3ZWQgdGVzdCBmaXgg KGNyYXNoIGluIGRlYnVnIGJ1aWxkKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNDVi NGMwYi4uZTRkMDAwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTU1OTUsMTQgKzU1 OTUsMTQgQEAgUGFzc1JlZlB0cjxDU1NCYXNpY1NoYXBlPiBDU1NQYXJzZXI6OnBhcnNlQmFzaWNT aGFwZVBvbHlnb24oQ1NTUGFyc2VyVmFsdWVMaXN0KgogCiAgICAgQ1NTUGFyc2VyVmFsdWUqIGFy Z3VtZW50WCA9IGFyZ3VtZW50OwogICAgIHdoaWxlIChhcmd1bWVudFgpIHsKKwogICAgICAgICBp ZiAoIXZhbGlkVW5pdChhcmd1bWVudFgsIEZMZW5ndGggfCBGUGVyY2VudCkpCiAgICAgICAgICAg ICByZXR1cm4gMDsKKyAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB4TGVuZ3RoID0g Y3JlYXRlUHJpbWl0aXZlTnVtZXJpY1ZhbHVlKGFyZ3VtZW50WCk7CiAKICAgICAgICAgQ1NTUGFy c2VyVmFsdWUqIGFyZ3VtZW50WSA9IGFyZ3MtPm5leHQoKTsKICAgICAgICAgaWYgKCFhcmd1bWVu dFkgfHwgIXZhbGlkVW5pdChhcmd1bWVudFksIEZMZW5ndGggfCBGUGVyY2VudCkpCiAgICAgICAg ICAgICByZXR1cm4gMDsKLQotICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHhMZW5n dGggPSBjcmVhdGVQcmltaXRpdmVOdW1lcmljVmFsdWUoYXJndW1lbnRYKTsKICAgICAgICAgUmVm UHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB5TGVuZ3RoID0gY3JlYXRlUHJpbWl0aXZlTnVtZXJpY1Zh bHVlKGFyZ3VtZW50WSk7CiAKICAgICAgICAgc2hhcGUtPmFwcGVuZFBvaW50KHhMZW5ndGgucmVs ZWFzZSgpLCB5TGVuZ3RoLnJlbGVhc2UoKSk7Cg==