129838 2014-03-06 15:29:51 -0800 [CSS Shapes] inset complex calc() args vanish in serialized computed style 2014-04-07 17:02:30 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98664 1 rhauck zoltan commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard zoltan oldest_to_newest 987904 0 rhauck 2014-03-06 15:29:51 -0800 The attached test file tests this: inset(calc(25%*3 - 10in)) getComputedStyle(div).getPropertyValue('-webkit-shape-outside') returns: inset( round 0px 0px 0px 0px / 0px 0px 0px 0px) The inset args completely vanish. Some additional info: - The inline style version of this test passes - If I drop the '- 10in' from the calc() the args don't vanish 987905 1 226049 rhauck 2014-03-06 15:30:25 -0800 Created attachment 226049 Test case for bug 987906 2 rhauck 2014-03-06 15:30:43 -0800 Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing 987914 3 226052 rhauck 2014-03-06 15:41:13 -0800 Created attachment 226052 fixed test case file (added prefixes) 998269 4 228766 zoltan 2014-04-07 16:02:46 -0700 Created attachment 228766 Patch 998275 5 228766 zoltan 2014-04-07 16:14:16 -0700 Comment on attachment 228766 Patch Note: the simplest serialization for shapes will be implemented in bug #129825. 998280 6 228766 bjonesbe 2014-04-07 16:23:41 -0700 Comment on attachment 228766 Patch r=me 998300 7 228766 commit-queue 2014-04-07 17:02:25 -0700 Comment on attachment 228766 Patch Clearing flags on attachment: 228766 Committed r166894: <http://trac.webkit.org/changeset/166894> 998301 8 commit-queue 2014-04-07 17:02:30 -0700 All reviewed patches have been landed. Closing bug. 226049 2014-03-06 15:30:25 -0800 2014-03-06 15:41:13 -0800 Test case for bug parsing-shape-outside-inset-complex-calc.html text/html 866 rhauck PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+CiAgICAgICAgPHNjcmlw dCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+ CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj cmlwdCI+CiAgICAgICAgICAgIHRlc3QoZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICB2YXIg dmFsdWUgPSAnaW5zZXQoY2FsYygyNSUqMyAtIDEwaW4pKSc7CiAgICAgICAgICAgICAgICB2YXIg ZXhwZWN0ZWQgPSAnaW5zZXQoY2FsYyg3NSUgLSA5NjBweCkpJzsgICAgICAgICAgICAgICAgCiAg ICAgICAgICAgICAgICB2YXIgZGl2ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CiAg ICAgICAgICAgICAgICBkaXYuc3R5bGUuc2V0UHJvcGVydHkoJ3NoYXBlLW91dHNpZGUnLCB2YWx1 ZSk7CiAgICAgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRpdik7CiAgICAg ICAgICAgICAgICB2YXIgc3R5bGUgPSBnZXRDb21wdXRlZFN0eWxlKGRpdik7CiAgICAgICAgICAg ICAgICB2YXIgYWN0dWFsID0gc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnc2hhcGUtb3V0c2lkZScp OwogICAgICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChkaXYpOwogICAgICAg ICAgICAgICAgYXNzZXJ0X2VxdWFscyhhY3R1YWwsIGV4cGVjdGVkKTsKICAgICAgICAgICAgfSwg J2luc2V0KGNhbGMoMjUlKjMgLSAxMGluKSknKTsKICAgICAgICA8L3NjcmlwdD4KICAgIDwvYm9k eT4KPC9odG1sPgo= 226052 2014-03-06 15:41:13 -0800 2014-03-06 15:41:13 -0800 fixed test case file (added prefixes) parsing-shape-outside-inset-complex-calc.html text/html 882 rhauck PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+CiAgICAgICAgPHNjcmlw dCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+ CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj cmlwdCI+CiAgICAgICAgICAgIHRlc3QoZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICB2YXIg dmFsdWUgPSAnaW5zZXQoY2FsYygyNSUqMyAtIDEwaW4pKSc7CiAgICAgICAgICAgICAgICB2YXIg ZXhwZWN0ZWQgPSAnaW5zZXQoY2FsYyg3NSUgLSA5NjBweCkpJzsgICAgICAgICAgICAgICAgCiAg ICAgICAgICAgICAgICB2YXIgZGl2ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CiAg ICAgICAgICAgICAgICBkaXYuc3R5bGUuc2V0UHJvcGVydHkoJy13ZWJraXQtc2hhcGUtb3V0c2lk ZScsIHZhbHVlKTsKICAgICAgICAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZGl2 KTsKICAgICAgICAgICAgICAgIHZhciBzdHlsZSA9IGdldENvbXB1dGVkU3R5bGUoZGl2KTsKICAg ICAgICAgICAgICAgIHZhciBhY3R1YWwgPSBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCctd2Via2l0 LXNoYXBlLW91dHNpZGUnKTsKICAgICAgICAgICAgICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hp bGQoZGl2KTsKICAgICAgICAgICAgICAgIGFzc2VydF9lcXVhbHMoYWN0dWFsLCBleHBlY3RlZCk7 CiAgICAgICAgICAgIH0sICdpbnNldChjYWxjKDI1JSozIC0gMTBpbikpJyk7CiAgICAgICAgPC9z Y3JpcHQ+CiAgICA8L2JvZHk+CjwvaHRtbD4K 228766 2014-04-07 16:02:46 -0700 2014-04-07 17:02:24 -0700 Patch fixInsetCalc.patch text/plain 5316 zoltan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYTYyYzJkLi40MjRiNjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDQt MDcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBT aGFwZXNdIGluc2V0IGNvbXBsZXggY2FsYygpIGFyZ3MgdmFuaXNoIGluIHNlcmlhbGl6ZWQgY29t cHV0ZWQgc3R5bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyOTgzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLW91dHNpZGUtZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGZhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy10ZXN0LXV0aWxzLmpz OgorCiAyMDE0LTA0LTA3ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBbRUZMXSBUdXJuIG9uIEVOQUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy1zaGFwZS1vdXRz aWRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2lu Zy1zaGFwZS1vdXRzaWRlLWV4cGVjdGVkLnR4dAppbmRleCAwM2JlODJlLi5iYmQ5MDM5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hhcGUtb3V0 c2lkZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9w YXJzaW5nLXNoYXBlLW91dHNpZGUtZXhwZWN0ZWQudHh0CkBAIC01NSw2ICs1NSw4IEBAIFBBU1Mg Z2V0Q1NTVGV4dCgiLXdlYmtpdC1zaGFwZS1vdXRzaWRlIiwgImluc2V0KDEwcHggMjBweCAzMHB4 IDQwcHggcm91bmQgNXB4IDZwCiBQQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1z aGFwZS1vdXRzaWRlIiwgImluc2V0KDEwcHggMjBweCAzMHB4IDQwcHggcm91bmQgNXB4IDZweCki KSBpcyAiaW5zZXQoMTBweCAyMHB4IDMwcHggNDBweCByb3VuZCA1cHggNnB4IDVweCA2cHggLyA1 cHggNnB4IDVweCA2cHgpIgogUEFTUyBnZXRDU1NUZXh0KCItd2Via2l0LXNoYXBlLW91dHNpZGUi LCAiaW5zZXQoMTBweCAyMHB4IDMwcHggNDBweCByb3VuZCA1cHggNnB4IDdweCA4cHggLyA1MHB4 IDYwcHggNzBweCA4MHB4KSIpIGlzICJpbnNldCgxMHB4IDIwcHggMzBweCA0MHB4IHJvdW5kIDVw eCA2cHggN3B4IDhweCAvIDUwcHggNjBweCA3MHB4IDgwcHgpIgogUEFTUyBnZXRDb21wdXRlZFN0 eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUtb3V0c2lkZSIsICJpbnNldCgxMHB4IDIwcHggMzBweCA0 MHB4IHJvdW5kIDVweCA2cHggN3B4IDhweCAvIDUwcHggNjBweCA3MHB4IDgwcHgpIikgaXMgImlu c2V0KDEwcHggMjBweCAzMHB4IDQwcHggcm91bmQgNXB4IDZweCA3cHggOHB4IC8gNTBweCA2MHB4 IDcwcHggODBweCkiCitQQVNTIGdldENTU1RleHQoIi13ZWJraXQtc2hhcGUtb3V0c2lkZSIsICJp bnNldChjYWxjKDI1JSozIC0gMTBpbikgMCAwIDApIikgaXMgImluc2V0KGNhbGMoNzUlIC0gMTBp bikgMHB4IDBweCAwcHgpIgorUEFTUyBnZXRDb21wdXRlZFN0eWxlVmFsdWUoIi13ZWJraXQtc2hh cGUtb3V0c2lkZSIsICJpbnNldChjYWxjKDI1JSozIC0gMTBpbikgMCAwIDApIikgaXMgImluc2V0 KGNhbGMoNzUlIC0gOTYwcHgpIDBweCAwcHggMHB4IHJvdW5kIDBweCAwcHggMHB4IDBweCAvIDBw eCAwcHggMHB4IDBweCkiCiBQQVNTIGdldENTU1RleHQoIi13ZWJraXQtc2hhcGUtb3V0c2lkZSIs ICJjaXJjbGUoKSIpIGlzICJjaXJjbGUoYXQgNTAlIDUwJSkiCiBQQVNTIGdldENvbXB1dGVkU3R5 bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1vdXRzaWRlIiwgImNpcmNsZSgpIikgaXMgImNpcmNsZShj bG9zZXN0LXNpZGUgYXQgNTAlIDUwJSkiCiBQQVNTIGdldENTU1RleHQoIi13ZWJraXQtc2hhcGUt b3V0c2lkZSIsICJjaXJjbGUoZmFydGhlc3Qtc2lkZSkiKSBpcyAiY2lyY2xlKGZhcnRoZXN0LXNp ZGUgYXQgNTAlIDUwJSkiCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJz aW5nL3BhcnNpbmctdGVzdC11dGlscy5qcyBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNp bmcvcGFyc2luZy10ZXN0LXV0aWxzLmpzCmluZGV4IDYxZTAwZDkuLmVkNzc2MjkgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy10ZXN0LXV0aWxzLmpz CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy10ZXN0LXV0aWxz LmpzCkBAIC0zMyw2ICszMyw4IEBAIHZhciB2YWxpZFNoYXBlVmFsdWVzID0gWwogICAgIFsiaW5z ZXQoMTBweCAyMHB4IDMwcHggNDBweCByb3VuZCA1cHggNnB4KSIsICJpbnNldCgxMHB4IDIwcHgg MzBweCA0MHB4IHJvdW5kIDVweCA2cHggNXB4IDZweCAvIDVweCA2cHggNXB4IDZweCkiLCAiaW5z ZXQoMTBweCAyMHB4IDMwcHggNDBweCByb3VuZCA1cHggNnB4IDVweCA2cHggLyA1cHggNnB4IDVw eCA2cHgpIl0sCiAgICAgImluc2V0KDEwcHggMjBweCAzMHB4IDQwcHggcm91bmQgNXB4IDZweCA3 cHggOHB4IC8gNTBweCA2MHB4IDcwcHggODBweCkiLAogCisgICAgWyJpbnNldChjYWxjKDI1JSoz IC0gMTBpbikgMCAwIDApIiwgImluc2V0KGNhbGMoNzUlIC0gMTBpbikgMHB4IDBweCAwcHgpIiwg Imluc2V0KGNhbGMoNzUlIC0gOTYwcHgpIDBweCAwcHggMHB4IHJvdW5kIDBweCAwcHggMHB4IDBw eCAvIDBweCAwcHggMHB4IDBweCkiXSwKKwogICAgIFsiY2lyY2xlKCkiLCAiY2lyY2xlKGF0IDUw JSA1MCUpIiwgImNpcmNsZShjbG9zZXN0LXNpZGUgYXQgNTAlIDUwJSkiXSwKICAgICBbImNpcmNs ZShmYXJ0aGVzdC1zaWRlKSIsICJjaXJjbGUoZmFydGhlc3Qtc2lkZSBhdCA1MCUgNTAlKSIsICJj aXJjbGUoZmFydGhlc3Qtc2lkZSBhdCA1MCUgNTAlKSJdLAogICAgIFsiY2lyY2xlKGNsb3Nlc3Qt c2lkZSkiLCAiY2lyY2xlKGNsb3Nlc3Qtc2lkZSBhdCA1MCUgNTAlKSIsICJjaXJjbGUoY2xvc2Vz dC1zaWRlIGF0IDUwJSA1MCUpIl0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RmOTdiNS4uOTI1MzY4YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTA3ICBab2x0YW4gSG9ydmF0aCAgPHpv bHRhbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtDU1MgU2hhcGVzXSBpbnNldCBjb21wbGV4IGNh bGMoKSBhcmdzIHZhbmlzaCBpbiBzZXJpYWxpemVkIGNvbXB1dGVkIHN0eWxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBkaWRuJ3QgcGFzcyB0aGUg c3R5bGUgcGFyYW1ldGVyIHdoZW4gc2V0dGluZyB0aGUgd2lkdGggbWVtYmVycyBvZiBDU1NCYXNp Y1NoYXBlSW5zZXQsCisgICAgICAgIHdoaWNoIGxlYWQgdG8gYSAnc2hvdWxkIG5ldmVyIHJlYWNo IGFzc2VydHRpb24nIGluIENTU1ByaW1pdGl2ZVZhbHVlOjppbml0LiBUaGlzIHBhdGNoCisgICAg ICAgIGFkZHMgdGhlIG1pc3NpbmcgcGFyYW1ldGVycyB0byB0aGUgY2FsbCBzaXRlcy4KKworICAg ICAgICBFeHRlbmRlZCBleGlzdGluZyBwYXJzaW5nIHRlc3Qgc2NyaXB0LgorCisgICAgICAgICog Y3NzL0Jhc2ljU2hhcGVGdW5jdGlvbnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dmFsdWVGb3JC YXNpY1NoYXBlKToKKwogMjAxNC0wNC0wNyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgW0VGTF0gVHVybiBvbiBFTkFCTEVfTUVESUFfQ09OVFJPTFNfU0NS SVBUCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQmFzaWNTaGFwZUZ1bmN0aW9ucy5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQmFzaWNTaGFwZUZ1bmN0aW9ucy5jcHAKaW5kZXggODkw NTI4Ni4uZjI3ODk0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0Jhc2ljU2hhcGVG dW5jdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9CYXNpY1NoYXBlRnVuY3Rpb25z LmNwcApAQCAtMTA3LDEwICsxMDcsMTAgQEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gdmFsdWVGb3JC YXNpY1NoYXBlKGNvbnN0IFJlbmRlclN0eWxlKiBzdHlsZSwgY29uc3QgQmFzaWNTaGEKICAgICAg ICAgY29uc3QgQmFzaWNTaGFwZUluc2V0KiBpbnNldCA9IHN0YXRpY19jYXN0PGNvbnN0IEJhc2lj U2hhcGVJbnNldCo+KGJhc2ljU2hhcGUpOwogICAgICAgICBSZWZQdHI8Q1NTQmFzaWNTaGFwZUlu c2V0PiBpbnNldFZhbHVlID0gQ1NTQmFzaWNTaGFwZUluc2V0OjpjcmVhdGUoKTsKIAotICAgICAg ICBpbnNldFZhbHVlLT5zZXRUb3AocG9vbC5jcmVhdGVWYWx1ZShpbnNldC0+dG9wKCkpKTsKLSAg ICAgICAgaW5zZXRWYWx1ZS0+c2V0UmlnaHQocG9vbC5jcmVhdGVWYWx1ZShpbnNldC0+cmlnaHQo KSkpOwotICAgICAgICBpbnNldFZhbHVlLT5zZXRCb3R0b20ocG9vbC5jcmVhdGVWYWx1ZShpbnNl dC0+Ym90dG9tKCkpKTsKLSAgICAgICAgaW5zZXRWYWx1ZS0+c2V0TGVmdChwb29sLmNyZWF0ZVZh bHVlKGluc2V0LT5sZWZ0KCkpKTsKKyAgICAgICAgaW5zZXRWYWx1ZS0+c2V0VG9wKHBvb2wuY3Jl YXRlVmFsdWUoaW5zZXQtPnRvcCgpLCBzdHlsZSkpOworICAgICAgICBpbnNldFZhbHVlLT5zZXRS aWdodChwb29sLmNyZWF0ZVZhbHVlKGluc2V0LT5yaWdodCgpLCBzdHlsZSkpOworICAgICAgICBp bnNldFZhbHVlLT5zZXRCb3R0b20ocG9vbC5jcmVhdGVWYWx1ZShpbnNldC0+Ym90dG9tKCksIHN0 eWxlKSk7CisgICAgICAgIGluc2V0VmFsdWUtPnNldExlZnQocG9vbC5jcmVhdGVWYWx1ZShpbnNl dC0+bGVmdCgpLCBzdHlsZSkpOwogCiAgICAgICAgIGluc2V0VmFsdWUtPnNldFRvcExlZnRSYWRp dXMocG9vbC5jcmVhdGVWYWx1ZShpbnNldC0+dG9wTGVmdFJhZGl1cygpKSk7CiAgICAgICAgIGlu c2V0VmFsdWUtPnNldFRvcFJpZ2h0UmFkaXVzKHBvb2wuY3JlYXRlVmFsdWUoaW5zZXQtPnRvcFJp Z2h0UmFkaXVzKCkpKTsK