129837 2014-03-06 15:21:38 -0800 detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail 2014-03-06 18:12:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 987900 0 mhahnenberg 2014-03-06 15:21:38 -0800 This is due to the following line: output = sshRead("cd #{$remoteDirectory}/#{$outputDir.basename}/.runner && (ls test_fail_* 2> /dev/null || true)") ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok. The fix is to use find instead of ls like we do in shell-runner.sh. 987909 1 226050 mhahnenberg 2014-03-06 15:35:19 -0800 Created attachment 226050 Patch 987956 2 226067 mhahnenberg 2014-03-06 17:24:50 -0800 Created attachment 226067 Patch 987981 3 226067 commit-queue 2014-03-06 18:12:54 -0800 Comment on attachment 226067 Patch Clearing flags on attachment: 226067 Committed r165239: <http://trac.webkit.org/changeset/165239> 987982 4 commit-queue 2014-03-06 18:12:56 -0800 All reviewed patches have been landed. Closing bug. 226050 2014-03-06 15:35:19 -0800 2014-03-06 17:24:49 -0800 Patch bug-129837-20140306153440.patch text/plain 1441 mhahnenberg SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NTIyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTAzLTA2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CisKKyAgICAgICAgZGV0ZWN0RmFpbHVyZXMgaW4gcnVuLWpzYy1zdHJlc3MtdGVzdHMg Y2FuIHJlcG9ydCBldmVyeXRoaW5nIHdhcyBvayBpZiB0b28gbWFueSB0ZXN0cyBmYWlsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4MzcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBscyB0ZXN0X2ZhaWxf KiBjYW4gZmFpbCBpZiB0aGVyZSBhcmUgdG9vIG1hbnkgZmlsZXMgdGhhdCBtYXRjaC4gV2UgdGhl biBzd2FsbG93IHRoYXQgZXJyb3IsIHdoaWNoIG1ha2VzIGV2ZXJ5dGhpbmcgc2VlbSBvay4KKyAg ICAgICAgVGhlIGZpeCBpcyB0byB1c2UgZmluZCBpbnN0ZWFkIG9mIGxzIGxpa2Ugd2UgZG8gaW4g c2hlbGwtcnVubmVyLnNoLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0 czoKKwogMjAxNC0wMy0wNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIEJ1aWxkIFdlYktpdDIgYmVmb3JlIGJ1aWxkaW5nIFdlYktpdApJbmRleDogVG9v bHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCShyZXZpc2lvbiAxNjUyMDUpCisrKyBUb29scy9TY3Jp cHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xMjE3LDcgKzEyMTcs NyBAQCBkZWYgZGV0ZWN0RmFpbHVyZXMKICAgICByYWlzZSBpZiAkYnVuZGxlCiAKICAgICBpZiAk cmVtb3RlCi0gICAgICAgIG91dHB1dCA9IHNzaFJlYWQoImNkICN7JHJlbW90ZURpcmVjdG9yeX0v I3skb3V0cHV0RGlyLmJhc2VuYW1lfS8ucnVubmVyICYmIChscyB0ZXN0X2ZhaWxfKiAyPiAvZGV2 L251bGwgfHwgdHJ1ZSkiKQorICAgICAgICBvdXRwdXQgPSBzc2hSZWFkKCJjZCAjeyRyZW1vdGVE aXJlY3Rvcnl9LyN7JG91dHB1dERpci5iYXNlbmFtZX0vLnJ1bm5lciAmJiAoZmluZCAuIC1uYW1l ICd0ZXN0X2ZhaWxfKicgLWRlcHRoIDEpIikKICAgICAgICAgb3V0cHV0LnNwbGl0KC9cbi8pLmVh Y2ggewogICAgICAgICAgICAgfCBsaW5lIHwKICAgICAgICAgICAgIG5leHQgdW5sZXNzIGxpbmUg PX4gL3Rlc3RfZmFpbF8vCg== 226067 2014-03-06 17:24:50 -0800 2014-03-06 18:12:54 -0800 Patch bug-129837-20140306172407.patch text/plain 1441 mhahnenberg SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NTIyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTAzLTA2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CisKKyAgICAgICAgZGV0ZWN0RmFpbHVyZXMgaW4gcnVuLWpzYy1zdHJlc3MtdGVzdHMg Y2FuIHJlcG9ydCBldmVyeXRoaW5nIHdhcyBvayBpZiB0b28gbWFueSB0ZXN0cyBmYWlsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4MzcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBscyB0ZXN0X2ZhaWxf KiBjYW4gZmFpbCBpZiB0aGVyZSBhcmUgdG9vIG1hbnkgZmlsZXMgdGhhdCBtYXRjaC4gV2UgdGhl biBzd2FsbG93IHRoYXQgZXJyb3IsIHdoaWNoIG1ha2VzIGV2ZXJ5dGhpbmcgc2VlbSBvay4KKyAg ICAgICAgVGhlIGZpeCBpcyB0byB1c2UgZmluZCBpbnN0ZWFkIG9mIGxzIGxpa2Ugd2UgZG8gaW4g c2hlbGwtcnVubmVyLnNoLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0 czoKKwogMjAxNC0wMy0wNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIEJ1aWxkIFdlYktpdDIgYmVmb3JlIGJ1aWxkaW5nIFdlYktpdApJbmRleDogVG9v bHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCShyZXZpc2lvbiAxNjUyMDUpCisrKyBUb29scy9TY3Jp cHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xMjE3LDcgKzEyMTcs NyBAQCBkZWYgZGV0ZWN0RmFpbHVyZXMKICAgICByYWlzZSBpZiAkYnVuZGxlCiAKICAgICBpZiAk cmVtb3RlCi0gICAgICAgIG91dHB1dCA9IHNzaFJlYWQoImNkICN7JHJlbW90ZURpcmVjdG9yeX0v I3skb3V0cHV0RGlyLmJhc2VuYW1lfS8ucnVubmVyICYmIChscyB0ZXN0X2ZhaWxfKiAyPiAvZGV2 L251bGwgfHwgdHJ1ZSkiKQorICAgICAgICBvdXRwdXQgPSBzc2hSZWFkKCJjZCAjeyRyZW1vdGVE aXJlY3Rvcnl9LyN7JG91dHB1dERpci5iYXNlbmFtZX0vLnJ1bm5lciAmJiBmaW5kIC4gLW5hbWUg XCJ0ZXN0X2ZhaWxfKlwiIC1kZXB0aCAxIikKICAgICAgICAgb3V0cHV0LnNwbGl0KC9cbi8pLmVh Y2ggewogICAgICAgICAgICAgfCBsaW5lIHwKICAgICAgICAgICAgIG5leHQgdW5sZXNzIGxpbmUg PX4gL3Rlc3RfZmFpbF8vCg==