129836 2014-03-06 15:21:30 -0800 CodeGeneratorJS.pm doesn't need to add spaces between consecutive closing template brackets 2014-03-07 10:10:37 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg bburg andersca cdumez cgarcia commit-queue kling ossy oldest_to_newest 987898 0 bburg 2014-03-06 15:21:30 -0800 There are a few little cases where it tries to avoid a compiler error we won't ever hit now. 987944 1 226063 bburg 2014-03-06 16:50:51 -0800 Created attachment 226063 the patch 987989 2 226063 commit-queue 2014-03-06 18:18:10 -0800 Comment on attachment 226063 the patch Clearing flags on attachment: 226063 Committed r165242: <http://trac.webkit.org/changeset/165242> 987990 3 commit-queue 2014-03-06 18:18:14 -0800 All reviewed patches have been landed. Closing bug. 988045 4 ossy 2014-03-06 22:47:40 -0800 (In reply to comment #2) > (From update of attachment 226063 [details]) > Clearing flags on attachment: 226063 > > Committed r165242: <http://trac.webkit.org/changeset/165242> It broke the bindings tests, please fix it. 988205 5 bburg 2014-03-07 10:10:37 -0800 (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 226063 [details] [details]) > > Clearing flags on attachment: 226063 > > > > Committed r165242: <http://trac.webkit.org/changeset/165242> > > It broke the bindings tests, please fix it. Ugh, I forgot those still aren't run by EWS. Will fix. 226063 2014-03-06 16:50:51 -0800 2014-03-06 18:18:10 -0800 the patch bug-129836-20140306165137.patch text/plain 2499 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA4MGY5NTRmNWMwYjJk YTM0YmNkNTBiZmU4MzUxY2RiYmE4MDVlNC4uZDNlMjlhMTIyNTMyY2ZhYzE3OGY2ZWIxNDYzY2Y1 ZTg2ZjQ2MGJiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTA2ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIENvZGVHZW5lcmF0b3JKUy5wbSBk b2Vzbid0IG5lZWQgdG8gYWRkIHNwYWNlcyBiZXR3ZWVuIGNvbnNlY3V0aXZlIGNsb3NpbmcgdGVt cGxhdGUgYnJhY2tldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyOTgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChH ZW5lcmF0ZVBhcmFtZXRlcnNDaGVjayk6CisgICAgICAgIChHZXROYXRpdmVWZWN0b3JJbm5lclR5 cGUpOgorICAgICAgICAoR2V0U1ZHUHJvcGVydHlUeXBlcyk6CisKIDIwMTQtMDMtMDYgIEJyZW50 IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aXNlIE91dC1vZi1i YW5kIFZUVCBzdXBwb3J0IGZvciBiZXR0ZXIgaW50ZWdyYXRpb24gd2l0aCBBVkZvdW5kYXRpb24g ZW5naW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtCmluZGV4IDFhZTdjNWExMzAzZjA0NGY2YzgxMDIxYWJiOGMzYmU2ODY3NDMwMWEu LjYxYTlhODE0ZTkwMDZmNzQyMGY1ZDIyOWEwZGNkMGI3ZThmM2ExZjYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0zMjE2 LDkgKzMyMTYsNiBAQCBzdWIgR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2sKICAgICAgICAgICAgICAg ICAkbmF0aXZlRWxlbWVudFR5cGUgPSAiU3RyaW5nIjsKICAgICAgICAgICAgIH0gZWxzZSB7CiAg ICAgICAgICAgICAgICAgJG5hdGl2ZUVsZW1lbnRUeXBlID0gR2V0TmF0aXZlVHlwZSgkYXJnVHlw ZSk7Ci0gICAgICAgICAgICAgICAgaWYgKCRuYXRpdmVFbGVtZW50VHlwZSA9fiAvPiQvKSB7Ci0g ICAgICAgICAgICAgICAgICAgICRuYXRpdmVFbGVtZW50VHlwZSAuPSAiICI7Ci0gICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBpZiAoIUlzTmF0aXZlVHlwZSgk YXJnVHlwZSkpIHsKQEAgLTM1OTksNyArMzU5Niw3IEBAIHN1YiBHZXROYXRpdmVWZWN0b3JJbm5l clR5cGUKIAogICAgIHJldHVybiAiU3RyaW5nIiBpZiAkYXJyYXlPclNlcXVlbmNlVHlwZSBlcSAi RE9NU3RyaW5nIjsKICAgICByZXR1cm4gJG5hdGl2ZVR5cGV7JGFycmF5T3JTZXF1ZW5jZVR5cGV9 IGlmIGV4aXN0cyAkbmF0aXZlVHlwZXskYXJyYXlPclNlcXVlbmNlVHlwZX07Ci0gICAgcmV0dXJu ICJSZWZQdHI8JHthcnJheU9yU2VxdWVuY2VUeXBlfT4gIjsKKyAgICByZXR1cm4gIlJlZlB0cjwk e2FycmF5T3JTZXF1ZW5jZVR5cGV9PiI7CiB9CiAKIHN1YiBHZXROYXRpdmVUeXBlRm9yQ2FsbGJh Y2tzCkBAIC0zNjIwLDEzICszNjE3LDEwIEBAIHN1YiBHZXRTVkdQcm9wZXJ0eVR5cGVzCiAgICAg bXkgJHN2Z05hdGl2ZVR5cGU7CiAKICAgICByZXR1cm4gKCRzdmdQcm9wZXJ0eVR5cGUsICRzdmdM aXN0UHJvcGVydHlUeXBlLCAkc3ZnTmF0aXZlVHlwZSkgaWYgbm90ICRpbXBsVHlwZSA9fiAvU1ZH LzsKLSAgICAKKwogICAgICRzdmdOYXRpdmVUeXBlID0gJGNvZGVHZW5lcmF0b3ItPkdldFNWR1R5 cGVOZWVkaW5nVGVhck9mZigkaW1wbFR5cGUpOwogICAgIHJldHVybiAoJHN2Z1Byb3BlcnR5VHlw ZSwgJHN2Z0xpc3RQcm9wZXJ0eVR5cGUsICRzdmdOYXRpdmVUeXBlKSBpZiBub3QgJHN2Z05hdGl2 ZVR5cGU7CiAKLSAgICAjIEFwcGVuZCBzcGFjZSB0byBhdm9pZCBjb21waWxhdGlvbiBlcnJvcnMg d2hlbiB1c2luZyAgUGFzc1JlZlB0cjwkc3ZnTmF0aXZlVHlwZT4KLSAgICAkc3ZnTmF0aXZlVHlw ZSA9ICIkc3ZnTmF0aXZlVHlwZSAiOwotCiAgICAgbXkgJHN2Z1dyYXBwZWROYXRpdmVUeXBlID0g JGNvZGVHZW5lcmF0b3ItPkdldFNWR1dyYXBwZWRUeXBlTmVlZGluZ1RlYXJPZmYoJGltcGxUeXBl KTsKICAgICBpZiAoJHN2Z05hdGl2ZVR5cGUgPX4gL1NWR1Byb3BlcnR5VGVhck9mZi8pIHsKICAg ICAgICAgJHN2Z1Byb3BlcnR5VHlwZSA9ICRzdmdXcmFwcGVkTmF0aXZlVHlwZTsK