129833 2014-03-06 15:03:52 -0800 Missing include in JSConsole.cpp 2014-03-06 15:38:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue ossy oldest_to_newest 987885 0 jbriance 2014-03-06 15:03:52 -0800 See buildbot: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/45406/steps/compile-webkit/logs/stdio CXXLD Programs/jsc-3 ./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSValue::isGetterSetter() const' ./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSCell::structure(JSC::VM&) const' ./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSValue::encode(JSC::JSValue)' ./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSValue::decode(long)' collect2: error: ld returned 1 exit status make[1]: *** [Programs/jsc-3] Error 1 987890 1 226046 jbriance 2014-03-06 15:07:06 -0800 Created attachment 226046 Add missing include in JSConsole.cpp 987893 2 commit-queue 2014-03-06 15:10:17 -0800 Attachment 226046 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSConsole.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 987896 3 jbriance 2014-03-06 15:15:10 -0800 Landed: http://trac.webkit.org/changeset/165221 987902 4 jbriance 2014-03-06 15:26:48 -0800 ... with style fixed: http://trac.webkit.org/changeset/165223 226046 2014-03-06 15:07:06 -0800 2014-03-06 15:08:48 -0800 Add missing include in JSConsole.cpp bug-129833.patch text/plain 908 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MjE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE0LTAzLTA2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEJ1aWxkIGZpeDogYWRkIG1pc3NpbmcgaW5jbHVkZSBpbiBKU0Nvbm9sZS5jcHAuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4MzMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUv SlNDb25zb2xlLmNwcDoKKwogMjAxNC0wMy0wNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEZpeCBBUk12NwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNDb25zb2xlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0NvbnNvbGUuY3BwCShyZXZpc2lvbiAxNjUyMDgpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU0NvbnNvbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw2ICsy NCw3IEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIkpTQ0pTVmFsdWVJ bmxpbmVzLmgiCiAjaW5jbHVkZSAiSlNDb25zb2xlLmgiCiAKIG5hbWVzcGFjZSBKU0Mgewo=