<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>129824</bug_id>
          
          <creation_ts>2014-03-06 13:59:43 -0800</creation_ts>
          <short_desc>Remove WebKit1 header includes from WebKit2</short_desc>
          <delta_ts>2014-03-06 14:37:40 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>987847</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-03-06 13:59:43 -0800</bug_when>
    <thetext>Remove WebKit1 header includes from WebKit2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987848</commentid>
    <comment_count>1</comment_count>
      <attachid>226035</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-03-06 14:00:56 -0800</bug_when>
    <thetext>Created attachment 226035
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987869</commentid>
    <comment_count>2</comment_count>
      <attachid>226035</attachid>
    <who name="">mitz</who>
    <bug_when>2014-03-06 14:32:11 -0800</bug_when>
    <thetext>Comment on attachment 226035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226035&amp;action=review

&gt; Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:84
&gt; +    if ([responder isKindOfClass:[NSView class]] &amp;&amp; [(id)responder isDescendantOf:view])

NSView * instead of id</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987872</commentid>
    <comment_count>3</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-03-06 14:37:40 -0800</bug_when>
    <thetext>Committed r165218: &lt;http://trac.webkit.org/changeset/165218&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>226035</attachid>
            <date>2014-03-06 14:00:56 -0800</date>
            <delta_ts>2014-03-06 14:32:11 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-129824-20140306140055.patch</filename>
            <type>text/plain</type>
            <size>6599</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTUzOWNjNmU1MDgzM2Q3
ZjFhMmQyYTI3ZTUxMTQ4MWI4Y2UzNjE0NC4uOTIwMjNhZDg1OTM0ZjRlN2Y2Y2IxZTMwNWZmYTdm
MjQyMDhjNjM4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTAzLTA2ICBBbmRl
cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIFdlYktp
dDEgaGVhZGVyIGluY2x1ZGVzIGZyb20gV2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv
d0NvbnRyb2xsZXIubW06CisgICAgICAgIChtYWtlUmVzcG9uZGVyRmlyc3RSZXNwb25kZXJJZkRl
c2NlbmRhbnRPZlZpZXcpOgorICAgICAgICBBZGQgYSBuZXcgZnVuY3Rpb24gaW5zdGVhZCBvZiBj
YWxsaW5nIGFuIE5TV2luZG93IGNhdGVnb3J5IG1ldGhvZCB0aGF0J3MgZGVmaW5lZCBpbiBXZWJL
aXQxLgorCisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgZW50ZXJGdWxs
U2NyZWVuOl0pOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGZpbmlz
aGVkRW50ZXJGdWxsU2NyZWVuQW5pbWF0aW9uOl0pOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5X
aW5kb3dDb250cm9sbGVyIGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246XSk6CisgICAg
ICAgIENhbGwgbWFrZVJlc3BvbmRlckZpcnN0UmVzcG9uZGVySWZEZXNjZW5kYW50T2ZWaWV3Lgor
CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRHJhZ0NsaWVudE1h
Yy5tbToKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBXZWJLaXQxIGhlYWRlciBpbXBvcnQuCisKKyAg
ICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9XZWJFZGl0b3JDbGllbnRNYWMu
bW06CisgICAgICAgIChXZWJLaXQ6OldlYkVkaXRvckNsaWVudDo6ZG9jdW1lbnRGcmFnbWVudEZy
b21BdHRyaWJ1dGVkU3RyaW5nKToKKyAgICAgICAgQ2hhbmdlIGEgY2F0ZWdvcnkgdG8gYmUgb24g
TlNPYmplY3QgaW5zdGVhZCBvZiBXZWJSZXNvdXJjZS4KKwogMjAxNC0wMy0wNiAgSm9zZXBoIFBl
Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEV4
cG9zZSB0aGUgY29uc29sZSBvYmplY3QgaW4gSlNDb250ZXh0cyB0byBpbnRlcmFjdCB3aXRoIFdl
YiBJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tG
dWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9t
YWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCBlYTIyMjc0ZWNkNmU4MGIz
YTE2YjIzZTAwMGZkMjgwZWVkYmQxNTgxLi44NDY3MGE1MDc1MjdkNTI1MTlmZjI3OTJlODgzZDM2
ZTRkMjY1MjY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVs
bFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz
L21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCkBAIC00Myw3ICs0Myw2IEBACiAj
aW1wb3J0IDxXZWJDb3JlL1dlYkNvcmVGdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lmg+CiAjaW1w
b3J0IDxXZWJDb3JlL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lmg+CiAjaW1wb3J0IDxXZWJDb3Jl
L1dlYldpbmRvd0FuaW1hdGlvbi5oPgotI2ltcG9ydCA8V2ViS2l0L1dlYk5TV2luZG93RXh0cmFz
Lmg+CiAjaW1wb3J0IDxXZWJLaXRTeXN0ZW1JbnRlcmZhY2UuaD4KIAogdXNpbmcgbmFtZXNwYWNl
IFdlYktpdDsKQEAgLTgwLDkgKzc5LDExIEBAIHN0YXRpYyBOU1JlY3QgY29udmVydFJlY3RUb1Nj
cmVlbihOU1dpbmRvdyAqd2luZG93LCBOU1JlY3QgcmVjdCkKICAgICByZXR1cm4gW3dpbmRvdyBj
b252ZXJ0UmVjdFRvU2NyZWVuOnJlY3RdOwogfQogCi1AaW50ZXJmYWNlIE5TV2luZG93KElzT25B
Y3RpdmVTcGFjZUFkZGl0aW9uRm9yVGlnZXJBbmRMZW9wYXJkKQotLSAoQk9PTClpc09uQWN0aXZl
U3BhY2U7Ci1AZW5kCitzdGF0aWMgdm9pZCBtYWtlUmVzcG9uZGVyRmlyc3RSZXNwb25kZXJJZkRl
c2NlbmRhbnRPZlZpZXcoTlNXaW5kb3cgKndpbmRvdywgTlNSZXNwb25kZXIgKnJlc3BvbmRlciwg
TlNWaWV3ICp2aWV3KQoreworICAgIGlmIChbcmVzcG9uZGVyIGlzS2luZE9mQ2xhc3M6W05TVmll
dyBjbGFzc11dICYmIFsoaWQpcmVzcG9uZGVyIGlzRGVzY2VuZGFudE9mOnZpZXddKQorICAgICAg
ICBbd2luZG93IG1ha2VGaXJzdFJlc3BvbmRlcjpyZXNwb25kZXJdOworfQogCiBAaW1wbGVtZW50
YXRpb24gV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcgogCkBAIC0yNDYsNyArMjQ3LDcgQEAg
c3RhdGljIFJldGFpblB0cjxDR0ltYWdlUmVmPiBjcmVhdGVJbWFnZVdpdGhDb3BpZWREYXRhKENH
SW1hZ2VSZWYgc291cmNlSW1hZ2UpCiAgICAgW2NvbnRlbnRWaWV3IGFkZFN1YnZpZXc6X3dlYlZp
ZXcgcG9zaXRpb25lZDpOU1dpbmRvd0JlbG93IHJlbGF0aXZlVG86bmlsXTsKICAgICBbX3dlYlZp
ZXcgc2V0RnJhbWU6W2NvbnRlbnRWaWV3IGJvdW5kc11dOwogCi0gICAgW1tzZWxmIHdpbmRvd10g
bWFrZVJlc3BvbmRlcjp3ZWJXaW5kb3dGaXJzdFJlc3BvbmRlciBmaXJzdFJlc3BvbmRlcklmRGVz
Y2VuZGFudE9mVmlldzpfd2ViVmlld107CisgICAgbWFrZVJlc3BvbmRlckZpcnN0UmVzcG9uZGVy
SWZEZXNjZW5kYW50T2ZWaWV3KHNlbGYud2luZG93LCB3ZWJXaW5kb3dGaXJzdFJlc3BvbmRlciwg
X3dlYlZpZXcpOwogCiAgICAgW3NlbGYgX21hbmFnZXJdLT5zZXRBbmltYXRpbmdGdWxsU2NyZWVu
KHRydWUpOwogICAgIFtzZWxmIF9tYW5hZ2VyXS0+d2lsbEVudGVyRnVsbFNjcmVlbigpOwpAQCAt
MzA5LDcgKzMxMCw3IEBAIHN0YXRpYyBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gY3JlYXRlSW1hZ2VX
aXRoQ29waWVkRGF0YShDR0ltYWdlUmVmIHNvdXJjZUltYWdlKQogCiAgICAgICAgIE5TUmVzcG9u
ZGVyICpmaXJzdFJlc3BvbmRlciA9IFtbc2VsZiB3aW5kb3ddIGZpcnN0UmVzcG9uZGVyXTsKICAg
ICAgICAgW3NlbGYgX3JlcGxhY2VWaWV3Ol93ZWJWaWV3UGxhY2Vob2xkZXIuZ2V0KCkgd2l0aDpf
d2ViVmlld107Ci0gICAgICAgIFtbX3dlYlZpZXcgd2luZG93XSBtYWtlUmVzcG9uZGVyOmZpcnN0
UmVzcG9uZGVyIGZpcnN0UmVzcG9uZGVySWZEZXNjZW5kYW50T2ZWaWV3Ol93ZWJWaWV3XTsKKyAg
ICAgICAgbWFrZVJlc3BvbmRlckZpcnN0UmVzcG9uZGVySWZEZXNjZW5kYW50T2ZWaWV3KF93ZWJW
aWV3LndpbmRvdywgZmlyc3RSZXNwb25kZXIsIF93ZWJWaWV3KTsKICAgICAgICAgW1tfd2ViVmll
dyB3aW5kb3ddIG1ha2VLZXlBbmRPcmRlckZyb250OnNlbGZdOwogCiAgICAgICAgIFtzZWxmIF9t
YW5hZ2VyXS0+ZGlkRXhpdEZ1bGxTY3JlZW4oKTsKQEAgLTM3OSw3ICszODAsNyBAQCBzdGF0aWMg
UmV0YWluUHRyPENHSW1hZ2VSZWY+IGNyZWF0ZUltYWdlV2l0aENvcGllZERhdGEoQ0dJbWFnZVJl
ZiBzb3VyY2VJbWFnZSkKIAogICAgIE5TUmVzcG9uZGVyICpmaXJzdFJlc3BvbmRlciA9IFtbc2Vs
ZiB3aW5kb3ddIGZpcnN0UmVzcG9uZGVyXTsKICAgICBbc2VsZiBfcmVwbGFjZVZpZXc6X3dlYlZp
ZXdQbGFjZWhvbGRlci5nZXQoKSB3aXRoOl93ZWJWaWV3XTsKLSAgICBbW193ZWJWaWV3IHdpbmRv
d10gbWFrZVJlc3BvbmRlcjpmaXJzdFJlc3BvbmRlciBmaXJzdFJlc3BvbmRlcklmRGVzY2VuZGFu
dE9mVmlldzpfd2ViVmlld107CisgICAgbWFrZVJlc3BvbmRlckZpcnN0UmVzcG9uZGVySWZEZXNj
ZW5kYW50T2ZWaWV3KF93ZWJWaWV3LndpbmRvdywgZmlyc3RSZXNwb25kZXIsIF93ZWJWaWV3KTsK
IAogICAgIE5TUmVjdCB3aW5kb3dCb3VuZHMgPSBbW3NlbGYgd2luZG93XSBmcmFtZV07CiAgICAg
d2luZG93Qm91bmRzLm9yaWdpbiA9IE5TWmVyb1BvaW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRHJhZ0NsaWVudE1hYy5tbSBi
L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkRyYWdDbGll
bnRNYWMubW0KaW5kZXggMTUzY2VjYjJmZTVmOWQ3NGFkNDA5YzE2OGFkZjUxN2VhOTZiZWI0NC4u
OGU2NTk2ZGFjMzRiZWMwODA1MTRkYjExYmFjMDAyMzQxODZlNWE1YyAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRHJhZ0NsaWVudE1h
Yy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9X
ZWJEcmFnQ2xpZW50TWFjLm1tCkBAIC00Niw3ICs0Niw2IEBACiAjaW1wb3J0IDxXZWJDb3JlL1Jl
bmRlckltYWdlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1Jlc291cmNlSGFuZGxlLmg+CiAjaW1wb3J0
IDxXZWJDb3JlL1N0cmluZ1RydW5jYXRvci5oPgotI2ltcG9ydCA8V2ViS2l0L1dlYkFyY2hpdmUu
aD4KICNpbXBvcnQgPFdlYktpdFN5c3RlbUludGVyZmFjZS5oPgogI2ltcG9ydCA8d3RmL1N0ZExp
YkV4dHJhcy5oPgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNv
cmVTdXBwb3J0L21hYy9XZWJFZGl0b3JDbGllbnRNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ
cm9jZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9XZWJFZGl0b3JDbGllbnRNYWMubW0KaW5kZXggNjk2
MzlkNTUyNjQ4OTRkMTE1OTdhZGUyMjc4MDgxMTZhYzgyM2NiNi4uZWY0YTU3NDZlZThmNGZhNTFl
NDVkMTc0MjdjNmZiNGEzNGUwZGMyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv
Y2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRWRpdG9yQ2xpZW50TWFjLm1tCisrKyBiL1NvdXJj
ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkVkaXRvckNsaWVudE1h
Yy5tbQpAQCAtNDcsNyArNDcsNiBAQAogI2ltcG9ydCA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5o
PgogI2ltcG9ydCA8V2ViQ29yZS9QYWdlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1dlYkNvcmVOU1VS
TEV4dHJhcy5oPgotI2ltcG9ydCA8V2ViS2l0L1dlYlJlc291cmNlLmg+IC8vIEZJWE1FOiBXZWJL
aXQyIHNob3VsZCBub3QgaW5jbHVkZSBXZWJLaXQgaGVhZGVycy4KIAogdXNpbmcgbmFtZXNwYWNl
IFdlYkNvcmU7CiAKQEAgLTU1LDcgKzU0LDcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAt
IChET01Eb2N1bWVudEZyYWdtZW50KilfZG9jdW1lbnRGcm9tUmFuZ2U6KE5TUmFuZ2UpcmFuZ2Ug
ZG9jdW1lbnQ6KERPTURvY3VtZW50Kilkb2N1bWVudCBkb2N1bWVudEF0dHJpYnV0ZXM6KE5TRGlj
dGlvbmFyeSAqKWRpY3Qgc3VicmVzb3VyY2VzOihOU0FycmF5ICoqKXN1YnJlc291cmNlczsKIEBl
bmQKIAotQGludGVyZmFjZSBXZWJSZXNvdXJjZSAoV2ViUmVzb3VyY2VJbnRlcm5hbCkKK0BpbnRl
cmZhY2UgTlNPYmplY3QgKFdlYlJlc291cmNlSW50ZXJuYWwpCiAtIChXZWJDb3JlOjpBcmNoaXZl
UmVzb3VyY2UqKV9jb3JlUmVzb3VyY2U7CiBAZW5kCiAKQEAgLTExNiwxMSArMTE1LDEzIEBAIERv
Y3VtZW50RnJhZ21lbnQqIFdlYkVkaXRvckNsaWVudDo6ZG9jdW1lbnRGcmFnbWVudEZyb21BdHRy
aWJ1dGVkU3RyaW5nKE5TQXR0cmliCiAgICAgCiAgICAgTlNBcnJheSAqc3ViUmVzb3VyY2VzOwog
ICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG1fcGFnZS0+bWFpbkZyYW1lKCktPmRvY3VtZW50KCk7
CisKKyAgICAvLyBGSVhNRTogSXNudGVhZCBvZiBjYWxsaW5nIHRoaXMgV2ViS2l0MSBtZXRob2Qs
IHRoZSBjb2RlIHNob3VsZCBiZSBmYWN0b3JlZCBvdXQgYW5kIG1vdmVkIGludG8gV2ViQ29yZS4K
ICAgICBET01Eb2N1bWVudEZyYWdtZW50KiBmcmFnbWVudCA9IFtzdHJpbmcgX2RvY3VtZW50RnJv
bVJhbmdlOk5TTWFrZVJhbmdlKDAsIFtzdHJpbmcgbGVuZ3RoXSkKICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50OmtpdChkb2N1bWVu
dCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnRB
dHRyaWJ1dGVzOmRpY3Rpb25hcnkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgc3VicmVzb3VyY2VzOiZzdWJSZXNvdXJjZXNdOwotICAgIGZvciAoV2Vi
UmVzb3VyY2UqIHJlc291cmNlIGluIHN1YlJlc291cmNlcykKKyAgICBmb3IgKGlkIHJlc291cmNl
IGluIHN1YlJlc291cmNlcykKICAgICAgICAgcmVzb3VyY2VzLmFwcGVuZChbcmVzb3VyY2UgX2Nv
cmVSZXNvdXJjZV0pOwogCiAgICAgcmV0dXJuIGNvcmUoZnJhZ21lbnQpOwo=
</data>
<flag name="review"
          id="250215"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>